Commit Graph
4212 Commits
Author SHA1 Message Date
Brandon Thomas 859808e062 Merge PR #2979 2026-11-03 09:30:23 -05:00
Brandon ThomasandClaude Opus 5.5 26228247e2 Follow-ups to the batch: name numbering keeps no double space (#2908), Material Options error names the parameters (#2924), corrupt file timecodes stay on timecode (#2835), restore #2934's scroll-gutter asserts, #2825's Motion Tile test compiles
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 09:30:22 -05:00
Brandon Thomas e96f47f3c2 Merge PR #2819 2026-11-03 09:08:08 -05:00
Brandon Thomas 7a172b04e0 Merge PR #2825 2026-11-03 09:08:08 -05:00
Brandon Thomas a768cdb42f Merge PR #2878 2026-11-03 09:08:08 -05:00
Brandon Thomas 38e33992bd Merge PR #2892 2026-11-03 09:08:08 -05:00
Brandon Thomas f5e81cd1f9 Merge PR #2957 2026-11-03 09:08:08 -05:00
Brandon Thomas 764343e08c Merge PR #2888 2026-11-03 09:08:08 -05:00
Brandon Thomas 072db0ca35 Merge PR #2842
# Conflicts:
#	crates/lottie/src/tests.rs
2026-11-03 09:05:06 -05:00
Brandon Thomas 6334d07fe1 Merge PR #2872
# Conflicts:
#	apps/effectcraft-cli/tests/it/cli.rs
2026-11-03 09:05:01 -05:00
Brandon Thomas 369608c826 Merge PR #2978 2026-11-03 09:04:56 -05:00
Brandon Thomas 5dc64bb227 Merge PR #2885 2026-11-03 09:04:55 -05:00
Brandon Thomas e52727fa91 Merge PR #2887 2026-11-03 09:04:55 -05:00
Brandon Thomas 3072f009bf Merge PR #2891 2026-11-03 09:04:54 -05:00
Brandon Thomas 21edd52ae6 Merge PR #2933 2026-11-03 09:04:53 -05:00
Brandon Thomas 8a82962335 Merge PR #2934 2026-11-03 09:04:53 -05:00
Brandon Thomas b97a8f796a Merge PR #2935 2026-11-03 09:04:52 -05:00
Brandon Thomas ff204b37fa Merge PR #2962 2026-11-03 09:04:51 -05:00
Brandon Thomas 0d640999e6 Merge PR #2812 2026-11-03 09:04:46 -05:00
Brandon Thomas 0a91567425 Merge PR #2834 2026-11-03 09:04:45 -05:00
Brandon Thomas d6b67ac56c Merge PR #2835 2026-11-03 09:04:45 -05:00
Brandon Thomas f13aef1655 Merge PR #2847 2026-11-03 09:04:45 -05:00
Brandon Thomas 2267ea4970 Merge PR #2852 2026-11-03 09:04:45 -05:00
Brandon Thomas 3170c0e34f Merge PR #2905 2026-11-03 09:04:45 -05:00
Brandon Thomas 708de30891 Merge PR #2908 2026-11-03 09:04:45 -05:00
Brandon Thomas 180d0b9d91 Merge PR #2843 2026-11-03 09:04:45 -05:00
Brandon Thomas 0e3d54f982 Merge PR #2909 2026-11-03 09:04:45 -05:00
Brandon Thomas 5720043d32 Merge PR #2922 2026-11-03 09:04:45 -05:00
Brandon Thomas 2fb7003643 Merge PR #2924 2026-11-03 09:04:45 -05:00
Brandon Thomas 7758a6b99d Merge PR #2881 2026-11-03 09:04:45 -05:00
Brandon Thomas 7ae139ebf0 Merge PR #2931 2026-11-03 09:04:45 -05:00
Brandon Thomas f50985f9e6 Merge PR #2960 2026-11-03 09:04:45 -05:00
Brandon Thomas e175a272c7 Merge PR #2824 2026-11-03 09:04:45 -05:00
Claude a5e0da657e Pre-compose: layers left behind drop links to moved layers, default names are numbered
Unselected layers parented to, or track-matted by, a layer that moved into the
new composition kept ids that no longer exist in the outer comp. The command's
default name was always "Pre-comp 1"; it now picks the lowest unused number.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RDvxCS8xcR28VArjzn1x7U
2026-11-03 13:58:54 +00:00
zitann2020andDeepSeek V4.1 Flash e8e3262a86 i18n(ja): the work area is ワークエリア in the panel too
The panel catalog said 作業領域 for Work Area while the four menu rows say ワークエリア. The installed After Effects 2026 settles it: Edit > Preferences > Previews reads キャッシュ範囲: ワークエリアと現在の時間.

The row draws the Content-Aware Fill panel range menu and the Time Span form, so a reader met both words for
one thing depending on where they looked. One row, no other change.

Co-Authored-By: DeepSeek V4.1 Flash <noreply@deepseek.com>
2026-11-03 22:14:57 +09:00
Matej Kozlovský 3eb7ac7c5e Hold the probe build in the remaining crypto-pick reading tests
The "while reading" sections of the waiting-click, in-order and undo/redo
tests now hold the build with the Held wrapper until their asserts are
done, instead of relying on a 4K plate being slow to read.

The undo tests use the shared helpers from ui_crypto_pick.rs, so they now
go through crypto_exr with k = 1 rather than a copy without it.
2026-11-03 12:47:53 +01:00
Dylan M. Taylor d025b59e6d OCIO config: a mismatched closing bracket ends a flow collection, and multiline flows are assembled in linear time (#2939) 2026-11-03 06:03:05 -05:00
Bar BorerandClaude Opus 5.5 220d85f4fc Effect Controls: Shift-click selects a range of effects
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 11:53:55 +02:00
Matej Kozlovský 310c6da745 Cryptomatte eyedropper: hold the probe in the queued-clicks undo test (#473)
clicks_queued_while_reading_are_one_step_each_and_undo_in_order relied on
a blurred 4K plate being slow to read, and failed when the IDs were read
while the clicks were still being pressed. The probe's ID read is now held
(the Held footage from ui_crypto_pick) until the clicks are checked, and
the test asserts that the build reached that read and that nothing was
made while it was held.
2026-11-03 09:36:23 +01:00
Matej Kozlovský f8463fcf7e Cryptomatte eyedropper: Esc that closes a dialog keeps it armed (#473)
The Esc that closed New Solid or Composition Settings also disarmed the
eyedropper. An open dialog now takes Esc like a focused text field or an
open popup, so that Esc only closes the dialog and the next one disarms.
long_sequence asserts both instead of logging a finding.
2026-11-03 08:56:53 +01:00
JonRC 940a57e865 3D Camera Tracker: Effect Controls say how many frames a partial solve solved (#2959)
A solve with unsolved frames drew the same block as a full one, so it
looked complete. It now gets one more line in the warning colour,
"Partial solve: N of M frames solved", under the status line, and the
editor grows by that line only then. The line is an automation element,
so agents can read it too.
2026-11-03 04:08:39 -03:00
Matej Kozlovský 0d1c5c08bf Docs: the Cryptomatte Selection is picked in the viewer (#473)
effects-parity.md and gaps.md: the Selection is picked in the viewer. control-protocol.md: the
viewer.cryptoPick element ids. footage.md: a paragraph on the eyedropper.
2026-11-03 07:37:53 +01:00
Matej Kozlovský 7cea1625f6 Cryptomatte eyedropper: arm it from the Selection in Effect Controls (#473)
An eyedropper next to the Cryptomatte effect's Selection arms the viewer pick, and the status
line says how to use it. It stays armed until Esc or the button (Esc in a text field or a menu
only ends that); disarming, New, Open and Revert end it and let go of the session's probe.

The app runs the pick's bookkeeping at the start and end of each pass, the viewer hands the
pointer to the pick while it is armed and opens its context menu for a right-click the pick
forwarded, and a Selection cut off by a narrow Effect Controls panel shows whole on hover.

UI tests: ui_crypto_pick (arming, hover, clicks, modifiers, drags, waiting clicks, status,
highlight) and ui_crypto_pick_undo (one undo step per pick, the probe kept over undo).
2026-11-03 07:37:53 +01:00
Matej Kozlovský 6b0f72e4be Cryptomatte eyedropper: the viewer pick (#473)
panels::crypto_pick is the eyedropper's viewer side; it is wired in by the next commit. Armed,
the hover names the ID under the cursor and highlights its coverage, a click replaces the
Selection with it, Shift adds, Alt or Ctrl (Option or Cmd on a Mac) removes. Each pick is one
undo step, "Pick Cryptomatte".

The probe the hover needs is built off the UI thread, one at a time for the app
(EffectcraftApp::crypto_probe_busy, re-arming included), not while playing and not until a
scrub has settled for 100 ms; meanwhile the chip says so. Session::crypto_probe_ready asks for
readiness without changing anything; a job is asked for only when it starts.

Clicks made meanwhile are queued, own the build and are made in order at the end of the pass,
after its keys and edits. A click is the frame, point, resolution and project revision its
press saw. If any of them changed before it is made (an edit, Ctrl+Z, a nudge, a frame step),
it and every click waiting with it are dropped and the status says "Pick not made". A pick's
own change of the revision doesn't count as an edit for a click still held. Losing the window
focus drops a held press. A click that takes the focus from the Selection field waits for the
field to commit and is made on top of it.

The overlay takes drags too: a click that drifts picks at its press, and one dragged further
than 24 points picks nothing ("Drag cancelled the pick"). Presses and releases are read from
the pass's events in order rather than from egui's end-of-pass click state, since a slow pass
can hold a whole click. Space, the Hand and the Zoom tool keep their clicks, the middle button
pans, and a right-click is passed on under viewer::FORWARDED_SECONDARY for the viewer to open
its context menu (the viewer side is in the next commit). Errors show in the chip in red,
without the command's prefix, wrapped to the viewer's width.

The hovered ID's coverage (Session::crypto_coverage) is drawn as a texture through the layer's
effect-space transform, rebuilt only when the hovered ID, frame or revision changes, and
exposed to the test harness as viewer.cryptoPick.highlight.

Supporting changes:
- EffectcraftApp::say sets the status line and restarts its 5 s; each status message now gets
  its own 5 s, also when the same text is shown again.
- Points snap to the centre of the shown frame's pixel at the exact 1/n scale the viewer
  renders (frames::render_scale; the frame key keeps 0.333 for Third, which named the next
  row's ID). Cache Frames When Idle renders at that exact scale too, so idle-cached frames are
  on the grid the pick reads.
2026-11-03 07:37:53 +01:00
heojunfoandClaude Opus 5.5 a5f0af1f57 test(export): name the tiled bit in the EXR version check
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 15:33:34 +09:00
Matej Kozlovský 6b1f91ffb8 Cryptomatte: read an ID's coverage from the kept probe (#473)
Session::crypto_coverage returns the coverage of one Cryptomatte ID over the layer, read from
the probe Session::crypto_probe_job keeps: at most max_side samples on the long side, each at
the centre of its cell, or None until the probe is built. It is what the Cryptomatte
eyedropper's hover highlight will draw.

Tests cover the coverage of an ID from the kept probe and the cost of a highlight with six
ranks.
2026-11-03 07:22:46 +01:00
Bar BorerandClaude Opus 5.5 8ff461b35b Panels: a window widened under the open panel menu gives it its width back (#2864)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 06:17:54 +02:00
Bar BorerandClaude Opus 5.5 dc28883993 Tests: build the viewer tests' EvalCtx from the session's active comp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 05:35:02 +02:00
Bar BorerandClaude Opus 5.5 6c49ef819d Tests: trim the key box tests to what #2857 changes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 05:16:27 +02:00
Bar BorerandClaude Opus 5.5 8a37ff6b43 Tests: trim the midpoint snap tests to what #2855 changes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 05:07:59 +02:00