Commit Graph
8150 Commits
Author SHA1 Message Date
Khawar Zamman Wani 66ac154d68 perf(algo): select median stack samples without full sorting (#9628) 2026-10-29 11:36:34 -04:00
Khawar Zamman Wani 6b2ad6b620 Reduce Noise: reuse guide statistics with bit-identical output (#9639)
* perf(algo): reuse Reduce Noise guide statistics

* fix(algo): use fixed-size chunks for guide statistics

* Reduce Noise: test that the caller routes the cleaned luma guide and both chroma planes

Review follow-up: compares reduce_noise's output (Lab, so planes pass through) with the
independent guided filters run in order.

* test(algo): assert bit-identical output in Reduce Noise routing test
2026-10-29 11:35:24 -04:00
Khawar Zamman Wani 991ef9907b fix(actions): allow no-op Arrange steps during playback (#8457) 2026-10-29 11:34:13 -04:00
David Mann 010ab858e7 Merge PR #7716: Add Pattern Fill option to Layer Panel Footer 2026-10-29 16:26:56 +01:00
David MannandClaude Opus 5.5 72a7caf04a Integration: path.addToSelection/subtractFromSelection name document paths, not files (#8015)
Their params doc mentions path.toSelection, so the automation filesystem-path
classifier test flagged them; they take a document path name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 16:14:58 +01:00
3968e24cf0 Integration: the empty-layer check honours the default pixel and video (#7716)
`is_empty_pixel_layer` took any layer without stored tiles for empty, so a
layer opaque only through its default pixel (as KRA imports it,
`Surface::with_default`) or a blank video layer became the Pattern Fill
(and the Stamp Visible target) instead of getting one above. It now
needs a transparent default pixel (alpha only: a mode or profile
conversion gives an empty layer's default pixel other colour bytes) and
no video.

Co-authored-by: Hodd <32705043+hodd1444@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 16:12:49 +01:00
David Mann 0e72c418da Merge remote-tracking branch 'origin/main' into pr-7716-fixup
# Conflicts:
#	crates/engine/src/cmd/pattern_cmds.rs
#	crates/ui-egui/src/panels.rs
2026-10-29 15:45:55 +01:00
David Mann cf66eea4c9 Merge PR #8015: Added advanced selections keyboard shortcuts 2026-10-29 15:45:22 +01:00
David Mann 601f2ed7f9 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/ui-egui/src/i18n.rs
#	crates/ui-egui/src/i18n/LICENSE-translations.txt
#	crates/ui-egui/src/i18n/live_tests.rs
#	crates/ui-egui/src/i18n/system.rs
#	docs/localization-parity.md
2026-10-29 15:41:15 +01:00
c53409b451 Integration: Ctrl+Shift/Alt+Enter take the path being drawn, as Ctrl+Enter (#8015)
The new keys went straight to the engine with the Paths-panel path name
injected in PhotocraftApp::run, skipping the route Ctrl+Enter takes
(vector_ui::path_to_selection). So a Pen path still being drawn was not
finished and used: Pen, three clicks, Ctrl+Shift+Enter combined the old
work path (or failed with "no work path") and left the Pen path open,
and the loaded path stayed selected. Both ids now go through the same
route with the mode forced to add/subtract, and the injection is gone.

Also removes crates/ui-egui/src/vector_cmds.rs, an uncompiled byte-for-
byte copy of the old engine file, and makes the add test check that both
areas end up selected.

Co-authored-by: mahefanante <42338306+mahefanante@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 15:31:26 +01:00
David Mann 56d1da1943 Merge origin/main into pr-8015-fixup
Main split crates/engine/src/vector_cmds.rs into cmd/vector_cmds.rs and
cmd/vector_cmds/paths.rs, moved the shortcuts tests into
input/shortcuts/tests.rs and PhotocraftApp::run into app/commands.rs.
The PR's change is ported as it is to the new places; its text-field
test now draws the field every frame, as main's egui drops the focus of
a field that isn't drawn.
2026-10-29 15:29:05 +01:00
David Mann 102b1df924 Merge PR #5403: fix(ui): default active tool on startup to Move tool (#5355) 2026-10-29 15:20:54 +01:00
ea48482f92 Integration: keep the ui.set and tool-memory tests meaningful with the Move default (#5403)
With Move as the default tool, `ui_set_rejects_unknown_fields_before_changing_anything`
asserted Move after the rejected `{"tool": "move", "dark": true}`, which is also the
starting tool, so a `ui.set` that applied `tool` before rejecting the call still passed.
The test now starts on Brush and asserts Brush.

`tool_memory::tests::selected_tool_and_non_default_options_roundtrip` (added on main
after this PR branched) used Move as its non-default tool; `persist` now writes no
`selectedTool` for it and the test failed. It uses Lasso instead.

No other test in photocraft-ui-egui or the photocraft app relied on the Brush default.

Co-authored-by: safvanedge <241307593+safvanedge@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 15:12:50 +01:00
David Mann c06f1e3da9 Merge remote-tracking branch 'origin/main' into pr-5403-fixup
# Conflicts:
#	crates/ui-egui/src/control.rs
#	crates/ui-egui/src/move_mods.rs
#	crates/ui-egui/src/prefs_ui.rs
2026-10-29 14:56:27 +01:00
David Mann c7e1bcd03c Merge PR #8623: fix(ui): add transform handles for multi-layer selection 2026-10-29 14:53:29 +01:00
472aeccffd Integration: a shared transform box keeps the held handle's cursor (#8623)
Main's handle_at (#5405) read only the one-layer preview's gesture, so with
several layers framed the corner being dragged lost its resize pointer once
the pointer left the handle (it showed the commit pointer instead). It now
reads the shared box's gesture too, through live_gesture.

Co-authored-by: ekedal <71788463+ekedal@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 14:51:25 +01:00
FredApps 7c05ffe243 Keep packed-key overlap expression within repository formatting style 2026-10-29 14:41:10 +01:00
FredApps f72b2ccab1 Reconcile stroke touches with packed coverage tile keys
Preserve both sparse and bounded-rectangle overlap paths after integrating #9852 with current main. Existing touches_covers_every_pixel_with_coverage covers negative coordinates, edges and huge rectangles. Combined CI will validate; no local build claimed.
2026-10-29 14:40:31 +01:00
David MannandClaude Opus 5.5 7b72ce949e Merge origin/main into #8623's fix-up branch
Main split the files this PR changes: transform_tool.rs into tools/transform_tool/ (begin,
commit, drag_modes, draw, pointer, tests), canvas.rs into canvas/ (display, tool_input,
transform_controls, transform_controls_tests, snap_ui), and transform_cmds.rs into
cmd/transform_cmds.rs + tests.rs. The PR's changes are carried into the new modules as they
were. One adaptation: rotate_dir on main takes the live gesture (#5405), so the shared box's
gesture is passed through a new live_gesture helper instead of the PR's `rotating` bool.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 14:37:31 +01:00
FredApps 53dbfe280c Integrate 16 reviewed performance and usability PRs
Includes #8472 #8488 #9461 #9793 #9809 #9813 #9814 #9822 #9826 #9847 #9850 #9852 #9921 #9924 #9961 #10080 at reviewed heads.

Preserves each PR head as a parent. Reconciles CI workflow inputs and benchmark jobs without dropping checks. Excludes #8536 #9825 #9969 #10129. Combined CI pending; no manual validation claimed.
2026-10-29 14:31:15 +01:00
Claude b46caa37e5 Merge storytold/photocraft main into the Fill/Stroke popover branch
Clean merge of 92 upstream commits; scorecard unchanged (12 of 182).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TYsCL5E2GM6hUabP9dmYAv
2026-10-29 13:27:19 +00:00
David Mann 403b6f1742 Merge PR #8311: Type: a paragraph box that can't hold its text draws a red + overflow port 2026-10-29 14:00:09 +01:00
a005704eda Integration: overflow mark is a + in the enlarged lower-right handle (#8311)
The reference application marks a paragraph box that can't hold its text
with a black "+" inside an enlarged lower-right handle; nothing is drawn
below the box. The PR drew a red disc 0-9 px below the box at a fixed
screen offset, so on a rotated layer it came loose from the box, a click
on it either grabbed the corner handle or ended the edit, and its hover
card popped up while dragging that same corner to enlarge the box.

Now the lower-right handle grows to 11 px and carries the black "+",
centred on the transformed corner, and the whole enlarged handle grabs
that corner, also in a rotated view. The disc, the hover card (state, its
tooltip row in every catalog), the GPU pixel test and its pollster
dev-dependency are gone; detection (`TextLayout::overflows`) and the
`typeBoxOverflow` inspect flag stay. docs/ui-parity.md: the overflow row
no longer claims box threading, the Guides row the PR duplicated is
removed, and the history has one row in date order.

Tests: `an_overflowing_box_shows_a_plus_in_its_enlarged_lower_right_handle`
(upright and rotated box; fails on the PR head with a 7 px handle) and
`the_whole_enlarged_overflow_handle_grabs_in_a_rotated_view`.

Co-authored-by: VladimirPozdnyakov <49595925+VladimirPozdnyakov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 13:57:27 +01:00
David Mann 93f8cfd47a Merge main into #8311 (type_tool split into tools/type_tool, control split into control/) 2026-10-29 13:30:46 +01:00
FredApps 8f9f1a9481 docs: freeze verified Windows portable test protocol [skip ci] 2026-10-29 13:08:26 +01:00
Khawar Zamman Wani 2d3f6dc91a TIFF: reserve a strip's scratch buffer fallibly in decode_band 2026-10-29 16:44:38 +05:30
Khawar Zamman Wani 706186384a test(segment): make the long-run cancellation test fail when periodic polling is removed 2026-10-29 16:44:22 +05:30
FredApps f5b3f1238b Reconcile both packaging validation jobs and remove merge markers 2026-10-29 11:34:43 +01:00
FredApps d676995a77 Localize fixed picker titles with a translated-template fallback 2026-10-29 10:58:27 +01:00
Khawar Zamman Wani 2f68e85f95 Merge origin/main into fix/font-name-editable-9338
The font menu from #6526 (preview, filter bar, class list, favourite stars,
style expanders, format badges) now sits under the editable family field:
the field is the search, so the menu has no search box of its own. The list
keeps the viewport measured when the menu opens and shrinks to its message
when nothing matches, ending with the class list.

keys.rs takes main's split key handlers with this branch's changes: caret
moves and Cmd+A clear the pending typing font, and Cmd+Enter waits for the
IME. Explicit imports replace `use super::*` for the strict lints;
`with_target` is gone on main.
2026-10-29 14:49:56 +05:30
FredApps 1c85e25bbf Preserve localized picker titles and reconcile remaining UI fixtures 2026-10-29 10:17:46 +01:00
FredApps c3d1e816c9 Reconcile integrated UI ownership, gestures and text regressions 2026-10-29 09:56:08 +01:00
Khawar Zamman Wani f5dfe82a53 Test PNG export conflict resolution on upstream main 2026-10-29 13:11:59 +05:30
FredApps bd2b66dfce Record current UI validation failures and reconciliation checkpoint 2026-10-29 08:23:45 +01:00
FredApps 2334a460f2 Verify export-only formats stay out of Open dialogs 2026-10-29 08:00:41 +01:00
FredApps e40cdadb63 Preserve opening snapshot assertions and refresh generated scorecard 2026-10-29 07:52:28 +01:00
FredApps 2d52465091 Separate eyedropper event handling from the tool dispatcher 2026-10-29 07:42:06 +01:00
Lauri Methuen 7a6b685540 Finnish: translate the 34 strings added on main since the last rebase
Font menu favourites, font classes, similar and variable font filters,
History Options checkboxes, New Group from Layers, the CPU rendering
notice and the artboard X/Y fields. fi.tsv is 3,414 rows;
i18n-coverage reports fi at 2175/2175.
2026-10-29 08:41:11 +02:00
FredApps ee1040273c Publish current validation checkpoint 2026-10-29 07:34:31 +01:00
Lauri Methuen 514c3d2474 Finnish: translate the 37 strings added on main since the last rebase
Histogram panel statistics, Art History Brush styles, New Snapshot
sources, Vanishing Point clone stamp, Camera Raw .xmp notices, the
update notice and a few labels. fi.tsv is 3,380 rows; i18n-coverage
reports fi at 2049/2049.
2026-10-29 08:32:37 +02:00
Lauri Methuen 792cfbc89a Finnish: fix translations that misread their context
Override in Brush Pose replaces the pen's value, so "Pakota" instead of
"Ohita" (skip). Layers panel Filter Options is layer filtering, not image
filters. The app appends the English "copy" to names, so the labels say
"copy". Bevel & Emboss highlight/shadow rows are singular blend modes.
Also: warped text, brush load swatch, title bar, colour fringing, GPU
adapter and a few smoother wordings.
2026-10-29 08:32:24 +02:00
Lauri Methuen 3c17f24c2d Finnish: translate the 209 strings added on main since the first version
Rebased on main; fi.tsv now has every row the other complete catalogs
have (Content-Aware Fill panel, Wayland paste notice, memory preferences,
update checks, Color panel menu, Styles import/export and more).
2026-10-29 08:32:24 +02:00
Lauri Methuen 4d8cbc9a0e Add Finnish (Suomi) interface language 2026-10-29 08:32:24 +02:00
FredApps 964a47b51c Reconcile history, gradient, type safety and UI validation behavior 2026-10-29 07:30:56 +01:00
Khawar Zamman Wani e2cd2a335a Composite smart object sources in tile-aligned blocks
Row strips of a very wide source still allocated whole 256-row tiles
across the full width for every few rows (about 293 MiB per strip of a
300000 px RGBA8 source). Blocks are now whole tiles, at most 4096 px wide
and 1 Mpx in all, and their tiles move into the result without a copy.
2026-10-29 11:48:58 +05:30
FredApps 8d1fe17c51 Record exact-head compile and refreshed approval provenance 2026-10-29 07:16:49 +01:00
FredApps 30a2b002be Clarify executable Windows test protocol and validation provenance 2026-10-29 07:12:36 +01:00
FredApps 11fdb18070 Fix integration validation regressions and enable manual full sweeps 2026-10-29 07:10:41 +01:00
FredApps bd52c643ca Wire JXL codec import and preserve destination-tab path tracking after owned commit 2026-10-29 06:51:52 +01:00
FredApps 595d631372 Publish complete 108-head manifest with validation pending 2026-10-29 06:45:42 +01:00