* perf(algo): reuse Reduce Noise guide statistics
* fix(algo): use fixed-size chunks for guide statistics
* Reduce Noise: test that the caller routes the cleaned luma guide and both chroma planes
Review follow-up: compares reduce_noise's output (Lab, so planes pass through) with the
independent guided filters run in order.
* test(algo): assert bit-identical output in Reduce Noise routing test
Their params doc mentions path.toSelection, so the automation filesystem-path
classifier test flagged them; they take a document path name.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`is_empty_pixel_layer` took any layer without stored tiles for empty, so a
layer opaque only through its default pixel (as KRA imports it,
`Surface::with_default`) or a blank video layer became the Pattern Fill
(and the Stamp Visible target) instead of getting one above. It now
needs a transparent default pixel (alpha only: a mode or profile
conversion gives an empty layer's default pixel other colour bytes) and
no video.
Co-authored-by: Hodd <32705043+hodd1444@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The new keys went straight to the engine with the Paths-panel path name
injected in PhotocraftApp::run, skipping the route Ctrl+Enter takes
(vector_ui::path_to_selection). So a Pen path still being drawn was not
finished and used: Pen, three clicks, Ctrl+Shift+Enter combined the old
work path (or failed with "no work path") and left the Pen path open,
and the loaded path stayed selected. Both ids now go through the same
route with the mode forced to add/subtract, and the injection is gone.
Also removes crates/ui-egui/src/vector_cmds.rs, an uncompiled byte-for-
byte copy of the old engine file, and makes the add test check that both
areas end up selected.
Co-authored-by: mahefanante <42338306+mahefanante@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main split crates/engine/src/vector_cmds.rs into cmd/vector_cmds.rs and
cmd/vector_cmds/paths.rs, moved the shortcuts tests into
input/shortcuts/tests.rs and PhotocraftApp::run into app/commands.rs.
The PR's change is ported as it is to the new places; its text-field
test now draws the field every frame, as main's egui drops the focus of
a field that isn't drawn.
With Move as the default tool, `ui_set_rejects_unknown_fields_before_changing_anything`
asserted Move after the rejected `{"tool": "move", "dark": true}`, which is also the
starting tool, so a `ui.set` that applied `tool` before rejecting the call still passed.
The test now starts on Brush and asserts Brush.
`tool_memory::tests::selected_tool_and_non_default_options_roundtrip` (added on main
after this PR branched) used Move as its non-default tool; `persist` now writes no
`selectedTool` for it and the test failed. It uses Lasso instead.
No other test in photocraft-ui-egui or the photocraft app relied on the Brush default.
Co-authored-by: safvanedge <241307593+safvanedge@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main's handle_at (#5405) read only the one-layer preview's gesture, so with
several layers framed the corner being dragged lost its resize pointer once
the pointer left the handle (it showed the commit pointer instead). It now
reads the shared box's gesture too, through live_gesture.
Co-authored-by: ekedal <71788463+ekedal@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Preserve both sparse and bounded-rectangle overlap paths after integrating #9852 with current main. Existing touches_covers_every_pixel_with_coverage covers negative coordinates, edges and huge rectangles. Combined CI will validate; no local build claimed.
Main split the files this PR changes: transform_tool.rs into tools/transform_tool/ (begin,
commit, drag_modes, draw, pointer, tests), canvas.rs into canvas/ (display, tool_input,
transform_controls, transform_controls_tests, snap_ui), and transform_cmds.rs into
cmd/transform_cmds.rs + tests.rs. The PR's changes are carried into the new modules as they
were. One adaptation: rotate_dir on main takes the live gesture (#5405), so the shared box's
gesture is passed through a new live_gesture helper instead of the PR's `rotating` bool.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reference application marks a paragraph box that can't hold its text
with a black "+" inside an enlarged lower-right handle; nothing is drawn
below the box. The PR drew a red disc 0-9 px below the box at a fixed
screen offset, so on a rotated layer it came loose from the box, a click
on it either grabbed the corner handle or ended the edit, and its hover
card popped up while dragging that same corner to enlarge the box.
Now the lower-right handle grows to 11 px and carries the black "+",
centred on the transformed corner, and the whole enlarged handle grabs
that corner, also in a rotated view. The disc, the hover card (state, its
tooltip row in every catalog), the GPU pixel test and its pollster
dev-dependency are gone; detection (`TextLayout::overflows`) and the
`typeBoxOverflow` inspect flag stay. docs/ui-parity.md: the overflow row
no longer claims box threading, the Guides row the PR duplicated is
removed, and the history has one row in date order.
Tests: `an_overflowing_box_shows_a_plus_in_its_enlarged_lower_right_handle`
(upright and rotated box; fails on the PR head with a 7 px handle) and
`the_whole_enlarged_overflow_handle_grabs_in_a_rotated_view`.
Co-authored-by: VladimirPozdnyakov <49595925+VladimirPozdnyakov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The font menu from #6526 (preview, filter bar, class list, favourite stars,
style expanders, format badges) now sits under the editable family field:
the field is the search, so the menu has no search box of its own. The list
keeps the viewport measured when the menu opens and shrinks to its message
when nothing matches, ending with the class list.
keys.rs takes main's split key handlers with this branch's changes: caret
moves and Cmd+A clear the pending typing font, and Cmd+Enter waits for the
IME. Explicit imports replace `use super::*` for the strict lints;
`with_target` is gone on main.
Font menu favourites, font classes, similar and variable font filters,
History Options checkboxes, New Group from Layers, the CPU rendering
notice and the artboard X/Y fields. fi.tsv is 3,414 rows;
i18n-coverage reports fi at 2175/2175.
Histogram panel statistics, Art History Brush styles, New Snapshot
sources, Vanishing Point clone stamp, Camera Raw .xmp notices, the
update notice and a few labels. fi.tsv is 3,380 rows; i18n-coverage
reports fi at 2049/2049.
Override in Brush Pose replaces the pen's value, so "Pakota" instead of
"Ohita" (skip). Layers panel Filter Options is layer filtering, not image
filters. The app appends the English "copy" to names, so the labels say
"copy". Bevel & Emboss highlight/shadow rows are singular blend modes.
Also: warped text, brush load swatch, title bar, colour fringing, GPU
adapter and a few smoother wordings.
Rebased on main; fi.tsv now has every row the other complete catalogs
have (Content-Aware Fill panel, Wayland paste notice, memory preferences,
update checks, Color panel menu, Styles import/export and more).
Row strips of a very wide source still allocated whole 256-row tiles
across the full width for every few rows (about 293 MiB per strip of a
300000 px RGBA8 source). Blocks are now whole tiles, at most 4096 px wide
and 1 Mpx in all, and their tiles move into the result without a copy.