Commit Graph
8150 Commits
Author SHA1 Message Date
FredApps 7acb183256 Format completed approved PR integration 2026-10-29 06:45:20 +01:00
FredApps 3eb42a3ab3 Wire polygon autoscroll into authoritative camera and retain modal exclusions 2026-10-29 06:43:41 +01:00
FredApps d1ada5010f Merge approved PhotoCraft PR #2300: Scroll the viewport while outlining with Polygonal Lasso
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Port polygon stale cancellation and finite edge scrolling into authoritative target camera before transforms, preserving animated display interpolation. Clamp after scrolling; retain modal/workspace/focus/gesture, neighboring document, flip/rotation/aspect exclusions and all approved regressions. Remove obsolete bidi pre-pass helper now superseded by native egui.
2026-10-29 06:42:49 +01:00
FredApps ab7b1412d0 Merge approved PhotoCraft PR #3139: Draw right-to-left layer names in visual word order
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Current pinned egui already implements UAX9 paragraph bidi and main already preserves logical-start RTL truncation. Retain native rendering, avoid double reordering, and port approved mixed-script, joiner, Arabic/Hebrew rendering and truncation regressions using the logical-text compatibility shim. Keep current bidi_text elision.
2026-10-29 06:40:56 +01:00
FredApps fd3a12dfde Merge approved PhotoCraft PR #3142: Read applied Sony RAW metadata and crop ILCE-6000 images
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Integrate bounded Sony SR2 metadata decoding and ILCE-6000 image area; preserve newer bit-depth-aware camera profile application and explicit file crop precedence. Keep current parity counts and original metadata/crop tests.
2026-10-29 06:38:44 +01:00
FredApps 5a5e2c48dd Merge approved PhotoCraft PR #3345: Add grouped gradient presets and selectable style icons
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Port grouped gradient browsers and style previews into current modular sidebar/options controls. Keep current transactional stop preview, drag/drop ownership and sidebar activation semantics; add compact Properties preset picker without replacing stop engine. Preserve accessibility Role metadata and all approved regressions.
2026-10-29 06:37:29 +01:00
FredApps f85bc4c545 Merge approved PhotoCraft PR #3387: feat(codecs): add lossless JPEG XL export for 8/16-bit images
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Integrate lossless export-only JXL and independent decoder regression matrix, preserving current JPEG/TIFF save extensions and 12-bit/arithmetic JPEG decoder dependency.
2026-10-29 06:34:37 +01:00
FredApps 4f23f459ba Merge approved PhotoCraft PR #3464: fix(vector): target selected saved paths and own Pen gestures
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Reconcile captured Pen and Freeform targets with current resumed-subpath, Type Path, Path Operation and draft recovery behavior. Valid source-owned tab switches commit to captured original target; invalid snapshots cancel with a diagnostic; refused commits retain draft and suppress automatic retries. Preserve current Saved(index) API and hidden-work-path protections, register all new ownership/gesture tests and add original-target tab-switch/deleted-target cases. Includes verified compile/API corrections from prior checkpoints.
2026-10-29 06:33:02 +01:00
Khawar Zamman Wani dafbff2b05 Test the web build's Memory Usage cap
The cap is now a function of the stored value and the target, so native
tests check values below, at and above it; the native-only assertions are
gated to native targets.
2026-10-29 11:02:50 +05:30
Khawar Zamman Wani 0eaf976088 Keep smart object source strips within their pixel budget
Rounding the strip height up to the compositor's 256-row tile let a very
wide source (300000 px) composite 76.8 Mpx in one strip. Strips are now as
many rows as fit in the budget, at least one; the equivalence test also
covers strips off the tile grid.
2026-10-29 11:02:50 +05:30
FredApps de48193ece Merge approved PhotoCraft PR #3519: feat(export): optionally trim transparent margins from layer files
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Port transparent-margin trim into current authorized streaming export report, retaining skipped-layer reasons and stable numbering. Measure alpha in bounded render bands, including masks/effects; keep empty-layer canvas and source document immutable. Preserve original regressions.
2026-10-29 06:15:09 +01:00
FredApps c9430c92e3 Merge approved PhotoCraft PR #3748: control: suggest near matches for unknown command ids and methods (#3674)
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Add bounded deterministic suggestions via current error/session/control modules while preserving authorization/modal checks. Register hints and all original tests; fix scrollbar choice import and updated PSD image fixture field found by 100-head check.
2026-10-29 06:14:31 +01:00
FredApps 97dfeda00c Merge approved PhotoCraft PR #3967: Add move and delete actions to Smart Filter rows
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Port guarded filter context actions and selection updates into current Layers/Smart UI modules. Register all new modules and regressions; preserve current filter blend button and drag-to-reorder routing, document/modal/job ownership.
2026-10-29 06:13:32 +01:00
FredApps 8f05c13094 Merge approved PhotoCraft PR #4023: i18n(es): add 548 missing rows, fix five filter and video terms
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Apply approved Spanish terminology/completion changes by catalog key, retaining all newer unrelated translation rows and command IDs without duplicate keys.
2026-10-29 06:13:04 +01:00
FredApps dd428d2780 Merge approved PhotoCraft PR #4035: fix(cmyk): Flatten Image and merges keep the inks of a tagged CMYK document (#3778)
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Current compositor already preserves plain CMYK inks, tagged profile separation and uncropped merge bounds. Keep stronger native CMYK/Lab paths and current merge API; apply profile context to style rasterization and retain approved tagged-CMYK regression fixtures.
2026-10-29 06:12:35 +01:00
FredApps b753d0e942 Merge approved PhotoCraft PR #4042: feat(canvas): rotate view with Shift + middle-mouse drag
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Port Shift-middle pointer-anchored rotation into current camera path, retaining modal/temporary-tool exclusions and flick cancellation; preserve finite and flip/aspect regressions.
2026-10-29 06:12:02 +01:00
FredApps b63c6e00a6 Merge approved PhotoCraft PR #4711: Treat Dissolve as a per-pixel choice
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Current modular compositors already implement spatial Dissolve for adjustments and finished effects. Preserve equivalent implementations and newer Fill/HDR behavior, append approved missing CPU/GPU regression coverage.
2026-10-29 06:11:42 +01:00
FredApps 1c6acdf90f Merge approved PhotoCraft PR #4763: refactor(liquify): reuse native brush resizing and anchored HUD feedback
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Use shared zoom-corrected brush resize and HUD while preserving immediate press ownership and anchored outline when hover is absent. Keep original resize regressions. Fix duplicate identical Dissolve test registration and missing test-only UnicodeString import reported by 94-head check.
2026-10-29 06:11:12 +01:00
FredApps 7836d4b9e6 Merge approved PhotoCraft PR #4783: Fix/4758 type extreme finite geometry 20261013s1215
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Apply stricter finite 1e9 geometry bound to current parse/import safety paths; prevent corrected legacy origin bypass and retain current full PSD unsafe-import warning/raster fallback regression. Keep split import/build modules and port new overflow tests into import module.
2026-10-29 06:10:30 +01:00
FredApps 1daf3bc079 Merge approved PhotoCraft PR #4890: Add scrollbar visibility preferences (#3262)
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Port visibility preference, choice registration, live panel style and canvas override. Keep current animated camera and toolbar exclusions. Relocate misplaced persistence regression to prefs tests; retain current parity score counts.
2026-10-29 06:09:52 +01:00
FredApps 2ab2348adf Merge approved PhotoCraft PR #4992: Preserve Dissolve coverage when compositing clipped layers
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Current CPU and GPU already implement binary clipped Dissolve at document coordinates. Preserve current equivalent implementation and stronger negative-origin/depth regression; retain original named regression and added GPU parity coverage.
2026-10-29 06:08:48 +01:00
FredApps 76de179f75 Record 91-head integration checkpoint and verified pattern tests 2026-10-29 06:08:07 +01:00
FredApps 3c79ed4430 Merge approved PhotoCraft PR #4993: Prevent control-channel engine commands from editing behind modal dialogs
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Apply modal ownership gate to both control entry points while retaining current Camera Raw and full-window workspace continuations, authorization, and direct engine dispatch. Fix Windows case-variant fixture to use supported document suffix; add explicit existing unrelated-file refusal assertion.
2026-10-29 06:07:59 +01:00
FredApps c89736bbdc Keep Mixer cursor helper export warning-free 2026-10-29 06:05:52 +01:00
FredApps 32f583f1d6 Merge approved PhotoCraft PR #5082: fix(mixer-brush): Alt-click samples the foreground colour like the Brush (#4873)
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Preserve current spatial Mixer Brush Alt-click sampling and live transaction architecture; add compatible point-sample command without foreground mutation. Retain sample across automatic reload until foreground changes and preserve all new regressions.
2026-10-29 06:05:02 +01:00
FredApps b4097ca07f Format gradient editor ports and use current egui role API 2026-10-29 06:03:15 +01:00
FredApps 1953077164 Merge approved PhotoCraft PR #5270: Layer Style: Gradient Overlay takes any number of colour stops (#5177)
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Port arbitrary-stop editor into current responsive dialog. Preserve source interpolation and exact model colors; unchanged dense imported snapshot lists roundtrip while edited lists retain 256-stop cap. Retain both validation guards and all original regression tests. Correct saved-path callers, floating-window and crop fixtures found by frozen 88-head all-target check.
2026-10-29 06:02:29 +01:00
FredApps 8323688e1f Merge approved PhotoCraft PR #5453: Shapes: independent fill and stroke paints (solid, gradient, pattern), part 1
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Integrated independent exact shape paints and atomic pattern clipboard snapshots into current modules, preserving current soft-mask coverage, shape cache keys and gradient stop caps. Shared bounded COW pattern sampling now retains minification filtering; shapes/clipboards resolve lazy catalog entries to full pixels. Preserved CPU/GPU/depth/model regression matrices; also corrected missing glow-test enum imports found by the 80-head check.
2026-10-29 05:53:29 +01:00
FredApps c81347aaa8 Merge approved PhotoCraft PR #5493: Import Photoshop custom shape sets into the Shapes panel
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Integrated bounded atomic CSH set parsing, unique shape/group naming and native Shapes panel import with inline-data authorization guards; preserved duplicate-name, inner-hole, malformed-second-record and preferences-reload regressions. Combined independent catalog additions and retained current parity metadata.
2026-10-29 05:47:45 +01:00
FredApps 9df3697de8 Merge approved PhotoCraft PR #5650: Guides: ⌥ turns a dragged guide; dropping one on either ruler deletes it (#5034)
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Added Alt guide rotation in current ruler/tool-input modules and engine Move Guide, retaining click-versus-drag selection, deletion on either ruler, colors, ruler-origin units and snapping. Selection follows the new orientation/index after a successful turn; original guide-turn/deletion regressions retained.
2026-10-29 05:46:02 +01:00
FredApps d34c7a92e0 Merge approved PhotoCraft PR #5744: fix(ui): keep detached documents in one interactive window
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Ported floating-document filtering and focused interactive view ownership into current tab/viewport modules, preserving stable arrangement tiles, fit_doc_tabs, zoom-resizes-windows and layer-transfer hover mapping through filtered document indices. Retained original detached-window/tab-order regressions and current metadata APIs.
2026-10-29 05:43:49 +01:00
FredApps e1f1171eb1 Merge approved PhotoCraft PR #6026: Marquee: Fixed Size selects exactly the entered width and height (fixes #6015)
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Retained current exact fixed-size pixel geometry and its stronger pointer-positioning, completed-outline movement and Alt-centered regressions; current split drag module already contains the approved size rounding helper. Avoided restoring the older release-position expectations.
2026-10-29 05:39:59 +01:00
FredApps 5cafc0968d Keep obsolete view command monolith deleted after modular form port 2026-10-29 05:39:24 +01:00
FredApps a72296ee57 Merge approved PhotoCraft PR #6139: Fix painting workflows, File Info and layer selection
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Ported Behind paint across engine/render and shared options-bar/canvas mode menus, preserving Clear and current popup ownership. Added localized responsive picker title/width and File Info multiline fields without dropping ordered fields, Browse or camera metadata; ported Pen anchor repositioning, copy cursor, grayscale-target sampling and authorized select-under-cursor dispatch into current modules with original regressions.
2026-10-29 05:39:00 +01:00
Khawar Zamman Wani 272e5279ba Wrap the history budget doc comments to the line width 2026-10-29 10:08:06 +05:30
Khawar Zamman Wani a4cb9cd729 Test smart object source compositing across strip edges
The equivalence tests used a 64x48 source, a single strip, so a shadow or
mask crossing a strip boundary was never compared with the full-size path.
2026-10-29 10:08:06 +05:30
FredApps 08ab0a4da7 Merge approved PhotoCraft PR #6449: Hand tool: Cmd held zooms in and Alt zooms out, as in Photoshop
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Kept current stronger Hand modifier zoom implementation including sticky modifiers, primary-release ownership, middle-button pan and Free Transform exclusions; retained the original approved zoom/pan/release regressions alongside newer guards.
2026-10-29 05:34:11 +01:00
Khawar Zamman Wani 10f0648058 Cap the history budget on the web build
The default Memory Usage is 8 GiB per document, above the 4 GiB a
wasm module can address, so on the web the History budget could never
be reached and trimming never ran.

Performance::effective_memory_usage_mb caps the stored preference at
1536 MB on wasm32 and returns it unchanged elsewhere. The History
budget, the transform budget and the canvas allowance in the UI read
it. The stored preference and its default are untouched, so a saved
8192 still loads and still means 8192 on desktop.
2026-10-29 10:03:25 +05:30
Khawar Zamman Wani b779bd8f02 Count embedded smart object contents toward the history budget
History counted a document's pixel tiles but not the file bytes a
smart object embeds (SmartSource::Embedded). A document of large
embedded sources was far over its memory budget without trimming
ever noticing, and every Replace Contents kept the old bytes alive in
the undo states unaccounted.

The four counters (add, remove, bytes_with and the uncounted walk)
now visit one shared list of blocks: the tiles as before plus each
embedded source's Arc, keyed by address. States, snapshots and
duplicated layers that share an Arc count it once, and trimming the
last state that holds an old source releases it.
2026-10-29 10:03:25 +05:30
Khawar Zamman Wani e96386fe47 Bound and purge the decoded smart object source cache
The cache estimated an entry at channels * 4 bytes a pixel, four times
too much for 8-bit, always kept a single oversize entry, recovered a
poisoned lock by disabling itself, and nothing ever cleared it.

Count each entry's real tile bytes once when it is cached, and do not
cache a source larger than the whole budget (as the stage cache does).
Web builds keep 4 entries and 384 MiB instead of 32 and 1 GiB, and the
smart filter stage cache 256 MiB instead of 768 MiB. A poisoned lock
is recovered rather than ignored.

Edit > Purge > All now clears the cache and reports it, and enables on
it alone. Closing a document that has smart objects clears it too:
entries are shared by content hash, so other documents just decode
again on their next re-render.
2026-10-29 10:03:25 +05:30
Khawar Zamman Wani ee57fdb90e Smart object sources decode through the strip compositor
The first re-render of a smart object (Free Transform commit, Image
Size, a filter edit) flattened its source into one full-size RGBA
float buffer (16 bytes a pixel) and then converted it into a second
f32 vector before the surface was built, about 32 bytes a pixel on top
of the decoded document.

Composite the source in strips of about a megapixel straight into the
target pixel format instead. RGB, Grayscale and the depth conversions
give the same pixels as before (checked bit for bit, including masks,
blend modes and layer effects). CMYK and Lab composite natively in the
banded compositor and land up to 16 and 1 steps (8-bit) off the buffer
path, so sources in those modes keep the buffer path.

A 4096x4096 RGBA8 source now peaks +191 MiB (12.0 B/px) instead of
+655 MiB (41.0 B/px); tests/smart_source_peak.rs holds it under 16 B/px.
2026-10-29 10:03:25 +05:30
FredApps 425799851c Merge approved PhotoCraft PR #6492: Fail control startup promptly when its port is occupied
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Prebound the listener inside current authorized control_setup before Linux display and GPU initialization, retaining integration preferences, workspace grants, authentication and single-instance routing. Preserved actual port logging, added occupied-port/prebound-dispatch regressions and bounded child cleanup to current process test harness.
2026-10-29 05:33:21 +01:00
FredApps 78f9c137b3 Merge approved PhotoCraft PR #6621: Crop: right-click on the pending crop opens the crop menu (#6561)
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Extended current crop menu with Reset and shield toggles, preserving newer preset management, overlays, ownership checks and no-menu-during-gesture logic. Ported reset-frame no-op/undo semantics into current CropState/release and crop commit; retained original regression cases in split modules.
2026-10-29 05:29:44 +01:00
FredApps 8bc26fc9b1 Merge approved PhotoCraft PR #7848: fix(retouch): preserve Smudge pickup with live-pixel stroke commits
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Verified current modular Smudge implementation already retains the approved fixed pickup square, DabNeighborhood read_rect and live-pixel replay/commit behavior, with all changed regression names present. Preserved newer document-aware with_neighborhood_on APIs; kept obsolete monolith deleted.
2026-10-29 05:25:55 +01:00
FredApps 55bcfaed35 Keep one registered copy of the preserved outer glow regression 2026-10-29 05:25:00 +01:00
FredApps f369874ddb Merge approved PhotoCraft PR #8039: Compose: Extend Softer outer glows past Size (#7899)
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Added bounded Softer outer-glow tail in current CPU paint and GPU glow-builder modules, retaining original tent convolution and current program dispatch; registered exact tail/kernel regression and expanded render margin only for outer Softer glows.
2026-10-29 05:24:44 +01:00
FredApps 1e5d6a4285 Merge approved PhotoCraft PR #8074: Transform: remember selected interpolation (#8067)
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Preserved current transform start/target/preview routes while remembering interpolation in ToolOptions, using General default only when unset; registered current-module helper imports and persistence/next-transform regressions.
2026-10-29 05:23:40 +01:00
FredApps a62b9ee217 Merge approved PhotoCraft PR #8347: Type: Roman Hanging Punctuation (trailing marks hang, don't steer the alignment)
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Ported hanging punctuation into current line placement and kerning modules, preserving forced breaks, bounded edge-tip row merging, justified-last-line behavior, area exclusions and independent Roman orientation shaping; kept PSD/engine/UI regression coverage.
2026-10-29 05:22:57 +01:00
FredApps 9eec5c99e0 Merge approved PhotoCraft PR #8892: ui: larger Align icons and overflow button; Save for Web keeps its width on an invalid Matte
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Retained newer 20-point Align icons from current main rather than regressing to the approved 16-point version; applied larger overflow chevrons and constrained invalid-Matte error placement in current Save for Web pane.
2026-10-29 05:21:16 +01:00
FredApps eab48af082 Merge approved PhotoCraft PR #8986: Path tools: edit the saved path selected in the Paths panel (#8478)
Port behavior and regression coverage into current modules; preserve current upstream behavior.
Combined selected saved paths with current Type Path and targeted-mask editing; retained hidden Work Path exclusion independently of saved-path targeting, registered saved-path regressions and current modular overlay routing.
2026-10-29 05:20:45 +01:00