Commit Graph
11425 Commits
Author SHA1 Message Date
David Mann 1d5c69dda4 Merge PR #11458: Crop: fill the active layer and Background with Content-Aware Fill 2026-11-06 00:28:41 +01:00
David Mann f96e77e794 Merge PR #11553: Actions: replay recorded Perspective Warp steps 2026-11-06 00:28:38 +01:00
David Mann ed70b01354 Merge PR #11532: The Artboard tool's Add New Artboard button switches on a placing mode where a click puts a bar-sized board at the click (#11386) 2026-11-06 00:28:28 +01:00
David Mann a77d7d6b53 Merge PR #11503: Layer > Smart Objects says Reveal in Explorer, Embed Linked and Embed All Linked, in the reference order, without the Warp rows (#11401) 2026-11-06 00:28:25 +01:00
David Mann 932c38ee24 Merge PR #11449: Marquee: with no selection, Shift and Alt held from the press constrain the shape (#11389) 2026-11-06 00:28:22 +01:00
David Mann c581cd57c2 Merge PR #11455: Menus: Combine Shapes, Open Recent, Arrange and Proof Setup items carry the reference's names (#11399) 2026-11-06 00:28:19 +01:00
David Mann be08f07614 Merge PR #11453: Polygonal Lasso: History step "Polygonal Lasso" and Shift diagonals snap to the shorter offset (#11393) 2026-11-06 00:28:16 +01:00
David Mann d6d14dea8f Merge PR #11496: Artboard tool: the first board drawn in a document takes the Background in as "Layer 0" (#11387) 2026-11-06 00:28:10 +01:00
David Mann 45c797b85b Merge PR #11521: Shift+letter cycles a tool group in toolbar order and the anchor point tools no longer take the letter P (#11376) 2026-11-06 00:28:07 +01:00
David Mann fd69404ea5 Merge PR #11535: The healing slot starts on Spot Healing Brush and the brush slot lists Color Replacement before Mixer Brush (#11375) 2026-11-06 00:28:04 +01:00
David Mann 010e1a434d Merge PR #11461: Elliptical Marquee: the anti-aliased edge ramps across the pixel, matching the reference within 1 level (#11391) 2026-11-06 00:28:01 +01:00
David Mann 5f749c9324 Merge PR #11511: Select and Mask: E switches the tool mode between add and subtract (#11402) 2026-11-06 00:27:58 +01:00
David Mann 6ff31fa4f8 Merge PR #11437: Shortcuts: Ctrl+/ opens Layer › Lock Layers…, shown in the Layer menu and the Layers panel menu (#11397) 2026-11-06 00:27:52 +01:00
David Mann 9beb5a0cba Merge PR #11444: Selection tools: dragging the outline records Move Selection, as the reference does (#11390) 2026-11-06 00:27:46 +01:00
David Mann 9f3e07eebb Merge PR #11436: Move tool: Shift+drag of a layer locks to the eight directions, as the reference does (#11382) 2026-11-06 00:27:43 +01:00
David Mann 9f88425d83 Merge PR #11456: Shortcuts: Ctrl+Alt+0 also zooms to 100% and F9 also opens Actions, the reference's second keys (#11396) 2026-11-06 00:27:40 +01:00
yoriswind b5ff372c45 Check reference point ownership through the actual drag 2026-11-05 15:22:12 -08:00
dotCooCoo b7e5c92195 Merge main into feat/equalize-entire-image 2026-11-05 15:00:22 -08:00
ebosido444-ai 8c7b173e03 test(text): pin faux bold's ink at 12, 32, 72, 120 and 200 px
The ring is `max(size/72, min(size/40, 0.45))`; the ink test only checked
120 px. It now walks five sizes, asserts the ink rectangle grows by twice the
ring at each (the flat 3.6 % ring this replaced grew it by 0.072 * size), and
pins the bold/plain ink ratio: 1.35x at 32, 72, 120 and 200 px, 1.64x at 12 px
where the pixel floor is 3.75 % of the size.

No caller of the removed constant is left: `grep -rn FAUX_BOLD` finds only the
`type.fauxBold` menu command id, and `faux_bold_radius(size_px)` is the only
reader of the ring.
2026-11-06 01:47:53 +03:00
ebosido444-ai a68d2a3dbf fix(text): size faux bold by Photoshop's size/72 ring instead of a flat 3.6% (#9008)
Faux bold grew the outline by a flat 3.6% of the font size. Photoshop thickens
by about `size/72`, so a PSD's Faux Bold layer rendered 1.3-1.5x heavier than
the pixels Photoshop stored in the file. That shows up as soon as the layer is
clicked: it displays the PSD's own raster until edit mode re-renders it
(`begin_edit` -> `type.edit` -> `refresh_at`), and the text visibly turns
bolder at that moment.

`faux_bold_radius(size_px)` now returns the ring in pixels, fitted to
Photoshop's stored layer pixels: `size/72`, with a pixel floor that fades in
below ~32 px (Photoshop's small type reads heavier than `size/72`) and a cap so
a sub-pixel glyph does not grow into a blob.

Measured with a temporary probe that compared each type layer's render with the
PSD's own cached raster (alpha sum, no text or file content recorded) on a
4200x5940 CMYK document with five faux-bold layers, 18-60 pt at 300 dpi:

    layer   px size   ink vs Photoshop, before   after
    3        125        1.35x                    0.87x
    4        125        1.29x                    0.89x
    8        250        1.26x                    0.93x
    9         75        1.47x                    0.96x
    10        75        1.44x                    0.96x

Text without faux bold is untouched (the radius is only read for bold glyphs).

Tests: `faux_bold_radius_has_a_pixel_floor_that_fades_for_tiny_type` (the
fitted curve), `faux_bold_at_display_sizes_grows_the_outline_by_size_over_72`
(the weight at 120 px, 1.35x over plain; the flat ring measured 1.95x there),
and the weight pinned in `faux_bold_keeps_antialiased_edges_at_small_sizes`,
which was adjusted to the new ring.

(faux bold does not widen advances) is still open and not touched here.
2026-11-06 01:47:53 +03:00
yoriswind c59f12a4eb Reconcile Free Transform hit zones with the reference point toggle 2026-11-05 14:46:59 -08:00
e4e2607c85 Preview spot inks over the RGB/CMYK composite as an overprint (#10276)
* PSD: a flat file's named extra channels are not its transparency

A PSD without layer records had its first extra channel read as the merged
transparency, so the first spot or alpha channel of a flattened document
vanished and its ink punched a transparent hole in the image (psd-tools
cmyk-alpha-spot.psd, cmyk-spot.psd). When the alpha channel names (1045, or
1006 when 1045 is missing) name every extra channel and the first is not
"Transparency", there is none. The import also reads channel names from
1006 when 1045 is missing, and a spot whose DisplayInfo colour space is
unknown takes its ink from the Alternate Spot Colors (1067).

* channel_map: read 1067 records with as_chunks

* Preview spot inks over the RGB/CMYK composite as an overprint

Visible spot channels of RGB and CMYK documents print over the canvas
composite with the Multichannel ink formula, in Channels panel order,
instead of a tint; alpha channels and Quick Mask still tint over them.
Spot channels open visible, and the PSD thumbnail (1036) prints them.
flatten, export and the merged image stay free of spot inks. Ink
colours go through the document's CMYK profile, and into an RGB
document's own profile.

Refs #10249

* channel_view: test solidity over a gray picture

* Thumbnail: matte only inked pixels; test the merged planes directly

Review feedback on #10276: pixels without spot ink keep their
transparency in the thumbnail buffer, and the thumbnail test checks the
saved merged process planes instead of a re-imported flatten.

* Thumbnail spot inks: sample big boxes on a 4x4 grid

Review feedback on #10276: reducing each spot channel no longer scans the
whole document; a thumbnail pixel averages at most 4x4 samples, so a huge
document costs about h x 4 row reads per spot.

* Spot overlay: composite a proxy for the first draw of big documents

The overprint needs the composite under the inks. Rendering the full-resolution
composite to sample every factor-th pixel cost ~1 s for a 24 MP CMYK document.
A proxy document picks the same pixels (nearest-neighbour downsample) for about
1/factor² of the work. Documents with layer effects, vector masks or feathered
masks keep the full-resolution path.

* Proxy: downsample rows in parallel; the overlay proxy leaves out unused channels

The spot overlay's proxy shrank the spot channels, selection and Quick Mask that an
RGB or CMYK composite never reads: about two thirds of its cost. downsample now
reads its rows in parallel, 64 at a time.

* Spot overlay proxy: keep the full-resolution composite under uncached pattern fills

A pattern fill renders its tiles at their own size on a proxy, so the proxy would
sample other pattern pixels. Unless the fill's matching cache is shrunk with the
proxy, use the full-resolution composite.

* Spot overlay proxy: hidden layers don't decide the composite path

Hidden layers and the contents of hidden groups are not composited, so a hidden
feathered mask or pattern fill no longer forces the full-resolution composite
(the same rule as proxy_faithful).

* Update crates/compose/src/multichannel.rs

Co-authored-by: aiongg <67543387+aiongg@users.noreply.github.com>

* Spot overlay: only inked pixels replace the canvas; inks through the display transform

Where every visible spot is 0 the overlay stays transparent, so the normal
canvas (display LUT, proofing, 32-bit preview, full resolution) shows; an
empty spot renders no composite. Printed pixels go through the canvas
display transform (sRGB encoding of linear composites, monitor profile,
Proof Colors), keyed into the texture. Ink colours come from one InkSpace
per render: the document's profiles are parsed once, not per spot per
damage rect.

* test(compose): cover hidden spot preview and document approximation

* fix(ui-egui): preserve solo spot channel display when process colours are hidden

Clicking a spot channel row in the Channels panel targets the channel alone
and hides all process colour channels (`vis == 0`). Overprint inks were
previously extracted from `overlays` before checking `vis == 0`, leaving
`overlays` empty and causing the solo channel view to fall back to an active
layer mask (or return `None` if the layer had no mask).

Keep the spot channel in `overlays` so `vis == 0` can select it as the solo
grayscale picture, separating overprint inks only when process colours are
visible (`vis > 0`).

Adds a regression test targeting an existing spot channel in RGB and CMYK on
an unmasked layer and editing it.

* channel_view: document the spot overprint preview as an approximation

* test(ui-egui): solo spot channel wins over an unrelated layer mask

* channel_view: sRGB spot inks, lazy display transform, inked-area composite

Review fixes for the spot overprint preview:

- RGB spot colours are sRGB, like the CMYK, Lab and gray ones: InkSpace now
  converts them into an RGB document's own profile too. In a linear (EXR/HDR),
  Adobe RGB or ProPhoto document an RGB ink showed the wrong colour (brightened
  in a linear one once the canvas sRGB-encoded it).
- The display transform is looked up only when the view is redrawn and inks
  are shown, not every frame before the cache check; display_transform_for
  borrows the proof state (proof_ref) instead of cloning a default CMYK profile.
- Visible spot channels without ink, with nothing else shown, draw no texture:
  render returns None and ensure remembers it, instead of uploading an
  all-transparent document-sized texture. A damage re-render that finds nothing
  clears its rect, so erased ink never lingers.
- Printing a few inked pixels composites only their bounding box when that is
  cheaper than the whole (proxy) composite, and a cached composite is borrowed
  instead of copied.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: aiongg <67543387+aiongg@users.noreply.github.com>
Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 23:34:12 +01:00
e55e2f3577 Place decodes and fits in the background: dropping a large file no longer freezes the window (#10147)
* Place decodes, fits and renders in a background job

File > Place Embedded / Linked started with Session::start, and
Session::start_place_bytes for bytes with no path, now run the decode,
flatten, resize and SVG render on a worker (prepare_place) and insert the
layer when the job is applied (apply_place). Inline callers (execute, the
CLI, headless MCP, actions) behave and return exactly as before. Part of
#10031.

* Dropped and placed files no longer freeze the window on desktop

With background jobs on, File > Place and files dropped on the canvas start
the place as a job (JobsUi.place). Free Transform begins when the layer has
landed, a failed or cancelled place is reported and the drop queue goes on,
and a drop that arrives meanwhile waits for it. The place shows its progress
in the status bar instead of the modal dialog, so the view stays usable.
Part of #10031.

* Tests: compare place job results without the layer id

Layer ids come from a counter shared by every session, so a job and an inline place in two sessions never get the same one.

* Dropped files stay with the document they were dropped on

Each queued canvas drop now carries its document's id. A file is placed
only while that document is active: files dropped on a document in
another tab wait until it is back in view, and are discarded with a
message when it is closed. Web drops, read by the shell after the drop,
go to the document the drop landed on.

Before, the next queued file went into whichever document was active
when the previous place finished, failed or was cancelled, in the
background and inline paths alike.

* Remove the unused file_open import

* fix: address background placement review feedback

* fix: preserve drop targets and interrupt placement pixel stages

* fix: qualify placement inbox document identity

* test: wait for background placement in app drop regression

* fix: retain queued drops while external document jobs run

* test: clone rendered pixels from drop-managed buffers

* test: cover band rows channels and queued-drop resumption

* Place decodes and fits in the background: dropping a large file no longer freezes the window

Placing a file decoded, flattened and resized on the UI thread; a large PNG froze the
window for seconds (#10031). `place_bytes` is split into a session read, `prepare_place`
(decode, flatten, fit, translate, SVG render at placement scale) and `apply_place`, and
runs through `jobs::run`, so File › Place and canvas drops run on a worker with progress
and cancel. The window follows the job: status-bar progress, Free Transform when the layer
lands, and drops queued per target document.

Review fixes on the way:
- a path and byte drop queue entry records its target DocId, so files dropped on one
  document never land in another after a tab switch, and closed documents discard theirs;
- the closed-document notice stays up for a frame instead of being cleared by the next
  queued placement;
- the queue is bounded (32 files / 256 MiB) so drops waiting on another tab cannot grow it
  without limit;
- flatten and resize stop at the job's interrupt, and a place skips the modal progress
  dialog only when the status bar actually shows its progress;
- the placement's `doc` is kept only for SVG input, through the importer's `is_svg_input`;
- the interrupted-composite test uses an opaque fixture that varies by row and channel, and
  checks the composite against the layer's stored pixels.

* Place reads its file in the job, and refuses a huge canvas as before

file.placeEmbedded and file.placeLinked read the whole file in the
command before the job started, so a path dropped on the canvas or
picked in File > Place still blocked the window for the read. The place
now carries the path and reads it in prepare_place: on the job's worker
in the background, on the calling thread inline (wasm, background jobs
off), with the same read_file limit and error text. Whether the source
is a vector one is decided once it has been read.

The job's flatten check returned Other("the document canvas is too large
to flatten"), where the place used to give flattened_checked's
BadParams for file.place naming the canvas size. Both now share
check_flattenable, so the old error type and message are back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Path drops aren't capped, and a discarded drop wakes the queue

The 32-file cap on the drop queue counted path drops, which hold no
file contents while they wait, so dropping 40 files on the canvas
placed 32 and refused 8 where main placed them all. The count cap now
applies to browser drops only (each holds its whole file); the byte
budget still bounds those.

When place_next_dropped discarded a closed document's files it returned
without asking for another frame, so another document's queued files
waited for the next input event. It now requests a repaint when files
remain, keeping the one frame that shows the notice.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:49:52 +01:00
5c157e8400 Build the GPU compositor off the UI thread (#9969)
* Prepare GPU compositor in background

* Add compositor startup performance scenarios

* Generate scorecard in scratch CI

* Fix pipeline build type inference

* Address compositor startup review and document measurements

* Run startup performance checks on scratch CI

* Remove scratch performance job

* Count failed GPU attempts in frame timing

* Make shader fingerprint test portable

* Address review: run first-document scenario as a guarded group; share COMPOSITOR_BUILDING constant

* Handle compositor startup benchmark failures

* Fix frame timing after upstream merge

* Keep GPU startup failures on CPU fallback

* Record the failed GPU attempt of a deferred redraw, and bound --reps

A redraw deferred after a failed GPU composite carries that attempt's time to its end, where it is
recorded once beside the CPU time. Perf::record clears the attempt so a direct CPU refresh doesn't
inherit the last one's. perf_scenarios caps --reps.

* Refresh cached canvases after compositor build

* Expose canvas cache key to GPU completion handler

* ci: drop the GPU compositor probe job

AGENTS.md: feature and fix PRs don't add or change CI, and app workflows
only call the shared craft-common-actions workflows. The probe example
stays as a manual tool (cargo run -p photocraft-gpu --example
compositor_build_probe).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:49:12 +01:00
c441fd350c perf(paint): sampled, textured and wet-edge dabs rasterize on all cores (#11369)
* perf(paint): sampled, textured and wet-edge dabs rasterize on all cores (#11350)

The general dab loop runs its rows on the thread pool, with the same pixels as serially.
It reaches the pool from about 16,000 pixels, a quarter of the round path's threshold.

* test(paint): the parallel-vs-serial depth test checks colour, not alpha, for painted pixels

The opaque background's alpha (1.0) is 0.5 away from 0.5, so the check
passed even if nothing was painted (CodeRabbit on #11369).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(paint): read pixels with as_chunks (clippy chunks_exact_to_as_chunks)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:40:33 +01:00
yoriswind 3ba306e132 docs(crop): clarify content-aware fill targets 2026-11-05 13:32:51 -08:00
Finn NewickandClaude Opus 5.5 77b41ad917 fix(ui): wheeling a Properties Transform field is one edit (#9898)
Every wheel notch over the Properties panel's W, H, X or Y ran edit.transform (or
layer.translate) at once: N notches were N resamples, each of the previous result, and N
history steps, so a fast scroll destroyed the layer. A wheeled value is now held like a drag
(field_wheel::field_gesture_running) and applied once when the gesture ends: one resample
from the original pixels, one step. The held value keeps the layer it was wheeled on and is
dropped if another layer becomes active or its field stops drawing; wheeling W then H straight
away applies each once.

Fixes #9898.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:23:53 +00:00
Finn NewickandClaude Opus 5.5 ffdb797b19 fix(ui): Properties Opacity and Fill sliders keep a drag (#9683, #7601)
The Studio Properties panel's Opacity and Fill sliders re-read the layer's value every frame
and applied a change only when the drag stopped, but on egui's release frame the slider no
longer held the pointer, so it wrote the old value back and the knob bounced. Both sliders now
apply as they move through the Layers panel's pct_action: a drag is one history step, a click
one step, the change shows live, and errors go to the status bar.

Fixes #9683. Fixes #7601.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:23:53 +00:00
6326117c53 Web build: big operations that won't fit fail with an error instead of trapping, and a trap says so (#10129)
* Raster: ask the allocator whether a big operation fits; PSD save reserves its whole output

New photocraft_raster::headroom: ensure(need) tries to reserve the need plus a margin and frees it
at once (web only; native always passes), below(bytes) tells whether less than that can be
allocated, and simulate_available fakes the answer for tests and diagnostics.

PsdFile::to_bytes reserved only the pixel data, so embedded smart-object data and other tagged
blocks grew the output by doubling, which on the web is one unrecoverable huge realloc. It now
reserves the exact encoded length.

* Big operations that won't fit in memory fail with an error instead of trapping

Place, Image Size, a smart-object re-render and Save now ask the allocator whether their estimated
need can be allocated before they start (photocraft_engine::memory_gate, estimates per operation,
photocraft_io::estimate_export_bytes for saves). A refusal changes nothing and says what the
operation needed and what to do (save, Edit > Purge > All, close documents).

A standing notice warns when less than 512 MiB can be allocated, with hysteresis, so the user can
save before anything traps. Notices can now be sticky, which keeps them past the auto-hide delay.

* Web build: a trap says so instead of freezing the page, and ?free-mb simulates low memory

index.html holds a hidden, static 'PhotoCraft stopped' message with a Reload link. web.rs reveals
it when the module traps (the window error event, or an unhandled rejection from a spawned
future), tells running out of memory from an internal error by the panic message a chained panic
hook kept, and skips the Leave site prompt once stopped. ?free-mb=N makes the memory gates and the
low-memory warning see only N MiB, for checking them in a browser.

* Docs: web build memory handling in the gaps list and the parity assessment

* Engine: use is_multiple_of in the megabyte formatter

* Cargo.lock: the web shell depends on photocraft-raster

* Web boot page: carry the stopped message too, as the test that keeps the two pages equal requires

* Save check counts one copy of the document, and runs once per save

The encoded file's buffer is reserved fallibly, so a save it doesn't fit
in fails with an error instead of trapping; counting it as well refused
saves that would have fitted. On the background-save path the check ran
in write_document and again in start_save, which other callers reach
directly; it now runs only in start_save there.

* Review fixes: warning check allocates nothing, PSD merged image counted, automation saves checked

The low-memory warning's periodic check reads the size of linear memory
instead of reserving a block: wasm memory never shrinks, so a trial every
few seconds raised the high-water mark by up to 768 MiB for nothing. The
operation checks keep their trial reservation.

PSD and PSB saves always build a canvas-sized merged image (a placeholder
without maximum compatibility) and hold it raw and encoded; the save
estimate now counts it. The synchronous automation save checks memory
before encoding, as File > Save does, and its test asserts the memory
error.

The trap listeners go in before the app is built, so a trap while
building it shows the stopped message too, and a memory access out of
bounds reads as unexpected rather than as running out of memory.

* Cover layered PSD preflight limitation

* Fix layered PSD test iteration

* Docs: layered PSD preflight limitation in the gaps list

* Web OOM gate: gate direct exports, truthful advice for unbounded PSD sources (#10024)

* Web OOM gate: estimate layered PSDs per layer instead of refusing every real PSD

The PSD check admitted a file only when its color-mode data, image
resources and layer section were all empty. Every Photoshop file has
image resources (at least the resolution), so on the web nearly every
real PSD was refused for Place, PSD smart objects could not render,
and Image Size was refused for documents holding one, whatever the
free memory (u64::MAX never fits).

The color-mode data and image resources hold no pixels, so they are
now only skipped. A layered file reads its layer count from the layer
info (signed, absolute value) and adds a canvas-sized surface and mask
per layer to the flat estimate. Files that are not 8-bit RGB or
grayscale, keep their layers in a Layr tagged block, or whose sections
can't be read stay unbounded and refused, as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Web stopped page: match trap messages ignoring case

Safari reports the allocation-failure abort as "Unreachable code
should not be executed" and Firefox says "out of memory", which the
case-sensitive matching missed: the trap was not recognised, or was
shown as an unexpected stop instead of running out of memory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Export estimate: count the merged image OpenRaster writes

The ORA writer keeps the layers but also flattens the document for
mergedimage.png, a 16 B/px composite of the canvas, which the
estimate left out.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:04:59 +01:00
a3c0b7258c Select Subject: keep parts that run off the image edge and detached parts near the subject (#10160)
* Select Subject: keep parts that run off the image edge and detached parts near the subject

The backdrop pass trained its colour model on the whole frame outside the first
result's box and fixed it as background, so a subject cut off by the edge (a
portrait's torso) taught the backdrop its own colour and was dropped. Frame
pixels of a side that the rest of the frame cannot explain are now left out of
the model and left to the cut; a floor or table running up the sides stays
backdrop.

The first pass also dropped every part under a fifth of the largest, losing a
head behind a thin neck or a tail. Non-speck parts next to the main one are kept.

* Select Subject: stray edge pixels stay backdrop; cache test checks the recompute

A lone odd pixel in the frame (noise, a dead pixel) is not the subject running
out of the picture: only patches of at least half a frame square are released.

The #2865 cache test asserted a bit-identical selection after painting a corner
pixel. One changed pixel can move the cut's edge slightly (the original
algorithm already did on other noise), so it now checks that the mask was
recomputed and still selects the subject.

* Test subject selection against edge and nearby clutter

* Keep narrow edge clutter out of subject selection

* Preserve cropped subject components at image edges

* Keep edge poles and diagonal streaks out of subject selection

A detached part counted as near the subject when its bounding box
overlapped the main part's margin box. A thin diagonal streak from a
corner (a cable, a rail) has a box that reaches the margin without any
of its pixels doing so, and was kept as part of the subject. A part is
now near only when some of its pixels lie inside the margin box.

A patch that runs along an image edge for two frame widths was released
from the backdrop model whatever its colour, so a pole or door frame
along a side edge next to the subject's shoulder was left to the cut,
which could grow the selection along it. A wide patch is now released
only where its extent along the edge overlaps the first-pass blob's
margin box. Beside the subject that box is cut out of the frame, so the
pole only remains above or below it and is not released, while a torso
cut off below a head (the case the release exists for) still lies under
the head's box. Requiring the subject's colour for wide patches too, or
requiring them to touch the box, would drop exactly that torso: its
colour is not in the head-only blob and it is far from the head's box.

The margin box computation moves into margin_box so subject_at_edge
and its tests share it. Tests pin the diagonal streak, the pole beside
the shoulder (on all four edges, with the cropped torso still
released) and clutter that is too far or too small.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:04:32 +01:00
f127459ca3 perf(algo): build Remove Tool target masks with a bounded separable dilation (#10179) (#10194)
* perf(algo): build Remove Tool target masks with a bounded separable dilation (#10179)

* docs(algo): remove::dilate no longer always runs two full-grid passes

* test(algo): shrink the square dilation tests

Exhaustive masks up to 3x3 instead of 4x4, drop the 300x200 named grid
(the smaller grids already clip at r = 200, so its oracle-cost guard goes
too), and run the path-choice tests on 600x400 and 240x240 grids.

* test(algo): a mask with more set cells than bounds keeps matches the oracle

Covers the branch where bounds drops its cell list (more than KEEP set
cells) and the direct path rescans the box.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:04:08 +01:00
fcb4f4e494 Grow and Similar: budget the colour index and report allocation failures (#9825)
* Select: Grow and Similar index colours under a byte budget and fail instead of aborting

ColorMatcher::new returns a Result, the colour tree is a flat node array reserved at its exact size, and Grow/Similar's mask and frontier stack use fallible allocation so a failure keeps the selection.

* Select: a 1 GiB colour index on 32-bit, and Sample All Layers reports a failed composite

The web build's 256 MiB index budget (about 4.2M colours) refused Grow and
Similar on a noisy 24 MP photo whose index fits easily; 1 GiB admits every
distinct colour of such a photo. The 64-byte charge per colour is an average,
not a worst case, so the comment now says so, and the point list the tree keeps
gives back its doubling slack once the dedupe set is gone.

Sample All Layers renders the composite inside compose, so the selection tools
now pass an allocation checkpoint before it, like the other commands that hand
big work to another crate, and a failure there keeps the selection.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:03:48 +01:00
yoriswind 8bc5399652 Keep unknown Stack Mode None descriptors inert 2026-11-05 12:57:30 -08:00
Trevor BrownandClaude Fable 5.1 6e6fb8ef12 Artboard placing mode ends on every tool change, the shortcut path included (#11386)
tool_memory::ended_by_tool is the one rule that clears the mode when the current tool is not the Artboard tool. tool_memory::select and the tool-key shortcut path both call it right after they set the tool. The pointer and options-bar clears stay as a last resort.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 15:47:24 -05:00
Higgs32584andClaude Opus 5.5 caf7b95dc2 Menu scroll arrows: import what dropdown.rs uses; arrows as wide as the rows (#2091)
The upstream split of widgets.rs moved menu_scroll into widgets/dropdown.rs,
whose imports lacked Sense, Stroke, Tokens, pos2 and vec2 that the arrows use,
so photocraft-ui-egui no longer compiled. The arrows were also allocated at the
popup's whole available width, which widened an overflowing menu on later
opens; they now take the rows' width from last frame (the scroll area's
content width; its inner_rect is the width asked for, before auto-shrink).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 15:29:13 -05:00
Trevor BrownandClaude Fable 5.1 cfc63b2b8e The Artboard tool's options bar gets the iPhone 8/7/6 default size, a background control, the Align panel and the gear menu (#11385)
The bar now starts at iPhone 8/7/6, 750 x 1334 px, with a White background and four checked gear entries, all kept as serde tool options that Reset Tool restores. With no board selected, Size, W and H edit those options; the background reaches layer.new.artboard when the tool draws a board; the Align panel runs the matching layer.align command on the selected boards, and the gear's Auto-nest Layers turns the Move tool's auto-nesting on and off.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 15:21:29 -05:00
Trevor BrownandClaude Fable 5.1 4c33342af1 Artboard placing mode: reported by ui.inspect, cleared on every tool change, and the button is tested (#11386)
ui.inspect now returns an artboardTool entry with the adding flag. tool_memory::select clears the mode whenever the new tool is not the Artboard tool, so switching away and back in one pass leaves it off. A harness test clicks Add New Artboard twice and checks the mode and that no board is added.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 15:15:55 -05:00
Trevor BrownandClaude Fable 5.1 d9e983549e Alt-click on the reordered healing and brush slots is covered through the pointer (#11375)
The new test pointer_alt_click_steps_the_healing_and_brush_slots_in_the_new_order drives Alt-click on each slot button, following alt_click_cycles_the_tool_flyout_slot, and checks the full wrapped sequence.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 15:11:04 -05:00
Michael Higgins a8f7c1fe2d Merge branch 'storytold:main' into fix/2091-menu-scroll-arrows 2026-11-05 15:08:12 -05:00
Trevor BrownandClaude Fable 5.1 366a4a0df9 Toolbar order applies to Shift presses only; a plain letter from outside the group picks what it did before (#11376)
The sort now runs only when the Shift key cycles, so the Shift cycle and the Shift fallback to the group's first tool use the toolbar order while plain presses keep the Tool::ALL order. A test pins plain W from the Move tool selecting the Magic Wand.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 15:01:58 -05:00
Trevor BrownandClaude Fable 5.1 b3f3cabf44 Right-click on the toolbar's "…" button opens a flyout with one row, Edit Toolbar… (#11378)
The flyout is drawn like a tool flyout, beside the button. Its row runs edit.toolbar and closes it; Escape or a press outside closes it without running anything. A left click on the button still opens Edit Toolbar directly.

Press-and-hold on the button is not measured and is not added.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 14:54:56 -05:00
Trevor BrownandClaude Fable 5.1 e0d6b77160 feat(move): options bar gets Distribute buttons, the ... icon panel and the gear menu (#11381)
The Move tool's bar now shows Align and Distribute in the measured order, a compact ... icon panel that only a second click closes, and a gear menu with three check items (hover bounds, expand group on click, hover bounds from Layers). The items are on by default, saved with the Move tool options and reset by Reset Tool, and each one switches the behaviour it names.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 14:53:25 -05:00
3317aede3b Fix Paint Bucket target with Gradient-style crosshair (#7994)
* Mark Paint Bucket fill target with a lower-right crosshair

* Unify Paint Bucket artwork and crosshair in one cursor bitmap

* Match Paint Bucket target crosshair to Gradient cursor

* Keep Paint Bucket cursor errors concise and fix Windows Clippy

* Simplify blend preview condition for strict Clippy

* Fix deprecated IDs in Linux bucket cursor test

* Paint Bucket: a cursor error clears when the cursor recovers

The failure branch wrote its error to the status bar, but nothing cleared
it after a later scale worked, and the same failure could not report again.
The open dialog stays until it is closed: it reports what happened.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: envy-ai <bart.kelsey@osumc.edu>
Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 20:27:28 +01:00
Trevor BrownandClaude Fable 5.1 9afc9295a7 Toolbar order applies to Shift-switch cycling only; plain letters keep their order (#11376)
With "Use Shift Key for Tool Switch" off, plain letters cycle the group, and that case was not measured. The toolbar-order sort now runs only when the preference is on; with it off the group keeps its Tool::ALL order. A test pins plain W from Magic Wand going Quick Selection, Object Selection, Magic Wand.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 14:19:44 -05:00
Trevor BrownandClaude Fable 5.1 87062ef0c0 The healing slot starts on Spot Healing Brush and the brush slot lists Color Replacement before Mixer Brush (#11375)
TOOL_SECTIONS and Tool::ALL now order the healing slot as Spot Healing, Remove, Healing, Patch, Content-Aware Move, Red Eye and the brush slot as Brush, Pencil, Color Replacement, Mixer Brush. A fresh healing slot shows Spot Healing Brush and J selects it.

Existing tests that expected the old orders (B and J cycles, the brush flyout click, the shortcut override test) are updated. The engine's shortcut table keeps the same order as Tool::ALL, so its two pairs are swapped to match.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 14:12:50 -05:00
Saloouu 8f2b952359 Tool keys look through the list for the last tool they can still pick 2026-11-05 20:11:15 +01:00
Trevor BrownandClaude Fable 5.1 b9cf495f57 Embed All Linked: tests check each object keeps its own linked file; regenerate the scorecard (#11401)
The Embed All Linked test now gives every fixture a different fill and asserts each embedded source carries its own linked file name and bytes, and leaves the already embedded object alone. docs/scorecard.md is regenerated with cargo xtask scorecard after the parity checklist.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 14:00:46 -05:00
Trevor BrownandClaude Fable 5.1 b03637e258 Select and Mask E test: a polygon closed after E keeps the mode it started with (#11402)
The polygon test now gives the polygon a third point, presses E, closes it with Enter, and checks that the recorded lasso edit has mode add while the workspace mode is subtract.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 13:59:55 -05:00
Khawar Zamman Wani eecc821ee8 Scratch room uses what the user can write; a failed volume query is unknown
sysinfo reports a Windows volume's free bytes, which a per-user disk quota can
exceed, so admission could promise room the user can't write. free_space now asks
GetDiskFreeSpaceEx for the bytes available to the caller.

sysinfo also keeps a volume whose space query failed, with both numbers zero, which
read as an empty disk and would pause spilling. A zero total now counts as unknown.

Docs: describe network scratch per platform and the size limit's import allowance.
2026-11-06 00:21:07 +05:30
Trevor BrownandClaude Fable 5.1 fce6d91d1b The Artboard tool's Add New Artboard button switches on a placing mode where a click puts a bar-sized board at the click (#11386)
The button now toggles a mode flag in ArtboardToolUi instead of adding a board beside the last one. With the mode on, a click on empty canvas runs one layer.new.artboard with rect = [click x, click y, bar width, bar height], rounded to whole pixels. Switching to another tool ends the mode, and layer.new.artboard without a rect is unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 13:45:00 -05:00