Commit Graph
11425 Commits
Author SHA1 Message Date
Trevor BrownandClaude Fable 5.1 e761b30160 View › Guides: the menu cache keys on the selected guide; scorecard regenerated (#11400)
The menu state hash now includes the selected guide, so Edit Selected Guides and Clear Selected Guides follow a selection change made by a canvas press while a title menu is open. docs/scorecard.md is regenerated with cargo xtask scorecard, and the flat-rows test now checks each guide command appears exactly once and sits in View › Guides.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 13:29:36 -05:00
Saloouu 75df80fe33 Merge main and regenerate the scorecard 2026-11-05 19:18:47 +01:00
Trevor BrownandClaude Fable 5.1 4083cb6cf4 Artboard first-board test: the Background's pixels travel with it and come back on undo (#11387)
The first-board test now samples pixels as well as names and locks: Layer 0 holds the Background's white after the move, Red keeps its red, and the Background restored by undo holds the same white. This catches a regression that swaps in an empty unlocked layer named "Layer 0".

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 13:06:47 -05:00
Trevor BrownandClaude Fable 5.1 f336f8e28c Select and Mask E test: through handle(), with and without a focused text field (#11402)
Two tests send a bare E through the shortcut handler with Select and Mask open. With a text field focused the mode stays, and without one the mode flips, so the text-edit gate in handle() is covered.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 12:56:36 -05:00
Trevor BrownandClaude Fable 5.1 7ea1eb13b0 Tab menu test: the clicked tab is not the active one (#11403)
The multi-document Move to New Window test now makes document 0 active and clicks the menu on tab 2, then checks that tab 2 floated and document 0 did not. Before, the clicked tab was also the active one, so a regression that floated the active document would have passed.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 12:56:01 -05:00
Trevor BrownandClaude Fable 5.1 8d33de79b0 Shift+letter cycles a tool group in toolbar order and the anchor point tools no longer take the letter P (#11376)
The group Shift+letter steps through is now sorted by position in TOOL_SECTIONS, so it follows the flyout instead of Tool::ALL. Add Anchor Point, Delete Anchor Point and Convert Point have no default letter, so P cycles only Pen, Freeform Pen and Curvature Pen.

The engine's shortcut table lists the three anchor point tools without a key to match, and two tests that expected the letter P for them are updated.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 12:53:30 -05:00
Khawar Zamman Wani af2914fd17 Refusal wording holds when memory sets the 32-bit limit; keep non-UTF-8 scratch paths
On a 32-bit build, free RAM or commit headroom can set the limit instead of the
cap, and then 'install the 64-bit build' was wrong. The message now mentions the
cap and says the 64-bit build may open the file.

The verbatim prefix is now removed through path components, so a scratch path with
a non-UTF-8 name still finds its disk. The UNC rewrite is gone: sysinfo lists only
fixed and removable volumes, so a network path can never match. That limitation is
now documented.
2026-11-05 23:22:13 +05:30
Trevor BrownandClaude Fable 5.1 14d9de4f86 Merge upstream/main into fix/smart-objects-menu-11401
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 12:42:11 -05:00
Taxperia f7ab833411 Merge latest main and complete Azerbaijani frame labels 2026-11-05 20:30:18 +03:00
Trevor BrownandClaude Fable 5.1 05d7ac607a Select and Mask: E switches the tool mode between add and subtract (#11402)
The reference application's default key "Cycle Tool Mode: E" had no binding in the Select and Mask workspace. E now flips the shared add / subtract mode when an editing tool is active, and the options bar's + and - buttons follow. Hand and Zoom, and E with any modifier held, do nothing.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 12:29:06 -05:00
Trevor BrownandClaude Fable 5.1 c9714b36af Smart Objects menu: Embed Linked and Embed All Linked in every catalog (#11401)
Adds an Embed All Linked row to all 27 translation catalogues and re-drafts Embed Linked where the copied Convert to Embedded text still said convert. Reveal in Explorer is unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 12:28:08 -05:00
Davit MatchakhelidzeandClaude Opus 5.5 87393e92d5 i18n(ka): Georgian for 11 new strings (Actions playback options, defaults)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YMTAbGNRxnMEzRvYnQGphF
2026-11-05 21:24:16 +04:00
Trevor BrownandClaude Fable 5.1 093cba6cc1 Tab menu: the two remaining labels in every catalog (#11403)
Consolidate All to Here and Move to New Window now have a row in each of the 27 translated catalogs, next to New Document… and Open Document…. They are drafts built from each file's own wording for Consolidate All to Tabs, Float in Window and New Window, for the native reviews.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 12:23:11 -05:00
Trevor BrownandClaude Fable 5.1 712da4f05e Layer > Smart Objects says Reveal in Explorer, Embed Linked and Embed All Linked, in the reference order, without the Warp rows (#11401)
Windows now reads "Reveal in Explorer", Convert to Embedded is "Embed Linked", and a new Embed All Linked command (layer.smartObjects.embedAllLinked) embeds every linked smart object of the document in one history step, refusing the whole step with an error that names a missing file. The three Warp rows leave the submenu; their commands stay registered for scripts and the Edit menu.

The menu parity floor drops from 660 to 658 because three live catalog rows were removed and one added.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 12:20:09 -05:00
Trevor BrownandClaude Fable 5.1 3b62794f66 The document tab's right-click menu lists the reference's eight entries in order, with its two separators (#11403)
The menu now reads Consolidate All to Here, Close, Close All, Close Others, Move to New Window, then New Document… and Open Document…, then the reveal entry. Each row runs the command named in the issue on the clicked tab; Consolidate All to Here and Close Others are greyed with one document, and Move to New Window stays enabled.

Both tab strips share the menu, so the floating window gets the same rows. The new tests are in doc_tab_menu_tests.rs.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 12:18:50 -05:00
yoriswind 19ac2452a0 Merge Batch 17 while preserving Crop fill and Artboard sizing 2026-11-05 09:15:36 -08:00
Higgs32584 94fd55ad98 Merge remote-tracking branch 'upstream/main' into fix/8208-move-click-after-resize
# Conflicts:
#	crates/ui-egui/src/tools/transform_tool/pointer.rs
#	crates/ui-egui/src/transform_commit_click_tests.rs
2026-11-05 12:13:42 -05:00
Davit Matchakhelidze 4803183fdf Merge upstream main into ka 2026-11-05 21:10:56 +04:00
yoriswind 8a126888f3 Merge upstream main after integration batch 17 2026-11-05 09:09:02 -08:00
Trevor BrownandClaude Fable 5.1 4d679b3a1c Layers panel menu: the thumbnail rows' labels in every catalog (#11404)
Adds No, Small, Medium and Large Thumbnails and Clip Thumbnails to Document Bounds to the 26 translated catalogs, next to the existing Clip Thumbnails to Layer Bounds row. They are drafts in each catalog's own style; hi.tsv is English-only and is left alone.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 12:04:23 -05:00
David Mann 405b56c3c2 Merge pull request #11320 from davidmann4/integration-batch-17
Integration batch 17: 14 epic PRs
2026-11-05 18:02:17 +01:00
Trevor BrownandClaude Fable 5.1 f2e541e97d Layers panel: a right-click on the empty area opens the reference's menu (#11404)
A right-click below the last layer row now opens a menu with No, Small, Medium and Large Thumbnails, a separator, then Clip Thumbnails to Layer Bounds and Clip Thumbnails to Document Bounds. The size entries set the same panel option Panel Options... sets and save it the same way, and the clip entries go through prefs.set. A left click there still deselects every layer and a right-click does not.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 11:59:26 -05:00
yoriswind 1a68a20c1c fix(actions): match the fixed-width pixel unit array 2026-11-05 08:50:56 -08:00
yoriswind 9f393ebeb5 Require the null class for edited Stack Mode None provenance 2026-11-05 08:50:31 -08:00
Taxperia 25ed8e5cb8 Merge upstream main and verify Azerbaijani command translations 2026-11-05 19:49:51 +03:00
yoriswind b6bb43bc19 Handle edited Stack Modes and cap video frame growth 2026-11-05 08:48:40 -08:00
yoriswind 0bd6c4de71 style(actions): match the Perspective Warp pixel unit directly 2026-11-05 08:47:11 -08:00
Claude 2347d0bdaa Merge remote-tracking branch 'upstream/main' into fix/typing-records-one-step
# Conflicts:
#	crates/engine/src/jobs.rs
#	crates/ui-egui/src/dialogs.rs
2026-11-05 16:45:46 +00:00
SvenCarstensen 657182ac6f Test exact guide positions, unit changes and subsequent text edits 2026-11-05 17:42:20 +01:00
SvenCarstensen 426ac67593 Honor edited guide positions matching the initial readout 2026-11-05 17:40:59 +01:00
Trevor BrownandClaude Fable 5.1 2dd2e0a532 Menus: View › Guides submenu in the reference's order, with Edit Selected Guides and Clear Selected Guides (#11400)
The seven flat guide rows in View move into a View › Guides submenu in the reference's order, joined by two new catalogue commands, view.editSelectedGuides and view.clearSelectedGuides. They run the same helpers the guide right-click menu used, are enabled only while a guide is selected, and return an error with no guide selected. The right-click menu now uses the same ids.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 11:40:58 -05:00
yoriswind fbccaaeabb style(actions): apply Perspective Warp formatter 2026-11-05 08:40:04 -08:00
SvenCarstensen acd8c0e04a Preserve exact guide positions across unit changes 2026-11-05 17:39:56 +01:00
Khawar Zamman Wani 83f492f445 Windows scratch room is measured; hard memory refusal names the build's limit
fs::canonicalize returns verbatim paths on Windows, whose prefix never equals a
disk's plain mount point, so free_space always returned None there. That removed
the scratch allowance from import admission (unless a size limit was set) and
turned off the low-disk check.

The PsdHardBudget message said 'on this machine' even when the limit is the fixed
cap of the 32-bit desktop or web build. It now says so and names the build to use.
2026-11-05 22:07:47 +05:30
yoriswind 3feae0e0b6 Actions: map recorded Perspective Warp planes 2026-11-05 08:36:06 -08:00
Trevor BrownandClaude Fable 5.1 3718b5468e Artboard tool: the first board drawn in a document takes the Background in as "Layer 0" (#11387)
Drawing the first artboard now turns the Background into a normal layer named "Layer 0" and moves it into the new board, in the same "New Artboard" step, as the reference does. The engine does this behind a new `takeBackground` param on `layer.new.artboard`, which the Artboard tool's drag sets; the menu command and scripts keep their result.

A document that already has a board, or has no Background, gets the same result as before.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 11:27:33 -05:00
16eef63294 Type: a duplicated type layer is renamed after its new text (#9023) (#10352)
* Type: a duplicated type layer is renamed after its new text (#9023)

A type layer's name follows its text until the layer is renamed (#483),
but only while the name is exactly the text. A duplicate is "Title copy"
(or "Title copy 2"), so editing its text kept the old name. A name that
is the text plus Duplicate Layer's " copy" or " copy N" now counts as
named after the text too, so the copy takes its new text's name; any
other name is still kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Type: a copy of a "… copy" type layer follows its text too (#9023)

Duplicate Layer names a copy of "Draft copy" "Draft copy 2", so the
check now compares the names' roots (the name before " copy" or
" copy N") rather than adding " copy" to the text's name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Type: a copy keeps its "… copy" name until its text changes (#9023)

A type layer named after its text was renamed after every edit through
the type helpers, so with "Title copy" now counting as named after its
text, Change Type Size, a style-only or kerning edit, Convert to
Paragraph or Point Text, Area Type and Type on a Path renamed the copy
"Title". The name now follows the text only when the text changed; a
layer named exactly after its text gets the same name as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Type: a "… copy" name the user typed is kept when the text changes (#9023)

A type layer named "Title copy 2" by hand, with "Title" as its text,
counted as a Duplicate Layer copy and was renamed after its next text
edit. The document now remembers the names the user typed (Rename
Layer, a name Duplicate Layer's dialog didn't offer, type.edit's name)
for the session, and such a name is kept. A name Duplicate Layer made
still follows the text, and so does one an undone rename brings back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Type: a name given in the Layers panel or by type.create is the user's (#9023)

The Layers panel renames in place with layer.setProps, and type.create
takes a name: neither recorded it in typed_names, so a copy-shaped name
typed there ("Title copy 2" on text "Title") was replaced by the next
text edit. Both now record it, as Rename Layer and type.edit's name do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Type: a name typed for a duplicate into another document is the user's (#9023)

Duplicate Layer into a new document and Copy Layers to Document take a
name but returned without recording it, so a copy-shaped name typed there
was replaced by the next text edit. A name other than the copy's own is
now recorded in the destination document, as the in-document duplicate
does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
2026-11-05 17:27:14 +01:00
Trevor BrownandClaude Fable 5.1 9c58dd8ea0 Menus: Edit › Preferences says Plugins… and Camera Raw… and has the reference's separators (#11398)
The catalogue now labels the Preferences rows "Plugins…" and "Camera Raw…" (was "Plug-ins…" and "Raw Defaults…"), and the engine label and the dialog page name for plugIns say "Plugins" too. Two "---" rows sit after the first entry and before Camera Raw…. Ids and section keys are unchanged, and each translation file gets "Plugins…" and "Plugins" rows next to the old ones.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 11:24:43 -05:00
Luis daa9a01955 Release: refresh contributor credits for each release (#8737) (#11426)
About > Contributors still showed a snapshot from 2026-10-10, because
nothing regenerated contributors/contributors.json before a release.
Opt in to the shared refresh from craft-common-actions: a read-only
credits job regenerates the snapshot for the release commit, and the
shared release workflow installs it before every source build. The
snapshot is not committed back.
2026-11-05 17:23:30 +01:00
FredAppsandClaude Opus 5.5 4943e2c3da fix(ui): About credits table columns can be dragged wider or narrower (#11182)
* fix(ui): About credits table columns can be dragged wider or narrower

The Contributors and Models tables already open fitted to the dialog, the
name column taking the spare width, and scroll sideways only when there is
not room for every column. Their columns were fixed, though: no edge could
be dragged. They are resizable now, down to 28 points (the flexible column
to its minimum). Widening a column grows the table, as in a spreadsheet,
and only then does it scroll sideways; cells clip instead of overlapping.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* About: refit credits tables when what they measure changes

The columns became resizable, so the table keeps its own widths. A longer
name, a changed cell or a resized window left the old widths in place and
clipped text. The table now goes back to its fit when a column measure or
the clip rect width changes, which scrolling never moves.

Adds tests that drag every column edge, change the fit and scroll a
widened table, as CodeRabbit asked for the drag.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Tests: a fitted credits table fills the window exactly

The table ends on the window edge, which the layout rounds to whole points,
so the check allows that edge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 17:23:15 +01:00
David Mann 5e7a097d10 Merge commit '20d561715b' into integration-batch-17
# Conflicts:
#	crates/engine/src/cmd/transform_cmds.rs
2026-11-05 17:20:07 +01:00
SvenCarstensen cf69b5fd0b Merge branch 'main' into codex/guide-position-units 2026-11-05 17:19:54 +01:00
David Mann 37f9d3b7d4 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/codecs/src/codecs/png.rs
2026-11-05 17:18:28 +01:00
Khawar Zamman Wani 33e20b5707 Add recipe-driven checks for PSD exports (#10307)
* Add recipe-driven PSD export checks

* Exercise PSD recipe runner with the headless CLI

* Make PSD oracle tests isolate temporary paths

* Keep inspect output unchanged; PSD write runner as an xtask library

- info --detail adds text runs, anti-aliasing and full layer-effect settings;
  the control channel and MCP inspect output is unchanged.
- The CLI test uses xtask's new library target instead of #[path] includes.
- The runner records revision and dirty state as unknown outside a git checkout.

* psd-write-oracle: name the layer in each check, document versioning, add recipe tests

* Clean up PSD oracle test fixtures on failure with tempfile::TempDir and add docstrings
2026-11-05 17:18:03 +01:00
David MannandClaude Opus 5.5 7f151b6542 algo: filter admission counts no more workers than tiles
Since 42e92cb512 the Shape Blur admission also counts each worker's f64
prefix sums, but it charged every rayon thread even when the area has
fewer tiles. A 24 MP Shape Blur at radius 500 (24 tiles of 1024 px) was
charged for 32 workers and refused under the CLI's default 8 GiB policy,
which main still ran (5.4 GB peak measured). Workers are now capped at
the tile count, for every radius filter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 17:14:19 +01:00
Khawar Zamman Wani f54d605e2c Add recipe-driven checks for PSD exports (#10307)
* Add recipe-driven PSD export checks

* Exercise PSD recipe runner with the headless CLI

* Make PSD oracle tests isolate temporary paths

* Keep inspect output unchanged; PSD write runner as an xtask library

- info --detail adds text runs, anti-aliasing and full layer-effect settings;
  the control channel and MCP inspect output is unchanged.
- The CLI test uses xtask's new library target instead of #[path] includes.
- The runner records revision and dirty state as unknown outside a git checkout.

* psd-write-oracle: name the layer in each check, document versioning, add recipe tests

* Clean up PSD oracle test fixtures on failure with tempfile::TempDir and add docstrings
2026-11-05 17:11:56 +01:00
yoriswind 7604b34cdc Check descriptorless Stack Mode in ATN registry round-trip 2026-11-05 07:33:06 -08:00
834e253377 Canvas: a right-click that moved a few pixels still opens its menu (#10183) (#10351)
* Canvas: a right-click that moved a few pixels still opens its menu (#10183)

egui reports a secondary click only within its click distance of the
press, and a high-DPI mouse moves that far just from the button going
down: the right-click then counted as a drag, and the Brush Preset
picker, the canvas tool menus and the layer menu did not open. A right
press released over the canvas now opens them however far the pointer
moved, unless a gesture used that drag (Alt+right brush resize, a
right-erase stroke).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Canvas: the Hand pans with the left and middle buttons, not the right (#10183)

The Hand tool panned on a drag with any button. Now that a right-click
that moved still opens the canvas menus, a right drag with the Hand
panned and then opened its view menu on release. In Photoshop the Hand
pans with the left button and its right-click is the view menu, so a
right drag now opens that menu without panning; the left button, Space
and the middle button pan as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Canvas: a right-click moved and released in one frame opens its menu (#10183)

When the move past the click distance and the release reach egui in the
same frame (a slow frame), it reports neither a click nor a drag stop,
so the menu still did not open. The canvas now keeps its own right press:
one that went down over it and comes up over it that frame is a
right-click too, unless a gesture used it (Alt+right resize, a right-erase
stroke). The menus open where the button came up.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Canvas: a right-click counts only when it was pressed on the canvas itself (#10183)

The canvas's own record of a right press checked only that the press
was inside the canvas's rectangle. A right press on a popup over the
canvas (the Brush Preset picker, a tool's canvas menu) that moved off it
and came up in the same frame reopened the popup where the button came
up, and every right-click on a canvas scrollbar opened the picker or the
tool's menu.

A right-click past egui's click distance now needs the press to land on
the canvas itself, as a still right-click does: under no popup or
window, and not on a scrollbar or another control drawn over the
canvas. The release must come up on the canvas the same way. A right
press that an Alt+right brush resize or a right-erase stroke used still
opens nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Canvas: a right button that took part in a pan is no right-click (#10183)

Making the Hand pan with the left and middle buttons only went too far:
Space and a right drag no longer panned with any tool, and the selected
Hand stopped panning with the back and forward mouse buttons. Only the
selected Hand's right button has another use, its view menu. Now the
Hand pans with a drag of any button, except a drag with the selected
Hand's right button on its own, which still opens the view menu where
the button comes up.

A right button that took part in a pan no longer counts as a
right-click when it comes up. Letting go of Space before the right
button at the end of a Space+right pan used to erase a dab (Erase
preference) or open the Brush Preset picker; it now just ends the pan.
A left pan with the Hand with the right button pressed in, either way
round, no longer opens the view menu.

A right-click is the right button on its own: a right press made while
another button is down, or one joined by another button, only counts as
the still click egui itself reports. A right press moved during a left
brush stroke opens no picker again, as before #10183.

The canvas now follows its right press on every frame, panning or not.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Canvas: Escape while the right button is down cancels the right-click (#10183)

Pressing Escape during a right drag that had moved past the click
distance did not cancel it: when the button came up, the Brush Preset
picker or the canvas tool menu still opened. The same happened after
Escape closed a Shift+Alt+right HUD Color Picker and the button was
then let go somewhere else. Before #10183 nothing opened in either
case, because a moved right drag was never a click.

Escape pressed while the canvas follows a right press now cancels that
press, so its release opens nothing. The canvas reads the Escape from
the frame's own key events, so a shortcut or a popup that already took
the key does not hide it. A still right-click that egui itself reports
is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Canvas: Space and a right drag pan with the Hand selected too (#10183)

With the Hand tool selected, holding Space and dragging with the right
button opened the Hand's view menu instead of panning. Before #10183 it
panned, as Space and a right drag still do with every other tool.

Space is the pan itself, so with Space held a right drag now pans with
any selected tool, the Hand included, and the pan uses the press: no
view menu opens when the button comes up. Without Space, the selected
Hand's right drag still opens its view menu without panning. Ctrl or
Shift with the Hand's right button are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Canvas: a moved right-click points where the button went down (#10183)

A right-click on a guide with the Move tool that moved a few pixels past
the click distance, across the guide, opened the menu of the layers
under the pointer instead of the guide menu. The canvas menus found
their target where the button came up, and by then the pointer was off
the guide. Before #10183 such a click opened nothing.

A right-click that the canvas counts itself, past egui's click distance,
now points where the button went down: that is what was right-clicked.
Every canvas menu finds its target there (a guide, the layers under it,
the pasteboard, a pending crop) and opens there too, so the Brush
Preset picker, the canvas tool menus and the Hand's view menu open at
the press for such a click. A still click that egui reports itself is
unchanged and opens at the pointer as before.

The tests for moved right-clicks now expect the picker where the button
went down. The comment on right_click_at now spells out the whole rule,
including that a still press held past egui's click time counts when
the button comes up, as a system context menu does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Canvas: a right drag past a few pixels is no right-click (#10183)

The canvas counted a right press released on it as a right-click
however far the pointer had moved while the button was down. A right
drag of hundreds of pixels that no gesture used opened the Brush
Preset picker or a canvas menu, back at the press, far from the
pointer. Before #10183 such a drag opened nothing. With the Hand
selected, a fast Space+right flick, too quick for egui to see as a
drag, opened the Hand's view menu instead of panning.

A right press now counts as a click only while the pointer stays
within three times egui's click distance of it, 18 points by default.
That covers the few pixels a high-DPI mouse moves as its button goes
down, or a slow frame's move, and is well short of a deliberate drag.
Every pointer position between the press and the release counts, also
the moves inside one frame, so a drag out and back near the press is
no click either. Within that distance menus still open at the press.

The tests for moved right-clicks now move within that distance, about
14 points instead of 30 to 70. The tests where a gesture, Escape, a
popup or another button stops the click also move only a few pixels
now, so that the distance alone does not make them pass. The comment
on right_click_at states the limit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Canvas: letting go of Space mid right drag keeps the Hand panning (#10183)

With the Hand selected, Space and a right drag pan. Letting go of Space
while the right button was still down ended that pan: the view went on
gliding with the button held (flick panning), and moving the mouse no
longer panned. Before #10183 the mouse kept panning until the button
came up, because the selected Hand's right drag always panned.

A right drag that Space made a pan now stays a pan until the right
button comes up, as the held Hand already does for the left button.
Letting go of Space first keeps the mouse panning and starts no glide,
and the release still opens no view menu. Without Space, the selected
Hand's right drag still opens its view menu without panning. Other
tools are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Canvas: a scroll or zoom while the right button is down cancels the right-click (#10183)

A right-click that moved a few pixels opens its menu where the button
went down, and finds what was right-clicked there: a guide, the layers
under it, the pasteboard. The canvas kept that point on the screen.
When the view scrolled or zoomed while the button was held, a
different part of the image was under that point by the release, so
the menu was for whatever had moved there, not for what was pressed.

The canvas now notes its view when a right press goes down: the zoom,
the centre, the rotation, the flip and where the canvas is. If any of
it changes before the button comes up, by the wheel, a zoom or
anything else, the release is no right-click and opens nothing. A
still click that egui reports itself is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Canvas: the Hand's right drag past a few pixels pans again (#10183)

With the Hand selected, a right drag within a right-click's reach opens
its view menu without panning. Once the cap made a longer right drag no
right-click, that drag did nothing at all: it neither panned nor opened
the menu. Past the reach it is a drag, so it pans as it did before
#10183, and its release opens nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Canvas: each painting tool's Shift+right-click menu reads the moved right-click (#10183)

Main gave the Pencil, Clone Stamp, Eraser, Dodge, Sponge, Paint Bucket, Gradient, Mixer
Brush and Healing Brush their own Shift+right-click menu, and the HUD Color Picker now opens
with the current colour under the pointer. Both go through the canvas's right-click record:
a Shift+right-click that moved a few pixels opens the tool's menu where the button went
down and nothing else, a long Shift+right drag opens nothing, Spot Healing keeps its picker,
and a HUD press released after a small move, on the HUD or just off it, opens no menu.
These tests hold that on the rebased branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
2026-11-05 16:29:42 +01:00
Higgs32584andClaude Opus 5.5 7d446b5072 fix(transform): a click on another layer's pixels commits the box; the next click picks it (#8208, #11100)
Measured in the reference application (#9862, #11100): with a box open, a click outside it on
pixels of a layer the box doesn't move commits one Free Transform step and leaves the selection
alone; a second click picks that layer. Drop the one-click Auto-Select replay, which went further
than the reference, and add that commit path next to #11165's pasteboard rule. Where only the
Background has pixels the box stays open. Unmeasured cases (Transform Selection, path or mask
targets, hidden, locked or grouped layers) keep the box open as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 10:29:18 -05:00
Higgs32584 7dc126c2a4 Merge #11165 (Free Transform: a click outside the box on the image no longer commits) to build on it
# Conflicts:
#	crates/ui-egui/src/tools/transform_tool/pointer.rs
2026-11-05 10:25:50 -05:00