Commit Graph
11425 Commits
Author SHA1 Message Date
Hector VillarrealandClaude Opus 5.5 da7f83e1cc New Guide takes arithmetic in its position, as in Photoshop (#10440)
The position took one length; Photoshop's field evaluates + - * / over mixed
units ("100% / 3", "100% - 50px", "1in + 10"). Unit::eval_length does that
for view.newGuide / view.moveGuide: * and / bind tighter, a bare number added
or subtracted takes the first operand's unit (as Photoshop's "1in + 10" is
11 in), a bare multiplier is a number. New Guide's dialog gives a leading bare
number the ruler unit, as it does a lone one.

Fixes #10440

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:23:15 -06:00
Khawar Zamman Wani 123b2032c4 Web build: Place runs a slice per frame, so a large PNG no longer freezes the page (#10164, rebased onto main)
The remaining commits of the stack, applied on top of the squash-merged #10147:

- PNG decodes in resumable steps of rows (PngDecodeRows, shared with decode_rows)
- PNG imports as a document in resumable steps (io PngImport, text metadata and
  document build in bounded steps)
- Jobs can run a slice at a time where there are no threads (StepWork,
  cooperative sessions, Session::poll_jobs)
- Place decodes, flattens and resizes in slices (PlaceSteps), reading a path
  and keeping the frame, memory gate and typed memory-budget errors main has
- The web build places dropped and picked files a slice per frame, with a
  bounded place inbox
- A measurement of the stepped place; docs for jobs without threads
2026-11-06 08:51:17 +05:30
Hector VillarrealandClaude Opus 5.5 be4a915161 Replace Color: Lab bounds refuse subtracted samples; panic_hunt covers them (tanish2k09 review)
Main's Lab bounds (#10765) refuse RGB samples, subtractPoints and order
included. A test pins that for subtractPoints and order, and panic_hunt
now sends malformed and far-off subtractPoints, points and click orders,
also with Lab bounds, to every command.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:15:00 -06:00
Hector VillarrealandClaude Opus 5.5 dd07d15aa3 Replace Color: check the unsampled black with a lifting pass (CodeRabbit review on tests.rs:888)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:15:00 -06:00
Hector VillarrealandClaude Opus 5.5 01c825b693 Replace Color: test a partly covered colour blends by its coverage (CodeRabbit review on crates/engine/src/cmd/adjust_cmds/tests.rs:898)
The several-samples test only checked pixels the samples cover fully or not
at all, so thresholding the coverage at 0.5 passed it. A lighter red at the
edge is covered about 0.45 by Select > Color Range for the same clicks;
Replace Color must give the blend of its colour and its fully replaced
colour at that coverage.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:15:00 -06:00
Hector VillarrealandClaude Opus 5.5 647a177428 Replace Color: test an interleaved click order against Color Range (CodeRabbit review on crates/engine/src/cmd/adjust_cmds/tests.rs:846)
Every test with `order` used the default grouping (all additions first), so
dropping `order` from the keys forwarded to the Color Range matcher failed
none. `+ - +` on the grey strips subtracts while the box is the dark grey
alone, so the light grey added after it is matched; the test checks Replace
Color changes exactly what Select > Color Range covers for those clicks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:15:00 -06:00
Hector VillarrealandClaude Opus 5.5 d2deecca21 Replace Color: check undo restores every pixel with several samples (FredApps review)
The multi-sample test undid without looking at the result. It now
compares the whole layer with the pixels from before, after two added
samples and after an added and a subtracted one. Applying the edit as
two history steps makes it fail.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:15:00 -06:00
Hector VillarrealandClaude Opus 5.5 53646b796f Replace Color: test Localized Color Clusters with several samples (FredApps review)
Two creams sampled in two places with Range 20 %: each is replaced near
its sample, the same cream far from both is left alone, and Select ›
Color Range covers the same pixels. Not forwarding `localized` to the
multi-sample matcher makes it fail.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:15:00 -06:00
Hector VillarrealandClaude Opus 5.5 4ff73834bc Replace Color: test a subtraction inside the added range (FredApps review)
The subtraction checks subtracted a blue that never matched the red
sample at fuzziness 40, so "blue stays" held with or without
`subtractPoints`. The new test adds a dark and a light grey and subtracts
a grey near the light end: as in Photoshop the light edge of the Lab box
moves onto the subtracted grey, so the light grey is no longer replaced,
and Select › Color Range agrees. Ignoring `subtractPoints` makes it
fail. The old checks now say why blue stays, and a doc comment that sat
on the wrong test is moved back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:15:00 -06:00
Hector VillarrealandClaude Opus 5.5 627afeda1c Replace Color: forward the resolved From colour to the subtract-only matcher (CodeRabbit review on adjust_cmds.rs:427)
Test: replace_color_subtract_only_reads_a_null_colour_as_the_foreground.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:15:00 -06:00
Hector VillarrealandClaude Opus 5.5 ebcc2b5e91 Replace Color: subtract-only samples start from the From colour (CodeRabbit follow-up on adjust_cmds.rs:418-425)
Test: replace_color_subtract_only_starts_from_the_from_colour.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:15:00 -06:00
Hector VillarrealandClaude Opus 5.5 9b9deca07d Replace Color: a first Add to Sample click sets the From colour (CodeRabbit review on crates/ui-egui/src/dialogs/filter_dialog.rs:763)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:15:00 -06:00
Hector VillarrealandClaude Opus 5.5 02d244a8f7 Replace Color: Reset forgets the eyedroppers' click order (CodeRabbit review on crates/ui-egui/src/dialogs/filter_dialog.rs:768)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:15:00 -06:00
Hector VillarrealandClaude Opus 5.5 90f9d0e07d Replace Color: refuse a malformed subtractPoints with one sample (CodeRabbit review on crates/engine/src/cmd/adjust_cmds.rs:414)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:15:00 -06:00
Hector VillarrealandClaude Opus 5.5 099195e978 cargo fmt (CI gate failed on formatting)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:15:00 -06:00
Hector VillarrealandClaude Opus 5.5 0e421d6a33 Replace Color: Add to Sample and Subtract from Sample (#6280)
Replace Color had one eyedropper and matched one colour. As in Photoshop, its
dialog now has the Eyedropper, Add to Sample and Subtract from Sample tools
(Shift-click adds, Alt-click subtracts), and image.adjustments.replaceColor
takes several points, subtractPoints and their click order. Several samples
match through Select › Color Range's own matcher, so the two agree for the
same clicks; a single colour keeps the existing path.

Fixes #6280

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:14:59 -06:00
dotCooCoo 8fe24e4a62 Merge main into feat/equalize-entire-image 2026-11-05 19:13:39 -08:00
Khawar Zamman Wani e66ca23a72 Resizing can run in resumable steps of 64 output rows 2026-11-06 08:36:46 +05:30
David MannandClaude Opus 5.5 99b93f82da Batch 18 (CodeRabbit nitpicks): crop test checks the active layer's covered pixels; Esc test goes through the shortcut handler
- #11458: the straight-crop rows also check that the active layer's pixels
  inside the old canvas are the plain crop's, so a fill that recolours them
  fails.
- #11295: the Esc case sends the key through shortcuts::handle instead of
  calling cancel directly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 04:04:26 +01:00
Khawar Zamman Wani 3bc3bec1d5 Merge remote-tracking branch 'origin/main' into claude/selective-colours-isolation-329d87
# Conflicts:
#	docs/ui-parity.md
2026-11-06 08:27:58 +05:30
dotCooCoo 4a87e8d4f3 Hand tool: keep the Scroll All Windows glide choice in a helper 2026-11-05 18:33:18 -08:00
yoriswind d58701ddff Merge current main into the Actions preservation candidate 2026-11-05 18:31:30 -08:00
David MannandClaude Opus 5.5 2fcb4d699e Batch 18 (CodeRabbit): a zero nudge must leave History exactly as it was
The test accepted an added Nudge step; layer.translate records nothing for
a zero offset, so require unchanged entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 03:31:27 +01:00
yoriswind 1c18b06264 Merge Crop update before Free Transform Windows validation 2026-11-05 18:27:23 -08:00
Higgs32584andClaude Opus 5.5 fb371cede5 Merge upstream/main into fix/2091-menu-scroll-arrows
Resolve conflicts in widgets/dropdown.rs (union of imports: main's
grouped dropdown separator and the menu scroll arrows' pos2) and
widgets/tests.rs (keep both the menu scroll arrow tests and main's
grouped dropdown test).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:23:51 -05:00
yoriswind 994443c310 Preserve Actions menu ownership controls 2026-11-05 18:23:19 -08:00
David Mann a259993118 Merge pull request #9204 from davidmann4/fix/crop-doc-switch-view-turn
Crop: switching documents leaves the old document's view turned (#9202)
2026-11-06 03:22:25 +01:00
David Mann a46e6e0e4a Merge pull request #9286 from davidmann4/fix/crop-history-jump
Crop: History jumps wait for a pending crop (#9285)
2026-11-06 03:20:56 +01:00
David Mann bab0e5c2e2 Merge pull request #9278 from davidmann4/fix/crop-straighten-snap
Crop: a Straighten line inside the frame no longer snaps like a frame move (#9277)
2026-11-06 03:20:43 +01:00
David Mann dee552a817 Merge pull request #9284 from davidmann4/fix/crop-click-snap
Crop: a click on the frame or a handle never snaps it (#9283)
2026-11-06 03:20:20 +01:00
yoriswind 18d431c2ea Merge current main for Free Transform Windows validation 2026-11-05 18:19:07 -08:00
David Mann 5d10956221 Merge pull request #9261 from davidmann4/fix/image-size-resolution-range
Image Size: refuse a resolution outside 1..30000 ppi instead of clamping it (#9260)
2026-11-06 03:16:20 +01:00
David Mann 7122a21fec Merge pull request #9670 from davidmann4/fix/svg-markup-check
SVG: a DTD entity can't hide nesting from the depth check (#9669)
2026-11-06 03:15:57 +01:00
David Mann 03f9f53b13 Merge pull request #9213 from davidmann4/fix/crop-hidden-resample-budget
Crop W x H budgets the hidden pixels it resamples (#9212)
2026-11-06 03:15:14 +01:00
David Mann b81932c64a Merge pull request #9224 from davidmann4/fix/crop-drag-tool-switch
Crop: a tool switch during a frame drag ends the drag (#9223)
2026-11-06 03:14:21 +01:00
David Mann b7b61addcd Merge pull request #9276 from davidmann4/fix/9275-crop-esc-mid-drag
Crop: Esc in full screen cancels a drag on the default frame (#9275)
2026-11-06 03:13:52 +01:00
David MannandClaude Opus 5.5 55a2dffcaa Batch 18 (CodeRabbit): Layers empty-list menu under a filter; the pen's eraser end ends Add New Artboard
- #11500: a filter that matches no layer draws no row, so the empty-area
  right-click was never created; the whole empty list now takes it.
- #11532: flipping the pen to its eraser end is a tool switch, so Add New
  Artboard's placing mode ends as with any other switch.

Tests for both (the Layers one fails without the fix).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 03:13:29 +01:00
David Mann 908afc7bb3 Merge pull request #5533 from davidmann4/fix/5532-blend-separators
Layers: separators between the Blend Mode groups (#5532)
2026-11-06 03:12:28 +01:00
David Mann 5b9900e52e Merge pull request #9310 from davidmann4/fix/crop-drag-autoscroll
Crop / Perspective Crop: a drag held past the canvas edge scrolls the view (#9307)
2026-11-06 03:10:57 +01:00
David Mann 0b9a113414 Merge pull request #9672 from davidmann4/fix/svg-fallback-cmap-cache
SVG: the fallback font search reads each font's character map once (#9671)
2026-11-06 03:10:12 +01:00
David MannandClaude Opus 5.5 ea15b297f5 Batch 18 (CodeRabbit): parity floor back to 660; Nudge relabel only after a move; shape box drag ends on a tool switch
- menus/parity.rs: #11503 lowered FLOOR to 658 (two Warp rows went);
  with #11497's two entries the batch has 660 live again.
- #11443: a nudge that changed nothing (zero offset) no longer renames
  the state on top to "Nudge".
- #11295: a handle drag remembers its tool and ends on any tool switch,
  also to another tool that shows the box; the release of a drag that was
  just dropped is consumed instead of reaching the new tool; the box is
  drawn only over the active document's view.

Tests for each (both new UI tests fail without their fix).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 03:07:11 +01:00
dotCooCoo 9ffbca0e5c Merge main into feat/equalize-entire-image 2026-11-05 18:04:02 -08:00
David MannandClaude Opus 5.5 8f7815adc5 Batch 18 (#11295): the shape box names its own step when the transform lands as a job
In the app (background jobs on) edit.transform runs as a job and lands
after app.run returns, so renaming the top History step to "Transform
Path" right away renamed the step before it (the second shape's "New
Shape Layer") and left the scale as "Free Transform". Found in the batch
smoke run; the PR's tests run with background jobs off.

edit.transform now takes stepName "Transform Path" (any other name is
refused, as select.transformSelection's stepName from #11444), and the box
passes it instead of renaming afterwards. New tests: the box with
background jobs on (fails without the fix), and the parameter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 03:01:30 +01:00
yoriswind 51806959ef Expect the default cursor inside Free Transform 2026-11-05 18:00:58 -08:00
Higgs32584andClaude Opus 5.5 0d924e6fcc fix(ui): keep both menu scroll arrows inside a short window (#2091)
The arrows were taken from the room and then the scroll area was raised
back to the 120 pt minimum, so with 120-148 pt of room the menu grew 28 pt
taller than the room and the lower arrow could fall off screen. The
minimum now applies to the whole menu, arrows included.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 20:51:17 -05:00
yoriswind 58b0265f18 Format the five-command Actions repair 2026-11-05 17:47:05 -08:00
Trevor BrownandClaude Fable 5.1 e0bf853eeb Merge upstream/main into feat/move-options-bar-distribute-gear-11381
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 20:41:23 -05:00
Trevor BrownandClaude Fable 5.1 1855419220 Merge upstream/main into feat/artboard-options-bar-11385
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-05 20:41:18 -05:00
yoriswind 106e953232 Preserve Move selection outside the transform press band 2026-11-05 17:33:55 -08:00
David Mann 4c6d5e259a Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	docs/ui-parity.md
2026-11-06 02:32:59 +01:00