Commit Graph
4501 Commits
Author SHA1 Message Date
Dylan M. Taylor 5455139d54 Reuse shared Android drawable wire primitives 2026-11-15 13:27:48 -05:00
Patrik LermonandClaude Opus 5.5 3c4111bacb i18n(sv): translate 1 new string, remove 1 obsolete
Brings the Swedish catalog up to date with upstream main (0015eb5f).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-15 17:25:32 +01:00
Patrik Lermon bc60d0490c Merge upstream/main into swedish-ui-2026-11-15 2026-11-15 17:09:56 +01:00
Dylan M. Taylor 0015eb5f06 Merge pull request #2332 from storytold/codex/figcraft-native-consumer
Move .figcraft native schema to craft-libs
2026-11-15 11:03:09 -05:00
Dylan M. Taylor 91a0cafc9c Merge pull request #2284 from storytold/switch/craft-fig-rebased
M6: move .fig parsing and mapping to craft-libs
2026-11-15 10:56:46 -05:00
Mex 14bdeff591 fix: check device names after filename length limits
Cap generated CLI names before device-name escaping, then cap again so the prefix fits both limits. Cover character and byte truncation boundaries.
2026-11-15 16:30:31 +01:00
Mex 4382b9b591 docs: explain generated device-name prefixes
Document the reserved Windows name prefix alongside the existing generated export filename rules.
2026-11-15 16:27:19 +01:00
Mex 71cd63a21b engine: escape device components after export suffixes
Apply the shared device-name rule to completed folder/name/suffix components before collision numbering, with regression coverage.
2026-11-15 16:02:12 +01:00
Mex 19a4a309e4 test: cover generated device-name path components
Exercise device names, extensions, nested components and safe near-matches using the existing device-name classification.
2026-11-15 16:01:13 +01:00
Mex af87503d04 Implement escape_device_names function
Prefix generated path components using the existing device classifier, after filtering and suffix construction.
2026-11-15 15:59:34 +01:00
Mex 8244acce2d cli: escape device names in generated export filenames
Use the shared device-name escaping rule for generated CLI export basenames, before existing length caps.
2026-11-15 15:58:13 +01:00
Mex ea8c630821 cli: reject malformed attach address components
Validate a nonempty host and a u16 port before attempting attachment. Preserve valid address spelling and bare-port behavior.
2026-11-15 15:34:15 +01:00
FredApps ac4f5511ef Merge #2284's branch (with current main) into codex/figcraft-native-consumer 2026-11-15 15:14:14 +01:00
FredApps 4675ae65d6 M6: drop the repeated test attributes on two fig modules (#2284) 2026-11-15 15:10:29 +01:00
FredApps 8b1f315335 Merge remote-tracking branch 'origin/main' into fix2284 2026-11-15 15:10:21 +01:00
Patrik LermonandClaude Opus 5.5 e780264e55 i18n(sv): translate 21 new strings
Brings the Swedish catalog up to date with upstream main (3bbd1d3c).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-15 15:07:16 +01:00
Mex 9e99135ffc M0: reject invalid complete versions before writing Cargo.toml
Validate the numeric core, prerelease identifiers and build metadata before the version command changes the manifest. Add boundary and malformed-input coverage.
2026-11-15 14:36:43 +01:00
Adithya Shankaran d4e2641fa0 Automation roots: same_file doesn't open a path outside the roots, native NT link targets and names Windows trims are refused, and the docs say network paths are refused 2026-11-15 18:24:05 +05:30
Madhav Agarwal 2462a86253 Batch: a refused step names its step and keeps its kind (#2181) 2026-11-15 17:41:14 +05:30
Madhav Agarwal 8133b31c74 Text: embedded Noto Sans JP backs up Japanese runs (#2375) 2026-11-15 14:02:39 +05:30
Trevor BrownandClaude Sonnet 5.5 3bbd1d3ce5 Pages: Set as opening page, so a shared file opens on the page the team chooses (#1817) (#1972)
* M9: page.setOpening sets the page a shared file opens on, for everyone who joins (#1817)

A file on a figcraft-server opened on the page current at publish time, with no way to change it:
`DocProp::CurrentPage` was synced but nothing wrote it (`page.select` is each viewer's own page,
only a local save stamps the document). `page.setOpening {id?}` writes `doc.current_page` as a
document edit: one undo step, a synced change in a live session, so every later join opens on it;
the current page when none is named; a divider or a layer refused; nobody's own page moves. The
pages list's context menu gets "Set as opening page". Docs: mcp.md, collaboration-parity.md.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* M9: the pages menu's new string is in the English catalog (#1817)

The gate's i18n test wants every tr() key in locales/en.toml.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Opening page: the parity doc states the default when no opening page is set (#1972 issue)

With none set, a file opens on its saved current page, not the first page, and a link cannot name a page, so the row is partial.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Opening page: one sharing row, and the spotlight exception on the opening-page row (#1972 issue)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Opening page: the parity row states where the joiner's page comes from (#1972 issue)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Opening page: a no-op set adds no step, deleting the opening page falls back, and the tests cover junk ids, refusals, undo and the menu item (#1817)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* M5: the chosen opening page is saved with the file and opens it for everyone (#1817)

The opening-page flag now lives on the page node (NodeKind::Page opening), so it syncs
through the existing node kind. Saving writes the flagged page as current_page instead of
the page the saver was viewing. A duplicated page does not copy the flag, and deleting the
page removes it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Opus 5.5 briefed; Sonnet 5.5 wrote at medium

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-15 00:05:48 -06:00
Trevor BrownandClaude Sonnet 5.5 adad8a08ad M8: Duplicate repeats the copy's rotation as well as its move, and forgets the step on a deselect (#2293) (#2313)
* M8: Duplicate repeats the copy's rotation as well as its move, and forgets the step on a deselect (#2293)

Duplicate remembered only the shift of the copies' bounds corner, so a turned copy repeated an arbitrary offset and no rotation. The step is now the move of the copies' centre in the page frame plus the turn each copy has over its source, applied to the new copies about their own centre (one layer) or their shared centre (several). Size is not stepped; a resized copy repeats its move, not its growth. Measured in Figma's web app on 2026-11-12. The step was already dropped when the selection changes to anything but the copies (clean_selection), and a test now pins that.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Fable 5.2 queued; Opus 5.5 briefed; Sonnet 5.5 measured and wrote at medium

* M8: the duplicate step ignores turns in place, size changes and flips (#2293)

The move of the step is now measured per pair, as each copy's own centre minus its source's, less the shift a size change gives that centre (taken in the source's frame), averaged over the pairs. A turn about a layer's own centre, uneven layers and a widened-then-turned copy no longer record a move. A copy whose flip state differs from its source's repeats no turn, since flips were not measured.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Fable 5.2 queued; Opus 5.5 briefed; Sonnet 5.5 measured and wrote at medium

* M8: a turn of several copies together is not counted as a move in the duplicate step (#2293)

Duplicated::step took the mean of the per-pair centre moves, so a Rotate on several uneven layers (turned together about the selection centre) read as an extra move and the next Duplicate applied it. The step now also tries the reading where the copies were turned together about the sources' bounds centre, and uses it when every copy fits it and the in-place reading does not fit. Two tests cover a turn together and a move plus turn together.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Opus 5.5 briefed; Sonnet 5.5 wrote at medium

* M8: the duplicate step reads a turn about the rotation handle's centre, and a resize after a turn, as no move (#2293)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Opus 5.5 briefed; Sonnet 5.5 wrote at medium

* M8: the duplicate step turns several layers about their handle box's centre, with no pivot inferred (#2293)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Fable 5.2 briefed; Sonnet 5.5 wrote at medium

* Docs: repair a row the earlier merges garbled (Alt-drag duplicate)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Opus 5.5 briefed; Sonnet 5.5 wrote at medium

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-15 00:05:43 -06:00
Madhav Agarwal 4f89bbd37e docs: bring ROADMAP.md current through 2026-11-15 2026-11-15 11:08:26 +05:30
Trevor BrownandClaude Opus 5.5 7e1db33e63 Merge upstream/main into docs/repair-merged-rows-1113
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-14 09:33:24 -05:00
Trevor BrownandClaude Opus 5.5 e981f66d2d Merge upstream/main into feat/variables-window-resize-2354
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-14 09:33:23 -05:00
FredApps bad07e4433 Merge pull request #2357 from ZIDAN44/fix/2353-nest-group-rename
Variables: renaming a group to a path with / nests it (#2353)
2026-11-14 15:20:41 +01:00
Trevor BrownandClaude Opus 5.5 55239a44f1 M5: a reverted hover leaves no fired key for a layer that is gone (#2352)
On revert, fired-delay keys are kept only for layers the restored document has: a layer only the hover variant had is gone again, and its id may be issued anew by the next hover. Test a_hover_variants_own_layer_leaves_no_fired_key_after_the_revert (red before: a key for the missing NodeId(8) stayed); present 106 passed, clippy clean (CodeRabbit on #2362).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-14 04:40:10 -05:00
Trevor BrownandClaude Opus 5.5 29fe911dd9 M3: on a short screen the Local variables window's body takes what is left (#2354)
The body below the header had a 160-point floor, so with the minimum capped by a screen lower than 220 points the content ran past the window. It now takes the height left below the header (the table scrolls). Test on_a_short_screen_the_variables_window_fits_inside_it (red before: the window ran to y 206 on a 180-high screen); variables 45 passed, clippy clean (CodeRabbit on #2363).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-14 04:37:56 -05:00
Trevor BrownandClaude Opus 5.5 3a8313aba7 M5: a delay fired on a hover variant doesn't block the restored variant's delay (#2352)
A fired-delay key is (node, index), and inside an instance the index belongs to the variant shown. On revert, keys that fired during the temporary change inside an instance it changed the variant of are dropped (they name the hover variant's interactions); the snapshot's keys come back and the other new ones stay. Test a_delay_fired_on_a_hover_variant_does_not_block_the_restored_variants_delay (red before: A's runs left 0, right 1); present 105 passed, clippy clean (CodeRabbit on #2362).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-14 03:40:07 -05:00
Trevor BrownandClaude Opus 5.5 5a482af812 M3: the Local variables window fits a narrow screen and resizes from a fixed corner (#2354)
The minimum (600 x 240) is capped at the screen less its margin, so on a screen narrower than that the window stays inside it. The window is pinned at its top-left corner and opens centred, so dragging one edge leaves the opposite one in place (the centre pivot moved both). Tests on_a_narrow_screen_the_variables_window_fits_inside_it (red before: the window ran from x -26 to 576 on a 550-wide screen) and the top-edge check in the_variables_window_grows_when_dragged_taller (red before: 210 -> 190); variables 44 passed, clippy clean (CodeRabbit on #2363).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-14 03:38:02 -05:00
Trevor BrownandClaude Opus 5.5 24c2988bd5 M5: a reverted hover keeps the delays that ran; an edit drops the swap times (#2352)
The while-hovering / while-pressing snapshot also keeps the fired After delays, and the revert puts back the ones the temporary variant change cleared (keeping any that fired during it), so a delay that already ran on the variant doesn't run again. When an edit in the editor replaces the presented document, the run-time swap times are cleared with the rest of that state.

Tests: a_hover_variant_that_reverts_does_not_rerun_a_fired_delay (red before: count left 2, right 1) and an_edit_while_presenting_drops_the_swap_times (red before: left Some(0), right Some(1)); present 104 passed, clippy clean (CodeRabbit on #2362).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-14 02:59:37 -05:00
Trevor BrownandClaude Opus 5.5 4b9e900f89 M3: the Local variables window's minimum width fits the table's header row (#2354)
At 480 points the table was 279 wide, leaving 11 points next to the 220-point search field for a library collection's Extend collection button. The minimum is now 600 x 240 (table 399 wide); the default size's clamp uses the same minimum. variables 43 passed, clippy clean (CodeRabbit on #2363).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-14 02:49:35 -05:00
Trevor BrownandClaude Opus 5.5 d3f275fa70 M5: a temporary variant change that reverts keeps the After delay deadline (#2352)
The swap times now travel with the while-hovering / while-pressing snapshot, so reverting a hover's variant change restores them and the variant shown again fires on its own deadline. Test a_hover_variant_that_reverts_keeps_the_after_delay_deadline (red before: left Some(0), right Some(2) at 1.3 s); present 102 passed, clippy clean (CodeRabbit on #2362).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-14 01:48:54 -05:00
Trevor BrownandClaude Sonnet 5.5 c59dc0fdcb M3: the Local variables window resizes from its edges and corners (#2354)
The window was fixed at 880 x 480. It now resizes from every edge and corner, down to 480 x 240 and up to the screen less a margin, and its header, sidebar and table follow its current size. Egui's memory keeps the size and place while the app runs.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Opus 5.5 briefed; Sonnet 5.5 wrote at medium
2026-11-14 00:41:10 -05:00
Trevor BrownandClaude Sonnet 5.5 f451e60ceb M5: a chain of After delay variant changes plays to the end (#2352)
Change to swapped the instance's variant in place, so the next variant's After delay
kept the instance's node id and was already recorded as fired: the chain stopped
after one step. The swap now clears the fired keys inside the instance and records
when it happened; next_delay counts a timer from the later of the screen's arrival
and that swap.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Opus 5.5 briefed; Sonnet 5.5 wrote at medium
2026-11-13 23:42:18 -05:00
Zinadin Zidan 92d0ffdc62 Variables: fix the move order in the group rename collision test (#2353)
Both moves had names of the same length, so which one ran first came
from the order of the variables. The first one now has a longer name,
which the longest-first order always moves first, so the second one
always collides after a move that has to be undone.
2026-11-14 04:31:08 +06:00
Zinadin Zidan 70aeeee941 Variables: test that a refused group rename undoes the moves already made (#2353)
The collision test's two moves had names of the same length, so the
first one already collided and nothing was left to undo. With the
existing name on the second move, the first moves, the second collides,
and the test checks that the batch puts the first one back.
2026-11-14 04:05:13 +06:00
Zinadin Zidan 7644de9f81 Variables: renaming a group to a path with / nests it (#2353)
Renaming a group in the Local variables window replaced every slash in the
typed name with a hyphen, so "Palette/Orange" gave a flat Palette-Orange
group and there was no way to move a group under a new parent.

The typed path now replaces the group's last part, so a slash nests the
group as in Figma: Orange/100 becomes Palette/Orange/100 and the sidebar
shows Orange under Palette. Each part is trimmed and empty parts are
dropped; a name that comes out empty or unchanged does nothing. The
renames go deepest name first, so a group moved into its own new subgroup
(Orange to Orange/Warm) never collides with a variable that is still to
move. A rename onto a variable name that stays is refused by
variable.update and the batch rolls back; it stays one undo step.
2026-11-14 02:36:36 +06:00
Trevor BrownandClaude Opus 5.5 b38b4e3793 docs: the Arabic row names both builds that embed Noto Sans Arabic on the web
crates/text/build.rs keeps the face for a web build when FIGCRAFT_EMBED_SCRIPTS names Arab or when FIGCRAFT_WEB_FONTS names the family (CodeRabbit on #2350).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-13 15:34:43 -05:00
Trevor BrownandClaude Opus 5.5 71aabc14f1 Merge upstream/main into docs/repair-merged-rows-1113
docs/ui-parity.md: main's new Tidy up row is kept (the duplicate Selection colors and Keyboard box selection rows next to it, unchanged on main, stay merged into one row each); the revision table keeps this PR's 2026-11-13 row above main's new rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-13 14:38:23 -05:00
BFlat 24613d3fa6 Merge pull request #2310 from TrevorBrown-dev/fix/layers-icon-double-click-zooms
M8: a double-click on a layer's icon zooms to it, as in Figma
2026-11-14 01:48:53 +07:00
bflatastic fe301aeb74 Merge main into #2310 2026-11-14 01:35:02 +07:00
BFlat 4a0eafa77a Merge pull request #2319 from TrevorBrown-dev/feat/tidy-up-figma-rule
M8: Tidy up keeps the order and sizes and evens the gaps, as measured in Figma
2026-11-14 01:32:46 +07:00
bflatastic cf0ebbe27e Merge main into #2319 2026-11-14 01:14:26 +07:00
bflatastic 4cd86095c5 Merge main into #2310 2026-11-14 01:13:53 +07:00
BFlat 81699e8506 Merge pull request #2335 from TrevorBrown-dev/fix/crop-from-picker-2307
M8: after Crop is chosen in the image fill's menu, a drag on the image crops it, and no internal gesture message shows (#2307)
2026-11-14 01:12:40 +07:00
bflatastic 62c5f8c17a Merge main into #2335 2026-11-14 00:59:04 +07:00
bflatastic 8e3c46b27d Merge main into #2319 2026-11-14 00:57:58 +07:00
bflatastic b82924f760 Merge main into #2310 2026-11-14 00:57:25 +07:00
BFlat 7a80106a5e Merge pull request #2298 from TrevorBrown-dev/fix/align-auto-layout-child
M8: Align is unavailable for a layer in an auto layout frame's flow, as in Figma
2026-11-14 00:56:12 +07:00