daniel543x/figcraft
1
0 Fork 0
mirror of https://github.com/storytold/figcraft.git synced 2026-11-14 14:22:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Variables: test that a refused group rename undoes the moves already made (#2353)

Browse Source 
The collision test's two moves had names of the same length, so the
first one already collided and nothing was left to undo. With the
existing name on the second move, the first moves, the second collides,
and the test checks that the batch puts the first one back.
This commit is contained in:
Zinadin Zidan committed 2026-11-14 04:05:13 +06:00
1 parent 7644de9f81
commit 70aeeee941
1 file changed
+4 -3
Download Patch File Download Diff File Expand all files Collapse all files
crates/ui-egui/src/variables_select_tests.rs
+4 -3
View File
@@ -405,10 +405,11 @@ fn renaming_a_group_into_its_own_new_subgroup_moves_the_deeper_names_first() {
#[test]
fn a_group_rename_onto_a_variable_name_that_stays_changes_nothing() {
let mut u = named_window(&["Orange/100", "Orange/200", "Palette/Orange/100"]);
// Orange/100 moves first; Orange/200 then collides, and the move already made is undone.
let mut u = named_window(&["Orange/100", "Orange/200", "Palette/Orange/200"]);
rename_group(&mut u, "Orange", "Palette/Orange");
assert!(u.app.ui.last_error.as_deref().is_some_and(|e| e.contains("Palette/Orange/100")), "{:?}", u.app.ui.last_error);
assert_eq!(sorted_names(&u), ["Orange/100", "Orange/200", "Palette/Orange/100"]);
assert!(u.app.ui.last_error.as_deref().is_some_and(|e| e.contains("Palette/Orange/200")), "{:?}", u.app.ui.last_error);
assert_eq!(sorted_names(&u), ["Orange/100", "Orange/200", "Palette/Orange/200"]);
}
fn open_edit_variables(u: &mut Ui) -> Vec<egui::Shape> {