Commit Graph
11425 Commits
Author SHA1 Message Date
David Mann 0832f01bb7 Merge origin/main into feat/smart-sharpen-canvas-preview 2026-11-08 22:24:00 +01:00
08fb210964 Magnetic Lasso: the Standard cursor is the tool icon (#12151, #11690)
With Other Cursors set to Standard (or Precise swapped by Caps Lock) the
Magnetic Lasso showed a plain crosshair. The reference application shows
the tool's icon with its hotspot on the lasso's top-left tip; the Width
circle stays on the precise side.

Co-Authored-By: Hector Villarreal <1501713+hectorviov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 22:19:01 +01:00
David Mann 118fc0da6b Merge remote-tracking branch 'origin/main' into HEAD 2026-11-08 22:17:36 +01:00
David Mann 63f6cde667 Merge remote-tracking branch 'origin/main' into pr-12151 2026-11-08 22:12:01 +01:00
Sven Lafebre e0ca582b97 fix(engine): the Magic Eraser measures Tolerance by colour spread (#11995)
On 8-bit RGB a pixel now matches the clicked colour when the spread of
{0, dR, dG, dB} is within the Tolerance, so opposite changes in two
channels count double and green and blue stay at Tolerance 255. The
anti-alias fringe uses the same distance. The Magic Wand, the Paint
Bucket and other modes and depths keep the per-channel limit.
2026-11-08 22:11:51 +01:00
RickiNano ca005139f2 Shift-click lines aren't smoothed, so they end at the click (#11887)
Measured on #11887: smoothing doesn't apply to a Shift-click line, whatever
Smoothing and Catch-up on Stroke End are set to. With Catch-up on Stroke End
now off by default, the smoothed line stopped short of the click. A
Shift-click drag sends `smoothing: 0` with its stroke params; the options
bar's Smoothing is untouched.
2026-11-08 22:01:12 +01:00
RickiNano b390bef334 Revert "The ⇧-click smoothing test turns Catch-up on Stroke End on (#11887)"
This reverts commit d3e8039f76.
2026-11-08 22:01:12 +01:00
RickiNano 1450137575 The ⇧-click smoothing test turns Catch-up on Stroke End on (#11887)
The test expects a smoothed ⇧-click line to reach the click, which only
the catch-up does. It passed because Catch-up on Stroke End used to start
on.
2026-11-08 22:01:12 +01:00
RickiNano cf2f496660 Format the #11887 tests 2026-11-08 22:01:12 +01:00
RickiNano 3a21e14f06 Tests that draw the smoothing catch-up turn Catch-up on Stroke End on (#11887) 2026-11-08 22:01:12 +01:00
RickiNano 080d10c500 Brush: Catch-up on Stroke End starts unchecked, as in Photoshop (#11887)
Smoothing::default() now has catch_up_on_end: false, so after Reset Tool
a smoothed stroke ends short of the release point unless the option is
turned on. Tests that relied on the old default set it explicitly.
2026-11-08 22:01:12 +01:00
David Mann 70c0911d4e Merge pull request #12399 from davidmann4/fix/12397-wand-seed-tests-antialias
Magic Wand seed-outside tests expect the measured Anti-alias fringe, main green again (#12397)
2026-11-08 21:57:33 +01:00
Trevor BrownandClaude Opus 5.5 c1a109f894 Actions panel: the drop target is outlined only, so its icon stays visible (#12373)
The hover highlight filled the footer button with the opaque hover colour over the icon. It is
now a 1.5 px accent outline. control-protocol.md's Actions panel paragraph mentions the two drags.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove and wrote
2026-11-08 15:06:50 -05:00
David Mann dff5d29584 Merge remote-tracking branch 'origin/main' into fix/12397-wand-seed-tests-antialias 2026-11-08 21:03:43 +01:00
David MannandClaude Opus 5.5 bfe5d2a671 Magic Wand seed-outside tests: keep Anti-alias on, expect the measured fringe (#12397)
Instead of turning Anti-alias off, the tests keep the default setup and
expect the reference application's measured results (#11776, #11779):
the selection ends at 381, Subtract at 219, Intersect runs 219-381.
Suggested by hectorviov on #12399.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 21:03:37 +01:00
Trevor BrownandClaude Sonnet 5.5 a45699a4fe Actions panel: a row dragged onto the trash is deleted, onto Create new action duplicated (#12373)
The Actions panel rows carried a drag payload that only the reorder drop understood, so dropping a row on the footer trash or on Create new action did nothing. The footer buttons now take the drop (the trash deletes the dragged row, the plus duplicates it right after itself) through shared delete_row and duplicate_row helpers that also keep the selection and disclosure rows right, with a hover highlight and the same recording rules as the buttons. Tests drive real pointer drags for step and action rows onto both buttons, a drop on empty space, and a drop on the trash while recording.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove and briefed; Sonnet 5.5 wrote at medium
2026-11-08 15:03:19 -05:00
Hector Villarreal c3bd5e2fa3 Clear All's OK brings back the Note tool's default author and colour (CodeRabbit review on crates/ui-egui/src/tools/analysis_ui.rs:1096) 2026-11-08 13:48:51 -06:00
6afd603e53 Merge main into #7377 (Fujifilm compressed RAF)
Only the doc status lines, histories and raw tables conflicted. The
status lines take main's with the #7377 entry kept first; histories keep
both sides. The RAF table row keeps this PR's compressed support next to
main's new Hasselblad 3FR row and its sidecar status, and points at the
moved test file tests/it/raf.rs. The Camera RAW row keeps main's 3FR and
Nikon text and no longer lists compressed RAF as open.

Co-Authored-By: Yorgos S. <smyrgeorge@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 20:35:13 +01:00
David MannandClaude Opus 5.5 4e43c23e43 Magic Wand seed-outside tests: Anti-alias off, so they test the modes with hard edges (#12397)
#12146 gives near-matching neighbours a soft fringe when Anti-alias is on.
The #11848 tests left Anti-alias at its default and expected exact column
bounds, so main's engine tests failed (381 instead of 380).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 20:31:42 +01:00
e9cac335b4 Regenerate the parity checklist and scorecard after merging main into #10569
Co-Authored-By: hectorviov <hectorviov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 20:25:11 +01:00
David Mann a879c6ac0a Merge main into #10569
# Conflicts:
#	crates/ui-egui/src/menu_catalog.rs
2026-11-08 20:20:12 +01:00
Hector Villarreal 3f76716b98 Merge main into fix/color-replacement-tolerance-field (conflict in crates/engine/src/cmd/brush_cmds.rs, as asked on the PR) 2026-11-08 13:19:05 -06:00
David Mann a17acfa7a7 Merge pull request #12049 from DuBearte/fix/11897-clear-on-background
Brush: Clear on the Background paints as Normal and the Mode reads Normal
2026-11-08 20:16:11 +01:00
Hector Villarreal 07677a9cbc Merge main into fix/perspective-crop-modifiers (conflict in crates/ui-egui/src/tools/perspective_crop_ui.rs, as asked on the PR) 2026-11-08 13:13:28 -06:00
David Mann 3ef886c2e0 Merge pull request #12382 from TrevorBrown-dev/fix/layer-via-copy-capital-12357
Menus: Layer Via Copy and Layer Via Cut with a capital V, as in the reference (#12357)
2026-11-08 20:10:52 +01:00
Hector Villarreal 75503cfe4a Merge main into fix/perspective-crop-shield (conflict in crates/ui-egui/src/tools/perspective_crop_ui.rs, as asked on the PR) 2026-11-08 13:07:48 -06:00
Hector Villarreal 091f8a2666 Merge main into fix/note-clear-all-confirm (conflict in crates/ui-egui/src/tools/analysis_ui.rs, as asked on the PR) 2026-11-08 12:59:27 -06:00
David Mann 8acd45bfa9 Merge pull request #12298 from TrevorBrown-dev/fix/patch-destination-selection-12119
Patch: in Destination mode the selection moves with the patch (#12119)
2026-11-08 19:56:56 +01:00
Hector Villarreal 4ad2781d67 Merge main into fix/eyedropper-context-menu (conflict in crates/ui-egui/src/lib.rs, as asked on the PR) 2026-11-08 12:52:52 -06:00
David Mann 4e5f150eb4 Merge pull request #12146 from hectorviov/fix/wand-antialias-fringe
Magic Wand: Anti-alias keeps the region whole and softens only near-matching neighbours (#11776)
2026-11-08 19:49:41 +01:00
David Mann 5b0c31fc47 Merge pull request #11845 from mzuniga37/fix/11770-count-click-shows-count
Count tool: adding a marker turns View > Show > Count back on (#11770)
2026-11-08 19:49:27 +01:00
David MannandClaude Opus 5.5 f72fd4649e Merge origin/main into #12153: Protect Foreground narrows the graded Tolerance
main brought the graded erase (#11901), decontamination (#11902) and graded
Find Edges (#11904) into bg_erase.rs, and kept Protect Foreground Color on the
largest per-channel difference to the foreground. Resolved by narrowing the
Tolerance itself: with protection on, graded_weight runs on min(Tolerance,
distance from the sample to the foreground); a foreground equal to the sample
erases nothing. This replaces the distance stretch from before the merge.

Measured in the reference application with the issue's drag, foreground off in
two channels: (100,140,40) gives 0 32 75 112 156 196 238 255 (no protection),
(150,90,40) the block-5 row, (230,90,40) and (200,90,70) a Tolerance of 50
levels. So the narrowing uses the sample-match distance (largest increase plus
largest decrease), not the largest per-channel difference: the test on main
that kept the sampled colour for a two-channel foreground is replaced by these
rows. The reference rows of #11903 now match within 8 levels, 8- and 16-bit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 19:44:24 +01:00
David Mann f235e9f30c Merge pull request #12154 from davidmann4/fix/11902-bg-eraser-decontamination
Background Eraser: partly erased pixels lose the sampled colour's tint (#11902)
2026-11-08 19:34:28 +01:00
David Mann 83e2172336 Merge pull request #11848 from DuBearte/fix/11779-wand-seed-outside
fix(engine): Magic Wand Subtract and Intersect grow from the seed through the selection (#11779)
2026-11-08 19:33:29 +01:00
Harrison Smith 5dc2ad27fb Show Content-Aware Move's slider popups, tooltips, and transform actions
Structure and Color open a whole-number slider. A typed value outside the range
opens an OK alert and keeps the closest value. While the Transform On Drop box
is up, the bar is greyed and Cancel then Commit sit at the right end.

Fixes #12193
2026-11-08 11:28:47 -07:00
David Mann fa41efebc5 Merge pull request #9348 from VoiceLessQ/pattern-preview-wrap-tools
paint: 12 more painting tools wrap across the canvas edges in Pattern Preview (#8883)
2026-11-08 19:22:34 +01:00
David Mann 9eb2abcf33 Merge pull request #9396 from kavishkashehan726-sudo/fix/9356-pen-continue-path
Pen: carry on a shape's or vector mask's open path, and show the cont…
2026-11-08 19:22:19 +01:00
David Mann 40c310dfa3 Merge pull request #5224 from augrclk/fix/brush-spacing-row
Brush Settings: combine the Spacing checkbox and percentage header
2026-11-08 19:22:06 +01:00
David MannandClaude Opus 5.5 3d2667d0e6 Background Eraser: channel-target preview mixes back unlocked like its commit (#12191)
On a transparency-locked layer with a colour-channel target, the live
preview mixed the dabs back with the lock (straight mix) while the commit
mixes premultiplied without it, so at 32 bits partly transparent pixels
rounded differently in the preview. The channel branch now builds the
LiveDab unlocked and pushes the points afterwards, as the RGB branch does.
The test now runs at 8, 16 and 32 bits over a half-transparent strip at
half opacity; it failed at 32 bits before the fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 19:12:17 +01:00
8535cfb7e6 test(engine): exact labels for every Record Measurements source (#11853)
The review on #11853 noted that the tests checked only that a selection
row's label did not start with "Count", never tested `auto` choosing a
selection, never tested a ruler row, and read only the first row. Now
each record must give exactly one row, the selection and ruler rows must
be "Measurement N", `auto` with a selection must stay "Measurement N",
and the shared counter is checked across all three sources.

Co-Authored-By: DuBearte <DuBearte@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 19:03:58 +01:00
David Mann d351491e93 Merge remote-tracking branch 'origin/main' into pr-12191 2026-11-08 19:03:22 +01:00
David MannandClaude Opus 5.5 1c05802653 Background Eraser: tell the Angle's wheel steps from typing by the field's own wheel (#12186)
The Angle field took any frame's scroll delta for a wheel step. That was wrong both ways: a
focused field's wheel is taken out of the frame before layout, so its steps past 180 showed the
range alert, and a view scroll arriving with typed text suppressed the alert (CodeRabbit). The
field now asks field_wheel whether it was handed wheel notches, and only an entry made with the
field's focus can alert.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 19:03:03 +01:00
Harrison Smith 9836b213e2 Turn Content-Aware Move's Transform On Drop on by default
A fresh start and Reset Tool leave the checkbox on, so a drop shows the
scale and rotate box. Enter still commits and Escape still cancels. A
saved false stays off, and a missing key takes the new default. A plain
move still sends paint.contentAwareMove with no scale or rotate.

Fixes #12185
2026-11-08 11:01:17 -07:00
RickiNano bf330293cb Content-Aware Move: exact 8-bit rounding and a bounded no-pixels scan (#12192)
Review follow-up. A pixel counts as selected exactly when the selection's
coverage8 stores it nonzero: the least such coverage is found once by
bisecting the f32 bits, so the scan stays one compare per pixel.

The scan no longer costs more than the select.lasso it replaces: strips
start at 64 rows and double up to about 4 MP, and each strip is checked
in parallel, branch-free blocks (sequential on wasm). A corner-to-corner
line on 7360 x 4912 now takes 25-32 ms (was 65-73 ms; select.lasso took
23-27 ms). A lasso that selects is still answered after the first strip.

Adds a test for a lasso over pixel centres with Anti-alias off.
2026-11-08 18:59:50 +01:00
RickiNano e9d9c2a18c Content-Aware Move: decide "no pixels" by the lasso's own coverage (#12192)
Review follow-up. The check rasterizes the lasso as select.lasso does
(polygon_window over the canvas, kept from 1/255 as the selection stores
it) instead of a half-pixel area threshold. A tiny anti-aliased lasso that
covers part of a pixel selects it as before, and a thin lasso between
pixel centres without anti-aliasing now warns instead of adding an empty
Lasso step. Only the lasso's bounds are rasterized, 64 rows at a time,
stopping at the first selected pixel.

The Don't show again test now checks what reaches the preference store
and that a restart reads it back.
2026-11-08 18:59:50 +01:00
RickiNano 85c70cab19 Content-Aware Move: warn "No pixels are selected." for a drag with no area (#12192)
With no selection, a Content-Aware Move drag that encloses no area (a
click or a straight line) now opens the alert "No pixels are selected."
with OK and "Don't show again", instead of silently running select.lasso
on an empty polygon. No History state is added and nothing is selected.
A drag that encloses an area, a drag with a selection, and the Lasso tool
keep their behaviour.

"Don't show again" is a small reusable addition to the app's Error alert
(dialogs/dont_show_again.rs): the alert carries the dialog-preference key
it sets, and closing it with the box ticked keeps {"skip": true} there.

Fixes #12192
2026-11-08 18:59:50 +01:00
David Mann 55498d45ba Merge remote-tracking branch 'origin/main' into pr-9077
# Conflicts:
#	docs/gaps.md
2026-11-08 18:55:24 +01:00
David Mann ea6a1781cd Merge remote-tracking branch 'origin/main' into pr-12186 2026-11-08 18:54:27 +01:00
Hector Villarreal a01c8f8618 Eraser range alert tests: a real toolbar click after a typed 150 alerts once and switches tools (CodeRabbit review on crates/ui-egui/src/eraser_range_alert_tests.rs:147) 2026-11-08 11:54:12 -06:00
David Mann 5a194128b1 Merge remote-tracking branch 'origin/main' into pr-11853
# Conflicts:
#	crates/engine/src/cmd.rs
2026-11-08 18:53:37 +01:00