Commit Graph
11425 Commits
Author SHA1 Message Date
David Mann 34c9662c6b Merge pull request #12421 from slafebre/fix/11798-perspective-crop-free-size
fix(engine): a free Perspective Crop takes the quad's perspective size (#11798)
2026-11-09 15:45:51 +01:00
David Mann 43cfc2a397 Merge pull request #12236 from hectorviov/fix/perspective-crop-modifiers
Perspective Crop: Shift and Alt constrain the new drag and corner drags
2026-11-09 15:45:40 +01:00
David Mann 559ea66712 Merge pull request #12182 from hectorviov/fix/eyedropper-context-menu
Eyedropper: right-click menu with the Sample Sizes, Copy Color as HTML and Copy Color's Hex Code (#11747)
2026-11-09 15:45:29 +01:00
David Mann 03d22c63e0 Merge pull request #9798 from TimothyBritt/feat/cylinder-warp-editor
Warp mode: edit Photoshop's Cylinder warp with handles and fields (#4112)
2026-11-09 15:43:49 +01:00
4e22c92889 fix(text): #8247 colour glyph review findings (fan-out graphs, hidden glyphs, CMYK, clips, radial)
Works through the five CodeRabbit threads on d9102e7e0a:

- A COLR graph that reuses both children of every composite was walked
  exponentially often (skrifa 0.44 only limits depth and cycles on the
  current path), stalling rendering and measuring. photocraft-text moves to
  skrifa 0.47, already in the lockfile, which caps a walk at 16384 paints;
  such a glyph falls back to its plain outline like a cycle does.
- Glyphs hidden by a transparent text colour are skipped before their graph
  is walked or painted, so they can't spend the budget and drop the
  visible text.
- In CMYK (and other non-RGB) documents, pixels in the text colour alone
  keep its own components instead of a round trip through sRGB, as plain
  glyphs do (a K-only black stays K only).
- Nested clips intersect by the smaller coverage, so a glyph clipped by its
  own outline twice keeps its anti-aliased edge.
- A radial gradient's shared point of touching circles (a = b = c = 0) is
  painted with the largest t instead of dividing 0 by 0.

Each fix has a test that fails without it.

Co-Authored-By: adi-1108 <adi-1108@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 15:21:10 +01:00
Raghav Krishna 3576f83b50 Pencil: check the drawn toggle states after a tool switch (#11962) 2026-11-09 19:44:12 +05:30
Raghav Krishna f41a39276a Pencil: cover a mixed pressure setting across tool switches (#11962) 2026-11-09 19:32:12 +05:30
Raghav Krishna 7b8fb4fedc Pencil: cover pressure size in the isolation test (#11962) 2026-11-09 19:22:50 +05:30
Raghav Krishna cf93aeecd4 Pencil: check both directions of the pressure-flag isolation (#11962) 2026-11-09 19:10:57 +05:30
David Mann e06ba09af4 Merge remote-tracking branch 'origin/main' into pr-6215
# Conflicts:
#	docs/gaps.md
#	docs/ui-parity.md
2026-11-09 14:38:19 +01:00
719ce3cfda Merge main into #9798 (Cylinder warp editor)
Conflict only in docs/gaps.md's status line: both entries kept.

Co-Authored-By: TimothyBritt <TimothyBritt@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 14:36:07 +01:00
Raghav Krishna 390a855c1a Pencil: tighten the pressure-toggle tests (#11962) 2026-11-09 19:01:19 +05:30
David Mann 3369f427ba Merge main into #7377 (Fujifilm compressed RAF)
Only the docs status lines conflicted: main's text, with the compressed RAF entry kept first.
2026-11-09 14:26:32 +01:00
David Mann 1372bae3ea Merge pull request #9077 from ArjenS-LA/fix/average-smart-filters
Execute Average on Smart Objects and imported PSD smart filters
2026-11-09 14:23:56 +01:00
David Mann fbcb6798e0 Merge pull request #9021 from devstivi/apply-to-all-unsaved-prompt
Offer Apply to All in the unsaved-changes prompt
2026-11-09 14:23:44 +01:00
Raghav Krishna 951e9624cb Pencil: pressure toggles on the options bar (#11962) 2026-11-09 18:40:10 +05:30
61aa24991a PR #11836: map a recorded Displace path only when a document may name it
Playback reads the map path a loaded action file names. An action set is
shared like a document, so the path now follows the same rule as paths
stored in documents: a local absolute file. A network share, device, URL
or relative path stays a kept step with its bytes, so playing a
downloaded set never opens a remote share. Test paths are now native to
the platform, so the round trips also hold on Linux and macOS.

Co-Authored-By: yoriswind <yoriswind@yahoo.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 14:04:12 +01:00
David Mann 24cd4a4098 Merge remote-tracking branch 'origin/main' into pr-11836 2026-11-09 13:52:38 +01:00
David Mann 5ac21d0166 Merge remote-tracking branch 'origin/main' into pr-8247 2026-11-09 13:52:03 +01:00
David Mann 24ad0083fe Merge main into fix/color-replacement-tolerance-field (conflict in retouch_ui.rs test modules: kept both) 2026-11-09 13:47:35 +01:00
2c4f1eddd8 Merge main into fix/eyedropper-context-menu (#12182)
Conflict in crates/ui-egui/src/lib.rs: main added
mod cam_no_pixels_alert_tests next to this PR's
mod eyedropper_context_menu_tests; both are kept, each with its own
#[cfg(test)].

Co-Authored-By: Hector Villarreal <hectorviov@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 13:47:24 +01:00
83e5d34ba5 Merge main into fix/perspective-crop-modifiers (conflict in crates/ui-egui/src/tools/perspective_crop_ui.rs)
Main's #11972 (shield) added its own test module next to this PR's; both are
kept. Its shield test builds a Drag::New, which now also carries square and
centred: set to false (no modifier), so it compiles with this PR's pointer.

Co-Authored-By: hectorviov <hectorviov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 13:47:17 +01:00
David Mann 89b61333e5 Merge branch 'main' into fix/note-clear-all-confirm (merge queue) 2026-11-09 13:37:07 +01:00
David Mann 4dd25afb77 Merge pull request #12371 from rmsff/fix/pencil-shift-digit-opacity-11967
fix(ui): Shift plus a digit sets the Pencil's Opacity (#11967)
2026-11-09 13:19:08 +01:00
David Mann ccac986a82 Merge pull request #12406 from slafebre/fix/11995-magic-eraser-tolerance
fix(engine): the Magic Eraser measures Tolerance by colour spread (#11995)
2026-11-09 13:18:40 +01:00
David Mann b9d3d40fa3 Merge pull request #12151 from hectorviov/fix/magnetic-lasso-caps-lock-circle
Magnetic Lasso: Caps Lock swaps in the Width circle cursor (#11690)
2026-11-09 13:08:42 +01:00
rmsff c5239ca4d6 test(ui): Fit Screen after Fill Screen leaves only the fit pending (#12026) 2026-11-09 13:59:48 +03:00
FredApps 885a6ddf27 Merge pull request #9864 from Higgs32584/fix/8806-rasterize-click-replay
fix(ui-egui): the rasterize prompt no longer replays the click that opened it (#8806)
2026-11-09 11:55:33 +01:00
FredApps e4961259bb Merge pull request #10344 from ebosido444-ai/fix/faux-bold-weight
fix(text): size faux bold by Photoshop's size/72 ring instead of a flat 3.6% (#9008)
2026-11-09 11:55:23 +01:00
David Mann c06fbdc7ba Merge pull request #12227 from hectorviov/fix/perspective-crop-shield
Perspective Crop: dim the image outside the quad with a shield
2026-11-09 11:41:41 +01:00
FredApps c7b2efafd0 Merge pull request #9841 from Kaedo17/fix/zoom-tool-context-menu
fix: dismiss context menu without triggering tool action on outside click
2026-11-09 11:38:43 +01:00
DingusMcRinkyDinkyandClaude Opus 5.5 51760ec0be Warp: only tiles where the picture folds are drawn in the fold's order
A warp draws each tile in row order, as one that can't fold does, and notes
whether two parts of the picture meet at a pixel; only such a tile is drawn
again in the fold's order, with its layers composited, and the order is
worked out the first time a tile needs it. Without a fold the order makes no
difference, so such a warp costs what it did before folds stacked.

24 MP layer, release, best of three: main 0.22 s without a fold, 0.23 s with
one; now 0.20 s and 0.26 s (was 0.24 s and 0.29 s).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EZbgszHyuEuWAzxaamteuU
2026-11-09 11:32:15 +01:00
rmsff 0910d30c0f fix(ui): ⌘. waits for a composition's text to commit before cancelling (#12076) 2026-11-09 13:26:08 +03:00
rmsff c7752cc184 test(ui): the Hand bar tests draw in English (#12026) 2026-11-09 13:13:29 +03:00
rmsff b03c26c966 fix(ui): the Hand options bar gets the reference tooltips and no hint text (#12026) 2026-11-09 13:13:28 +03:00
rmsff 248f65d577 fix(ui): Shift plus a digit sets the Pencil's Opacity (#11967) 2026-11-09 13:12:54 +03:00
rmsff d6a1ed1b1c feat(ui): Cmd+. (Ctrl+.) cancels a type editing session (#12076)
While editing with any of the four type tools, Cmd+. (Ctrl+. off the
Mac) now does what the options bar's Cancel button does, as in the
reference application: the session ends and the document, the
selection and the history are as they were before it.

Shift+Cmd+. stays Increase Type Size. Outside a type session, while an
input method is composing and during a Cmd transform drag (not
measured) the key does what it did before: nothing.
2026-11-09 13:12:53 +03:00
DingusMcRinkyDinkyandClaude Opus 5.5 6687b4514e Warp: a fold reads its source in parts, not one window across it
Timing a 24 MP Warp showed folds cost five times main's time (1.23 s
against 0.22 s): a tile where the dragged part lies over the rest samples
two distant parts of the source, and its one window spanned everything
between them (230 MP read per render against 31 MP). A tile's samples are
now grouped into connected regions of the source on a coarse grid, each
read as a window of its own; a tile whose samples lie close together stays
one window, without the grid. A fold's layers are kept in one linked list
per tile instead of a list per folded pixel, and the cells are sorted in
parallel.

24 MP layer, release, best of three: main 0.22 s without a fold and
0.23 s with one; before 0.28 s and 1.23 s; now 0.24 s and 0.29 s.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EZbgszHyuEuWAzxaamteuU
2026-11-09 11:05:45 +01:00
Sven Lafebre 0a8eb9d6c8 fix(algo): keep the edges when a pixel of click error swings a free Perspective Crop (#11798)
A corner moved one pixel could take a quad across the parallel-sides limit and the output from 602 x 400 to 719 x 289. The estimate now has to survive one pixel of error on every corner, with its proportions moving by no more than 10 %. Also test the commit path with W and H empty, and a known rectangle seen by a camera model.
2026-11-09 10:22:12 +01:00
Kaedo17 51bf468007 contributors: keep davidvhk's name-sync setting in the table
The earlier people.toml merge resolution inserted the new
[people.Kaedo17] header between [people.davidvhk]'s real_name and its
sync_github_name = true, so TOML parsed that setting as Kaedo17's and
davidvhk silently lost theirs. Restore davidvhk's setting and keep
Kaedo17 as its own block with its own sync_github_name = true
(FredApps, #9841).

Parsing base 9394960e4 and this tree side by side: the only difference
is the added [people.Kaedo17] entry; every existing entry is unchanged.
2026-11-09 17:16:50 +08:00
Kaedo17 bc86b479e4 Merge remote-tracking branch 'upstream/main' into fix/zoom-tool-context-menu 2026-11-09 17:00:53 +08:00
FredApps d06ad73271 Naming: use RAW Develop for PhotoCraft's raw-processing feature (#12403)
Related to #5310. Display labels only; command ids (filter.cameraRaw, edit.preferences.rawDefaults), preference keys, serialized settings, PSD/action/XMP Adobe Camera Raw identifiers and .atn step names are unchanged.

- Camera Raw / Camera Raw Filter / Camera Raw Defaults -> RAW Develop / RAW Develop Filter / RAW Defaults in menus, preferences, filter names, diagnostics and all 34 catalogs.
- Saved Photoshop actions keep the "Camera Raw Filter" step name, so .atn files round-trip byte for byte (test extended).
- "Camera Raw" stays a command-search keyword.
- Removes dormant Adobe/Photoshop-branded catalog rows; display-name guard tests.
2026-11-09 08:30:33 +01:00
qvest-sselsandClaude Opus 5.5 aff412cfb7 feat(ui): a pixel layer thumbnail's right-click menu with Select Pixels (#12324)
Right-clicking a pixel layer's thumbnail in the Layers panel opens
Photoshop's thumbnail menu instead of the layer menu: Select Pixels, which
loads the layer's transparency as the selection as a Cmd/Ctrl-click on the
thumbnail does, then the thumbnail sizes and Clip Thumbnails to Layer /
Document Bounds (shared with the empty-area menu, #11404). The Background,
with no transparency to load, frames, and type, shape, smart object, fill,
adjustment and group thumbnails keep the layer menu with their own items.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 08:22:22 +01:00
DingusMcRinkyDinky 5cb4856607 Merge remote-tracking branch 'upstream/main' into pr-fold-layers 2026-11-09 07:32:41 +01:00
RickiNano 44a3c25a9e Background Eraser: a CMYK document compares against the picked inks (#12352)
Protect Foreground Color and Sampling Background Swatch converted the
foreground and background from their sRGB stand-ins, so a colour picked
as CMYK inks (100/0/0/0) came back as other inks and pixels painted with
exactly those inks were erased or missed. BgEraseSettings now carries the
picked inks, as BrushSettings::color_cmyk does, and a CMYK target compares
against them while the colour is still that sRGB colour. RGB, Gray and Lab
documents are unchanged.
2026-11-09 07:00:26 +01:00
RickiNano 66cbb2a117 Retouching tools: a Shift-click line isn't smoothed either (#11887)
The Shift-click override only reached the Brush, Pencil, Eraser and Mixer
Brush. The retouching tools take their brush from the engine
(`retouch_cmds::stroke_brush`, or `resolve_brush` for the Background Eraser
and Color Replacement), so with Catch-up on Stroke End off their lines
stopped short of the click.

- `stroke_brush` takes `smoothing` (0..100, the options bar's Smoothing).
- `canvas::unsmoothed_line` sends `smoothing: 0` for a Shift-click line in
  every retouching tool's live preview and in both commits, so a commit
  still takes the pixels its preview drew.
2026-11-09 06:56:00 +01:00
Tim BrittandClaude Fable 5.1 7eaaf85dcf Rebase: the transform bar test harness is 1000 pt wide, as main's since #11679
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-09 04:52:31 +00:00
Kaedo17 adaba2a34e style: split the glide-choice assignment for rustfmt
cargo fmt --all -- --check on the merge commit flags only the
glide_scroll_all assignment added by the conflict resolution: the merge
produced it as one long line, and rustfmt wants the call on its own line.
No behaviour change (cloutier, #9841).
2026-11-09 12:45:29 +08:00
ljkx c2039dd0e8 Actions: map Image › Analysis › Set Measurement Scale › Custom (#10723)
The Set of the document's measurementScale property (T: pixelLength long,
logicalLength double, logicalUnits text) loads as
image.analysis.setMeasurementScale with the custom preset and saves back
with its recorded descriptor. Other forms stay kept steps; a native step
that reads, resets or partly sets the scale refuses export.
2026-11-09 05:43:34 +01:00
Kaedo17 2f45dd691f Merge remote-tracking branch 'upstream/main' into fix/zoom-tool-context-menu 2026-11-09 12:42:28 +08:00