Commit Graph
11425 Commits
Author SHA1 Message Date
71acb4c47e native menu: test that an imported .kys set owns the system keys it binds (#7809)
Review on #7809 asked for coverage of imported .kys bindings. The set moves
Cmd+M to Levels and gives Fill Cmd+, as its second key; the menu bar shows
Cmd+M on Levels only, Minimize keeps Ctrl+Cmd+M, Settings yields Cmd+, and
the clash is reported. Fails without app_layout's dispatch ownership pass.

Co-Authored-By: andeecollard <6765611+andeecollard@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 18:51:44 +01:00
David Mann 4e0b455683 Merge remote-tracking branch 'origin/main' into pr-7809
# Conflicts:
#	crates/ui-egui/src/menus/native_menu.rs
2026-11-08 18:51:35 +01:00
David Mann 6f6db07478 Merge remote-tracking branch 'origin/main' into pr-12154 2026-11-08 18:50:05 +01:00
Trevor BrownandClaude Sonnet 5.5 76ad52bf47 Patch Destination: the rectangle check is capped and scans in bands (#12119)
Cause: is_hard_rect read selection coverage over the selection's own content bounds in one buffer. After a transform those bounds can reach far past the canvas, while the patch-size guard only measures the on-canvas part, so a huge mostly-off-canvas selection could stall or exhaust memory.

Fix: is_hard_rect now calls is_hard_rect_within with MAX_PIXELS (the patch's own cap); bounds over the cap are not a hard rectangle and the selection stays in place. Otherwise coverage is scanned in 64-row bands, stopping at the first pixel below 1.0.

Verified: new test covers a limit below and at the pixel count and a hole in the third band; patch (25) and retouch (126) lib tests pass, clippy -D warnings and fmt clean.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove and briefed; Sonnet 5.5 wrote at medium
2026-11-08 12:38:04 -05:00
Serikov Roman bbfa1758f6 fix(ui): Reset Tool gives the Healing Brush a 19 px hard tip at 25 % spacing (#12099) 2026-11-08 20:32:54 +03:00
dotCooCoo d92aab7b79 Updates: the updater reports installing, ready, installed and failed, and installs at exit
Move the craft-libs crates pinned at c5a1cbfb (craft-ui, craft-print,
craft-pdf, craft-docpath, craft-jpeg, craft-update and the hayro patches)
to a craft-libs branch that merges storytold/craft-libs#687 and #696.
craft-pcraft-format stays at b8f7d93b.

- At the first frame, the result window shows what the last self-update
  came to: the version it installed, or why it could not be installed.
  A new `Services::last_update` reads the outcome records once; a manual
  check made before that frame leaves them for the next start.
- A manual check that finds a release while an update installs or waits
  for the app to close, or while the launcher keeps this version, shows
  Installing, Ready (with Restart to Update) or the launcher's choice.
- Closing the result window clears the updater's status and the last
  update's outcome. The window comes back after the startup prompt
  closes while that outcome is still unread.
- The update helper starts when the app drops the updater at exit.
2026-11-08 09:22:02 -08:00
David Mann f439a33ce5 Merge remote-tracking branch 'origin/main' into pr-12049 2026-11-08 18:20:55 +01:00
b5501b9bd1 PR #12049: keep a held ~ erasing on the Background, keep Clear on a locked one
The engine turned every "mode": "clear" stroke on the Background into
Normal, so a held ~ painted the foreground there instead of erasing to
the background colour as on main. The options bar already turns a chosen
Clear off at the press, so the engine conversion was not needed: drop it
and keep the one check in clear_off_on_background.

A Background with locked pixels refuses the stroke, so a chosen Clear now
stays chosen there. The "Tool state machine" doc line is back on
tool_event.

Co-Authored-By: DuBearte <DuBearte@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 18:20:55 +01:00
FredApps e564137b23 Merge pull request #12275 from Triwarr/pdf-editable
PDF: opt-in editable import (paths and text)
2026-11-08 18:13:39 +01:00
1e4b8816fe New Guide Layout (#6083): drop a same-type cast in a test
Co-Authored-By: safvanedge <safvanedge@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 18:10:21 +01:00
Hector Villarreal 9390637f82 Mixer Brush: the load menu's and the setting's comments list Load Solid Colors Only and its key (eliets2 review on #12295) 2026-11-08 11:06:19 -06:00
David Mann bb7a1289b0 Merge remote-tracking branch 'origin/main' into pr-12049 2026-11-08 18:05:36 +01:00
Hector Villarreal e9f62aaef4 Eraser range alert tests: the leading-zero draft, a caption scrub past 100, and no alert on a tool switch (eliets2 review on crates/ui-egui/src/eraser_range_alert_tests.rs) 2026-11-08 11:01:17 -06:00
f5025f8f2a New Guide Layout (#6083): Tab selects while a button is held, lengths remembered in px
CodeRabbit found two more gaps on the PR's latest head:
- Tab into a length field while a mouse button was held did not select its
  text, so typing appended ("2 mm5"). field_tab now marks the field it hands
  focus to, and the dialog selects that field whatever the mouse does.
- A unitless length set over automation ("5") was remembered as typed, so a
  later ruler unit change reread it in the new unit. Confirm now remembers
  each length as the pixels it applied; reopening shows them in the new unit.

Also adds a test that Enter straight after a bare number applies it in the
unit the field showed.

Co-Authored-By: safvanedge <safvanedge@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 17:53:27 +01:00
David Mann 8500fd729a Merge remote-tracking branch 'origin/main' into pr-6083 2026-11-08 17:36:27 +01:00
David MannandClaude Opus 5.5 62c5d6283c Copy CSS: groups, fill layers and point type as the reference application writes them
Measured in the reference application:
- A group writes its box (the canvas) and z-index, then the rule of each
  layer in it, top first, with no blank line between rules. A group's end
  takes a place in the stack, so z-index counts it.
- A Solid Color fill layer without a shape greys Copy CSS out; so does a
  selection with no layer that has CSS.
- Point type is placed by its line box: left is the pixel left less the
  ink's offset from the origin; top centres the line box on the pixels, or
  on half the cap height above the baseline when the text has a
  descender. Left and top are cut after three decimals, not rounded.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 17:34:32 +01:00
FredApps 79f1da3a93 Merge main and Hand menu test compatibility fix 2026-11-08 17:30:30 +01:00
FredApps dd6e77309f test(ui): align Hand menu anchor checks with fixed zoom rows 2026-11-08 17:28:55 +01:00
David Mann 535ea2d15c Merge pull request #12152 from davidmann4/fix/11904-bg-eraser-find-edges-graded
Background Eraser: Find Edges erases soft edges graded instead of cutting them hard (#11904)
2026-11-08 17:00:18 +01:00
David Mann 1c9448e87f Merge pull request #12341 from rmsff/fix/vertical-type-align-buttons-12059
fix(ui): vertical text gets Top / Center / Bottom alignment buttons (#12059)
2026-11-08 17:00:04 +01:00
David Mann 718b06645e Merge pull request #12299 from TrevorBrown-dev/fix/patch-cursor-arrow-12130
Patch: an arrow badge over the selection shows that a drag moves the patch (#12130)
2026-11-08 16:59:48 +01:00
David Mann 532421aa2a Merge pull request #12212 from TrevorBrown-dev/feat/open-as-smart-object-11678
File: Open as Smart Object... opens a file as a new document holding one embedded smart object (#11678)
2026-11-08 16:59:25 +01:00
David Mann 6b73593478 Merge pull request #12238 from hectorviov/fix/brush-picker-angle-widget
Brush Preset picker: the tip's angle/roundness widget at its top left
2026-11-08 16:59:09 +01:00
David Mann 8c94ba8a15 Merge pull request #12203 from hectorviov/fix/count-history-names
Count tool: History names Add/Drag/Delete Count Object, Add Count Group and one name per group setting (#11763)
2026-11-08 16:58:51 +01:00
FredApps 5ae31d3de2 fix(pdf): preserve editable import fidelity and bound caches 2026-11-08 16:58:06 +01:00
David Mann 89660c82fe Merge pull request #12231 from hectorviov/fix/note-stored-values
Notes: new notes store the reference application's colour, popup rectangle and local-time date
2026-11-08 16:57:08 +01:00
David Mann 90e362e7a6 Merge pull request #12221 from hectorviov/fix/perspective-crop-bar-buttons
Perspective Crop: the options bar's Cancel and Commit show only during a session (#11978)
2026-11-08 16:56:52 +01:00
David Mann be4f54df4c Merge pull request #12205 from DuBearte/fix/11968-pencil-auto-erase-tooltip
Pencil: the Auto Erase checkbox shows its tooltip
2026-11-08 16:56:35 +01:00
David Mann b0953546ca Merge pull request #12148 from hnoerenberg/fix/straighten-layer-states-12033
fix(engine): Straighten Layer greys out and refuses the states the reference does
2026-11-08 16:56:18 +01:00
David Mann 45c76d5c5c Merge pull request #12144 from hnoerenberg/fix/indexed-type-selection-12041
fix(engine): the Type tool leaves a selection in Indexed Color
2026-11-08 16:56:00 +01:00
David Mann 32ce08364b Merge pull request #9991 from ljkx/feat/raw-xmp-crop
Camera Raw sidecars: apply the crop, stop reporting RawFileName (#9985)
2026-11-08 16:55:43 +01:00
David Mann 8f94ff568f Merge pull request #12338 from rmsff/fix/type-mask-replaces-selection-12073
fix(ui): a Type Mask always replaces the selection when committed (#12073)
2026-11-08 16:54:03 +01:00
David Mann 2a2b381297 Merge pull request #12333 from rmsff/fix/type-mask-escape-commits-12070
fix(ui): Escape commits a Type Mask session as Command+Return does (#12070)
2026-11-08 16:53:46 +01:00
David Mann 5a288de0e8 Merge pull request #12328 from rmsff/fix/type-options-bar-tooltips-12057
fix(ui): the Type options bar gets the reference tooltips (#12057)
2026-11-08 16:51:41 +01:00
David Mann 2ffe5d1008 Merge pull request #12102 from Bobderto/fix/12085-zoom-menu-centre
Zoom tool menu: keep the view centre for Zoom In and Out
2026-11-08 16:51:19 +01:00
1f6e1953dd Keep a moved float when an Option-drag of it becomes a tab transfer (#10059)
Arming a cross-document transfer from an Option-drag of an existing float
rolls back the drop-and-copy, which raises the document revision. The float
was restored with its old revision, so floating() treated it as stale and
the earlier move was lost. Restore it over the current revision, with a
regression test.

Co-Authored-By: tomgardenart <tomgardenart@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 16:34:17 +01:00
David Mann 367c518145 Merge remote-tracking branch 'origin/main' into pr-10059 2026-11-08 16:28:39 +01:00
Trevor BrownandClaude Sonnet 5.5 66d5ebed89 Menus: Layer Via Copy and Layer Via Cut with a capital V, as in the reference (#12357)
Cause: the menu bar, the command labels and the selection tools' canvas menu spelled the two commands "Layer via Copy" and "Layer via Cut", while the reference application (and PhotoCraft's own History names and ATN event table) use a capital V.

Fix: renamed the labels in crates/ui-egui/src/menu_catalog.rs, the two spec! labels in crates/engine/src/cmd/edit_cmds.rs, and the rows in crates/ui-egui/src/canvas/canvas_tool_menu.rs with its test assertions. In the 33 locale files crates/ui-egui/src/i18n/*.tsv that carry the keys, only the key column of those two rows changed (66 rows), so every translation is kept and no language falls back to English. New tests are in crates/ui-egui/src/layer_via_label_tests.rs, registered with one mod line in lib.rs like the other *_tests.rs files.

Verified: the 5 new tests pass; canvas_tool_menu 51 passed; engine edit_cmds 112 passed; i18n 66 passed and 8 live_tests failed with the known local font panic in epaint fonts.rs (font-dependent, green on CI); cargo xtask parity left docs/parity-checklist.md unchanged; clippy -D warnings and fmt are clean. TSV check against HEAD: 34 files, same row count in each, exactly 66 rows differ (2 per file in 33 files, Hindi has none), only the key column of those rows differs, the translation column is byte-identical, no old key remains, and no CR bytes in any touched file.

Not changed: the translations' text, the History names and the ATN event table (already the capital V), docs/ui-parity.md and the other parity docs.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove and briefed; Sonnet 5.5 wrote at medium
2026-11-08 10:14:55 -05:00
ac6822c7d6 Color Lookup: the Image > Adjustments dialog's defaults run again (#9827)
Since the embedded-LUT params were added, the generated Color Lookup dialog
filled `fileName` with 0 (the dialog has no kind for `text?`), `data` with ""
and `lutFormat` with "cube". Every OK failed, and a .3dl or .look file from
the LUT folder (#9754) would have been parsed as .cube. `fileName` is now
plain text, `lutFormat` gets an `auto` default (detect from the file), and
an empty `data` / `fileName` counts as not given, like an empty `file`.

Also puts the Lens Blur test's doc comment back on its test (a merge had
moved it onto the LUT folder test).

Co-Authored-By: Luis-0508 <43929895+Luis-0508@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 16:05:10 +01:00
Trevor BrownandClaude Opus 5.5 1483d5193d Merge upstream/main into fix/patch-destination-selection-12119
Conflict in retouch_cmds/patch.rs with #12255 (one History name, "Patch Selection", for every mode): kept the Destination branch that moves a hard rectangular selection with the patch and gave it HISTORY_NAME, and restored Plan's destination flag, which #12255 had removed as unused. patch tests 24 passed (including #12255's history-name test), clippy and fmt clean.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove and resolved
2026-11-08 09:51:27 -05:00
David Mann eaaa84b04b Merge remote-tracking branch 'origin/main' into fix/11905-bg-eraser-transparency-lock 2026-11-08 15:49:56 +01:00
David MannandClaude Opus 5.5 fcba4c875b Background Eraser: pin preview = commit for a channel target on a locked layer; LiveDab::unlocked usage
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 15:49:52 +01:00
Trevor BrownandClaude Sonnet 5.5 f3de619549 Patch Destination: a hard rectangle partly off the canvas moves with the patch (#12119)
Cause: is_hard_rect required the selection's bounds to equal plan.area, which is clipped to the canvas. A hard rectangle reaching past the canvas (e.g. moved there with select.transformSelection, which keeps the off-canvas pixels) has bounds larger than the area, so the pixels were patched but the selection was left behind.

Fix: treat the selection as a hard rectangle when nothing is selected outside its own bounds and every pixel inside those bounds is fully selected, then translate the whole selection by the drag offset. Feathered, non-rectangular and holed selections still stay in place.

Verified: new test destination_moves_a_hard_rectangle_that_extends_past_the_canvas failed before the change (selection stayed at -20,100..40,140 while the pixels changed) and passes after, including one-undo restore of pixels and selection. cargo test -p photocraft-engine --lib patch (19 passed) and retouch (120 passed), clippy -D warnings and fmt clean.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove and briefed; Sonnet 5.5 wrote at medium
2026-11-08 09:47:11 -05:00
David Mann cc4469b21d Merge remote-tracking branch 'origin/main' into fix/11908-bg-eraser-angle-pressure
# Conflicts:
#	crates/ui-egui/src/lib.rs
#	crates/ui-egui/src/tools/eraser_ui.rs
2026-11-08 15:40:34 +01:00
David MannandClaude Opus 5.5 64c6d98421 Background Eraser: arrow steps past the Angle's ends no longer alert; more Angle tests
The field consumes the arrow keys it steps with, so the step check now reads them
before the field. New tests: arrow steps stop at +-180 without the alert, a
click-away commits a typed 400 with one alert, a non-number keeps the angle, and
the Magic Eraser check finds any field named Angle.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 15:30:38 +01:00
David Mann 848fa306f5 Merge pull request #12255 from SBaksa/patch-history-names
Patch: History names as the tool's (fixes #12117)
2026-11-08 15:25:52 +01:00
David Mann b11e866957 Merge branch 'fix/11904-bg-eraser-find-edges-graded' into fix/11902-bg-eraser-decontamination
# Conflicts:
#	crates/paint/src/bg_erase.rs
2026-11-08 15:14:07 +01:00
David MannandClaude Opus 5.5 1d5d94cf17 Background Eraser: document that Find Edges grades in this tool
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 15:13:28 +01:00
David Mann ec76a8f08a Merge branch 'fix/11901-bg-eraser-graded-alpha' into fix/11904-bg-eraser-find-edges-graded 2026-11-08 15:13:00 +01:00
David MannandClaude Opus 5.5 cbdce347f0 Background Eraser: Protect Foreground keeps the per-channel distance; tolerance doc
Only the sample match uses the measured increase-plus-decrease distance (#11901).
Protect Foreground Color keeps today's largest per-channel difference, as #11903
asks for its unmeasured cases. The tolerance doc describes the new distance and
the graded falloff.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 15:12:49 +01:00