Commit Graph
11425 Commits
Author SHA1 Message Date
Raghav Krishna 3ecc3a0fdf Crop options bar: translate the new strings into every catalog (#10888) 2026-11-10 17:48:54 +05:30
Raghav Krishna 1de14304f1 Crop: reference tooltips, Fill help modal, live-only Cancel/Commit, blank ratio sides (#10888) 2026-11-10 17:47:31 +05:30
Raghav Krishna aa12046847 Crop: Straighten gets its label and a spirit-level glyph (#10888) 2026-11-10 17:47:27 +05:30
FredApps 7091cb6b8c Raster: the memory reservation tests take turns (#12854)
RESERVED is process-wide. Under cargo test (the FreeBSD job) the module's tests run on threads of one process, so an_operation_that_fits_alone_waits_for_a_concurrent_one's reservation could land between reservations_are_bounded_and_returned's before and after counts (left: 434166548, right: 0). nextest on Linux gives each test its own process, which hid it. Locally the unfixed module failed 15 of 40 runs, the fixed one 0 of 40.
2026-11-10 13:16:05 +01:00
rmsff 9b438fb90e Remove tool: show the centre + in its brush cursor by default (#12550) 2026-11-10 15:04:08 +03:00
rmsff c7407f50e5 Reset Tool gives the Clone Stamp a 21 px soft tip at 25 % spacing
The Clone Stamp now starts, and comes back after Reset Tool and Reset All Tools, with the reference's 21 px soft round at 25 % spacing and no smoothing (#12601).
2026-11-10 14:29:38 +03:00
rmsff 1195fb971a Blur Strength: alert when a typed value is out of range
Typing a Blur Strength past 1..100 now stores the closest whole number and shows the reference's "Closest value inserted" alert once the field is left, as the Eraser's fields do. Sharpen and Smudge share the field but were not measured, so they keep the silent clamp.
2026-11-10 14:27:13 +03:00
rmsff 75650176b6 Tests: the fill-layer rasterize prompt text and OK (#12538)
A Paint Bucket click on a Solid Color fill layer shows the reference
question; OK only rasterizes the fill (one history state, no fill). The
catalogs that translated the old text translate the new one, a language
without an entry falls back to English, and no catalog keeps the old key.
2026-11-10 14:14:40 +03:00
rmsff 75341eff57 Rasterize prompt: the fill wording as in the reference (#12538)
A Paint Bucket (or other pixel tool) click on a fill layer asks "The fill
for this layer must be rasterized before proceeding. It will no longer be
editable as a fill. Rasterize the fill?", as measured in the reference
application. The 22 catalogs that translated the old text are re-keyed to
the new English text, so those languages keep a translation, as #11899
did for the smart object text. The test that pinned the four prompts now
expects the new fill text; OK and Cancel are unchanged.
2026-11-10 14:01:38 +03:00
rmsff 2390a935ff Tests: Red Eye history states for hits, misses and refusals 2026-11-10 13:56:00 +03:00
rmsff 6106c825e7 Red Eye: name the step Red Eye Removal Tool and record a click that changes nothing
A click that runs but changes no pixel (a blue pupil, a transparent area, an
empty layer, Darken Amount 0) now adds one unchanged history state instead of
the "no red-eye pixels" error, as in Photoshop. Non-RGB/Lab documents, channel
and mask targets, hidden layers and clicks outside the selection or the canvas
keep the error and add no state.
2026-11-10 13:56:00 +03:00
Hector Villarreal d8fdb5aa4b Merge main into fix/perspective-crop-click-preview (picks up the fixed sampler and wand tests) 2026-11-10 04:46:18 -06:00
Hector Villarreal 8257d890a9 Merge main into fix/mixer-load-solid-colors (picks up the fixed sampler and wand tests) 2026-11-10 04:37:57 -06:00
Trevor Brown 3d56b2df67 Merge main (sampler test expectations, #12790) for CI 2026-11-10 05:37:54 -05:00
rmsff aa4ef1735c Test the Remove Tool new layer name 2026-11-10 13:14:42 +03:00
rmsff 829a8b8f51 Remove Tool: name the new layer "Remove tool edits"
With Create new layer on, the result layer was "Layer N". Name it as the
reference does: "Remove tool edits", then "Remove tool edits 1", "2"...
taking the first free name.
2026-11-10 13:14:42 +03:00
rmsff 6c3579fb59 Test Convert Point's History step names 2026-11-10 13:14:39 +03:00
rmsff 35abce7773 Name Convert Point's History steps Change Anchor Point and Corner Drag
path.convertPoint and path.moveHandle take an optional stepName (only
that one name is accepted, as with edit.transform), and the Convert Point
tool sends it. Direct Selection, the Pen's Alt conversion and the
Curvature Pen keep Convert Point and Drag Direction Point.
2026-11-10 13:14:39 +03:00
rmsff bc3d366c4c Test the Dodge tool's Indexed Color and Bitmap refusal 2026-11-10 13:14:36 +03:00
rmsff 7188facf57 Refuse Dodge in Indexed Color and Bitmap documents
paint.dodge and its live stroke return the reference application's
message in Indexed Color and Bitmap documents and tone nothing; a press
with the Dodge tool shows it as a modal alert. Other modes keep dodging.
2026-11-10 13:14:36 +03:00
rmsff 0610e89921 Test deleting the last anchor of a saved path 2026-11-10 13:14:33 +03:00
rmsff 7a77b42a35 Delete Anchor Point: deleting a saved path's last anchor leaves it empty
A saved path whose only anchor is deleted keeps its place in the Paths panel with no subpaths, as in Photoshop. The Work Path, a shape's path, a vector mask and a Type Path still refuse it.
2026-11-10 13:14:33 +03:00
rmsff c4296987d3 Test the Art History Brush state of a click held back by the tolerance 2026-11-10 13:14:30 +03:00
rmsff bdf1050f6f Art History Brush: a click held back by the tolerance adds its state
Photoshop adds one unchanged "Art History Brush" state when the Tolerance holds back every dab. A stroke that could write nothing anyway (wholly outside the selection, on locked transparent pixels) stays a quiet no-op, and refusals still add no state.
2026-11-10 13:14:30 +03:00
rmsff 992d2d77a4 Test the Add and Delete Anchor Point options bars 2026-11-10 13:14:27 +03:00
rmsff 9878a61e3b Add Anchor Point: options bar says the tool has no options
Photoshop's bar holds only the preset picker and "No options for the Add Anchor Point Tool.", centred in the rest of the bar. The Alt hint goes; the Delete Anchor Point bar keeps its hint.
2026-11-10 13:14:27 +03:00
David Mann 71a5c58585 Merge pull request #12790 from tjbbjt/fix/sampler-tests-pixel-centre
Tests: expect Color Sampler points on pixel centres after #12174
2026-11-10 11:04:45 +01:00
Trevor BrownandClaude Opus 5.5 6944f6eddf Anchor tools: only a hidden active layer is skipped; a layer in a hidden group keeps today's behaviour (#12762, #12705)
The items measured a hidden active shape layer; shape layers inside a group were not measured, so their behaviour stays as on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove and wrote (review fix, no brief)
2026-11-10 04:49:10 -05:00
Trevor BrownandClaude Sonnet 5.5 0363c5b20e Add/Delete Anchor Point: edit only the targeted path (#12762, #12705)
The anchor tools searched Direct Selection's candidates, which include every visible shape layer, so a shape that was not active could be edited. They now search only the targeted paths (new direct_select::hit_active), and skip a hidden shape layer. Direct and Path Selection are unchanged.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Opus 5.5 briefed; Sonnet 5.5 wrote at medium
2026-11-10 04:46:02 -05:00
tjbbjt e2580ccdb5 Tests: document the Color Sampler tests updated for pixel centres 2026-11-09 22:26:46 -08:00
Hector Villarreal 4cb7519df6 Perspective Crop click-preview tests: pass the modifiers main's pointer() now takes 2026-11-10 00:12:40 -06:00
Hector Villarreal aedda3996c Merge main into fix/perspective-crop-click-preview (conflicts as asked on the PR) 2026-11-10 00:09:37 -06:00
Hector Villarreal 1beefac1ed Merge main into fix/mixer-load-solid-colors (conflicts as asked on the PR) 2026-11-09 23:46:36 -06:00
tjbbjt 010fbe9e2e Tests: expect Color Sampler points on pixel centres after #12174 2026-11-09 21:44:47 -08:00
David Mann d6b97e5b4b Merge pull request #12174 from hectorviov/fix/sampler-pixel-centre
Color Sampler: points sit on the clicked pixel's centre (#11725)
2026-11-10 03:04:39 +01:00
David Mann 7c263e28eb Merge pull request #12721 from Bobderto/codex/12670-burn-dodge-tooltips
fix(ui): add Burn and Dodge options-bar tooltips
2026-11-10 02:24:33 +01:00
David Mann 382ed04521 Merge pull request #12677 from RickiNano/fix/remove-history-name-12541
Remove tool: name the History step "Remove Tool" (#12541)
2026-11-10 02:24:19 +01:00
David Mann dfdafa3b33 Merge pull request #11160 from vangel76/fix-11096-corner-projection
Free Transform: a proportional corner drag follows the pointer along the diagonal (#11096)
2026-11-10 02:23:56 +01:00
David Mann 93ca888de3 Merge pull request #12690 from ElNeMeR70/fix/art-history-brush-shift-click-12627
fix(ui): do not connect Art History Brush Shift-clicks with a straight line
2026-11-10 02:10:06 +01:00
David Mann 840f24c6fd Merge pull request #12691 from RickiNano/fix/burn-default-tip-12671
fix(ui): Reset Tool gives the Burn tool a 65 px soft tip at 25 % spacing (#12671)
2026-11-10 02:09:53 +01:00
David Mann 625ea98a37 Merge pull request #10059 from tomgardenart/fix/selected-pixel-transfer-nostella
Drag selected pixels between document tabs and tiled canvases
2026-11-10 01:03:25 +01:00
Dan f6d5b92bf2 fix(ui): keep tone tooltips within issue scope and document tests 2026-11-09 23:42:47 +00:00
Eng. Mahmoud Bek ElNemer e5bd507a77 fix(art-history): do not draw Shift-click connecting line (#12627) 2026-11-10 01:29:46 +02:00
David Mann e72d12106a Merge pull request #9337 from DuBearte/feat/8639-stroke-emboss
feat(compose): Stroke Emboss bevels the stroked outline (#8639)
2026-11-10 00:21:56 +01:00
Dan 9957f9870a fix(ui): attach tone tooltip descriptions to named controls 2026-11-09 23:19:38 +00:00
vangel76andClaude Sonnet 5.5 ae481e7a1a Project the corner drag onto the on-screen diagonal for distorted boxes (#11096)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-09 23:50:17 +01:00
vangel76 97cf4fa88c Merge remote-tracking branch 'upstream/main' into wt-11160 2026-11-09 23:44:27 +01:00
Dan aab25d6925 test(ui): keep the unexpected-role assertion within test lint rules 2026-11-09 22:34:59 +00:00
Dan 9ad7b7ad87 fix(ui): bound all tone tooltips and avoid anonymous accessibility nodes 2026-11-09 22:23:24 +00:00
Dan 076e82956b test(ui): cover Burn and Dodge hover interactions and narrow layouts 2026-11-09 21:51:17 +00:00