select.object (rectangle and point) returns the reference application's
alert text in these two modes and leaves the selection and History alone;
a click or drag with the tool opens that alert with OK instead of running.
After Image > Mode the source state from before the change was converted
and painted; Photoshop refuses it. Compare the document modes, not the
pixel formats, which read Indexed and Multichannel as RGB. A bit depth
change still converts. The History Brush keeps its behaviour (#12842).
alt_with_twirl_clockwise_twirls_counterclockwise sent both strokes
through pointer(), which reads the wall clock. A held twirl's strength
is the elapsed time, so the plain and Alt runs could differ by more than
the 5 % the test allows on a slow runner. Both now go through pointer_at
at the same fixed times.
New test \`with_the_work_path_selected_a_click_on_the_active_shape_does_nothing\`: the shape is active and the Work Path selected, and a Delete Anchor Point click on the shape's corner (650,250) leaves it unchanged with no history step. It fails on the previous head, where the corner knot was deleted. Anchor and direct_select tests: 107 passed; clippy \`-D warnings\` and fmt clean.
EOF2
cd C:/Users/thetr/.claude-personal-2/jobs/5c930f10/tmp && python cr_reply_resolve.py storytold/photocraft 12815 4525641135 $S/reply-12815-work-path.md 2>&1 | tail -2
Anchor tools: a selected Work Path is the only target too (#12762, #12705)
Review item on #12815: with the Work Path selected in the Paths panel, a miss on it fell through to the active shape.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove and wrote (review fix, no brief)
The two files had the same setup and steps; SonarCloud flagged them as duplicated new code.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove and wrote (CI fix)
Both sides added test-module lines at the end of analysis_ui.rs (main:
analysis_ruler_shift_tests from #11985 and note_clear_all_tests); kept all
three.
A horizontal split now turns the vertical thirds into anchor columns and drops the horizontal ones (3 x 2), a vertical split the mirror (2 x 3). Crosswise and splits of an already split grid are unchanged. The two tests that expected every third to stay now expect the cut in place of the dropped thirds.
* Eraser: add Erase to History (Brush, Pencil and Block modes)
Photoshop's Eraser has an Erase to History option; PhotoCraft had only the History Brush.
With it ticked, the Eraser paints the History panel's source state back instead of
erasing, through paint.historyBrush with eraseToHistory. Pencil and Block modes paint back
through their hard tips. A layer that did not exist in the source state paints that
state's visible image; the History Brush itself still refuses such a layer, as Photoshop's
does.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* Keep tool_event within clippy's complexity limit
* Test Erase to History at every depth and tip
* Update the History Brush params comment for Erase to History
* Erase to History paints a layer made since only from a single-layer state
Compared with Photoshop 27.11.0: on a layer the source state does not hold, Erase to History paints
when that state holds a single layer, Background or not, and gives an error when it holds a second
layer, even an empty one. The composite of a multi-layer state is gone; those states now refuse
the layer with the History Brush's error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Erase to History paints a single source layer's own pixels
Photoshop 27.11.0 paints a layer made since with the source layer's pixels: a 50% opacity layer
gives a solid stroke, where the composite gave a faded one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Erase to History: Pencil mode paints at full flow; test a group-only source state
Pencil mode has no Flow control, so a lower Flow set in Brush mode must not carry over. A source
state holding only a group has no pixels of its own and refuses a layer made since.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Erase to History keeps its options if a tool key is pressed mid-stroke
The stroke read the current tool and brush when it was committed, so pressing a tool's letter
during the drag dropped eraseToHistory and the stroke failed on a layer made since. The options
and the Eraser's tip are now captured at the press.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Erase to History: a single solid shape paints its colour; name the History row
Photoshop 27.11.0 paints a shape layer's solid colour along the whole stroke, past its path, and
calls the stroke History Eraser in the History panel.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Erase to History: a single shape without a solid fill paints white
Observed in Photoshop 27.11.0: a gradient, pattern or no fill paints plain white along the whole stroke, past the path and whatever the outline, in RGB, CMYK, Grayscale and Lab.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Eraser: Alt at the press reverses Erase to History for that stroke
As in Photoshop 27.11.0: with the option off Alt restores, with it on Alt erases. Alt pressed or released during the stroke changes nothing, and the option itself is left as it was.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Erase to History: name the Photoshop version compared
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Erase to History: review fixes for the error and the History Brush tip
A layer without pixels now gets the error that the target did not exist
in that history state, not "no active document". The History Brush keeps
its size, hardness and spacing from the press, as the Eraser does, if a
tool key is pressed mid-stroke.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Brush parity: add the Eraser's Erase to History
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Erase to History: document the functions this change touches
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* History Brush and Erase to History keep their whole brush from the press
Only mode, opacity, flow, size, hardness and spacing were kept from the press; the rest of the brush (tip shape, sampled tip, angle, dynamics, smoothing) came from the session brush at release. A tool key mid-stroke changed that brush, the commit rejected the live preview, and the fallback repainted the whole stroke with the new tool's brush. The stroke's params now carry the press-time brush as "brush" (stored tips as references, as each tool's remembered brush), and paint.historyBrush deep-merges it onto the session brush, so the live preview, the commit, its fallback and a replayed action all paint with it. Tests: a tool switch mid-stroke paints exactly what the same stroke paints without it, for the History Brush and Erase to History in Brush, Pencil and Block mode, across tip shape, sampled tips, dynamics and smoothing; a "brush" param paints as the session brush would; a malformed one is refused.
* History Brush docs: say "outside its shape", not "past its path"
The automation crate flags any command whose params text mentions a path as a possible filesystem path (registry_filesystem_path_params_are_classified); the eraseToHistory description meant a shape's vector outline. Also a test that a state whose one root item is a group of several layers is refused like the one-layer group: a group has no pixels to paint back.
* Test that a Shift-click Erase to History line commits its live pixels unsmoothed
Main's Shift-click fix (#11887) and this branch's press-time History
Brush params meet in finish_stroke_with; check the commit sends
smoothing 0 beside the brush param in all three Eraser modes.
---------
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
hit_active now searches only the saved path selected in the Paths panel when there is one, instead of falling through to the active shape or work path. Without a selected saved path it puts the Pen draft first, as direct_select::candidates does. The draft's destination is private to vector_ui, so it is not filtered here.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Opus 5.5 briefed; Sonnet 5.5 wrote at medium
A click or a drag with the Horizontal Type Mask tool now starts with the same selected placeholder text as the Type tool, so typing replaces it and committing it untouched selects its outline. With "Fill new type layers with placeholder text" off, masks start empty, as type does.
The Vertical Type Mask keeps starting empty: its placeholder is not measured yet.
Three findings from the review of #11490.
- A cleared ratio field with blank_when_zero now parses as zero instead of falling into the arithmetic hold, so deleting a side unsets it rather than restoring the old value.
- The Fill help's info button remembers its rect, so Esc and Enter in the frame the help opens go to the help: the shortcut pass runs before the options bar draws, and Esc used to cancel the pending crop first.
- Hiding the options bar (F twice, or Home) closes the Fill help, so its flag no longer keeps Enter and Esc away from the crop underneath.
Tests in tests/it/crop_options_bar_chrome.rs; all three fail without the fixes.
Default's 4 corners and 8 edge handles are always drawn as round points,
and a split grid's anchors as hollow circles. A split or preset grid's
handles still show only near the pointer; the presets keep square anchors.
Fixes#12497