Commit Graph
11425 Commits
Author SHA1 Message Date
Khawar Zamman Wani e827296f27 Cover Selective Color's Reset, Method, preview and bad params in the UI
Drive Reset and the Method radios through the real controls in both
hosts, check the live preview shows every colour until the dialog
closes, and check OK on malformed params reports an error and commits
nothing. Find the Properties Cyan slider by role, not a pixel offset.
2026-11-06 14:25:32 +05:30
Khawar Zamman Wani 349a03b6b1 Refusal text states the lower limit, links the download and shows readable sizes
The 32-bit message ended mid-phrase. It now says the cap applies or less if
less memory is free, and separates the cause from the next step. Windows
scratch tests check the returned numbers belong to the temp directory's volume.
2026-11-06 14:01:03 +05:30
Davit MatchakhelidzeandClaude Sonnet 5.5 dd10f81580 Drop crates/text font changes (now in #8812); add ka.tsv ATTRIBUTION row
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YMTAbGNRxnMEzRvYnQGphF
2026-11-06 11:57:49 +04:00
Davit Matchakhelidze 82b9447732 Merge remote-tracking branch 'origin/main' into ka-language 2026-11-06 11:57:18 +04:00
Khawar Zamman Wani 8f5c0cf92b Clear a smart filter's stored smooth count when its dialog folds it
The dialog's curves already hold the Smooth passes. Merged over the stored
params, the old count stayed and each render smoothed them again.
2026-11-06 12:59:21 +05:30
Khawar Zamman Wani 1eb3218a4b Merge remote-tracking branch 'origin/main' into claude/investigate-issue-e27e90 2026-11-06 12:37:29 +05:30
Khawar Zamman Wani 805d238a97 Keep an adjustment smart filter's settings when its dialog opens
The dialog opened on the kind's defaults with the recorded params laid over
them, so a default could be read over a recorded key for the same setting: in
Lab, the seeded lightness hid a recorded points or inBlack, and OK saved the
filter with its effect gone. The same happened to an RGB Curves gray, a Photo
Filter preset, and Channel Mixer and Hue/Saturation values implied by their
checkboxes. Seed from the complete set the recorded params render instead.
2026-11-06 12:02:27 +05:30
Khawar Zamman Wani 090b759deb Test that confirming an unedited adjustment smart filter keeps its settings
Fails until the dialog stops reading its seeded keys over the recorded ones.
2026-11-06 12:01:38 +05:30
Khawar Zamman Wani 390b3b388a Replace params for every adjustment smart filter dialog and Shape Blur
Color Lookup uses the schema dialog, which removes an emptied text key, so
a stale data or file was read over the chosen lut. Key the replacement on
image.adjustments.* rather than the dedicated editors. setParams' replace
now also holds for Shape Blur, which merged before resolving its shape.
2026-11-06 12:01:12 +05:30
Khawar Zamman Wani 2e13ec280b Replace an adjustment smart filter's params when its dialog edits them
layer.smartFilter.setParams merges, so a key the dialog removed stayed
stored. A Channel Mixer filter with Monochrome turned off kept its gray
row, which is read over red: the Red sliders had no effect. The dialog
holds all of an adjustment's settings, so it now passes replace: true;
other callers keep merging.
2026-11-06 11:52:38 +05:30
yoriswind 145747962a Keep Actions control playback headless and preserve ATN imports 2026-11-05 22:14:49 -08:00
RickiNanoandClaude Opus 5.5 0c93920ff1 Text fields: test that their text is centred in the box (#2084)
The number-field half of #2084 (digits low, then 0.9 pt high after #1322)
was fixed by #5226. Plain text fields (hex, search, names) had no check;
this adds one: digits and capitals sit within 0.25 pt of the box's middle
in the mono and proportional faces, Pro and Studio themes (measured 0.125).

Closes #2084

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 07:10:44 +01:00
tronicumandClaude Opus 5.5 653a177e6f Romanian: complete the catalog, credit and disclose the translation
- Translate the 118 strings added on main since the catalog was finished
  (Romanian now covers 2,345 of 2,345 keys).
- Register Bosnian and Romanian together in LANGUAGES (29 entries after the merge).
- Add ATTRIBUTION.md, LICENSE-translations.txt and docs/localization.md rows
  (plurals one / few / other), and note in the catalog header that it is
  machine-translated and not yet reviewed by a native speaker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 07:07:10 +01:00
tronicumandClaude Opus 5.5 7649a728e4 Hebrew: complete the catalog, credit and disclose the translation
- Translate the 118 strings added on main since the catalog was finished
  (Hebrew now covers 2,345 of 2,345 keys).
- Register Bosnian and Hebrew together in LANGUAGES (29 entries after the merge).
- Add ATTRIBUTION.md, LICENSE-translations.txt and docs/localization.md rows,
  and note in the catalog header that it is machine-translated and not yet
  reviewed by a native speaker.
- Restore the lost backslash in the header's escapes line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 07:07:10 +01:00
tronicumandClaude Opus 5.5 8f342c5939 Urdu: complete the catalog, credit and disclose the translation
- Translate the 118 strings added on main since the catalog was finished
  (Urdu now covers 2,345 of 2,345 keys).
- Register Bosnian and Urdu together in LANGUAGES (29 entries after the merge).
- Add ATTRIBUTION.md, LICENSE-translations.txt and docs/localization.md rows,
  and note in the catalog header that it is machine-translated and not yet
  reviewed by a native speaker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 07:01:02 +01:00
tronicum aee4d123a6 Merge remote-tracking branch 'origin/main' into upstream-ur-only 2026-11-06 07:01:02 +01:00
tronicum 1bce8adff8 Merge remote-tracking branch 'origin/main' into upstream-ro-only 2026-11-06 06:58:21 +01:00
tronicum dac129326f Merge remote-tracking branch 'origin/main' into upstream-he-only 2026-11-06 06:57:54 +01:00
Hector VillarrealandClaude Opus 5.5 f8ef7d78d0 Hue/Saturation range bar: test a zone drag across the 0/360 seam (FredApps review)
Reds' fully-on span sits on both ends of the bar. Drags from its middle at
either end move the whole range intact, one history step each, and the
handles that pass the seam come out at the other end.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:53:19 -06:00
Hector VillarrealandClaude Opus 5.5 15437c9ea0 Hue range tests: keep #9252's doc comment on its own test after the rebase
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:53:19 -06:00
Hector VillarrealandClaude Opus 5.5 d2a70d63f1 Hue/Saturation: a range drag ends where the button let go
CodeRabbit on #9272: when a release and more pointer movement land in
one frame, interact_pos() is the later position, so a zone or handle
drag committed bounds past the release. The release frame now reads the
primary release event's own position.

Test: a_zone_drag_released_in_the_frame_it_moves_still_moves (adds the
release-then-move order)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:53:19 -06:00
Hector VillarrealandClaude Opus 5.5 435d47adad Hue/Saturation: a range drag released in its move frame still lands
CodeRabbit on #9272: when the pointer moves and lets go between two
frames, the release frame isn't 'button down', so the zone drag skipped
the final position and committed the bounds from before the move. The
release frame now applies its position, for zone and handle drags alike.

Test: a_zone_drag_released_in_the_frame_it_moves_still_moves

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:53:19 -06:00
Hector VillarrealandClaude Opus 5.5 fe19df6077 Hue/Saturation range bar: handle reach counts neighbours across the seam
CodeRabbit (discussion_r4369244320): Reds' fully-on zone crosses the bar's
seam, so its two seam handles saw no neighbour on their open side and kept
the full 10-point reach, swallowing the whole ~19-point zone on a 230-point
bar. The bar is a hue circle: the gap now wraps to the first handle from
the other edge.

Test: hue_range_zones_stay_selectable_on_a_narrow_bar (a Reds case).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:53:19 -06:00
Hector VillarrealandClaude Opus 5.5 f2dcbee218 Hue/Saturation range bar: narrow zones stay selectable
CodeRabbit (discussion_r4369183389): at the narrowest Properties panel
the bar is about 230 points, a 30° zone is ~19 points, and every press
in it fell within the fixed 10-point handle reach, so no zone could be
dragged. A handle's reach toward a neighbour is now a third of the gap
(3 to 10 points), leaving the middle third of a narrow zone to the zone;
an open side keeps the full 10 points.

Test: hue_range_zones_stay_selectable_on_a_narrow_bar.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:53:19 -06:00
Hector VillarrealandClaude Opus 5.5 aec8579000 feat(ui): drag the zones of a Hue/Saturation colour range (#9252)
The range bar's handles moved one at a time. As in Photoshop 2025,
dragging between them moves them together: the fully-on span moves all
four, the left or right fade its own two. A side stops at the other and
the range never passes a turn. One history step per drag.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:53:19 -06:00
Khawar Zamman Wani 7216e393a8 Clear folded params when saving a Selective Color smart filter
`layer.smartFilter.setParams` merges into the stored params, so re-editing
a filter recorded in the single-colour form kept its old `cyan` and
`relative` keys. The engine applies those after the rows and Method, which
silently undid the edit when the filter rendered and reopened.

The edit now sends nulls for the keys the editor folded away; the engine
reads a null as missing. Other `setParams` callers keep their merge.
2026-11-06 10:20:14 +05:30
Hector VillarrealandClaude Opus 5.5 4fae869018 Masks: a recorded mask drop replays on another document (CodeRabbit review on cmd.rs:815)
The journal made `layer` portable for layer.layerMask.moveTo but kept `to` as
the document's layer id. Replayed on another document, that id names some
other layer or none: the mask silently went to an unrelated layer or the step
failed. Before the fix, recorded_mask_drop_replays_on_another_document
recorded `"to": 8` and replay moved the mask onto "Extra" instead of "Shadow".

Recording now keeps `to` as the layer's name (from the document before the
step, since a drop on the Background renames it "Layer 0"), plus
`toOccurrence` when several layers share the name. move_mask resolves a name
(requiring `toOccurrence` when it is ambiguous), and explicit calls still take
a numeric id. This matches how layer.moveTo records its drop target
(`target` + `targetOccurrence`).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:33:42 -06:00
Hector VillarrealandClaude Opus 5.5 1fd0ec7a61 Save for Web: refuse slice numbers with a whole-image path and a null slices (CodeRabbit review on crates/engine/src/cmd/web_cmds/save_web.rs:211)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:05:35 -06:00
Hector VillarrealandClaude Opus 5.5 f1427bba65 Save for Web: refuse slice numbers with a whole-image path (CodeRabbit review on crates/engine/src/cmd/web_cmds/save_web.rs:237)
`path` alone writes the whole image as one file, so slice `numbers` with
it were ignored. It is refused; `dir` exports the chosen slices. Main's
`folder` destination (#5305) is the whole image too, so `folder` alone
with `numbers` on a document with slices is refused the same way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:05:34 -06:00
Hector VillarrealandClaude Opus 5.5 8a1e58ee41 Save for Web: refuse unknown Slices choices (FredApps review)
The engine read `slices` loosely: any value but "user", including the
dialog's "selected" and a typo, exported every slice when `numbers` was
absent. `slices` is now all, user or selected (documented in the
command's parameters), anything else is refused, and Selected Slices
without `numbers` on a document with slices is refused as the dialog
already does ("No slices are selected"). A document without slices
still exports the whole image whatever the choice, as the dialog sends
it then.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:05:34 -06:00
Hector VillarrealandClaude Opus 5.5 93831e9715 Save for Web: refuse slice numbers that don't exist (FredApps review)
A `numbers` entry naming no slice was dropped, so an export of only
missing numbers succeeded with no files, an HTML page of empty cells,
and remembered settings. Photoshop's dialog can only select slices it
shows, and ours builds `numbers` from the slices it draws, so any number
that doesn't exist (or isn't a slice number at all) now refuses the
whole export, naming the missing numbers. The check runs with the
settings, before a floating move is committed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:05:34 -06:00
Hector VillarrealandClaude Opus 5.5 cd1ac9c0e1 Save for Web: keep unexported slices as empty HTML cells (CodeRabbit review on crates/ui-egui/src/dialogs/file_ui/web.rs:569)
With HTML on, the table was built from the exported slices only, so
exporting the right of two slices (Selected Slices, or All User Slices
dropping an auto slice) moved its image to the first column. Every
resolved slice now keeps its grid position; the ones not exported are
empty cells.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:05:34 -06:00
Hector VillarrealandClaude Opus 5.5 3292719ef7 Save for Web: show slices in the preview and export selected slices
The preview now outlines the document's slices with their numbers, as
Photoshop's does. A click selects the slice under the pointer and
Shift-click adds or removes one; the Slices menu gains Selected Slices,
which exports only those through the command's numbers parameter.

Fixes #10548

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:05:34 -06:00
Gotya-OFFCIAL e7241d2e26 raw: decode Hasselblad 3FR/FFF (X2D II 100C, uncompressed)
The X2D II 100C's 3FR files develop at full sensor resolution instead of
falling back to the camera's embedded JPEG preview. A 3FR is a TIFF whose
IFD0 holds the camera's JPEG and whose CFA image sits in a SubIFD with
DNG-style tags but no DNGVersion and no CFA-pattern tag (neither the
TIFF/EP pair nor the EXIF one), which is why the generic TIFF/EP path
reported "CFA pattern not recorded". The new decoder reuses the shared
strip reader, takes BlackLevel, WhiteLevel, DefaultCropOrigin/Size and
AsShotNeutral from the file, and takes the Bayer phase from a measured
per-body table (the X2D II 100C: RGGB at the data origin, measured
against the camera's own embedded JPEG; unmeasured bodies warn).
Lossless-JPEG 3FR stays preview-only, like uncompressed-only ORF and RAF
before it.

Clean-room: the TIFF 6.0 and DNG specifications, the sample file's bytes
and its embedded JPEG; no code or tables from dcraw, LibRaw, rawspeed,
rawler or darktable.

Adds round-trip and hostile tests through a mirrored synthetic builder
(tests/it/hasselblad.rs, testgen::Hasselblad3frSpec) and updates the
support matrix (file-format-parity, gaps G14, target-app-parity).
2026-11-06 12:05:10 +08:00
Hector VillarrealandClaude Opus 5.5 d46c7b4623 Layers panel: take mask drops only where the list shows the row (CodeRabbit review on crates/ui-egui/src/panels/layer_drag.rs:301)
A row scrolled out of the Layers list keeps its rect, which still lies under
the panel's header or footer: a mask thumbnail released there was moved to
that hidden row. mask_drop now tests the row's rect clipped to the list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:54:45 -06:00
Hector VillarrealandClaude Opus 5.5 23e25237ae Layers panel: test that a mask thumbnail dropped on a masked row or its own row does nothing (FredApps review)
Dropped on a row whose layer has a mask already (with or without ⌥), or back on its own row, the
drag runs no command: no refused-command error, no history step, and both masks unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:54:45 -06:00
Hector VillarrealandClaude Opus 5.5 f57bcddbb5 engine: test mask drops on the mask's own layer and undo after a copy or replace (FredApps review)
Dropping a mask on its own layer (any copy/replace combination) is refused and leaves the mask's
pixels, enabled state and density, the document and the history as they were. One undo after an
⌥-copy, an ⌥-copy that replaces, or a move that replaces puts both layers' masks back exactly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:54:45 -06:00
Hector VillarrealandClaude Opus 5.5 84696c3b03 engine: check a replaced layer mask's content in the mask move test (CodeRabbit review on crates/engine/src/cmd/ops.rs:224)
The group now has a mask of its own, unlike the source's, before the replacing move, and the
test checks the group ends up with the source's mask, so a replacement that does nothing fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:54:45 -06:00
Hector VillarrealandClaude Opus 5.5 5c8549910a Layers panel: scroll at the list's edge while dragging a layer mask (CodeRabbit review on crates/ui-egui/src/panels/layer_drag.rs:298)
The edge scroll's drag check knew layer, fx and Smart Filter drags but not mask drags, so a
mask held at the list's edge left it in place and couldn't reach a row out of view.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:54:45 -06:00
Hector VillarrealandClaude Opus 5.5 911aa4dede Drag a layer mask onto another layer or group to move it, ⌥ to copy it (#10485)
In Photoshop, dragging a layer mask's thumbnail onto another layer or group moves the mask
there, and ⌥-dragging copies it. PhotoCraft's mask thumbnails could only be dragged to the
trash, so dropping one on a group did nothing.

- engine: layer.layerMask.moveTo {layer, to, copy, replace}: one history step; a layer
  that already has a mask keeps it unless `replace`; the Background becomes a layer first.
- Layers panel: a layer mask thumbnail dropped on another row (layer or group, without a
  mask of its own) moves the mask there, ⌥ copies it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:54:45 -06:00
Saloouu 633201a72b Merge main 2026-11-06 04:45:27 +01:00
Khawar Zamman Wani 7c2127b6bc PNG import in steps: stream the rows into tiles, turn upright in bands
PngImport decoded the whole image and then copied it into a second, tile surface (about
+400 MB for a 100 MP RGBA8 file, enough to kill a browser tab). A PNG whose rows come in
final order now streams: PngDecodeRows::step_stream hands each group of rows on, they
become tiles at once (the PngStream the one-shot streamed import also uses) and are
dropped, then the prune scan runs in batches. decode_rows is the same step_stream driven
to the end, so there is one path. Interlaced, animated and early-eXIf-oriented files are
decoded whole as before; a late eXIf sends a streamed import back to a whole decode.

The turn upright of an EXIF orientation 2-8 was one whole-buffer pass in the poll of the
last rows; OrientSteps (photocraft-codecs) does it in bands of 64 rows through the same
band writer as Image::oriented, and PngImport runs it as a stage of its own.

Memory-budget errors keep their type and text: the stream is checked as the one-shot
streamed import is, and, like the whole-image path, a layer under 32 MiB is not.
Docs for the stepped place updated.
2026-11-06 09:13:41 +05:30
Khawar Zamman Wani 6ebc4c96f8 Place: move the pixels a few tiles at a time, name the real place command in the size error
A place at an offset off the tile grid rebuilt nearly every tile the image touches in
a single poll, which can overrun the ~8 ms slice on a big image. TranslateSteps
(photocraft-raster) builds the target tiles of Surface::translated a tile at a time
with the same code (a shared ShiftBuilder), so the result is bit-identical; the place
runs it as a Placing stage of its own in a cooperative session.

The flatten size refusal named "file.place", which is no command: it now names
file.placeEmbedded or file.placeLinked.
2026-11-06 09:13:41 +05:30
yoriswind 8a27985973 Reconcile #10766 with the recorded-step lint successor 2026-11-05 19:35:04 -08:00
yoriswind 95a9dc74d8 Extract recorded Actions step dialog setup 2026-11-05 19:35:04 -08:00
yoriswind 873d97c285 Reduce complexity in Actions dialog dispatch 2026-11-05 19:28:18 -08:00
Hector VillarrealandClaude Opus 5.5 c58d0366bc New Guide: no ruler unit on a leading factor of a length (CodeRabbit review on new_guide_ui.rs:91)
The dialog put the ruler unit on a leading bare number whenever an
operator followed, so "2 * 50 px" and "2 / 2 * 50 px" became
"2 cm * 50 px" and the engine refused a length times a length. Now it
checks the whole leading term (`*` and `/` operands up to the first
`+` or `-`): when one of them has a unit, the bare number is a plain
factor and is sent as typed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:23:15 -06:00
Hector VillarrealandClaude Opus 5.5 3c97ed53c4 Guides: test arithmetic in Edit Selected Guides (indy2kro review on edit_cmds.rs guide_position)
`view.editGuide` reads its position through `guide_position` too, so it
takes the same arithmetic as New Guide. Cover the command (including a
turned guide, whose % is of the new extent) and the Edit Selected
Guides dialog, where a leading bare number is in the ruler unit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:23:15 -06:00
Hector VillarrealandClaude Opus 5.5 d2b3615db7 Guides: cap a guide position's arithmetic at 1024 bytes (indy2kro review on prefs.rs eval_length)
`Unit::eval_length` refuses text over 1024 bytes before tokenising it,
the same cap as the numeric fields' evaluator, so the operand and
operator lists it builds stay bounded (AGENTS.md: cap allocations sized
by input).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:23:15 -06:00
Hector VillarrealandClaude Opus 5.5 729045c35b Guides: read the Unicode minus in a guide position (indy2kro review on prefs.rs eval_length)
`Unit::eval_length` and the New Guide dialog now take `−` (U+2212) as a
minus, as the numeric fields' own evaluator does. In the dialog it also
lets a leading bare number get the ruler unit before a `−`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 21:23:15 -06:00