Commit Graph
11425 Commits
Author SHA1 Message Date
FredApps 07580bfb34 Merge commit '898979da306fe9af29e2ec60341951f098225cb5' into review/g-11652-update 2026-11-06 17:28:13 +01:00
FredApps 086c250d7c Keep final resize pruning cooperative
Visit at most four output tiles per closing work unit and honor the caller's deadline between batches. Sparse images with distant opaque corners otherwise make one final poll scan the whole resized surface.

Add a sparse-output regression at 8, 16 and 32-bit requiring multiple closing polls, identical pixels, and removal of the same empty tiles. Formatting and whitespace checks passed; compilation and test execution await hosted CI.
2026-11-06 17:28:13 +01:00
FredApps 6c6f5ff04c fix(ui): retain Selective Color row when reopening smart filters 2026-11-06 17:27:59 +01:00
FredApps 8afc35fdf9 Merge commit '2ce36bd66' into review/u1-11613-integrated 2026-11-06 17:27:58 +01:00
FredApps 898979da30 Merge main into scratch folder capacity queries 2026-11-06 17:27:38 +01:00
FredApps 2ce36bd66c Merge main and use replacement for adjustment smart filter edits 2026-11-06 17:27:16 +01:00
David MannandClaude Opus 5.5 757e0e1eae Integration: LANGUAGES holds all 34 languages after the merges
Each language PR set the array length for main plus its own entry; with six new
languages merged together the registry has 34 entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:27:02 +01:00
David Mann 1e82972ee1 Merge pull request #9667 from davidmann4/fix/system-tools-full-path
Windows: run explorer.exe and reg.exe by full path (#9666)
2026-11-06 17:26:45 +01:00
FredApps 8ab527b1e6 Merge pull request #11474 from wanikhawar/claude/selective-colours-isolation-329d87
Keep each colour's values in the Selective Color dialog
2026-11-06 17:26:42 +01:00
FredApps c8e4376ec6 Merge pull request #11513 from wanikhawar/claude/investigate-issue-e27e90
Windows: count scratch room when opening large files; refusal names the build's limit
2026-11-06 17:26:22 +01:00
David Mann 8b70147d06 Merge pull request #9244 from davidmann4/fix/flip-angle-gradient-sweep
Image Rotation: a flip reverses an Angle gradient fill's sweep (#9243)
2026-11-06 17:26:13 +01:00
RickiNano 69d43fb71c Marquee and Lasso: a drag after moving pixels moves only the outline (#11368)
After the Move tool (or a ⌘-drag) moved the selected pixels, they stayed
floating, and a plain Marquee or Lasso drag on them moved the pixels again.
Photoshop moves only the selection outline there.

A plain selection-tool press on a floating piece is now an outline drag:
the press drops the piece where it is (Move), then the drag moves the
outline (Move Selection). ⌘ and ⌘⌥ drags still move or copy the piece,
and the cursor over the piece follows suit (move cursor plain, arrow
with ⌘).

Fixes #11368
2026-11-06 17:25:50 +01:00
David Mann 3768e84b67 Merge pull request #9480 from davidmann4/fix/remove-enable-animations
Interface: remove the Enable animations preference (#9479)
2026-11-06 17:25:38 +01:00
David Mann 89235b39ac Merge pull request #10501 from davidmann4/fix/10328-review-followup
Review follow-up to #10328: Liquify saved twirl, copied type brings its styles, restored tests (#10500)
2026-11-06 17:25:11 +01:00
David Mann 16348db38b Merge pull request #9138 from davidmann4/fix/9137-control-click-coord-range
ui.click / ui.move reject coordinates beyond the screen range (#9137)
2026-11-06 17:24:27 +01:00
David Mann fff0db9850 Merge pull request #9309 from davidmann4/fix/match-rotation-crop-turn
Match Rotation leaves a pending crop's turn out (#9308)
2026-11-06 17:23:58 +01:00
Khawar Zamman Wani 146d49f5a2 PSD write recipes: keep every exported candidate and pin the base file (#11607)
* PSD write recipes: keep every exported candidate and pin the base file

A case that failed after export dropped out of manifest.json, losing the
file a reference-editor check most needs. The CLI also reopened the corpus
path after the hash was taken.

- Keep the candidate and its hash once export succeeds.
- Run the CLI on a copy of the hashed bytes, so it never opens the corpus.
- Compare numbers by value, so 17 equals 17.0.
- tracking-split also checks runs 0 and 2 and all three run lengths.

Part of #6130.

* PSD write recipes: compare large integers exactly, reject case-only id clashes

Converting to f64 made 9007199254740993 equal 9007199254740992. Ids that
differ only by letter case name one output directory on a case-insensitive
filesystem, so they are now rejected as duplicates.

* PSD write recipes: test that the CLI receives the hashed bytes

* PSD write recipes: reject the contour library commands

Their path param can read or write any file, including the pinned base and
the corpus, and they edit no document.
2026-11-06 17:23:40 +01:00
David Mann 3fe08580ae Merge PR #8185: Add Korean support
# Conflicts:
#	crates/ui-egui/src/i18n/ko.tsv
2026-11-06 17:23:35 +01:00
David Mann 90f6d9aab6 Merge pull request #9300 from davidmann4/fix/trim-subquantum-alpha
Image: Trim (Transparent Pixels) ignores alpha that rounds to 0 at the document's depth (#9299)
2026-11-06 17:23:32 +01:00
David Mann cc5044d5b4 Merge PR #10241: i18n: add Thai UI catalog
# Conflicts:
#	crates/ui-egui/src/i18n.rs
#	crates/ui-egui/src/i18n/LICENSE-translations.txt
2026-11-06 17:23:08 +01:00
David Mann c9e48117dd Merge PR #10555: i18n: add Azerbaijani UI language
# Conflicts:
#	crates/ui-egui/src/i18n/LICENSE-translations.txt
#	docs/localization.md
2026-11-06 17:23:00 +01:00
David Mann bcf818cca4 Merge PR #10547: i18n: add Romanian (ro) UI translation
# Conflicts:
#	ATTRIBUTION.md
#	crates/ui-egui/src/i18n.rs
#	crates/ui-egui/src/i18n/LICENSE-translations.txt
#	docs/localization.md
2026-11-06 17:22:40 +01:00
David Mann 50d7ff9722 Merge PR #10361: i18n: add Urdu (ur) UI translation
# Conflicts:
#	ATTRIBUTION.md
#	crates/ui-egui/src/i18n.rs
#	crates/ui-egui/src/i18n/LICENSE-translations.txt
#	crates/ui-egui/src/text/direction/tests.rs
#	docs/localization.md
2026-11-06 17:22:15 +01:00
David Mann 10608c2966 Merge PR #10365: i18n: add Hebrew (he) UI translation 2026-11-06 17:21:26 +01:00
David Mann f0e1e2a4b8 Merge PR #10359: i18n(ui-egui): add Tamil (ta) translation 2026-11-06 17:21:25 +01:00
8cdb452ef3 transform: keep a refused transform-controls press out of the Move tool (#11252)
With the Background among the selected layers, a press on a Move-tool
transform handle showed the locked-layer alert but was still forwarded
to the Move tool as Down (and, for a click, the tap and Up), so
Auto-Select could change the layer selection. begin_transform_controls_at
now returns ControlsPress (Missed / Started / Refused); the canvas press
and click paths and the ui.pointer path drop a Refused press. Tests drive
real canvas frames (click and drag) and ui.pointer, with an unselected
layer under the handle.

Co-Authored-By: NaufalDzz <NaufalDzz@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:09:44 +01:00
David MannandClaude Opus 5.5 e3ea244040 Integration batch 20: start the i18n batch
Empty commit so the draft batch PR can be opened before any candidate
PR is reviewed and merged on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:01:57 +01:00
David Mann 39330f8f07 Merge PR #11648: i18n and Layers empty-area menu follow-ups to integration batch 18 (#11494, #11503, #11455, #11500) 2026-11-06 16:54:26 +01:00
Trevor BrownandClaude Fable 5.1 f4e665c1a2 Move gear: the pick marker covers locked hits and expires with its frame (#11381)
The position-locked branch of the Move pick now records app.move_pick too, through one helper shared with the main pick, so Expand layer group on click governs it.

The marker now carries the frame it was set in (app.frame). The Layers panel's track() accepts it only in that frame or the next (the panel and the canvas can draw in either order within a frame); an older marker, left by a pick while the panel was hidden, is discarded, so a later command change that lands on the same layer expands its groups. Chosen over clearing at the end of every frame because the panel may draw before the canvas and would then never see the marker.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-06 10:48:42 -05:00
Trevor BrownandClaude Fable 5.1 3f9bdee03a Artboard options bar: a placed board keeps the bar's preset name; OK in the picker without a change leaves boards alone (#11385)
Placing by click with no board selected now sends the tool option's preset along with the explicit rect. layer.new.artboard keeps an explicit rect for the size and stores the preset name, so the bar shows the preset instead of Custom. Drawn boards stay Custom.

The swatch shows a custom background as 8-bit RGB, but the stored Color is f32 with alpha. set_background now skips selected boards whose custom colour already has the picked RGB, so OK without a change adds no history step and keeps alpha and precision bit-exact.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-06 10:47:02 -05:00
9a48ea54a6 Find Layers tests: follow #10879 now that it is on main (#11238)
Main gained #10879: a Layers panel filter that hides the selected layer deselects it, as in the
reference application. Three #11238 tests expected "Other" to stay selected under a "link" Name
filter. They now check the combined behaviour: Find Layers selects none of the matches and keeps a
selected layer the filter still lists, and the filter deselects what it hides. Also the module
order rustfmt wants after the merge.

Co-Authored-By: NaufalDzz <NaufalDzz@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 16:41:29 +01:00
2e294450af Find Layers: set the panel filter on every run path; a blank name lists every layer (#11238)
Two review findings on #11238 (#10884):
- `engine.execute` runs `select.findLayers` through `PhotocraftApp::run`, not `menus::invoke`, so
  the Layers panel's Name filter was never set on that path. `run` now applies the reply's filter
  after every Find Layers (menu, shortcut, `engine.execute`, action steps).
- A blank or whitespace `name` replied `selected: []`, while the panel doesn't filter by a blank
  Name and lists every layer. It now lists every layer.

Co-Authored-By: NaufalDzz <NaufalDzz@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 16:25:36 +01:00
David Mann f38a7dfecb Merge remote-tracking branch 'origin/main' into pr-11238
# Conflicts:
#	crates/ui-egui/src/panels/layer_filter_ui.rs
#	docs/control-protocol.md
2026-11-06 16:25:36 +01:00
David Mann 8df0c8ba54 Merge origin/main into fix/crop-overlay-and-fill-defaults
# Conflicts:
#	crates/ui-egui/src/tools/crop_ui.rs
2026-11-06 16:25:10 +01:00
David Mann 2740c5d58f Merge main into fix-transform-several-selection-rules (main c101cbfb7e) 2026-11-06 16:24:54 +01:00
Saloouu 5393bb680e Merge main 2026-11-06 16:19:00 +01:00
Khawar Zamman Wani cd2250cb25 Scratch folder queries: address second review
A stuck close no longer holds up the files queued behind it (up to four
closer threads), and a query identifies the current file by the configured
folder. Tests don't read the room and the status across a late answer, and
the growth-check step proves its query is stalled.
2026-11-06 20:48:08 +05:30
David Mann 5a6cd8c6bf Merge pr-11249-fixup: review fixes for #11249 (Gradient Fill Make export and extra layer props) 2026-11-06 15:59:28 +01:00
9d6cdca3fc Actions: a Gradient Fill Make exports with stops, keeps extra layer props (#11249)
Two CodeRabbit findings on #11249:
- A layer.newFillLayer.gradient step with from, to and stops plays the
  stops, but the ATN export refused it. from/to are now left out beside
  stops.
- A recorded Make whose Usng also held a name, opacity, mode or clipping
  loaded as the plain command, which plays none of them and saved back
  without them. It now stays the recorded step.

Each has a test that fails without the fix.

Co-Authored-By: NaufalDzz <90562913+NaufalDzz@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 15:58:57 +01:00
Trevor BrownandClaude Fable 5.1 8b7b161058 Artboard options bar: the background control shows and recolours the selected boards (#11385)
With boards selected the swatch and dropdown show the first board's background, and a choice sets every selected board in one layer.artboard.set step (Edit Artboard / Edit Artboards) and the tool option. layer.artboard.set takes a layers array for this. Also drops the bar_size dead_code allow and adds the placed-board size test.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-06 09:58:15 -05:00
Trevor BrownandClaude Fable 5.1 079f826658 Artboard options bar: a placed board takes the bar's size (#11385)
Add New Artboard's click now uses bar::bar_size (the selected board's size, else the tool option W/H the bar shows) instead of its own fallback to the document size.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-06 09:58:15 -05:00
Trevor BrownandClaude Fable 5.1 662a804776 Move gear: Expand layer group on click also governs a Ctrl-click pick from another tool (#11381)
layer_reveal gated on the current tool, so a Ctrl-click temporary-Move pick from the Brush still opened the group. The Move-way pick in tool_input.rs now sets app.move_pick to the layer it made active; layer_reveal::track consumes it and applies the option only to that pick. Every other active-layer change keeps revealing.

Auto-Select XOR Ctrl decides whether a click picks, so the Ctrl-click tests turn Auto-Select off first.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-06 09:57:26 -05:00
David Mann 244bd2c011 Merge PR #11541: Right-click on the toolbar's "…" button opens a flyout with one row, Edit Toolbar… (#11378) 2026-11-06 15:57:07 +01:00
David Mann eb83e5cc22 Merge PR #11092: Add Group filter to Layers panel (#10883) 2026-11-06 15:57:07 +01:00
32ca273fe6 PR #11092: the Artboard filter control test expects the error to list group
Co-Authored-By: Nurana100 <Nurana100@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 15:49:53 +01:00
Trevor BrownandClaude Fable 5.1 665170d1f8 Toolbar flyout: a failed Edit Toolbar… reports its error in the status bar (#11378)
The flyout row discarded the result of edit.toolbar, so a rejected command (for example by an automation policy) just closed the flyout silently. It now sets the status bar error like other panels.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-06 09:47:35 -05:00
David Mann eaddba69bd Merge PR #11249: Actions: load and save Blend If and Gradient Fill layers (#10771) 2026-11-06 15:36:23 +01:00
Khawar Zamman Wani e01c8719a0 Scratch folder queries: address review
The whole folder change now waits 2 s at most, old files close on one
background thread, the cap counts query threads until they finish, and
writes during a query aren't counted twice. Capacity is refused if a sweep
paused spilling meanwhile, a query opens a file unless this folder has one,
and on macOS an unrelated dead mount only costs the purgeable figure.
2026-11-06 19:44:03 +05:30
0217be25b4 Batch fix-up: #10438's zoomed-out nudge test expects "Nudge"
Main's #11383 renamed an arrow-key run's History step to "Nudge", as the reference
application names it; #10438's new zoomed-out test still expected "Move".

Co-Authored-By: hectorviov <hectorviov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 15:10:15 +01:00
92de311b2b Actions: keep more Blend If and Gradient Fill forms exact (#11249)
Review fix-ups on #11249 after merging main:
- A midpoint outside 5..95 %, transparency stops out of range or out of
  order, and a Gradient Fill Set without transparency stops stay
  reference-application steps instead of playing clamped or keeping the
  layer's own transparency.
- An inverted Blend If range stays a reference-application step; the
  command rejects it at play.
- The Layer Style dialog's OK records `Lefx` = {Scl} beside Blend If on a
  layer without effects (measured). That Set is still the dialog's one
  step and saves back with the `Lefx` it was recorded with.

Co-Authored-By: NaufalDzz <90562913+NaufalDzz@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 15:07:32 +01:00