Session::note_layer_change(before) now backs the change count and is called by execute, start, finished jobs, select_layer, restore_layer_selection, layer_multi_cmds::set_selection, undo, redo, rollback and a new Session::set_active_layer; document switches (note_active_change) count too. The Pen tool's direct write of the active layer goes through set_active_layer.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The Linux runner has no GPU, so the GPU tests ran on Mesa llvmpipe over
GL, which can't render Rgba32Float: 57 GPU checks (50 GPU parity, 3
canvas, 2 adjustment preview parity, 2 effect-map recovery) returned
early and passed without comparing anything. A new step after Test
installs mesa-vulkan-drivers and runs the nextest `gpu` group on
lavapipe (Vulkan), reusing Test's build, and fails unless the parity
tests report the Vulkan backend and no test printed a skip.
No code change: photocraft's tests take whatever adapter wgpu returns,
software adapters included. Follows the CI half of lightcraft#1148.
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Add an opt-in WinTab backend for pen pressure on Windows
Windows Ink stays the default. Preferences > Tools > Pen Tablet has a Tablet
input dropdown (Windows Ink (default) / WinTab). WinTab opens a WinTab 1.4
system context on PhotoCraft's window and polls pressure and the eraser end
(tilt on devices that report orientation axes; rotation only with a pen and
driver that report twist) into the stylus feed. The row says to turn Windows
Ink off in the tablet's software utility; the choice applies at next launch.
- crates/tablet: Windows-only wintab/wintab-sys backend. Devices with
orientation axes use the orientation packet; pressure-only devices open a
packet without it and report neutral tilt. Leaving is the driver's hardware
proximity message (WT_PROXIMITY) and the packet's out-of-context status, with
a long fallback for drivers that never report either. Overlap priority
follows window focus, and the message hook requests a frame for each WinTab
message so pressure-only strokes update without cursor movement.
- apps/photocraft: install the backend when the preference is on; poll it at
the start of each frame; the installed wake repaints the UI.
- ui-egui: TabletPollFn service; the Windows-only Pen Tablet row with the
Tablet input dropdown and the note.
- engine: tools.tabletInput (windowsInk/winTab), default windowsInk.
- docs: hardware-parity WinTab gap entry, qualifying tilt to orientation axes
and rotation to twist-reporting pens.
Tested locally on a Wacom tablet with Windows Ink off: pressure, tilt and the
eraser end reach the brush (rotation where the pen reports twist); the default
path is unchanged.
* WinTab: a message that finds the state borrowed is skipped, not a panic in the hook
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* WinTab: rustfmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Scorecard: count the Tablet input setting
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
- #11249: a recorded Blend If Set that also carries real layer effects (a
Lefx with more than the scale) stays the recorded step instead of playing
and saving back without the effects.
- #11541: the toolbar "..." flyout owns Escape, so Escape with it open no
longer deselects or leaves full screen; a failed Edit Toolbar from a left
click on "..." reports its error in the status bar like the flyout row.
- #9862: the click-on-another-layer check uses the commit's targets (the
link group as it is now), so a layer linked after the box opened is not
"another layer".
Each has a test that fails without the fix.
Co-Authored-By: NaufalDzz <NaufalDzz@users.noreply.github.com>
Co-Authored-By: TrevorBrown-dev <TrevorBrown-dev@users.noreply.github.com>
Co-Authored-By: Higgs32584 <Higgs32584@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The five partial catalogs landed on main after this branch was cut and
still listed the renamed strings under their old keys. Rekey them the same
way as the full catalogs, point the two toolbar swatch tooltips at the
Photoshop labels, and drop the rows whose replacement key already existed.
The two selection colour-matching errors added since read color too.
The Norwegian catalog landed on main after this branch was cut and still
listed the 26 strings under their old British spellings and the four
labels renamed to their Photoshop names. Rekey them the same way the other
catalogs were, point the two toolbar swatch tooltips at the Photoshop
labels, and drop the two rows whose replacement key was already present.
Camera Raw's demosaic method and its three descriptions spelled colour
the British way. Keys renamed in every catalog, translations unchanged. The
Hindi catalog's two Cancelled rows, added after the branch was cut, follow
the Canceled keys.
Edit > Preferences > General…, Select > Inverse, Filter > Other without the
ellipsis, Layer > Rename Layer… with one, Proof Setup's color-blindness names
with a hyphen, the Layers panel's Quick Export as PNG, the toolbar's Default
Foreground and Background Colors (D) and Switch Foreground and Background
Colors (X), and the remaining British spellings in the English source. Keys
renamed in every catalog; rows dropped where the new key was already translated.
cargo xtask parity and cargo xtask scorecard regenerated: 661 of 661 menu items
live, Layer 162 of 162. A ui-parity row for the command and the Layers panel
row-menu item, with the revision entry and the status line (#11662).
The catalogue row after Edit Contents, in the block the reference Layers panel
flyout shows for a smart object layer (#11662), and the same item in the
Layers panel row menu, where it lands between Edit Contents and Replace
Contents. The item goes live through its catalogue id; the menu parity floor
rises 660 -> 661.
"Reset Transform" is already a translated plain string in the 26 catalogues that
carry the neighbouring smart-object rows, so no translation was added.
Layer > Smart Objects > Reset Transform (#11662): the placement goes back to
100 % of the current contents' own box, with rotation, skew, Distort and
Perspective cleared and the object left centred where it sits, in one history
step. Photoshop resets the transform and not the warp, so the smart object's
Warp (kept in source space) and its smart filter stack stay as they are.
The map is applied through the Free Transform path, so a linked layer or
vector mask and the Smart Filter mask follow the placement back and the object
re-renders losslessly from its source. transform_by_map is the projective
sibling of transform_by: the step from a Distorted placement to an axis-aligned
one is not affine. The exact reset map is pinned onto the placement afterwards,
because new * old^-1 * old only lands on it to float noise and would otherwise
keep a nearly affine perspective in the document.
A document closed and reopened with the same ID, then edited past the
pressed revision before the next frame, kept a stale Patch or
Content-Aware Move drag alive. DragDocument now also records the
session's active generation, which closing and reopening advance.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The counter lives in the engine: Session::active_layer_changes(), bumped by Session::execute whenever a command leaves a different active document or layer (selection commands, Action playback, undo, canvas picks). note_move_pick stores it with the picked id; layer_reveal::track accepts the marker only if the active layer is that id and the count is unchanged, so it survives a hidden panel for any number of frames and any later non-pick change (even back to the same id) invalidates it.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Main gained the Crop tool's "Background (default)" / "Transparent (default)"
Fill labels and the Pen tool's refused-draft messages after these catalogs were
written, and two tests require them in every catalog:
the_fill_labels_are_translated_where_the_old_label_was (az, th, ta) and
esc_ends_a_refused_draft_and_return_keeps_it (th, ta). Built from each
catalog's own terms for Background, Transparent, Default and Work Path.
Co-authored-by: Thanawatttt <89511939+Thanawatttt@users.noreply.github.com>
Co-authored-by: NewsBaba <346041388+newsbaba24x7@users.noreply.github.com>
Co-authored-by: Tamer Albayrak <56173603+Taxperia@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Present the live scratch state as current configuration rather than the cause of a file's refusal. Explain that configured scratch capacity cannot override caller/build limits or replace non-spillable memory. Keep the typed error and admission policy unchanged, and add wording regressions.
Formatting and whitespace checks passed. No local build or test execution; validation awaits hosted CI.
The Crop tool gets the reference application's contextual task bar: a small floating
bar centred 11 pt under the crop frame with a grip, the preset dropdown (the options
bar's own, so both stay in sync), Straighten, a ⋯ menu (Hide bar, Reset bar position,
Pin bar position) and, while a crop is pending, Cancel and Done. It follows the frame,
stays inside the canvas, and stays put once dragged or pinned. Window › Contextual Task
Bar (after Tools, as in the reference) shows and hides it.
The bar itself is a reusable widget (widgets/task_bar.rs): position rule, grip, ⋯ menu
and the hide/pin/place state in Panels (kept with the panel layout across restarts,
read by ui.inspect › taskBar, set by ui.set {panels}). A context supplies only its
controls and where ⋯ goes; the Crop contents are tools/crop_task_bar.rs. Generative
Expand stays out until #41.
Also: Lucide pin and rotate-ccw icons, six new strings in all 27 catalogues, parity
661/661 (FLOOR raised), control-protocol docs. Three tests about the options bar's
Ratio dropdown now hide the task bar, which shows the same dropdown.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`retouch_ui::cancel_stale` compared only the DocId, so a document closed
and reopened with the same ID (and revision) mid-drag kept the drag, and
its release could lasso or patch the reopened document. The drag now
records the document's ID, revision and snapshot at the press and stays
only while the ID matches and either the revision advanced (an ordinary
edit) or the snapshot is the same: the rule sync_views uses for the
Paths selection.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The picker result is compared with the colour it opened with (__orig, which already follows the Only Web Colors snap); equal means no command and no history step, only the tool option follows. The per-board skip for colours some boards already have stays.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
- The canvas caches the active selection's bounds even while its ants are
hidden, so the ⌥ badge's check never scans the selection every frame.
- Patch and Content-Aware Move options bars show the New/Add/Subtract/
Intersect buttons, as in Photoshop, and Reset Tool sets them back to New.
- A Patch or Content-Aware Move drag remembers its document and is dropped
when another document becomes active.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review follow-up on #11115:
- document_selection_mode's ⌥ "anything selected" check reads the bounds the selection
outline caches (PhotocraftApp::known_bounds, same key as cached_bounds) instead of
scanning the selection every frame; a changed selection is still scanned.
- a_new_patch_lasso_paints_no_ants_on_the_old_selection paints the canvas mid-lasso and
checks no ants sit on the replaced selection (⇧ keeps them), so removing the
paint_selection_outline guard now fails a test.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A new-selection Patch or Content-Aware Move lasso now hides the old
marching ants from the press on, as the Polygonal and Magnetic Lasso do;
before, the old outline stayed beside the new one until the release.
Shift, Alt and Shift+Alt keep it visible. Floating pieces, Select and
Mask's preview and other documents keep their ants.
Both tools' cursors show the Lasso's + / − / × badge for Shift / Alt /
Shift+Alt, worked out as the gesture does, and none over the selection
without modifiers, where a press drags the patch.
document_selection_mode now scans the selection only when Alt could
change the answer, since the canvas asks every frame during a drag.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs/korean-translation-validation.md records one agent session's checks
against a base from October (a "root task", a correction ZIP, other apps'
string tables); it says nothing a reader of docs/ can use. The 344 rows #8185
adds on top of main's ko.tsv stay (the merge kept main's wording for the 14
keys where both differ and dropped the 3368 rows main already has).
Co-authored-by: AKY <85772856+arksky1@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#10241: `th.0.plural(5)` calls a function-pointer field with method syntax
(E0599), so the ui-egui test target did not build; call it as `(th.0.plural)(5)`
(CodeRabbit). Add the ATTRIBUTION.md row for th.tsv and Thai to the licence
header (review ask).
#10359, from the review asks on the PR: two rows used spaces instead of a TAB
(Layer Mask Display Options..., Proportional Lining) and two had an empty
fourth column; "Scratch: {size}" translated the placeholder, so it rendered
literally; "Zoom In (hold, drag to scrub)" was split into a second "Zoom In"
key; "Print Settings..." lost its trailing ellipsis to a space. Tamil counts
take one|other, so the 28 two-form @plural rows now use plural_one_other; the
entry moves to the end of the registry. Adds the ATTRIBUTION.md, licence and
docs/localization.md rows, and tamil_tags_plurals_and_placeholders, which fails
on the old plural rule and placeholder.
Co-authored-by: Thanawatttt <89511939+Thanawatttt@users.noreply.github.com>
Co-authored-by: NewsBaba <346041388+newsbaba24x7@users.noreply.github.com>
Co-authored-by: Tanish Manku <13985398+tanish2k09@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>