Commit Graph
11425 Commits
Author SHA1 Message Date
Trevor BrownandClaude Fable 5.1 402b59bcde Move gear: every active-layer change counts, not only the ones through execute (#11381)
Session::note_layer_change(before) now backs the change count and is called by execute, start, finished jobs, select_layer, restore_layer_selection, layer_multi_cmds::set_selection, undo, redo, rollback and a new Session::set_active_layer; document switches (note_active_change) count too. The Pen tool's direct write of the active layer goes through set_active_layer.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-06 12:52:14 -05:00
2ff8f419cb ci: run the GPU tests on lavapipe on Linux and fail if they skip (#7975)
The Linux runner has no GPU, so the GPU tests ran on Mesa llvmpipe over
GL, which can't render Rgba32Float: 57 GPU checks (50 GPU parity, 3
canvas, 2 adjustment preview parity, 2 effect-map recovery) returned
early and passed without comparing anything. A new step after Test
installs mesa-vulkan-drivers and runs the nextest `gpu` group on
lavapipe (Vulkan), reusing Test's build, and fails unless the parity
tests report the Vulkan backend and no test printed a skip.

No code change: photocraft's tests take whatever adapter wgpu returns,
software adapters included. Follows the CI half of lightcraft#1148.

Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 18:44:13 +01:00
f23d173933 Add an opt-in WinTab backend for pen pressure on Windows (#11331)
* Add an opt-in WinTab backend for pen pressure on Windows

Windows Ink stays the default. Preferences > Tools > Pen Tablet has a Tablet
input dropdown (Windows Ink (default) / WinTab). WinTab opens a WinTab 1.4
system context on PhotoCraft's window and polls pressure and the eraser end
(tilt on devices that report orientation axes; rotation only with a pen and
driver that report twist) into the stylus feed. The row says to turn Windows
Ink off in the tablet's software utility; the choice applies at next launch.

- crates/tablet: Windows-only wintab/wintab-sys backend. Devices with
  orientation axes use the orientation packet; pressure-only devices open a
  packet without it and report neutral tilt. Leaving is the driver's hardware
  proximity message (WT_PROXIMITY) and the packet's out-of-context status, with
  a long fallback for drivers that never report either. Overlap priority
  follows window focus, and the message hook requests a frame for each WinTab
  message so pressure-only strokes update without cursor movement.
- apps/photocraft: install the backend when the preference is on; poll it at
  the start of each frame; the installed wake repaints the UI.
- ui-egui: TabletPollFn service; the Windows-only Pen Tablet row with the
  Tablet input dropdown and the note.
- engine: tools.tabletInput (windowsInk/winTab), default windowsInk.
- docs: hardware-parity WinTab gap entry, qualifying tilt to orientation axes
  and rotation to twist-reporting pens.

Tested locally on a Wacom tablet with Windows Ink off: pressure, tilt and the
eraser end reach the brush (rotation where the pen reports twist); the default
path is unchanged.

* WinTab: a message that finds the state borrowed is skipped, not a panic in the hook

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* WinTab: rustfmt

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Scorecard: count the Tablet input setting

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 18:39:40 +01:00
FredApps d2ce418bb3 Merge pull request #11641 from wanikhawar/claude/agitated-jones-8e1a8e
A little free memory no longer refuses every PSD; the refusal says what to do
2026-11-06 18:36:17 +01:00
812b25fa10 Batch fix-up: CodeRabbit findings on #11249, #11541 and #9862
- #11249: a recorded Blend If Set that also carries real layer effects (a
  Lefx with more than the scale) stays the recorded step instead of playing
  and saving back without the effects.
- #11541: the toolbar "..." flyout owns Escape, so Escape with it open no
  longer deselects or leaves full screen; a failed Edit Toolbar from a left
  click on "..." reports its error in the status bar like the flyout row.
- #9862: the click-on-another-layer check uses the commit's targets (the
  link group as it is now), so a layer linked after the box opened is not
  "another layer".

Each has a test that fails without the fix.

Co-Authored-By: NaufalDzz <NaufalDzz@users.noreply.github.com>
Co-Authored-By: TrevorBrown-dev <TrevorBrown-dev@users.noreply.github.com>
Co-Authored-By: Higgs32584 <Higgs32584@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 18:35:38 +01:00
yoriswind 5f480238d0 Reconcile five Classic Actions commands with current main 2026-11-06 09:29:48 -08:00
FredApps 91a2fd1d85 Merge pull request #11652 from wanikhawar/claude/stoic-yalow-d695ab
A scratch folder that stops answering no longer freezes the app
2026-11-06 18:28:41 +01:00
Nikolai Nyegaard ec7e86b371 i18n: carry the renamed keys in the ar, bs, da, fi and sv catalogs
The five partial catalogs landed on main after this branch was cut and
still listed the renamed strings under their old keys. Rekey them the same
way as the full catalogs, point the two toolbar swatch tooltips at the
Photoshop labels, and drop the rows whose replacement key already existed.
The two selection colour-matching errors added since read color too.
2026-11-06 18:25:30 +01:00
Nikolai Nyegaard 2ab6daa274 Docs: Select › Inverse in the select and mask guide
The menu catalog renamed the command to Photoshop's Inverse; the user guide
still named the old label.
2026-11-06 18:19:19 +01:00
Nikolai Nyegaard ac39e1752d i18n(nb): carry the renamed keys from the Photoshop label pass
The Norwegian catalog landed on main after this branch was cut and still
listed the 26 strings under their old British spellings and the four
labels renamed to their Photoshop names. Rekey them the same way the other
catalogs were, point the two toolbar swatch tooltips at the Photoshop
labels, and drop the two rows whose replacement key was already present.
2026-11-06 18:19:19 +01:00
Nikolai Nyegaard f7aea09940 Menus: assert Offset's submenu path in the Color to Alpha test 2026-11-06 18:19:19 +01:00
Nikolai Nyegaard 6ee1991cde Labels: American spelling in the batch stop prompt added since 2026-11-06 18:19:19 +01:00
Nikolai Nyegaard 6669a94ba4 i18n(hi): Canceled keys in the cameraRaw rows too 2026-11-06 18:19:19 +01:00
Nikolai Nyegaard 5761dd6ff2 Labels: American spelling in the demosaic help texts added since
Camera Raw's demosaic method and its three descriptions spelled colour
the British way. Keys renamed in every catalog, translations unchanged. The
Hindi catalog's two Cancelled rows, added after the branch was cut, follow
the Canceled keys.
2026-11-06 18:19:19 +01:00
Nikolai Nyegaard d4240b630d Labels: match Photoshop's menu, tooltip and spelling conventions
Edit > Preferences > General…, Select > Inverse, Filter > Other without the
ellipsis, Layer > Rename Layer… with one, Proof Setup's color-blindness names
with a hyphen, the Layers panel's Quick Export as PNG, the toolbar's Default
Foreground and Background Colors (D) and Switch Foreground and Background
Colors (X), and the remaining British spellings in the English source. Keys
renamed in every catalog; rows dropped where the new key was already translated.
2026-11-06 18:19:19 +01:00
FredApps ce97bde34b Merge pull request #11628 from wanikhawar/claude/brave-wu-261567
Network scratch folders report their own free space, or say they can't
2026-11-06 18:15:40 +01:00
Hartmut Nörenberg 4438f0075b docs: record Reset Transform parity
cargo xtask parity and cargo xtask scorecard regenerated: 661 of 661 menu items
live, Layer 162 of 162. A ui-parity row for the command and the Layers panel
row-menu item, with the revision entry and the status line (#11662).
2026-11-06 18:13:52 +01:00
Hartmut Nörenberg 9eceb85ecc feat(ui): put Reset Transform in the Smart Objects menus
The catalogue row after Edit Contents, in the block the reference Layers panel
flyout shows for a smart object layer (#11662), and the same item in the
Layers panel row menu, where it lands between Edit Contents and Replace
Contents. The item goes live through its catalogue id; the menu parity floor
rises 660 -> 661.

"Reset Transform" is already a translated plain string in the 26 catalogues that
carry the neighbouring smart-object rows, so no translation was added.
2026-11-06 18:13:51 +01:00
Hartmut Nörenberg e24efcf762 feat(engine): reset a smart object's transform
Layer > Smart Objects > Reset Transform (#11662): the placement goes back to
100 % of the current contents' own box, with rotation, skew, Distort and
Perspective cleared and the object left centred where it sits, in one history
step. Photoshop resets the transform and not the warp, so the smart object's
Warp (kept in source space) and its smart filter stack stay as they are.

The map is applied through the Free Transform path, so a linked layer or
vector mask and the Smart Filter mask follow the placement back and the object
re-renders losslessly from its source. transform_by_map is the projective
sibling of transform_by: the step from a Distorted placement to an axis-aligned
one is not affine. The exact reset map is pinned onto the placement afterwards,
because new * old^-1 * old only lands on it to float noise and would otherwise
keep a nearly affine perspective in the document.
2026-11-06 18:13:51 +01:00
Saloouu 3ed01375e5 Merge main 2026-11-06 18:13:34 +01:00
FredApps 71aa3eef9a Merge pull request #10164 from wanikhawar/fix/10031-web-place-steps
Web build: Place runs a slice per frame, so a large PNG no longer freezes the page
2026-11-06 18:12:11 +01:00
RickiNanoandClaude Opus 5.5 d66bab2ae1 fix(ui): drop a Patch drag when its document is reopened and edited (#11024)
A document closed and reopened with the same ID, then edited past the
pressed revision before the next frame, kept a stale Patch or
Content-Aware Move drag alive. DragDocument now also records the
session's active generation, which closing and reopening advance.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 18:10:49 +01:00
FredApps 1659ceb2b7 Merge pull request #11613 from wanikhawar/fix/smart-filter-dialog-seed-shadows-alias
Stop an adjustment smart filter losing settings when its dialog is confirmed
2026-11-06 18:09:40 +01:00
FredApps a81d9f9220 Merge pull request #11609 from wanikhawar/fix/smart-filter-stale-adjust-params
Stop stale settings overriding edits to adjustment smart filters
2026-11-06 18:09:27 +01:00
RickiNanoandClaude Opus 5.5 b6687511fa style: rustfmt DragDocument::is_active (#11024)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:58:31 +01:00
Trevor BrownandClaude Fable 5.1 7fc8ec621c Move gear: the pick marker lasts until the next active-layer change, not a frame (#11381)
The counter lives in the engine: Session::active_layer_changes(), bumped by Session::execute whenever a command leaves a different active document or layer (selection commands, Action playback, undo, canvas picks). note_move_pick stores it with the picked id; layer_reveal::track accepts the marker only if the active layer is that id and the count is unchanged, so it survives a hidden panel for any number of frames and any later non-pick change (even back to the same id) invalidates it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-06 11:55:37 -05:00
DingusMcRinkyDinkyandClaude Opus 5.5 7c656447b7 Gradient Map test: the preview has the stop back while the drag is held
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EZbgszHyuEuWAzxaamteuU
2026-11-06 17:53:13 +01:00
156cab0d6f Integration: translate the strings main added since the Thai, Tamil and Azerbaijani catalogs (#10241, #10359, #10555)
Main gained the Crop tool's "Background (default)" / "Transparent (default)"
Fill labels and the Pen tool's refused-draft messages after these catalogs were
written, and two tests require them in every catalog:
the_fill_labels_are_translated_where_the_old_label_was (az, th, ta) and
esc_ends_a_refused_draft_and_return_keeps_it (th, ta). Built from each
catalog's own terms for Background, Transparent, Default and Work Path.

Co-authored-by: Thanawatttt <89511939+Thanawatttt@users.noreply.github.com>
Co-authored-by: NewsBaba <346041388+newsbaba24x7@users.noreply.github.com>
Co-authored-by: Tamer Albayrak <56173603+Taxperia@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:52:08 +01:00
FredApps c49c1fd6fc Describe scratch settings without promising memory admission
Present the live scratch state as current configuration rather than the cause of a file's refusal. Explain that configured scratch capacity cannot override caller/build limits or replace non-spillable memory. Keep the typed error and admission policy unchanged, and add wording regressions.

Formatting and whitespace checks passed. No local build or test execution; validation awaits hosted CI.
2026-11-06 17:51:45 +01:00
FredApps d41e29a24f fix(ui): identify the active scratch directory in warnings 2026-11-06 17:51:33 +01:00
FredApps 1eba8f6c72 Bound scratch capacity test query waits 2026-11-06 17:51:32 +01:00
FredApps 96cb31b8d2 Merge commit '0a2365e925567d0b4144bd9acef673081965889d' into fix/11641-final 2026-11-06 17:51:32 +01:00
FredApps 0a2365e925 Keep rejected scratch growth queries due for retry 2026-11-06 17:50:54 +01:00
David Mann 7919429708 Merge remote-tracking branch 'origin/main' into feat/crop-task-bar-10890 2026-11-06 17:50:28 +01:00
David MannandClaude Opus 5.5 c7b5373ba8 Crop: Contextual Task Bar under the crop frame, as a reusable task-bar widget (#10890)
The Crop tool gets the reference application's contextual task bar: a small floating
bar centred 11 pt under the crop frame with a grip, the preset dropdown (the options
bar's own, so both stay in sync), Straighten, a ⋯ menu (Hide bar, Reset bar position,
Pin bar position) and, while a crop is pending, Cancel and Done. It follows the frame,
stays inside the canvas, and stays put once dragged or pinned. Window › Contextual Task
Bar (after Tools, as in the reference) shows and hides it.

The bar itself is a reusable widget (widgets/task_bar.rs): position rule, grip, ⋯ menu
and the hide/pin/place state in Panels (kept with the panel layout across restarts,
read by ui.inspect › taskBar, set by ui.set {panels}). A context supplies only its
controls and where ⋯ goes; the Crop contents are tools/crop_task_bar.rs. Generative
Expand stays out until #41.

Also: Lucide pin and rotate-ccw icons, six new strings in all 27 catalogues, parity
661/661 (FLOOR raised), control-protocol docs. Three tests about the options bar's
Ratio dropdown now hide the task bar, which shows the same dropdown.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:50:20 +01:00
RickiNano 6ddfe56705 Canvas: filter_event_before_tool's doc names the axis lock too 2026-11-06 17:49:51 +01:00
RickiNano 33afe59583 Canvas: document filter_event_before_tool 2026-11-06 17:49:37 +01:00
RickiNanoandClaude Opus 5.5 d5a0dc000f fix(ui): drop a Patch drag when its document is reopened with the same ID (#11024)
`retouch_ui::cancel_stale` compared only the DocId, so a document closed
and reopened with the same ID (and revision) mid-drag kept the drag, and
its release could lasso or patch the reopened document. The drag now
records the document's ID, revision and snapshot at the press and stays
only while the ID matches and either the revision advanced (an ordinary
edit) or the snapshot is the same: the rule sync_views uses for the
Paths selection.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:47:07 +01:00
Trevor BrownandClaude Fable 5.1 ee956a3d24 Artboard options bar: an unchanged OK in the picker leaves every selected board alone (#11385)
The picker result is compared with the colour it opened with (__orig, which already follows the Only Web Colors snap); equal means no command and no history step, only the tool option follows. The per-board skip for colours some boards already have stays.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-06 11:47:04 -05:00
RickiNanoandClaude Opus 5.5 7df99e5a26 fix(ui): Patch review: cache hidden selection bounds, mode buttons, drop stale drags (#11024)
- The canvas caches the active selection's bounds even while its ants are
  hidden, so the ⌥ badge's check never scans the selection every frame.
- Patch and Content-Aware Move options bars show the New/Add/Subtract/
  Intersect buttons, as in Photoshop, and Reset Tool sets them back to New.
- A Patch or Content-Aware Move drag remembers its document and is dropped
  when another document becomes active.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:45:53 +01:00
RickiNanoandClaude Opus 5.5 5da01d72de fix(ui): Patch ⌥ check reads cached selection bounds; frame test for the hidden outline (#11024)
Review follow-up on #11115:
- document_selection_mode's ⌥ "anything selected" check reads the bounds the selection
  outline caches (PhotocraftApp::known_bounds, same key as cached_bounds) instead of
  scanning the selection every frame; a changed selection is still scanned.
- a_new_patch_lasso_paints_no_ants_on_the_old_selection paints the canvas mid-lasso and
  checks no ants sit on the replaced selection (⇧ keeps them), so removing the
  paint_selection_outline guard now fails a test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:45:53 +01:00
RickiNanoandClaude Opus 5.5 58f08031fb fix(ui): Patch tool hides the selection it replaces and shows +/− badges (#11024)
A new-selection Patch or Content-Aware Move lasso now hides the old
marching ants from the press on, as the Polygonal and Magnetic Lasso do;
before, the old outline stayed beside the new one until the release.
Shift, Alt and Shift+Alt keep it visible. Floating pieces, Select and
Mask's preview and other documents keep their ants.

Both tools' cursors show the Lasso's + / − / × badge for Shift / Alt /
Shift+Alt, worked out as the gesture does, and none over the selection
without modifiers, where a press drags the patch.

document_selection_mode now scans the selection only when Alt could
change the answer, since the canvas asks every frame during a drag.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:45:53 +01:00
RickiNano 8967dbe5f3 Single-line marquee tests: the dropped piece keeps its pixels (#11368)
The two no-op drag tests now drop an unmoved floating piece at the press;
check that its pixels are still where they were, not only the selection.
2026-11-06 17:42:37 +01:00
0b775dab11 Integration: keep the Korean rows, drop the session notes (#8185)
docs/korean-translation-validation.md records one agent session's checks
against a base from October (a "root task", a correction ZIP, other apps'
string tables); it says nothing a reader of docs/ can use. The 344 rows #8185
adds on top of main's ko.tsv stay (the merge kept main's wording for the 14
keys where both differ and dropped the 3368 rows main already has).

Co-authored-by: AKY <85772856+arksky1@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:33:07 +01:00
f236f0f6a4 Integration: Thai test compiles; Tamil catalog rows, plurals and attribution (#10241, #10359)
#10241: `th.0.plural(5)` calls a function-pointer field with method syntax
(E0599), so the ui-egui test target did not build; call it as `(th.0.plural)(5)`
(CodeRabbit). Add the ATTRIBUTION.md row for th.tsv and Thai to the licence
header (review ask).

#10359, from the review asks on the PR: two rows used spaces instead of a TAB
(Layer Mask Display Options..., Proportional Lining) and two had an empty
fourth column; "Scratch: {size}" translated the placeholder, so it rendered
literally; "Zoom In (hold, drag to scrub)" was split into a second "Zoom In"
key; "Print Settings..." lost its trailing ellipsis to a space. Tamil counts
take one|other, so the 28 two-form @plural rows now use plural_one_other; the
entry moves to the end of the registry. Adds the ATTRIBUTION.md, licence and
docs/localization.md rows, and tamil_tags_plurals_and_placeholders, which fails
on the old plural rule and placeholder.

Co-authored-by: Thanawatttt <89511939+Thanawatttt@users.noreply.github.com>
Co-authored-by: NewsBaba <346041388+newsbaba24x7@users.noreply.github.com>
Co-authored-by: Tanish Manku <13985398+tanish2k09@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:32:39 +01:00
David Mann b5acb4c622 Merge origin/main into integration-batch-19 2026-11-06 17:32:14 +01:00
David Mann b837027c41 Merge pull request #7064 from davidmann4/fix/rotated-view-drag-previews
Rotated view: Type box and Move marquee previews follow the document axes (#7063)
2026-11-06 17:29:48 +01:00
FredApps 8d2ee0787f Merge scratch query updates into memory admission policy 2026-11-06 17:29:23 +01:00
FredApps aee46a2fc6 Merge remote-tracking branch 'origin/main' into fix/10164-final-prune-u2 2026-11-06 17:28:48 +01:00
David Mann af99f69602 Merge pull request #7719 from davidmann4/fix/cas-background-selection
Content-Aware Scale works on the Background with a selection (#7717)
2026-11-06 17:28:41 +01:00