A field that has been clicked into takes the wheel wherever the pointer
is: field_wheel::begin_frame takes plain and Shift wheel events out of
the frame's input before anything is laid out, so the canvas and panels
neither scroll nor pan. Alt and Ctrl/Cmd + wheel stay the view's.
Over a field that hasn't been clicked, the wheel steps it too (as in
Photopea, #4061), but only for a gesture that starts over the field. A
panel being scrolled keeps scrolling when a field passes under the
pointer.
One step a notch, as the Up/Down keys: 1, or 0.01 for small ranges,
x10 with Shift. A typed sum is worked out first. Hovering never takes
focus, and a non-finite step is dropped. The slider wheel and the
fields share widgets::count_notches.
Closes#5473
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolve the docs/brush-parity.md conflict by keeping both sides: the
upstream notes (Hue Jitter amount track, Color Replacement) and the
Brush Shift+right-click Mode picker note, in the header and the change table.
Add bounded CSH version 2 reading and a persistent engine import command,
with Shapes-panel and File Open integration. Preserve the existing library
on malformed sets and disambiguate imported names.
Focused checks: 6 engine, 4 parser, 3 UI routing, 6 preset reader tests;
explicit GPU rendering; strict affected-crate Clippy; panic_hunt; layering;
parity generation (unchanged output). Original generated fixture cross-read
with ag-psd. Photoshop-written CSH fixtures and export remain out of scope.
Full repository CI is verified separately before upstream submission.
Prepared with OpenAI Codex assistance for jonathnwxh.
Resolve docs/file-format-parity.md: keep both the smart-filter and the
Mt16/Mt32 entries in the status line and the revision history.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The merged image carries its transparency in the first extra channel
when the layer count is stored negative, or when a "Saving Merged
Transparency" global block (Mtrn, Mt16, Mt32) is present. Photoshop
saves 32-bit documents the second way: a positive layer count, Mt32,
and a fourth channel named "Transparency" (psd-tools transparentbg).
merged_has_alpha only knew the first, so opening such a file added a
"Transparency" alpha channel to the document, and the oracle compared
it as if it were opaque white (83.7 % of pixels off; now 0.9 %, all on
the shape's edge).
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* test(engine): add Color Range fuzziness 0 exact-match test (#214)
Adds an explicit test for Sampled Colors at Fuzziness 0 (point sampling
and hex colors) asserting that exact matches are fully selected and
adjacent shades are rejected. Updates scorecard TOOL-214-3 to done.
* docs: regenerate scorecard (TOOL-214-3 done)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017WeVmjnnPPKdxVTpr2Vjtw
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
- ROADMAP.md: the oracle floor is 145 of 258 (crates/io/tests/corpus.rs,
gaps.md G1), not 133 of 256; 953 open issues, not 579.
- docs/architecture.md: ~539,000 lines in ~1,310 files and ~8,040
#[test] functions, recounted 2026-10-13.
- README.md: "a layer kind filter" instead of "layer filters"; only the
Kind filter exists.
- AGENTS.md: drop an empty bullet at the end of section 7.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A directory save lists the existing objects, writes its own, publishes its manifest and removes what that manifest doesn't reference. Two writers (two stores, or two processes) saving the same bundle could interleave, and one writer's cleanup could remove an object the other's winning manifest needs. Each save now holds an OS advisory lock on save.lock for its whole transaction; a held lock is waited for (10 s by default, PcraftWriter::set_lock_wait), then the save fails without writing. A crash releases the lock; a file system without file locks saves unlocked as before. Fixes#4957.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Testers report ~50 ms input-to-pixel while painting on Linux and macOS, and asked for a
per-stage breakdown. With PHOTOCRAFT_STROKE_TRACE=1 the app prints, per stroke, p50/p95 of
the frame interval, pointer moves per frame, the live stroke's render, the canvas refresh
(composite + upload), the UI build, eframe's CPU time (UI, tessellation, submission) and the
remaining vsync/swap-chain wait, with the GPU backend; =<file.csv> also appends every frame.
The last summary is in the control channel's perf.strokeTrace.
RTX 5090, Vulkan, 120 Hz: interval 8.33, cpu 2.2 (ui 0.9, stroke 0.8, canvas 0.4), wait 6.0 ms.
Keep X/Y flags through ABR import, presets, commands and painting; retain legacy combined inputs and expose both controls with regression coverage.
Co-authored-by: GPT-6 <noreply@openai.com>
Put the numeric controls in a right-aligned left column and keep the
interactive ellipse on the right. Preserve units, limits, imported values
and existing field/drag command routing. Addresses only the Angle/Roundness
layout subsection of #3825.
Co-authored-by: GPT-6 <noreply@openai.com>
The Gradient Overlay page modelled its gradient as a From and To colour,
so a rainbow gradient on text, as in Photoshop, was impossible; richer
gradients only survived the dialog through the snapshot.
Engine: `layer.layerStyle.gradientOverlay` (and a gradient `stroke`) take
`"stops": [[position, "#rrggbb"], …]` (2..256, sorted) and
`"opacityStops": [[position, opacity %], …]` ([] = opaque), replacing
From/To. Malformed lists are refused at the command entry (set and replace),
so a bad edit changes nothing; given lists replace the gradient's, and
without them intermediate stops still survive an edit.
Dialog: the page shows a ramp with colour-stop markers edited as in the
Gradient Editor: click under the ramp to add a stop with the colour there,
drag to move, drag away to delete (two stay), double-click or the Color
swatch opens the shared Color Picker on that stop (`__openColorPicker
{stop}`, `ui.dialog.open {kind: colorPicker, field: "stops", stop: i}`),
Location and Delete for the selected stop, and the Gradients panel's presets
to start from. The page always writes `stops` and `opacityStops`; the factory
From/To defaults become two stops. Transparency stops are carried, not
edited on the page.
Tests: engine stops and refusals; the field grammar, the factory conversion,
ramp add/move/delete, presets and Delete, the picker's stop preview and
confirm, and the control channel.
Share the header layout between Scattering and Dual Brush, retaining label
scrubbing, percentage limits, fractional values and tools.setBrush routing.
Cover layout in all themes and guard disabled input and independent brush
blocks. Addresses only the Both Axes placement subsection of #3825.
Co-authored-by: GPT-6 <noreply@openai.com>
docs/content-aware-scale-performance.md records what changed, the
exactness contract (bit-identical wherever the energy stays a number;
NaN and infinities now deterministic), and interleaved before/after
timings on a 4-core VM: the carve of P28's 24 MP photo 2013 -> 556 ms,
the P28 row 3281 -> 1639 ms against its 3 s budget, smaller images
1.65-2.3x faster, peak memory unchanged or lower.
gaps.md G2 and target-app-parity.md get the dated measurement;
budgets.toml's P28 comment says the target is met. Its enforce flag and
the committed baseline stay as they are until the reference machine
reruns cargo xtask perf --update-baseline.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LELc5BQzgV5dA7dxdMejkK
Keep the saved spacing while Off or toggling, and retain percentage limits
and tools.setBrush routing. Cover the shared header in all themes and add
disabled-input, value-retention and journal regressions. Addresses only the
Spacing header subsection of #3825.
Co-authored-by: GPT-6 <noreply@openai.com>
Smart filters PhotoCraft applied with Pinch, Polar Coordinates, Ripple,
Spherize, Twirl, Wave, ZigZag or Invert were dropped when saving a PSD ("this
filter has no PSD equivalent"), and the same filters in a Photoshop file opened
as kept-verbatim entries that didn't render. They are now mapped both ways in
`smart_map.rs`, with the keys, enum codes and key order Photoshop 27 writes
(checked against a Photoshop-saved file holding one smart object per filter):
- Pinch `Pnch` Amnt; Twirl `Twrl` Angl; Ripple `Rple` Amnt + RplS (Sml/Mdm/Lrg);
Spherize `Sphr` Amnt + SphM (Nrml/HrzO/VrtO); Polar Coordinates `Plr ` Cnvr
(RctP/PlrR); ZigZag `ZgZg` Amnt, NmbR, ZZTy (PndR/OtFr/ArnC);
- Wave `Wave` Wvtp, NmbG, WLMn/WLMx, AmMn/AmMx, SclH/SclV, UndA, RndS.
PhotoCraft's Wave has no Scale, so a Photoshop wave scaled off 100% stays
verbatim rather than lose it;
- Invert `Invr`: no `Fltr`, `hasoptions` true, like Photoshop.
Shear stays unmapped for now: Photoshop stores its curve on its own grid.
Tests: the Photoshop `Fltr` bytes read back as the PhotoCraft settings and are
rewritten with the same keys, values and order; a scaled Wave round-trips
unchanged; Invert's item; the new filters join modelled_filters_round_trip.
The verbatim-filter tests now use Crystallize and Shear.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Conflicts resolved:
- layer.new.layer: main's `position: above|below` (its Cmd/Ctrl-click New Layer) replaces this
branch's `below` flag, and `layer_place` still places the layer, so a layer added below
joins the open group or clip group it lands in. `layer.new.group` takes the same `position`
param, and the Layers panel's Cmd-click on New Group sends it.
- Paste keeps main's linked smart-object blocks and this branch's placement; Auto-Blend's new
Depth and Blended layers go through `layer_place` like its other new layers.
- dialogs.rs and menus.rs keep main's Channel Options / New Spot Channel dialogs next to the
New Group dialog; ui-parity.md keeps main's change list and rows next to this branch's.
- hu, tr and sr (complete catalogs on main) get "New Group…" and "New Group from Layers…".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NyBcWJNZ3eRotC5HNZuwge
Pass the active tool to the section renderer and disable the complete
Wetness/Mix Transfer blocks when they do not apply, preserving saved settings.
Cover all themes/tools, disabled input, active edits and real tool-cache swaps
with three regressions, including exact tools.setBrush journal routing.
Addresses the Wetness/Mix tool-applicability subsection of #3825.
Co-authored-by: GPT-6 <noreply@openai.com>
Amiga IFF/ILBM (EA 85) artwork opens read-only: the FORM chunks BMHD,
CMAP and BODY, both the interleaved ILBM and planar PBM variants, 1-8
bitplanes through the palette (a grey ramp when there is none), masking
0/1/2, and both stored (0) and ByteRun1/PackBits (1) compression. Chunk
lengths and Run lengths are checked, so a malformed file errors rather
than panicking; other bit-plane counts return Unsupported. No writer, so
.iff/.lbm/.ilbm join the open filters and the format opens in Photoshop
parity's Amiga IFF row.
Detect and exclude the subject from blur sampling while preserving selection, alpha, masks, and other layers in one undoable edit. Add the fifth preset and verify pixel behavior, failure handling, UI playback, and full-size performance.
Generated with Codex.