mirror of
https://github.com/storytold/photocraft.git
synced 2026-11-21 01:18:43 +00:00
Merge pull request #9184 from dotCooCoo/fix/stale-parity-rows
docs: mark tool flyout press-and-hold, Direct Selection nudge and two brush rows as built
This commit is contained in:
4 files changed
+21
-13
No files matched your search
@@ -37,7 +37,7 @@ tablets against Photoshop side by side.
|
||||
| Smoothing: amount, Pulled String, Stroke Catch-up, Catch-up on End, Adjust for Zoom | done | `brush.rs:428-438` |
|
||||
| Section locks | done | #174; `brush_panel_tests.rs` verifies section-specific accessible names and locked state for all 12 controls in 14 themes, plus visible themed focus, Tab blur, Space activation, minimal command patches and replay without selecting or enabling a section. |
|
||||
| Noise, Wet Edges, Build-up, Smoothing and Protect Texture: checkbox-only rows keep the selected controls open | done | `brush_panel_tests.rs`, #4283; Smoothing enable/disable preserves its amount and options, including imported ABR tool settings |
|
||||
| Brush tip from an image file | missing | TOOL-213-12 |
|
||||
| Brush tip from an image file | done | TOOL-213-12: `brush.presets.importImage` (`engine/src/cmd/preset_import_cmds.rs`, `imports_an_image_as_a_brush_tip`); Import Brushes… takes an image (`preset_files_ui.rs`, #3279) |
|
||||
| Erodible, Airbrush and Bristle tips (Photoshop's special tips) | partial | not audited in detail; "3D-based brushes don't work" (#1660) |
|
||||
| Anti-aliasing off for brushes | missing | #1666 (Pencil is the aliased path) |
|
||||
|
||||
@@ -47,7 +47,7 @@ tablets against Photoshop side by side.
|
||||
|---|---|---|
|
||||
| Pressure drives size/opacity/flow per sample (no shared pressure within a frame) | done | #2112 |
|
||||
| Global pressure curve in Preferences | done | #2195 |
|
||||
| Per-control pressure curves | missing | TOOL-213-11 |
|
||||
| Per-control pressure curves | done | TOOL-213-11: each dynamic's own curve (`paint/src/brush.rs` `Dynamic::curve`, `paint/src/dynamics.rs` `dynamic_value`), behind each Control row's curve button (`brush_sections.rs`, `brush_panel/tests.rs` `a_dynamic_gets_its_own_response_curve`, #3294) |
|
||||
| Quick taps keep their pressure | partial | #1967 fixed one case; a tap paints at its own pressure (#1798, #2757); tap sensitivity still open (#1933) |
|
||||
| Smooth pressure on Windows | partial | "jumpy" (#2046) |
|
||||
| Tilt and rotation drive angle/roundness | partial | macOS, X11, web; not Windows; rotation not applied (#1301) |
|
||||
|
||||
+13
-6
@@ -261,6 +261,9 @@ what an agent can't finish alone.
|
||||
- **Estimate:** 250–400 h (many overlap with other gaps; count each fix once).
|
||||
|
||||
### G4. Brush feel
|
||||
- **Progress (2026-10-24, stale entries corrected):** an image file can be imported as a brush
|
||||
tip (TOOL-213-12, #3279), and each brush dynamic has its own pressure curve (TOOL-213-11,
|
||||
#3294). The other brush-feel gaps remain open.
|
||||
- **Progress (2026-10-25):** Shift-selected colour sets now constrain raster drawing,
|
||||
erasers, tone adjustments and supported filters at native depths. Live previews,
|
||||
transparency and unselected encoded components are protected. Move/transform on
|
||||
@@ -312,16 +315,19 @@ what an agent can't finish alone.
|
||||
interpolation and smoothing problems (#2138), edge falloff (#2149), pixelated cursor vs
|
||||
Photoshop (#1433), brush rotation not driven by pen rotation (#1301); no live preview for the
|
||||
Mixer Brush yet (TOOL-213-7, in PR #3627; the other brush tools draw live, Spot Healing and Remove
|
||||
compute on release as in Photoshop); no image file as a brush tip (TOOL-213-12); per-control pressure
|
||||
curves (TOOL-213-11); 4 of Photoshop's symmetry modes.
|
||||
compute on release as in Photoshop); 4 of Photoshop's symmetry modes.
|
||||
- **Detail:** [`brush-parity.md`](brush-parity.md).
|
||||
- **Estimate:** 100–180 h. **Human:** checking feel on real tablets.
|
||||
|
||||
### G5. Transform, handles and modifiers
|
||||
- **Missing:** the full interpolation list; blend mode/opacity edits during
|
||||
a transform (#1384); path-point nudge; autoscroll at the edge while selecting (#2231);
|
||||
wheel and pinch behaviour (#2485, #2463, #1989);
|
||||
toolbar press-and-hold flyouts (#2301).
|
||||
- **Progress (2026-10-24, stale entries corrected):** a toolbar button held or dragged off opens
|
||||
its tool flyout (#2324; issue #2301 is still open), and Direct Selection's arrow keys nudge
|
||||
the selected anchor points (#4486; a selected segment is not nudged yet). The other transform
|
||||
and modifier gaps remain open.
|
||||
- **Missing:** Direct Selection arrow nudge of a selected path segment; the full
|
||||
interpolation list; blend mode/opacity edits during a transform (#1384);
|
||||
autoscroll at the edge while selecting (#2231);
|
||||
wheel and pinch behaviour (#2485, #2463, #1989).
|
||||
- **Done since the re-measure (2026-10-10 to 12):** right-click menu during Free Transform
|
||||
(TOOL-214-5); commit/cancel buttons in the options bar (#2442); transform keeps the layer's
|
||||
place in the stack (#2439, #2480); Hand tool no longer interrupts a transform (#2302, #2327);
|
||||
@@ -527,6 +533,7 @@ what an agent can't finish alone.
|
||||
| 2026-10-26 | minor | G15: classical Select › Sky can seed substantial high-confidence components beneath an obstructed top band; learned segmentation remains open; percentages and estimates unchanged |
|
||||
| 2026-10-25 | minor | G9: the count of preferences that do nothing is the scorecard's again, 12 of 178 (it still said 24 of 171, from 2026-10-15); no estimate changed |
|
||||
| 2026-10-25 | minor | G6: Art History Brush landed as partial (TOOL-213-20, #1610), so no toolbar tool is missing; no percentage or estimate changed |
|
||||
| 2026-10-24 | minor | Stale entries corrected against main: G4 image brush tips (TOOL-213-12, #3279) and per-control pressure curves (TOOL-213-11, #3294) are done; G5 tool flyouts on press-and-hold or click-drag (#2324) are done, and Direct Selection nudge of anchors (#4486) is done while segment nudge stays listed; estimates unchanged |
|
||||
| 2026-10-23 | minor | G4: hard-round built-in presets use 5% spacing (#8842), guarded by large-stroke outline and pressure-opacity pixel regressions at 8/16/32-bit; percentages and estimates unchanged |
|
||||
| 2026-10-23 | minor | G10: PSD stores and reads spot channels as Photoshop does (ink 0 = solid) with their identifiers (1053); PSDs from PhotoCraft 0.1.0–0.16.0 keep their ink (#7415 split, part 4); FILE-215-17 stays partial; estimate unchanged |
|
||||
| 2026-10-23 | minor | G10: TIFF alpha and spot channels written and read as extra samples with Photoshop's channel resources, PSD output unchanged (#7415); FILE-215-7 leaves the list, FILE-215-17 narrows to RGB/CMYK spot preview and PDF Separation |
|
||||
|
||||
@@ -156,7 +156,7 @@ workflows, PSD exchange edge cases, and everything excluded above.
|
||||
|
||||
Discounts: launch and stability ×0.90 (start failures without a usable GPU, #2519, #2412,
|
||||
#1859; Type tool freeze, #2518); discoverability and UI clarity ×0.92 (language option not
|
||||
found, #2532; flyouts only on right-click, #2301; toolbar hover issue, #2603); opening files
|
||||
found, #2532; toolbar hover issue, #2603); opening files
|
||||
people send ×0.95 (JPEG, PNG, HEIC, WebP, PSD open; AVIF and PDF don't, #463, #2541).
|
||||
**78% × 0.90 × 0.92 × 0.95 ≈ 61%** (range 55–67), estimated.
|
||||
|
||||
@@ -179,7 +179,7 @@ parity for the area and are already contained in the dimension rows above.
|
||||
| Transform, warp, puppet, perspective, liquify | 55% | 100–180 | Free Transform modifiers right, with a right-click transform menu (TOOL-214-5) and H/V skew fields; Puppet Warp mesh follows the object outline (TOOL-214-6); Liquify called "useless" by a user (#2606) |
|
||||
| Adjustments and filters | 70% | 120–200 | All present; smart-filter re-render matches Photoshop on 5 of 30 files; Filter Gallery looks approximate; no Neural Filters |
|
||||
| Type | 40% | 120–200 | Engine works; manual/optical kerning, a live Warp Text preview and variable-font axis sliders (2026-10-11); type on a path only places glyphs rigidly (TYPE-218-1 partial); no RTL paragraphs, OpenType panel UI; Type tool freeze on macOS (#2518) |
|
||||
| Vector shapes and paths | 55% | 80–140 | Pen, Direct/Path Selection, shapes, shape strokes. Freeform and Curvature Pen (#1054). Add/Delete Anchor Point and Convert Point tools exist (`Tool` enum); on-canvas corner radius widgets on live rectangles (TOOL-214-12, 2026-10-13); shape Density and Feather, the path as the fill's soft vector mask, matching Photoshop's 10 px feather ramp within 1 level (#5846, 2026-10-15); missing path-point nudge; shape parity tracking issue #2496 |
|
||||
| Vector shapes and paths | 55% | 80–140 | Pen, Direct/Path Selection, shapes, shape strokes. Freeform and Curvature Pen (#1054). Add/Delete Anchor Point and Convert Point tools exist (`Tool` enum); on-canvas corner radius widgets on live rectangles (TOOL-214-12, 2026-10-13); shape Density and Feather, the path as the fill's soft vector mask, matching Photoshop's 10 px feather ramp within 1 level (#5846, 2026-10-15); Direct Selection arrows nudge the selected anchors (#4486) but not a selected segment; shape parity tracking issue #2496 |
|
||||
| Colour management and modes | 70% | 60–100 | Own ICC engine, soft proof, CMYK/Lab/Indexed/Duotone/Multichannel; no Adobe CMYK profiles, spot plates in PSD and TIFF only (FILE-215-17: no PDF Separation), monitor profile only at launch |
|
||||
| Camera Raw and computational photo (Photomerge, HDR, lens) | 45% | 120–200 | Raw for DNG/CR2/NEF/ARW/RW2/ORF/RAF(uncompressed)/PEF; no CR3; ACR dialog partial (no masking; no per-camera colour for non-DNG cameras); generic lens profiles only |
|
||||
| Automation, actions, batch, scripting | 45% | 120–200 | CLI/MCP/control channel ahead of Photoshop; recording uses implicit active layers, unique layer names, whole-text Type steps, bundled Move-tool nudges, relative keyboard document switches and canvas-relative point text (AUTO-219-1, #4514; duplicate names and paragraph boxes remain open); Actions panel remains partial (AUTO-219-2); `.atn` load/save since 2026-10-12 (112 events mapped, the rest kept verbatim); compound layer properties export as separate Set events with rename last (#8304, 2026-10-21; independent Photoshop replay pending); no ExtendScript/UXP |
|
||||
@@ -617,6 +617,7 @@ See [method, raw measurements and reproduction](five-algorithm-performance.md).
|
||||
| 2026-10-23 | minor | Select and Mask is Photoshop's workspace with its own tools (#7069, #8148); TOOL-214-1 stays partial (Refine Hair, Object Aware, Presets); percentages and estimates unchanged |
|
||||
| 2026-10-26 | minor | Selections: classical Select › Sky can seed substantial high-confidence components beneath an obstructed top band; learned segmentation remains open; percentages and estimates unchanged |
|
||||
| 2026-10-25 | minor | UI / UX and Workspace rows: 12 of 178 preferences do nothing, the scorecard's count. Camera Raw row: the Calibration panel landed on 2026-10-13 (#5128); what is missing is per-camera colour for non-DNG cameras ([gaps.md](gaps.md) G14). Percentages and estimates unchanged |
|
||||
| 2026-10-24 | minor | Discoverability discount: removed the stale "flyouts only on right-click" reason, since a press held or dragged off a toolbar button opens its flyout (#2324); Vector shapes and paths: Direct Selection arrows nudge the selected anchors (#4486), not yet a selected segment; the ×0.92 discount and the percentages are unchanged |
|
||||
| 2026-10-23 | minor | Colour management and modes: PSD spot plates are stored as Photoshop stores them (ink 0 = solid), and PSDs from earlier PhotoCraft versions keep their ink (#7415 split, part 4); estimates unchanged |
|
||||
| 2026-10-23 | minor | Colour management and modes: spot plates now save and open in TIFF (#7415); estimates unchanged |
|
||||
| 2026-10-23 | minor | Average runs on Smart Objects and imported `Avrg` records; synthetic depth tests and an opt-in cold Photoshop PSD re-render are documented in [average-filter.md](average-filter.md). Corpus floors and percentages unchanged. |
|
||||
|
||||
+3
-3
@@ -54,7 +54,7 @@ Triangle and Curvature Pen (minus legacy Rounded Rectangle and Targeted Adjustme
|
||||
| Letter shortcuts, ⇧+letter cycles the group, "Use Shift Key for Tool Switch" (on by default, as in Photoshop) | done | `shortcuts.rs` `select_tool_by_key` |
|
||||
| Alt/Option-click a toolbar button cycles its flyout slot (including tools with no letter key) | done | `toolbar.rs` `next_slot_tool`; `type_flyout_tests.rs` `alt_click_cycles_the_tool_flyout_slot` |
|
||||
| Group remembers the last tool used: its toolbar slot shows it and its key brings it back, also after quitting and relaunching; temporary tool switches excluded | done | `state.rs` `group_tools`, `tool_memory.rs`; `shortcuts::tests::tool_key_brings_back_the_groups_last_used_tool`, `prefs_ui::tests::group_tools_survive_a_restart`, `group_tools_exclude_temporary_switches`, `type_flyout_tests::slots_come_back_on_their_last_tool_after_a_restart` |
|
||||
| Press-and-hold or click-drag opens the flyout | done | `toolbar.rs`; right-click, long-press, press-drag |
|
||||
| Press-and-hold or click-drag opens the flyout | done | `panels/toolbar.rs`: a press held 0.35 s or dragged off the button opens it, and releasing over a row picks that tool (`tool_flyout_drag_open`; tests `flyout_drag_only_opens_after_a_primary_press_leaves_its_button` and `flyout_press_drag_release_selects_the_row_without_long_press` in `panels.rs`, `long_press_type_button_selects_type_then_vertical_from_the_flyout` in `panels/type_flyout_tests.rs`; #2324, #2301) |
|
||||
| Edit Toolbar customization | done | `edit.toolbar` |
|
||||
| Last selected tool restored after quitting and relaunching; temporary tool switches excluded | done | `tool_memory.rs`; `prefs_ui::tests::selected_tool_survives_a_restart_without_option_changes`, `selected_tool_excludes_temporary_switches` |
|
||||
| Foreground/background colours restored across launches, including separate mask colours, HDR/alpha and exact CMYK picks | done | `tool_memory.rs`; `prefs/prefs_ui/tests.rs`: `tool_colors_survive_restart_before_the_first_frame`, `tool_colors_keep_pixel_and_mask_pairs_when_exiting_on_a_mask`, `tool_colors_restore_cmyk_inks_for_picker_and_fill_after_swapping_and_exiting_on_a_mask`, `tool_colors_preserve_finite_hdr_components` |
|
||||
@@ -97,7 +97,7 @@ Triangle and Curvature Pen (minus legacy Rounded Rectangle and Targeted Adjustme
|
||||
| Arrow 1 px, ⇧-arrow 10 px for layers | done | `move_mods.rs` |
|
||||
| Arrow nudge of a selection outline (selection tools) | done | #1502 |
|
||||
| Arrow nudge of the crop box, X swaps orientation | done | TOOL-214-19 |
|
||||
| Arrow nudge of path points with Direct Selection | missing | no arrow handling in `direct_select.rs` |
|
||||
| Arrow nudge of path points with Direct Selection | partial | `direct_select.rs` `arrow_keys`: the selected anchors move 1 px, ⇧ 10 px, one History step per press (`direct_select/tests.rs` `arrow_keys_nudge_the_selected_anchors`, #4486); a selected segment is not nudged, which Photoshop's arrow keys also move |
|
||||
| ⌘-arrow nudges the layer from any tool | done | #2474, #2556 |
|
||||
| ⌥-drag duplicates, ⇧ constrains to 45° | done | `move_mods.rs` |
|
||||
| Dragging selected pixels shrinks the selection to them (the selection limited to where the layer has pixels, so moving again leaves no edge behind) as the drag starts, also with ⌥; the move box, snapping and Show Transform Controls use the moved pixels' bounds | done | #7538, `canvas.rs` `floating_outline` and `transform_controls_rect`, `snap_ui.rs` `follow_cut`, engine `float_cmds.rs` `CutParts::outline` |
|
||||
@@ -169,7 +169,7 @@ Triangle and Curvature Pen (minus legacy Rounded Rectangle and Targeted Adjustme
|
||||
| Snap to guides, grid, layers, document bounds and centre, selection, slices; Ctrl disables other gestures, while Distort corners snap to guides and intersections | done | `engine/src/snap.rs`, `snap_ui.rs` (actual-corner grab-offset regressions, #3632) |
|
||||
| Snap vector tools and transforms to the pixel grid | done | `snap_ui.rs:196` |
|
||||
| Smart guides (magenta alignment lines) | done | |
|
||||
| Smart guide distance and spacing labels | missing | |
|
||||
| Smart guide distance and spacing labels | partial | distances: with the Move tool, holding ⌘ over another layer or the canvas labels the distances in the ruler unit, and an ⌥-drag shows the distance to the copy (`move_distance.rs`, #4946); no distances during an ordinary Move drag, and no spacing labels |
|
||||
| Ruler units px/in/cm/mm/pt/pica/% | done | |
|
||||
| ⇧-drag a guide out of a ruler, or move one already placed: it lands on the nearest ruler tick, in a pixel ruler on whole pixels at least | done | `rulers.rs` `snap_to_tick`, `snap_tick`, `GuideDrag::follow_pointer` (#3770) |
|
||||
| A dragged guide shows its position beside the pointer (X for vertical, Y for horizontal, in the ruler unit) | done | `rulers.rs` `guide_drag_readout` (#7680) |
|
||||
|
||||
Reference in new issue
Block a user