mirror of
https://github.com/storytold/craft-libs.git
synced 2026-11-16 23:42:27 +00:00
timeline: say that the report limit counts every distinct entry
The limit mirrors FilmCraft's MAX_REPORT_ENTRIES, which bounds the report's size and counts informational entries too. Document that rather than imply a warning-only budget.
This commit is contained in:
1 parent
a553c9f734
commit
9c6fa9ce33
1 file changed
+4
-1
@@ -35,7 +35,10 @@ impl Report {
|
||||
self.entries.push(ReportEntry { level, message, count: 1 });
|
||||
}
|
||||
}
|
||||
/// Add a warning while bounding distinct diagnostics. Existing messages continue to be counted.
|
||||
/// Add a warning while bounding distinct diagnostics. `limit` counts every distinct entry already
|
||||
/// in the report, informational ones included, exactly like FilmCraft's `MAX_REPORT_ENTRIES`
|
||||
/// budget this replaces; past it a new message is counted under "further diagnostics omitted".
|
||||
/// Existing messages continue to be counted.
|
||||
pub fn warn_limited(&mut self, limit: Option<usize>, message: impl Into<String>) {
|
||||
let mut message = message.into();
|
||||
if let Some(limit) = limit
|
||||
|
||||
Reference in new issue
Block a user