From 9c6fa9ce33ff1e93e15a9413163331b6cb2e979e Mon Sep 17 00:00:00 2001 From: FredApps <153173854+FredApps@users.noreply.github.com> Date: Mon, 16 Nov 2026 00:06:43 +0100 Subject: [PATCH] timeline: say that the report limit counts every distinct entry The limit mirrors FilmCraft's MAX_REPORT_ENTRIES, which bounds the report's size and counts informational entries too. Document that rather than imply a warning-only budget. --- crates/timeline/src/report.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/crates/timeline/src/report.rs b/crates/timeline/src/report.rs index e47c8a694..4c144a2d8 100644 --- a/crates/timeline/src/report.rs +++ b/crates/timeline/src/report.rs @@ -35,7 +35,10 @@ impl Report { self.entries.push(ReportEntry { level, message, count: 1 }); } } - /// Add a warning while bounding distinct diagnostics. Existing messages continue to be counted. + /// Add a warning while bounding distinct diagnostics. `limit` counts every distinct entry already + /// in the report, informational ones included, exactly like FilmCraft's `MAX_REPORT_ENTRIES` + /// budget this replaces; past it a new message is counted under "further diagnostics omitted". + /// Existing messages continue to be counted. pub fn warn_limited(&mut self, limit: Option, message: impl Into) { let mut message = message.into(); if let Some(limit) = limit