mirror of
https://github.com/storytold/craft-libs.git
synced 2026-11-18 08:15:29 +00:00
video: the real-file VMD oracle checks that ffmpeg succeeded
real_files_match_ffmpeg waited for ffmpeg without looking at its exit status, so pictures that matched before ffmpeg failed still passed. It now asserts success, as the generated-file oracle does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 file changed
+3
-1
@@ -530,7 +530,9 @@ fn real_files_match_ffmpeg() {
|
||||
pictures += 1;
|
||||
}
|
||||
assert_eq!(theirs_out.read(&mut theirs).unwrap(), 0, "{name}: ffmpeg has more pictures");
|
||||
child.wait().unwrap();
|
||||
// pictures that match but an ffmpeg that failed are no comparison
|
||||
let status = child.wait().unwrap();
|
||||
assert!(status.success(), "{name}: ffmpeg exited with {status}");
|
||||
}
|
||||
println!("{} files, {pictures} pictures match ffmpeg", paths.len());
|
||||
}
|
||||
Reference in new issue
Block a user