From 873fc3ecd5851577b5474ed336e5b74f3ab3fd32 Mon Sep 17 00:00:00 2001 From: alehel Date: Tue, 17 Nov 2026 06:08:45 +0100 Subject: [PATCH] video: the real-file VMD oracle checks that ffmpeg succeeded real_files_match_ffmpeg waited for ffmpeg without looking at its exit status, so pictures that matched before ffmpeg failed still passed. It now asserts success, as the generated-file oracle does. Co-Authored-By: Claude Opus 5.5 --- crates/video/tests/vmd/main.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/video/tests/vmd/main.rs b/crates/video/tests/vmd/main.rs index aed9cef35..3871849aa 100644 --- a/crates/video/tests/vmd/main.rs +++ b/crates/video/tests/vmd/main.rs @@ -530,7 +530,9 @@ fn real_files_match_ffmpeg() { pictures += 1; } assert_eq!(theirs_out.read(&mut theirs).unwrap(), 0, "{name}: ffmpeg has more pictures"); - child.wait().unwrap(); + // pictures that match but an ffmpeg that failed are no comparison + let status = child.wait().unwrap(); + assert!(status.success(), "{name}: ffmpeg exited with {status}"); } println!("{} files, {pictures} pictures match ffmpeg", paths.len()); }