Fix build errors around href accessibility

This commit is contained in:
Brandon Thomas committed 2022-07-10 23:12:39 -04:00
1 parent 559a133769
commit bfc28fb3e5
3 files changed
+25 -5

No files matched your search

@@ -8,6 +8,12 @@ class FrontendUrlConfig {
return '/';
}
// Login and signup flow
static signupPage() : string {
return '/signup';
}
// Standalone pages
static aboutUsPage() : string {
+10 -3
View File
@@ -260,9 +260,10 @@ function NewTopNavFc(props: Props) {
</li>
<li className="nav-item dropdown">
{/* TODO(echelon): Fix the build warnings about href not being accessible. */}
<a
className="nav-link dropdown-toggle"
href="#"
href="javascript:void(0);"
id="offcanvasNavbarLgDropdown"
role="button"
data-bs-toggle="dropdown"
@@ -291,9 +292,10 @@ function NewTopNavFc(props: Props) {
</li>
<li className="nav-item dropdown">
{/* TODO(echelon): Fix the build warnings about href not being accessible. */}
<a
className="nav-link dropdown-toggle"
href="#"
href="javascript:void(0);"
id="offcanvasNavbarLgDropdown"
role="button"
data-bs-toggle="dropdown"
@@ -354,7 +356,12 @@ function NewTopNavFc(props: Props) {
</li>
<li className="nav-item d-lg-none">
<a className="nav-link" aria-current="page" href="#">
{/* TODO(echelon): Fix the build warnings about href not being accessible. */}
<a
className="nav-link"
aria-current="page"
href="javascript:void(0);"
>
Developers
</a>
</li>
@@ -1,6 +1,7 @@
import React, { useState } from "react";
import { FrontendUrlConfig } from "../../../common/FrontendUrlConfig";
import { SessionWrapper } from "@storyteller/components/src/session/SessionWrapper";
import { useHistory } from "react-router-dom";
import { Link, useHistory } from "react-router-dom";
import {
CreateSession,
CreateSessionIsError,
@@ -177,7 +178,13 @@ function LoginPage(props: Props) {
</button>
<p>
Don’t have an account?
<a className="text-link">Create an account now.</a>
&nbsp;
<Link
to={FrontendUrlConfig.signupPage()}
className="text-link"
>
Create an account now.
</Link>
</p>
</div>
</form>