From bfc28fb3e54776662bbff4adbc4f82a04323ef71 Mon Sep 17 00:00:00 2001
From: Brandon Thomas <echelon@gmail.com>
Date: Sun, 10 Jul 2022 23:12:39 -0400
Subject: [PATCH] Fix build errors around href accessibility

---
 packages/fakeyou/src/common/FrontendUrlConfig.ts |  6 ++++++
 packages/fakeyou/src/v2/view/NewTopNavFc.tsx     | 13 ++++++++++---
 packages/fakeyou/src/v2/view/login/LoginPage.tsx | 11 +++++++++--
 3 files changed, 25 insertions(+), 5 deletions(-)

diff --git a/packages/fakeyou/src/common/FrontendUrlConfig.ts b/packages/fakeyou/src/common/FrontendUrlConfig.ts
index 21d6d3fd06..34225a2ccd 100644
--- a/packages/fakeyou/src/common/FrontendUrlConfig.ts
+++ b/packages/fakeyou/src/common/FrontendUrlConfig.ts
@@ -8,6 +8,12 @@ class FrontendUrlConfig {
     return '/';
   }
 
+  // Login and signup flow
+
+  static signupPage() : string {
+    return '/signup';
+  }
+
   // Standalone pages
 
   static aboutUsPage() : string {
diff --git a/packages/fakeyou/src/v2/view/NewTopNavFc.tsx b/packages/fakeyou/src/v2/view/NewTopNavFc.tsx
index 18c92555b4..8636ffb371 100644
--- a/packages/fakeyou/src/v2/view/NewTopNavFc.tsx
+++ b/packages/fakeyou/src/v2/view/NewTopNavFc.tsx
@@ -260,9 +260,10 @@ function NewTopNavFc(props: Props) {
                 </li>
 
                 <li className="nav-item dropdown">
+                  {/* TODO(echelon): Fix the build warnings about href not being accessible. */}
                   <a
                     className="nav-link dropdown-toggle"
-                    href="#"
+                    href="javascript:void(0);"
                     id="offcanvasNavbarLgDropdown"
                     role="button"
                     data-bs-toggle="dropdown"
@@ -291,9 +292,10 @@ function NewTopNavFc(props: Props) {
                 </li>
 
                 <li className="nav-item dropdown">
+                  {/* TODO(echelon): Fix the build warnings about href not being accessible. */}
                   <a
                     className="nav-link dropdown-toggle"
-                    href="#"
+                    href="javascript:void(0);"
                     id="offcanvasNavbarLgDropdown"
                     role="button"
                     data-bs-toggle="dropdown"
@@ -354,7 +356,12 @@ function NewTopNavFc(props: Props) {
                 </li>
 
                 <li className="nav-item d-lg-none">
-                  <a className="nav-link" aria-current="page" href="#">
+                  {/* TODO(echelon): Fix the build warnings about href not being accessible. */}
+                  <a 
+                    className="nav-link" 
+                    aria-current="page" 
+                    href="javascript:void(0);"
+                  >
                     Developers
                   </a>
                 </li>
diff --git a/packages/fakeyou/src/v2/view/login/LoginPage.tsx b/packages/fakeyou/src/v2/view/login/LoginPage.tsx
index bb52f03c50..1fe4dce70d 100644
--- a/packages/fakeyou/src/v2/view/login/LoginPage.tsx
+++ b/packages/fakeyou/src/v2/view/login/LoginPage.tsx
@@ -1,6 +1,7 @@
 import React, { useState } from "react";
+import { FrontendUrlConfig } from "../../../common/FrontendUrlConfig";
 import { SessionWrapper } from "@storyteller/components/src/session/SessionWrapper";
-import { useHistory } from "react-router-dom";
+import { Link, useHistory } from "react-router-dom";
 import {
   CreateSession,
   CreateSessionIsError,
@@ -177,7 +178,13 @@ function LoginPage(props: Props) {
                   </button>
                   <p>
                     Don’t have an account?
-                    <a className="text-link">Create an account now.</a>
+                    &nbsp;
+                    <Link 
+                      to={FrontendUrlConfig.signupPage()} 
+                      className="text-link"
+                    >
+                      Create an account now.
+                    </Link>
                   </p>
                 </div>
               </form>