daniel543x/winprint.rs
1
0 Fork 0
mirror of https://github.com/storytold/winprint.rs.git synced 2026-11-14 06:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: create the Direct2D factory multi-threaded for Windows.Data.Pdf

Browse Source 
Windows.Data.Pdf renders a page on several worker threads that share the
device context passed to RenderPageToDeviceContext. With a single-threaded
factory Direct2D takes no locks, so those threads race inside d2d1.dll:
access violations reading near null (d2d1.dll+0x93fd4, address 0x338) or
executing freed memory (BEX64), mostly on long jobs of scanned pages.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
cart2notasmn-opsandClaude Opus 5.5 committed 2026-10-27 12:31:35 -03:00
1 parent d1dc3c2089
commit f256775bec
1 file changed
+5 -2
Download Patch File Download Diff File Expand all files Collapse all files
src/printer/dxgi.rs
+5 -2
View File
@@ -20,7 +20,7 @@ use windows::Win32::Graphics::Direct2D::ID2D1Factory1;
use windows::Win32::Graphics::Direct2D::ID2D1PrintControl;
use windows::Win32::Graphics::Direct2D::D2D1_DEVICE_CONTEXT_OPTIONS_NONE;
use windows::Win32::Graphics::Direct2D::D2D1_FACTORY_OPTIONS;
use windows::Win32::Graphics::Direct2D::D2D1_FACTORY_TYPE_SINGLE_THREADED;
use windows::Win32::Graphics::Direct2D::D2D1_FACTORY_TYPE_MULTI_THREADED;
use windows::Win32::Graphics::Direct2D::D2D1_PRINT_CONTROL_PROPERTIES;
use windows::Win32::Graphics::Direct3D::D3D_DRIVER_TYPE_HARDWARE;
use windows::Win32::Graphics::Direct3D11::D3D11CreateDevice;
@@ -151,8 +151,11 @@ impl DxgiPrintContext {
.map_err(DxgiPrintContextError::InitializeDirectX)?;
let d2d_factory_options = D2D1_FACTORY_OPTIONS::default();
// Windows.Data.Pdf renders a page on several worker threads that share this
// device context. A single-threaded factory has no locking, so they race inside
// d2d1.dll (access violations reading near null or calling freed memory).
let d2d_factory: ID2D1Factory1 = D2D1CreateFactory(
D2D1_FACTORY_TYPE_SINGLE_THREADED,
D2D1_FACTORY_TYPE_MULTI_THREADED,
Some(&d2d_factory_options),
)
.map_err(DxgiPrintContextError::InitializeDirectX)?;