Compare commits
9
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
1575b14294 | ||
|
|
01ad745e86 | ||
|
|
d8f6bacddb | ||
|
|
fc74389b5a | ||
|
|
0891ffbf51 | ||
|
|
992f6a0a4d | ||
|
|
53e39884fc | ||
|
|
abdc26d8d1 | ||
|
|
56c975465c |
No files matched your search
+5
-5
@@ -4,7 +4,7 @@ VectorCraft is a clean-room, open-source, pure-Rust reimplementation of the Adob
|
||||
|
||||
This file tracks **how far we are and what's left**. Time estimates are wall-clock hours of continuous Claude Opus 5.5 agent work (including builds and the CI gate), given both for **one agent** and for **4–6 parallel agents** on disjoint crates. They are counted from the remaining work (see [Parity estimate](#parity-estimate)), calibrated against measured throughput, and updated as work lands.
|
||||
|
||||
_Last updated: 2026-10-09 (after placed documents (File › Place of a `.vectorcraft` file, linked), M4.14–M4.98, M8.1–M8.20, M14.4–M14.7, the MCP prompts, resource templates, completions and logging, the 2026-10-07 issue fixes, the Layers panel rework and the 2026-10-08 community contributions: Pen and shape-tool modifiers, path editing, Layers, Artboards, Swatches/Brushes and dialogs, Japanese composition and PDF text, Hebrew/Arabic type, interface languages (Spanish among them), the font menu, saved selections, MCP and EPS, the missing-font export warning (#319), open paths in the Shape Builder (#374), PDF/`.ai` import keeping strokes live and hidden and nested layers (#372), per-corner Live Corners (#381), SVG type opening at the size it draws at (#396), the Wayland clipboard with copied-file paste (#398), ruler guides that can be selected, moved and deleted (#414), two batches of Preferences options that were stored but unused (#394), skeleton reads with `document.find` for large documents over MCP (#416) and anchors dragged with Direct Selection snapping to points, segments and smart guides, clipped SVG layers opening as clipping layers (#420), PDF/`.ai` layers read on pages of tens of millions of operators (#419), Document Color Mode putting RGB greys on the black plate on request and converting pattern tiles (#421) and movable dialogs with Offset Path's Joins dropdown (#423) and numeric fields scrubbed by dragging their label (#400), stroke weight presets in the stroke unit (#426), the Appearance panel's Opacity popup (#430), type on a path brackets, flip and Type on a Path Options that keep the type in place (#429), Layers rows dragged with a ghost and dropped on the trash or New Layer (#435), tool flyouts opening on a right or corner press (#436), tool flyouts torn off into floating toolbars (#437), the Shape Builder's erase mode deleting edges too (#439), installed fonts registered outside the font folders and fonts installed while the app runs listed in the font menus (#443), alike circular corners on rectangles that aren't square (#442), tool cursors as OS cursors so the pointer no longer trails over the canvas (#444), artboards copied and pasted with their art (#446), guides dragged out of the rulers snapping to the art's side midpoints and the artboards, artboard guides (#451), the toolbar's double arrow and Window › Toolbars › Double Column switching between one and two columns in any window height (#455), the Smart Guides display options and Snapping Tolerance (#394), Font Size and Leading combo boxes with preset lists in the Character and Properties panels and the Control bar (#458), screenshots pasted from the clipboard on macOS, Windows and the web (#457), the Properties panel's Fill and Stroke matching the Control bar's, Illustrator's Window menu panel keys (Shift+F7 for Align…) and Alt-wheel zoom whatever the wheel preference (Discord feedback), the point/area type widget (Discord feedback), groups in legacy Illustrator .ai files (Discord feedback), a rotating desktop log file (#465), image controls in the Control bar and Properties panel: Image Trace with its presets, Mask, Crop Image, Embed/Unembed, and an Image Trace object's preset, Expand and Release (Discord feedback), the Pen working as the Anchor Point tool with Alt held over a selected path's handles and anchors, and anchor buttons that convert, connect and cut paths at the selected anchors (Discord feedback), Japanese hanging punctuation (burasagari, #463), Escape leaving Presentation Mode with no screen mode saved across restarts, documents dropped on the desktop app opening as tabs of their own and a note that an `.ai` file's art off its artboards isn't in the part read (#472), Add/Delete Anchor Point tool icons drawn from the Pen tool's (#479), EPS import running more of PostScript Level 3 (patterns, Type 3 fonts, mesh shadings, masked images, VM and resource probes), and a preview that stands in saying why (Discord feedback, #466, #469, #474), chords with modifiers recorded in Edit › Keyboard Shortcuts (#487), Type Object Selection by Path Only (#394), Anti-aliased Artwork (#394), Show Pixel Grid (#394), pen and touch taps pressed and lifted within one frame clicking where they tapped and the Linux/Wayland pen-tablet workaround (#491), bounding-box resizes landing on the other objects' anchors and centres with labels, and the Rotate, Scale, Shear and Reflect tools snapping their drags (#482), Shift-drag marquees that toggle the objects or anchors they reach and a Lasso whose Alt subtraction keeps the rest of the selection (#483), the mouse wheel stepping the focused numeric field, the dialogs' and preferences' drag values made such fields (#485), Show The Home Screen When No Documents Are Open (#394), Numbers Without Units Are Points (#394), Auto-Collapse Iconic Panels (#394), the Contextual Task Bar moved by its handle and its More Options menu pinning and resetting its position, a designed macOS DMG windoLine truncated
|
||||
_Last updated: 2026-10-09 (after placed documents (File › Place of a `.vectorcraft` file, linked), M4.14–M4.98, M8.1–M8.20, M14.4–M14.7, the MCP prompts, resource templates, completions and logging, the 2026-10-07 issue fixes, the Layers panel rework and the 2026-10-08 community contributions: Pen and shape-tool modifiers, path editing, Layers, Artboards, Swatches/Brushes and dialogs, Japanese composition and PDF text, Hebrew/Arabic type, interface languages (Spanish among them), the font menu, saved selections, MCP and EPS, the missing-font export warning (#319), open paths in the Shape Builder (#374), PDF/`.ai` import keeping strokes live and hidden and nested layers (#372), per-corner Live Corners (#381), SVG type opening at the size it draws at (#396), the Wayland clipboard with copied-file paste (#398), ruler guides that can be selected, moved and deleted (#414), two batches of Preferences options that were stored but unused (#394), skeleton reads with `document.find` for large documents over MCP (#416) and anchors dragged with Direct Selection snapping to points, segments and smart guides, clipped SVG layers opening as clipping layers (#420), PDF/`.ai` layers read on pages of tens of millions of operators (#419), Document Color Mode putting RGB greys on the black plate on request and converting pattern tiles (#421) and movable dialogs with Offset Path's Joins dropdown (#423) and numeric fields scrubbed by dragging their label (#400), stroke weight presets in the stroke unit (#426), the Appearance panel's Opacity popup (#430), type on a path brackets, flip and Type on a Path Options that keep the type in place (#429), Layers rows dragged with a ghost and dropped on the trash or New Layer (#435), tool flyouts opening on a right or corner press (#436), tool flyouts torn off into floating toolbars (#437), the Shape Builder's erase mode deleting edges too (#439), installed fonts registered outside the font folders and fonts installed while the app runs listed in the font menus (#443), alike circular corners on rectangles that aren't square (#442), tool cursors as OS cursors so the pointer no longer trails over the canvas (#444), artboards copied and pasted with their art (#446), guides dragged out of the rulers snapping to the art's side midpoints and the artboards, artboard guides (#451), the toolbar's double arrow and Window › Toolbars › Double Column switching between one and two columns in any window height (#455), the Smart Guides display options and Snapping Tolerance (#394), Font Size and Leading combo boxes with preset lists in the Character and Properties panels and the Control bar (#458), screenshots pasted from the clipboard on macOS, Windows and the web (#457), the Properties panel's Fill and Stroke matching the Control bar's, Illustrator's Window menu panel keys (Shift+F7 for Align…) and Alt-wheel zoom whatever the wheel preference (Discord feedback), the point/area type widget (Discord feedback), groups in legacy Illustrator .ai files (Discord feedback), a rotating desktop log file (#465), image controls in the Control bar and Properties panel: Image Trace with its presets, Mask, Crop Image, Embed/Unembed, and an Image Trace object's preset, Expand and Release (Discord feedback), the Pen working as the Anchor Point tool with Alt held over a selected path's handles and anchors, and anchor buttons that convert, connect and cut paths at the selected anchors (Discord feedback), Japanese hanging punctuation (burasagari, #463), Escape leaving Presentation Mode with no screen mode saved across restarts, documents dropped on the desktop app opening as tabs of their own and a note that an `.ai` file's art off its artboards isn't in the part read (#472), Add/Delete Anchor Point tool icons drawn from the Pen tool's (#479), EPS import running more of PostScript Level 3 (patterns, Type 3 fonts, mesh shadings, masked images, VM and resource probes), and a preview that stands in saying why (Discord feedback, #466, #469, #474), chords with modifiers recorded in Edit › Keyboard Shortcuts (#487), Type Object Selection by Path Only (#394), Anti-aliased Artwork (#394), Show Pixel Grid (#394), pen and touch taps pressed and lifted within one frame clicking where they tapped and the Linux/Wayland pen-tablet workaround (#491), bounding-box resizes landing on the other objects' anchors and centres with labels, and the Rotate, Scale, Shear and Reflect tools snapping their drags (#482), Shift-drag marquees that toggle the objects or anchors they reach and a Lasso whose Alt subtraction keeps the rest of the selection (#483), the mouse wheel stepping the focused numeric field, the dialogs' and preferences' drag values made such fields (#485), Show The Home Screen When No Documents Are Open (#394), Numbers Without Units Are Points (#394), Auto-Collapse Iconic Panels (#394), the Contextual Task Bar moved by its handle and its More Options menu pinning and resetting its position, a designed macOS DMG windoLine truncated
|
||||
|
||||
## Where we are
|
||||
|
||||
@@ -109,7 +109,7 @@ grade by behaviour against `plan/illustrator/`, not by whether a menu item exist
|
||||
- A canvas context menu: right-click selects the object under the pointer and lists what applies to the selection (Undo/Redo, clipboard, group, isolation, join, Remove Anchor Points when anchors are selected, masks, compound paths, guides, Transform, Arrange, Select, Export Selection), or the view commands on empty canvas.
|
||||
- Save / Don't Save / Cancel before closing or quitting with unsaved documents (tabs, Close, Close All, Quit, window close).
|
||||
- Four brightness themes, persistent preferences.
|
||||
- Preferences that act (#394, in part): Show Tool Tips, Double Click To Isolate, Zoom with Mouse Wheel (the wheel zooms about the pointer, Shift-wheel scrolls up and down, Cmd/Ctrl-wheel sideways; Alt/Option-wheel and a trackpad pinch zoom about the pointer either way), Use Precise Cursors; Selection & Anchor Display › Tolerance (objects, anchors and handles), Object Selection by Path Only, Command Click to Select Objects Behind (cycling down the stack), Zoom to Selection, anchor Size, Highlight anchors on mouse over; Type › Number of Recent Fonts (up to 15); Guides & Grid › guide and grid Color and Style (lines or dots) and Grids In Back. Then Snap to Point (its distance, for moves, drawn points and reference points), Move Locked and Hidden Artwork with Artboard, Enable Rubber Band for the Pen and Curvature tools, Handles style, Show handles when multiple anchors are selected, Hide Corner Widget for angles greater than; General › Transform Pattern Tiles (the transforms' and dialogs' Transform Patterns) and Select Same Tint %; Type › Size/Leading, Tracking and Baseline Shift increments (`type.step`, Cmd+Shift+. and Cmd+Shift+, for the size, the Type tool's Alt+arrows), Enable Missing Glyph Protection and Fill New Type Objects With Placeholder Text. Then Smart Guides › Color, Alignment Guides, Anchor/Path Labels, Measurement Labels, Transform Tools, Object Highlighting (with Smart Guides on) and Snapping Tolerance (4 px by default, for every smart guide snap), then Construction Guides and their Angles (#506: a drawn point near a line at one of those angles through the point it leaves from lands on it). Then Type › Type Object Selection by Path Only (type is picked on the baseline of any of its lines, area type's frame or the path of type on a path, no longer anywhere in its bounds; the Type tools and the Eyedropper still take a click among the characters). Then General › Anti-aliased Artwork (off, the canvas draws the art with hard edges). Then Guides & Grid › Show Pixel Grid (Above 600% Zoom), a line at every document pixel over the art in Pixel Preview, turning with a rotated view as the document grid now does too. Then General › Show The Home Screen When No Documents Are Open (off, closing the last document leaves an empty window; the Home button still opens the screen). Then Units › Numbers Without Units Are Points (on by default: a number typed with no unit into a field in picas is read in points, a typed unit still wins; dimmed unless a unit is Picas). Then User Interface › Auto-Collapse Iconic Panels (off by default: on, a click away from a panel popped out of the icon column puts it away). They reach agents too (`prefs.set`, then `pointer_gesture` or `press_key`; `ui.wheel` on the control channel). About 30 stored options still do nothing yet (the rest of #394: Auto Size New Area Type, Show Font Names in English, Highlight Alternate Glyphs, Spacing Guides, performance, devices…).
|
||||
- Preferences that act (#394, in part): Show Tool Tips, Double Click To Isolate, Zoom with Mouse Wheel (the wheel zooms about the pointer, Shift-wheel scrolls up and down, Cmd/Ctrl-wheel sideways; Alt/Option-wheel and a trackpad pinch zoom about the pointer either way), Use Precise Cursors; Selection & Anchor Display › Tolerance (objects, anchors and handles), Object Selection by Path Only, Command Click to Select Objects Behind (cycling down the stack), Zoom to Selection, anchor Size, Highlight anchors on mouse over; Type › Number of Recent Fonts (up to 15); Guides & Grid › guide and grid Color and Style (lines or dots) and Grids In Back. Then Snap to Point (its distance, for moves, drawn points and reference points), Move Locked and Hidden Artwork with Artboard, Enable Rubber Band for the Pen and Curvature tools, Handles style, Show handles when multiple anchors are selected, Hide Corner Widget for angles greater than; General › Transform Pattern Tiles (the transforms' and dialogs' Transform Patterns) and Select Same Tint %; Type › Size/Leading, Tracking and Baseline Shift increments (`type.step`, Cmd+Shift+. and Cmd+Shift+, for the size, the Type tool's Alt+arrows), Enable Missing Glyph Protection and Fill New Type Objects With Placeholder Text. Then Smart Guides › Color, Alignment Guides, Anchor/Path Labels, Measurement Labels, Transform Tools, Object Highlighting (with Smart Guides on) and Snapping Tolerance (4 px by default, for every smart guide snap), then Construction Guides and their Angles (#506: a drawn point near a line at one of those angles through the point it leaves from lands on it). Then Type › Type Object Selection by Path Only (type is picked on the baseline of any of its lines, area type's frame or the path of type on a path, no longer anywhere in its bounds; the Type tools and the Eyedropper still take a click among the characters). Then General › Anti-aliased Artwork (off, the canvas draws the art with hard edges). Then Guides & Grid › Show Pixel Grid (Above 600% Zoom), a line at every document pixel over the art in Pixel Preview, turning with a rotated view as the document grid now does too. Then General › Show The Home Screen When No Documents Are Open (off, closing the last document leaves an empty window; the Home button still opens the screen). Then Units › Numbers Without Units Are Points (on by default: a number typed with no unit into a field in picas is read in points, a typed unit still wins; dimmed unless a unit is Picas). Then User Interface › Auto-Collapse Iconic Panels (off by default: on, a click away from a panel popped out of the icon column puts it away). They reach agents too (`prefs.set`, then `pointer_gesture` or `press_key`; `ui.wheel` on the control channel). Then Smart Guides › Spacing Guides (moves space the selection evenly with its row or column, see Drawing aids). About 30 stored options still do nothing yet (the rest of #394: Show Font Names in English, Highlight Alternate Glyphs, performance, devices…).
|
||||
- Dialogs move by dragging their heading (the band down from the top edge, as a title bar), stay on screen and keep where they were moved for the session; the form dialogs' choices are dropdowns (Offset Path's Joins, Average's and Shear's and Reflect's axis), and Offset Path lists Offset, Joins, Miter Limit and previews (#423).
|
||||
- Dialogs open with their first field focused and its value selected: type a value and press Enter (Move, Rotate, Scale…). Number fields in panels, the Control bar and dialogs (preferences too) step with Up/Down, or with the mouse wheel over the focused field (#485: a notch a step; the panel under it then stays put, and an unfocused field leaves the wheel to scrolling) (Shift: ten, Ctrl/Cmd: a tenth of their unit), applied at once.
|
||||
- Scrubby labels (#400, beyond Illustrator, as in Photoshop): dragging a numeric field's label left or right (the ↔ cursor shows over it) steps the value one unit every 2 points (Shift: ten, Ctrl/Cmd: a tenth; counts stay whole), in the field's unit and within its limits, applied live as the art follows; the whole drag is one undo step and Escape puts the value back. A click on the label focuses the field; the text box itself never scrubs, and a field with no label doesn't. Text labels before a field (Transform, Properties, Control bar, Stroke, Transparency, form rows in dialogs) and the Character and Paragraph panels' icons act as labels. Preferences › General › Scrub Numeric Fields by Dragging (on by default) turns it off.
|
||||
@@ -135,7 +135,7 @@ grade by behaviour against `plan/illustrator/`, not by whether a menu item exist
|
||||
- **Panel drag and drop:** art dragged off the canvas onto the Symbols panel becomes a symbol, onto the Swatches panel a pattern swatch and onto the Brushes panel an Art brush; a symbol dragged onto the canvas places an instance where it is dropped, and a brush dragged onto a path is applied to it.
|
||||
- **Tool double-clicks:** double-clicking a tool's button opens its options: Hand fits the artboard in the window, Zoom shows 100 %, Rotate, Scale, Reflect and Shear open their Object › Transform dialogs, the Selection, Direct Selection and Group Selection tools the Move dialog (Enter opens these seven tools' dialogs too), Gradient, Eyedropper, Blend and the Liquify tools their panels or options, and the Pencil, Paintbrush, Smooth, Blob Brush and Eraser tools their Tool Options (Fidelity, fill, the tolerances, the brush size).
|
||||
- **Layers panel:** every layer, sublayer, group and object is a clickable row at any depth: a click highlights it and makes its layer current (new art goes there), Shift-click a range, Ctrl/Cmd-click toggles. Sublayers are no longer treated as objects: clicks, marquees, Select All and the Select menu take the art inside them, and each sublayer selects in its own colour. Selection squares on rows with selected art (click selects a row's art, Shift adds or removes; dragging the square moves the selection to another row, Alt copies), the eye and lock on every row with drag-down-the-column (one undo step), Ctrl/Cmd-click an eye for per-layer Outline, Alt-click an eye or lock to hide or lock the other layers (again: show or unlock them all), triangles with Alt to open or close everything inside, drag and drop rows above, below or into layers and groups with a drop line (Alt copies) and a dimmed copy of the row under the pointer (dropped on the trash rows are deleted, on New Layer duplicated, as in Illustrator), inline rename, Delete key on highlighted rows. Buttons and the full panel menu: New Layer/Sublayer (Alt: options, Ctrl: on top), Duplicate, Delete, Options for Selection, clipping mask, isolation, Locate Object, Merge Selected, Flatten Artwork, Collect in New Layer, Release to Layers (Sequence and Build), Reverse Order, Template, Hide/Outline/Lock Others and Show/Preview/Unlock All, Paste Remembers Layers, Panel Options (row size, thumbnails per kind, Show Layers Only). Layer Options: name, colour (presets, each with a chip of its colour, or custom), Template, Lock, Show, Print, Preview (outline drawing and clicking) and Dim Images to %. Every operation is a command (`layer.move`, `layer.highlight`, `layer.merge`…) with validation against cycles and invalid nesting. A document opens with only its top-level layers open; the rows left open are saved in the native file (nothing is written for the default) and reopen that way. Only the rows scrolled into view are laid out, from a row list made once per change: a layer of 5,000 groups of 10 paths, all open, draws the panel in 0.4 ms a frame instead of about 29 s (#638).
|
||||
- **Drawing aids:** Smart Guides and snapping (moving, with the Selection, Group Selection or Direct Selection tool, and resizing by the bounding-box handles with the Selection or Free Transform tool, Shift and Alt too: the dragged corner or side lands on the other objects' anchors and centres ("anchor", "center") or lines up with their edges and centres (a line and "align"); the Rotate, Scale, Shear and Reflect tools drag from the anchor they grab and snap the pointer the same way, so a corner dragged onto another object's anchor scales exactly onto it, #482; anchors dragged with Direct Selection: the one pressed on lands on other anchors, its own path's that stay put among them, on path segments or in line with them, the others following, Shift keeps 45° steps, and with Smart Guides off Snap to Point pulls it onto anchors; the Artboard tool snaps artboards, and their bleed, to other artboards, bleeds and art, the grid or whole pixels while moving, copying and resizing them, and the Transform panel shows and edits the active artboard's X/Y/W/H; drawn points, #506: hovering shows where the press goes, the point lands on the other objects' anchors, centres and paths ("anchor", "center", "path") or lines up with their anchors, edges and centres ("align"), the Pen's on the path being drawn too, near a construction guide through the anchor before it on that guide (Preferences › Smart Guides › Construction Guides and Angles), and with Shift kept to its 45° step or a square's diagonal it slides along that way into line; the targets are gathered once per document state, from the art in the window, and the anchors, centres and lines near the pointer are found by bisection, so hovering never rescans the document), guides dragged out of the rulers (#451: they snap as moved guides do, Shift to the ruler's ticks; with the Artboard tool they are artboard guides, which run across their artboard only and move, copy and delete with it, `guide.add {artboard}`) that the Selection, Direct Selection and Group Selection tools then pick and drag (#414: the selected guides highlight and move together, Alt copies them, Shift snaps the dragged one to the ticks, otherwise it snaps to pixels, the grid or the edges, centres (so the sides' midpoints) and anchors of the art and the artboards, or with Smart Guides off Snap to Point pulls it onto anchors; the arrow keys nudge them, Delete deletes them, dragging one back onto its ruler deletes it, Lock Guides and Hide Guides leave them alone; `guide.list`, `guide.select`, `guide.move` and `guide.remove` reach agents), a right-click on either ruler or the origin box to pick the document's units (the current one checked; `document.setUnits`, one undo step, #528), and Draw Normal / Behind / Inside modes.
|
||||
- **Drawing aids:** Smart Guides and snapping (moving, with the Selection, Group Selection or Direct Selection tool, and resizing by the bounding-box handles with the Selection or Free Transform tool, Shift and Alt too: the dragged corner or side lands on the other objects' anchors and centres ("anchor", "center") or lines up with their edges and centres (a line and "align"); with Smart Guides › Spacing Guides, a moved selection that lines up with nothing along an axis lands as far from its neighbour as two other objects of its row or column are apart, or halfway between its two neighbours, the equal gaps marked; the Rotate, Scale, Shear and Reflect tools drag from the anchor they grab and snap the pointer the same way, so a corner dragged onto another object's anchor scales exactly onto it, #482; anchors dragged with Direct Selection: the one pressed on lands on other anchors, its own path's that stay put among them, on path segments or in line with them, the others following, Shift keeps 45° steps, and with Smart Guides off Snap to Point pulls it onto anchors; the Artboard tool snaps artboards, and their bleed, to other artboards, bleeds and art, the grid or whole pixels while moving, copying and resizing them, and the Transform panel shows and edits the active artboard's X/Y/W/H; drawn points, #506: hovering shows where the press goes, the point lands on the other objects' anchors, centres and paths ("anchor", "center", "path") or lines up with their anchors, edges and centres ("align"), the Pen's on the path being drawn too, near a construction guide through the anchor before it on that guide (Preferences › Smart Guides › Construction Guides and Angles), and with Shift kept to its 45° step or a square's diagonal it slides along that way into line; the targets are gathered once per document state, from the art in the window, and the anchors, centres and lines near the pointer are found by bisection, so hovering never rescans the document), guides dragged out of the rulers (#451: they snap as moved guides do, Shift to the ruler's ticks; with the Artboard tool they are artboard guides, which run across their artboard only and move, copy and delete with it, `guide.add {artboard}`) that the Selection, Direct Selection and Group Selection tools then pick and drag (#414: the selected guides highlight and move together, Alt copies them, Shift snaps the dragged one to the ticks, otherwise it snaps to pixels, the grid or the edges, centres (so the sides' midpoints) and anchors of the art and the artboards, or with Smart Guides off Snap to Point pulls it onto anchors; the arrow keys nudge them, Delete deletes them, dragging one back onto its ruler deletes it, Lock Guides and Hide Guides leave them alone; `guide.list`, `guide.select`, `guide.move` and `guide.remove` reach agents), a right-click on either ruler or the origin box to pick the document's units (the current one checked; `document.setUnits`, one undo step, #528), and Draw Normal / Behind / Inside modes.
|
||||
- **Views:** the status bar's artboard navigator (first, previous, next, last; `view.goToArtboard`) goes to an artboard and fits it, and Fit Artboard in Window and Actual Size show the navigator's artboard. The Artboards panel highlights that active artboard: clicking a row makes it active (the Artboard tool's too, while it is chosen) as does clicking an artboard with the Artboard tool, double-clicking its number also fits it in the window and double-clicking its name renames it. Duplicate Artboards, or a row dragged onto New Artboard, copies the artboard with its art (#446). Escape leaves Presentation Mode, F from it goes back to Normal Screen Mode, and the screen mode isn't saved with the preferences: the app always starts in Normal Screen Mode with its menus and panels (#472). View › Pixel Preview shows the art as the document pixels it rasterizes to, one per point and hard-edged when magnified, turning with a rotated view (it used to draw the smooth vectors, with only the pixel grid over them).
|
||||
- **Geometry and effects:**
|
||||
- Pathfinder (10 exact curve booleans), Offset, Outline Stroke, Simplify, Clean Up, Split Into Grid, Divide Objects Below. Object › Path › Remove Anchor Points (`path.removeAnchors`) removes the direct-selected anchors without opening their paths (the Delete key still deletes them with their segments): the neighbours keep their handle directions and their facing handles are refitted so one cubic follows the two old segments, and straight sides stay straight. The Delete Anchor Point tool uses the same refit. The Control bar, the contextual task bar, the Properties quick actions and the canvas context menu offer it when anchors are selected. With anchors selected, the Control bar and the Properties panel also convert them to corner or smooth (`path.convertAnchors`), connect end points (Join) and cut the path at them (`path.cutAtAnchors`, also on the task bar and the context menu): a closed path opens there and an open one becomes one path per piece, each cut leaving one of its two coincident anchors selected so a drag pulls the path apart.
|
||||
@@ -218,12 +218,12 @@ about 1–1.5 agent-hours each, so the other rows (estimated on the older scale)
|
||||
| Image Trace, graphs, image tools | 3 | 70% | graph Design/Column/Marker, Create Object Mosaic, Crop Image polish (an on-canvas crop box), per-feature stroke/fill choice and varying widths in Image Trace's Create Strokes (Vector Halftone and the Image Trace View modes, Palette and Create Strokes are done) | 6–10 |
|
||||
| Layers, artboards, document setup | 5 | 82% | Layers panel: a confirmation before deleting layers that hold art, Collect for Export, row context menus, the Layer Options dialog for several rows with mixed values, Paste Remembers Layers for sublayers, drag-scrolling a long panel while dragging rows; artboard presets/rearrange polish (Document Setup, New Document and the rest of the Layers panel are done) | 4–7 |
|
||||
| View & navigation | 3 | 70% | New View/Edit Views, multiple windows/arrange, Snap to Pixel/Glyph (print tiling is done) | 9–14 |
|
||||
| Guides, grids, smart guides, snapping, rulers | 3 | 84% | global/video rulers, Spacing Guides, Smart Guides' angle and distance readouts while drawing, Alt swapping a ruler guide's orientation, ruler guides selected together with art (marquee, Shift-click), ruler guides as Layers rows with their own lock and hide (#451: Lock Guides locks them all; Make Guides paths are Layers rows already) (dragging existing guides is done, #414; new guides snapping to side midpoints and artboards, and artboard guides, #451; the drawing tools snapping, with Construction Guides, #506) | 2–4 |
|
||||
| Guides, grids, smart guides, snapping, rulers | 3 | 85% | global/video rulers, Spacing Guides' distance readouts and spacing for resized or drawn art, Smart Guides' angle and distance readouts while drawing, Alt swapping a ruler guide's orientation, ruler guides selected together with art (marquee, Shift-click), ruler guides as Layers rows with their own lock and hide (#451: Lock Guides locks them all; Make Guides paths are Layers rows already) (dragging existing guides is done, #414; new guides snapping to side midpoints and artboards, and artboard guides, #451; the drawing tools snapping, with Construction Guides, #506; Spacing Guides for moves, #394) | 2–4 |
|
||||
| File formats | 6 | 85% | DWG (no open spec: DXF instead), PSD placement as layers, EPS checked against more real files users send (Inkscape files open as vectors; other generators' constructs are tested with programs written from the PostScript Language Reference only; CID-keyed CJK type and `CCITTFaxDecode` images not read), legacy `.ai` files saved without the prolog that defines their operators (their own operator set isn't read yet), the remaining fidelity polish; EPS, DXF, EMF/WMF, TIFF, BMP, Targa, PSD export, SVGZ, PDF security, PDF/X, PDF layers and presets are done | 6–10 |
|
||||
| Export for Screens, Asset Export, slices, Save for Web | 3 | 85% | polish only (all four are done) | 2–4 |
|
||||
| Print, colour management, separations, flattener | 3 | 80% | print preview fidelity (flattener presets in PDF and print, overprint in PDF and composite print, Print dialog, presets, PostScript, marks, separations, Print Tiling, print overprint/flattener/bitmap options and printer profile are done) | 1–2 |
|
||||
| Automation | 3 | 60% | Variables (data merge), scripting surface, batch | 8–12 |
|
||||
| UI chrome (panels, contextual Properties, workspaces, prefs) | 6 | 78% | macOS native menu dismissal fixed (M14.8); remaining: Variables, SVG Interactivity, Properties per context, Consolidate All Windows, floating panels outside the app window and docked into any group, context menus beyond the canvas (Links, Asset Export, CSS Properties, Attributes and the canvas context menu are done), about 30 Preferences options stored but not yet acted on (#394: Spacing Guides, Auto Size New Area Type, Show Font Names in English, Highlight Alternate Glyphs, performance, devices…) | 14–22 |
|
||||
| UI chrome (panels, contextual Properties, workspaces, prefs) | 6 | 78% | macOS native menu dismissal fixed (M14.8); remaining: Variables, SVG Interactivity, Properties per context, Consolidate All Windows, floating panels outside the app window and docked into any group, context menus beyond the canvas (Links, Asset Export, CSS Properties, Attributes and the canvas context menu are done), about 30 Preferences options stored but not yet acted on (#394: Show Font Names in English, Highlight Alternate Glyphs, performance, devices…) | 14–22 |
|
||||
| Libraries, Links, Package | 2 | 50% | a local Libraries panel (no cloud by design); Links and Package are done; placed VectorCraft documents are done (linked by default, vectors in every output, previews, Break Link, Expand, Edit Original, refresh on save) | 5–8 |
|
||||
| **Feature parity** | **103** | **~75%** | | **~210–330** |
|
||||
| Interaction-fidelity pass (side by side with Illustrator: every tool modifier, cursor, dialog, Properties context) | | | | 60–90 |
|
||||
|
||||
@@ -147,6 +147,8 @@ fn auto_height(t: &mut TextObject) -> bool {
|
||||
let col_w = if cols > 1 { ((b.width() - t.area.gutter.max(0.0) * (cols - 1) as f64) / cols as f64).max(1.0) } else { b.width() };
|
||||
with_size(&mut probe, col_w, tall);
|
||||
probe.area.columns = 1;
|
||||
// Measured from the top: aligned in the tall probe the lines would sit far below.
|
||||
probe.area.vertical_align = vectorcraft_doc::VerticalAlign::Top;
|
||||
let lay = vectorcraft_text::layout(db, &probe);
|
||||
let inset = t.area.inset.max(0.0);
|
||||
let Some(bottom) = lay.lines.iter().map(|l| l.baseline + l.descent).filter(|y| y.is_finite()).reduce(f64::max) else { return false };
|
||||
|
||||
@@ -1586,6 +1586,8 @@ mod tests_swatchlib;
|
||||
#[cfg(test)]
|
||||
mod tests_targeting;
|
||||
#[cfg(test)]
|
||||
mod tests_textcombos;
|
||||
#[cfg(test)]
|
||||
mod tests_textedit;
|
||||
#[cfg(test)]
|
||||
mod tests_textimport;
|
||||
|
||||
@@ -282,6 +282,33 @@ fn snap_to_point_lands_a_dragged_selection_on_anchors() {
|
||||
assert_eq!(drag(&mut s, ViewInfo { snap_to_point: false, ..v }), (276.5, 76.0), "View › Snap to Point off");
|
||||
}
|
||||
|
||||
/// Smart Guides › Spacing Guides (#394): a square dragged 21 pt to the right of a row of two
|
||||
/// squares 20 pt apart lands 20 pt from it, with the gaps marked; off, it stays at 21.
|
||||
#[test]
|
||||
fn spacing_guides_space_a_dragged_square_like_its_row() {
|
||||
use vectorcraft_tools::PointerKind::{Down, Drag, Up};
|
||||
let mut s = new_doc();
|
||||
square(&mut s, 20.0, 300.0);
|
||||
square(&mut s, 90.0, 300.0);
|
||||
let m = square(&mut s, 200.0, 305.0);
|
||||
let v = ViewInfo::default();
|
||||
s.select_tool("selection", v).unwrap();
|
||||
// `m` grabbed by its centre and dragged so its left edge is 21 pt from the second square.
|
||||
let drag = |s: &mut Session| {
|
||||
gesture(s, v, &[(Down, 225.0, 330.0), (Drag, 200.0, 330.0), (Drag, 186.0, 330.0)]);
|
||||
let marks = s.overlays(v).iter().filter(|o| matches!(o, vectorcraft_tools::Overlay::Line { a, b, .. } if a.y == b.y)).count();
|
||||
gesture(s, v, &[(Up, 186.0, 330.0)]);
|
||||
let at = top_left(s, m).0;
|
||||
s.execute("edit.undo", &json!({})).unwrap();
|
||||
(at, marks)
|
||||
};
|
||||
let (at, marks) = drag(&mut s);
|
||||
assert_eq!(at, 160.0, "20 pt from it");
|
||||
assert!(marks >= 2, "both gaps marked");
|
||||
set_pref(&mut s, "spacingGuides", json!(false));
|
||||
assert_eq!(drag(&mut s), (161.0, 0), "off: where it was dragged");
|
||||
}
|
||||
|
||||
/// Preferences › Smart Guides (#394): Color, Alignment Guides, Anchor/Path Labels, Measurement
|
||||
/// Labels, Transform Tools and Snapping Tolerance change what the Selection tool shows while a
|
||||
/// square is dragged into line with another, and how far the pull reaches; a hidden guide still
|
||||
|
||||
@@ -0,0 +1,310 @@
|
||||
//! The text engine's newer features combined through commands: Auto Size and Shrink Text to Fit
|
||||
//! with inline graphics, per-paragraph attributes, the paragraph composer and vertical
|
||||
//! alignment; editing and undo across them; and a save round trip with all of them on.
|
||||
//! (`vectorcraft_text`'s `tests_combos` covers the layout side.)
|
||||
|
||||
use serde_json::{Value, json};
|
||||
use vectorcraft_doc::text::INLINE_CHAR;
|
||||
use vectorcraft_doc::{AreaFit, Composer, Justify, NodeKind, TextKind, TextObject, VerticalAlign};
|
||||
use vectorcraft_geom::Rect;
|
||||
|
||||
use super::*;
|
||||
|
||||
const STORY: &str = "The quick brown fox jumps over the lazy dog. A second sentence follows the first one here. Then a third one ends it.";
|
||||
|
||||
fn session() -> Session {
|
||||
let mut s = Session::new();
|
||||
s.execute("file.new", &json!({"width": 800, "height": 600})).unwrap();
|
||||
s
|
||||
}
|
||||
|
||||
/// A symbol `name`: a circle `d` points across, its instance deleted.
|
||||
fn circle_symbol(s: &mut Session, name: &str, d: f64) {
|
||||
s.execute("shape.ellipse", &json!({"x": 600, "y": 500, "width": d, "height": d})).unwrap();
|
||||
s.execute("symbol.new", &json!({"name": name})).unwrap();
|
||||
s.execute("edit.clear", &json!({})).unwrap();
|
||||
}
|
||||
|
||||
/// Area type at (40, 40), `w` × `h`, size 12, with `extra` area options; selected.
|
||||
fn area(s: &mut Session, w: f64, h: f64, text: &str, extra: Value) -> NodeId {
|
||||
let mut a = json!({"width": w, "height": h});
|
||||
if let (Some(a), Some(e)) = (a.as_object_mut(), extra.as_object()) {
|
||||
a.extend(e.clone());
|
||||
}
|
||||
let id = NodeId(s.execute("text.create", &json!({"x": 40, "y": 40, "size": 12, "area": a, "text": text})).unwrap()["id"].as_u64().unwrap());
|
||||
s.execute("select.set", &json!({"ids": [id.0]})).unwrap();
|
||||
id
|
||||
}
|
||||
|
||||
fn text(s: &Session, id: NodeId) -> TextObject {
|
||||
match &s.doc().unwrap().doc.node(id).unwrap().kind {
|
||||
NodeKind::Text(t) => (**t).clone(),
|
||||
k => panic!("not text: {k:?}"),
|
||||
}
|
||||
}
|
||||
|
||||
fn frame(s: &Session, id: NodeId) -> Rect {
|
||||
match text(s, id).kind {
|
||||
TextKind::Area { frame } => frame.bounds().unwrap(),
|
||||
k => panic!("not area type: {k:?}"),
|
||||
}
|
||||
}
|
||||
|
||||
fn lay(t: &TextObject) -> vectorcraft_text::TextLayout {
|
||||
vectorcraft_text::layout(vectorcraft_text::FontDb::global(), t)
|
||||
}
|
||||
|
||||
/// Auto Size's frame is tight: the text fits, and a point less overflows.
|
||||
fn assert_tight(s: &Session, id: NodeId, what: &str) {
|
||||
let t = text(s, id);
|
||||
assert!(!lay(&t).overflow, "{what}: the frame holds the text");
|
||||
let b = frame(s, id);
|
||||
let mut less = t.clone();
|
||||
less.area.fit = AreaFit::None;
|
||||
less.kind = TextKind::Area {
|
||||
frame: vectorcraft_geom::PathData::from_bezpath(&vectorcraft_geom::Shape::to_path(&Rect::new(b.x0, b.y0, b.x1, b.y1 - 1.0), 0.1)),
|
||||
};
|
||||
assert!(lay(&less).overflow, "{what}: a point less overflows ({b:?})");
|
||||
}
|
||||
|
||||
fn undo(s: &mut Session) {
|
||||
s.execute("edit.undo", &json!({})).unwrap();
|
||||
}
|
||||
|
||||
fn redo(s: &mut Session) {
|
||||
s.execute("edit.redo", &json!({})).unwrap();
|
||||
}
|
||||
|
||||
fn query(s: &mut Session) -> Value {
|
||||
s.execute("text.areaOptions", &json!({})).unwrap()
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn auto_height_x_inline_graphics() {
|
||||
let mut s = session();
|
||||
circle_symbol(&mut s, "Tap", 10.0);
|
||||
let id = area(&mut s, 200.0, 300.0, "Tap: add one mana.", json!({"fit": "autoHeight"}));
|
||||
let one = frame(&s, id);
|
||||
assert_tight(&s, id, "one line");
|
||||
// Art taller than the line makes the line, and so the frame, taller: in the same undo step.
|
||||
let n = s.doc().unwrap().history.undo.len();
|
||||
s.execute("text.insertInline", &json!({"id": id.0, "at": 0, "symbol": "Tap", "scale": 3})).unwrap();
|
||||
assert_eq!(s.doc().unwrap().history.undo.len(), n + 1);
|
||||
let tall = frame(&s, id);
|
||||
assert!(tall.height() > one.height() + 5.0, "{one:?} → {tall:?}");
|
||||
assert_tight(&s, id, "tall art");
|
||||
// Enough art to wrap: another line.
|
||||
for _ in 0..12 {
|
||||
s.execute("text.insertInline", &json!({"id": id.0, "at": 0, "symbol": "Tap", "scale": 1})).unwrap();
|
||||
}
|
||||
assert!(lay(&text(&s, id)).lines.len() > 1);
|
||||
assert_tight(&s, id, "wrapped art");
|
||||
// Deleting the art shrinks it back; undo restores each step exactly.
|
||||
let wrapped = frame(&s, id);
|
||||
let all = text(&s, id).plain_text().rfind(INLINE_CHAR).unwrap() + INLINE_CHAR.len_utf8();
|
||||
s.execute("text.editRange", &json!({"id": id.0, "start": 0, "end": all})).unwrap();
|
||||
assert_eq!(text(&s, id).plain_text(), "Tap: add one mana.");
|
||||
assert_eq!(frame(&s, id), one);
|
||||
undo(&mut s);
|
||||
assert_eq!(frame(&s, id), wrapped);
|
||||
for _ in 0..13 {
|
||||
undo(&mut s);
|
||||
}
|
||||
assert_eq!(frame(&s, id), one);
|
||||
redo(&mut s);
|
||||
assert_eq!(frame(&s, id), tall);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn auto_height_x_paragraph_attrs() {
|
||||
let mut s = session();
|
||||
let id = area(&mut s, 200.0, 300.0, "One\nTwo", json!({"fit": "autoHeight"}));
|
||||
let h0 = frame(&s, id).height();
|
||||
// Space before on the second paragraph only: the frame grows by exactly that.
|
||||
s.execute("text.setFormat", &json!({"ids": [id.0], "spaceBefore": 30, "start": 4, "end": 4})).unwrap();
|
||||
let t = text(&s, id);
|
||||
assert_eq!((t.para_at(0).space_before, t.para_at(1).space_before), (0.0, 30.0));
|
||||
let h1 = frame(&s, id).height();
|
||||
assert!((h1 - h0 - 30.0).abs() < 1e-6, "{h0} → {h1}");
|
||||
assert_tight(&s, id, "space before");
|
||||
// Return in the spaced paragraph: the new one inherits the spacing, the frame follows.
|
||||
s.execute("text.editRange", &json!({"id": id.0, "start": 7, "end": 7, "insert": "\nThree"})).unwrap();
|
||||
let t = text(&s, id);
|
||||
assert_eq!(t.paragraph_styles().iter().map(|p| p.space_before).collect::<Vec<_>>(), [0.0, 30.0, 30.0]);
|
||||
assert!(frame(&s, id).height() > h1 + 30.0);
|
||||
assert_tight(&s, id, "three paragraphs");
|
||||
// Merging paragraphs: the first one's attributes win, the frame shrinks.
|
||||
s.execute("text.editRange", &json!({"id": id.0, "start": 3, "end": 4})).unwrap();
|
||||
let t = text(&s, id);
|
||||
assert_eq!(t.paragraph_styles().iter().map(|p| p.space_before).collect::<Vec<_>>(), [0.0, 30.0]);
|
||||
assert_tight(&s, id, "merged");
|
||||
undo(&mut s);
|
||||
undo(&mut s);
|
||||
assert!((frame(&s, id).height() - h1).abs() < 1e-9);
|
||||
undo(&mut s);
|
||||
assert!((frame(&s, id).height() - h0).abs() < 1e-9);
|
||||
assert!(text(&s, id).paras.is_empty(), "back to one style for all");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn auto_height_x_composer() {
|
||||
// Switching the composer of one paragraph rebreaks it; Auto Size follows either way.
|
||||
let mut s = session();
|
||||
let story = format!("{STORY} {STORY}\n{STORY}");
|
||||
let id = area(&mut s, 130.0, 100.0, &story, json!({"fit": "autoHeight"}));
|
||||
assert_tight(&s, id, "every-line");
|
||||
for composer in ["singleLine", "everyLine", "singleLine"] {
|
||||
s.execute("text.setFormat", &json!({"ids": [id.0], "composer": composer, "start": 0, "end": 0})).unwrap();
|
||||
let t = text(&s, id);
|
||||
assert_eq!(t.para_at(1).composer, Composer::EveryLine, "the second paragraph keeps its own");
|
||||
assert_tight(&s, id, composer);
|
||||
}
|
||||
s.execute("text.setFormat", &json!({"ids": [id.0], "composer": "singleLine"})).unwrap();
|
||||
s.execute("text.setStyle", &json!({"id": id.0, "justify": "justifyAll"})).unwrap();
|
||||
assert!(text(&s, id).paragraph_styles().iter().all(|p| p.composer == Composer::SingleLine && p.justify == Justify::JustifyAll));
|
||||
assert_tight(&s, id, "justified");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn auto_height_x_vertical_align() {
|
||||
// An Auto Size frame has no space to spare: every alignment sets the lines as Top does, and
|
||||
// the frame is as tall as with Top.
|
||||
let mut s = session();
|
||||
let id = area(&mut s, 160.0, 100.0, STORY, json!({"fit": "autoHeight"}));
|
||||
let top_frame = frame(&s, id);
|
||||
let top = lay(&text(&s, id));
|
||||
for a in ["center", "bottom", "justify"] {
|
||||
s.execute("text.areaOptions", &json!({"verticalAlign": a})).unwrap();
|
||||
assert_eq!(frame(&s, id), top_frame, "{a}");
|
||||
let l = lay(&text(&s, id));
|
||||
for (li, l0) in l.lines.iter().zip(&top.lines) {
|
||||
assert!((li.baseline - l0.baseline).abs() < 1e-6, "{a}: {} vs {}", li.baseline, l0.baseline);
|
||||
}
|
||||
assert_tight(&s, id, a);
|
||||
}
|
||||
// Editing with the alignment on keeps the frame tight.
|
||||
s.execute("text.editRange", &json!({"id": id.0, "start": 0, "end": 0, "insert": format!("{STORY} ")})).unwrap();
|
||||
assert_eq!(text(&s, id).area.vertical_align, VerticalAlign::Justify);
|
||||
assert_tight(&s, id, "longer, justified");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn shrink_text_x_inline_graphics_and_paragraphs() {
|
||||
let mut s = session();
|
||||
circle_symbol(&mut s, "Dot", 8.0);
|
||||
let id = area(&mut s, 160.0, 60.0, "Short rules.\nFlavor.", json!({"fit": "shrinkText", "fitMinPercent": 20}));
|
||||
assert_eq!(query(&mut s)["fitScale"], 1.0);
|
||||
// Inline art and per-paragraph spacing push it over; shrinking makes it fit.
|
||||
s.execute("text.setFormat", &json!({"ids": [id.0], "spaceBefore": 12, "start": 13, "end": 13})).unwrap();
|
||||
for i in 0..10 {
|
||||
s.execute("text.insertInline", &json!({"id": id.0, "at": 0, "symbol": "Dot", "scale": 1.0 + i as f64 * 0.2})).unwrap();
|
||||
s.execute("text.editRange", &json!({"id": id.0, "start": 0, "end": 0, "insert": "Add "})).unwrap();
|
||||
}
|
||||
let q = query(&mut s);
|
||||
assert_eq!(q["overflow"], false, "{q}");
|
||||
let f = q["fitScale"].as_f64().unwrap();
|
||||
assert!((0.2..1.0).contains(&f), "{f}");
|
||||
let t = text(&s, id);
|
||||
assert_eq!(t.paragraph_count(), 2);
|
||||
assert_eq!(t.para_at(1).space_before, 12.0, "inserting in the first paragraph keeps the second's attributes");
|
||||
assert_eq!(t.runs[0].style.size, 12.0, "the stored size stays");
|
||||
let l = lay(&t);
|
||||
assert_eq!(l.inlines.len(), 10);
|
||||
assert!(l.inlines.iter().all(|i| i.bounds.height() < 12.0 * 2.8 * f + 1e-6));
|
||||
// Undo walks the fit back up.
|
||||
for _ in 0..20 {
|
||||
undo(&mut s);
|
||||
}
|
||||
assert_eq!(query(&mut s)["fitScale"], 1.0);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn paragraph_attrs_x_inline_editing() {
|
||||
// An inline graphic opening a paragraph belongs to it: inserting it keeps the paragraph's
|
||||
// attributes, deleting it with the paragraph break merges into the paragraph before.
|
||||
let mut s = session();
|
||||
circle_symbol(&mut s, "Tap", 10.0);
|
||||
let id = area(&mut s, 300.0, 200.0, "Rules\nFlavor", json!({}));
|
||||
s.execute("text.setStyle", &json!({"id": id.0, "justify": "center", "start": 6, "end": 6})).unwrap();
|
||||
s.execute("text.setFormat", &json!({"ids": [id.0], "composer": "singleLine", "start": 6, "end": 6})).unwrap();
|
||||
s.execute("text.insertInline", &json!({"id": id.0, "at": 6, "symbol": "Tap"})).unwrap();
|
||||
let t = text(&s, id);
|
||||
assert_eq!(t.plain_text(), format!("Rules\n{INLINE_CHAR}Flavor"));
|
||||
assert_eq!((t.para_at(0).justify, t.para_at(1).justify), (Justify::Auto, Justify::Center));
|
||||
assert_eq!(t.para_at(1).composer, Composer::SingleLine);
|
||||
// The art's line is centred.
|
||||
let l = lay(&t);
|
||||
let g = &l.glyphs[l.inlines[0].glyph];
|
||||
let line = &l.lines[g.line];
|
||||
assert!(((line.x0 + line.x1) * 0.5 - 150.0).abs() < 1e-6, "centred in the 300 pt frame: {line:?}");
|
||||
assert!((l.inlines[0].bounds.x0 - g.origin.x).abs() < 1e-6);
|
||||
// Return just before the art: the new paragraph (holding the art) continues the centred one.
|
||||
s.execute("text.editRange", &json!({"id": id.0, "start": 6, "end": 6, "insert": "Text\n"})).unwrap();
|
||||
let t = text(&s, id);
|
||||
assert_eq!(t.paragraph_styles().iter().map(|p| p.justify).collect::<Vec<_>>(), [Justify::Auto, Justify::Center, Justify::Center]);
|
||||
undo(&mut s);
|
||||
// Delete the break and the art together: one paragraph, the first one's attributes.
|
||||
let end = 6 + INLINE_CHAR.len_utf8();
|
||||
s.execute("text.editRange", &json!({"id": id.0, "start": 5, "end": end})).unwrap();
|
||||
let t = text(&s, id);
|
||||
assert_eq!(t.plain_text(), "RulesFlavor");
|
||||
assert!(t.paras.is_empty() && t.para.justify == Justify::Auto && t.para.composer == Composer::EveryLine);
|
||||
assert!(t.runs.iter().all(|r| r.inline.is_none()));
|
||||
undo(&mut s);
|
||||
let t = text(&s, id);
|
||||
assert_eq!(t.plain_text(), format!("Rules\n{INLINE_CHAR}Flavor"));
|
||||
assert_eq!(t.para_at(1).justify, Justify::Center);
|
||||
assert_eq!(t.runs.iter().filter(|r| r.inline.is_some()).count(), 1);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn vertical_align_x_inline_graphics_in_the_document() {
|
||||
// The art the renderer draws (the layout's inline placements) moves with centred lines.
|
||||
let mut s = session();
|
||||
circle_symbol(&mut s, "Tap", 10.0);
|
||||
let id = area(&mut s, 300.0, 200.0, "Add one mana.", json!({}));
|
||||
s.execute("text.insertInline", &json!({"id": id.0, "at": 0, "symbol": "Tap"})).unwrap();
|
||||
let top = lay(&text(&s, id));
|
||||
s.execute("text.areaOptions", &json!({"verticalAlign": "center"})).unwrap();
|
||||
let l = lay(&text(&s, id));
|
||||
let d = l.lines[0].baseline - top.lines[0].baseline;
|
||||
assert!(d > 50.0, "{d}");
|
||||
assert!((l.inlines[0].bounds.y0 - top.inlines[0].bounds.y0 - d).abs() < 1e-6, "{:?} vs {:?}", l.inlines[0].bounds, top.inlines[0].bounds);
|
||||
// The cached bounds (hit testing, selection) include the moved art.
|
||||
let cached = text(&s, id).cached_bounds.unwrap();
|
||||
assert!(cached.contains(l.inlines[0].bounds.center()), "{cached:?}");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn every_feature_saves_and_reopens() {
|
||||
let mut s = session();
|
||||
circle_symbol(&mut s, "Tap", 10.0);
|
||||
let id = area(
|
||||
&mut s,
|
||||
220.0,
|
||||
70.0,
|
||||
&format!(": Add one mana of any color. {STORY}\n{STORY}"),
|
||||
json!({"verticalAlign": "center", "fit": "shrinkText", "fitMinPercent": 30}),
|
||||
);
|
||||
s.execute("text.insertInline", &json!({"id": id.0, "at": 0, "symbol": "Tap", "scale": 0.8, "shift": 0.5})).unwrap();
|
||||
let flavor = text(&s, id).plain_text().find('\n').unwrap() + 1;
|
||||
s.execute("text.setFormat", &json!({"ids": [id.0], "spaceBefore": 8, "composer": "singleLine", "start": flavor, "end": flavor})).unwrap();
|
||||
s.execute("text.setStyle", &json!({"id": id.0, "justify": "justifyAll", "start": flavor, "end": flavor})).unwrap();
|
||||
s.execute("text.setStyle", &json!({"id": id.0, "tracking": 20})).unwrap();
|
||||
let t = text(&s, id);
|
||||
let l = lay(&t);
|
||||
assert!(!l.overflow && l.fit_scale < 1.0, "{}", l.fit_scale);
|
||||
assert_eq!(l.inlines.len(), 1);
|
||||
let doc = s.doc().unwrap().doc.clone();
|
||||
let back = vectorcraft_format::load(&vectorcraft_format::save(&doc, false)).unwrap();
|
||||
let NodeKind::Text(t2) = &back.node(id).unwrap().kind else { panic!("not text") };
|
||||
let mut t2 = (**t2).clone();
|
||||
// Resolved art bounds and layout caches aren't saved: resolve them as opening does.
|
||||
back.resolve_text_inline(&mut t2);
|
||||
assert_eq!(t2.runs, t.runs);
|
||||
assert_eq!(t2.paragraph_styles(), t.paragraph_styles());
|
||||
assert_eq!(t2.area, t.area);
|
||||
let l2 = lay(&t2);
|
||||
assert_eq!((l2.fit_scale, l2.lines.len()), (l.fit_scale, l.lines.len()));
|
||||
assert_eq!(l2.inlines.iter().map(|i| i.bounds).collect::<Vec<_>>(), l.inlines.iter().map(|i| i.bounds).collect::<Vec<_>>());
|
||||
}
|
||||
@@ -223,6 +223,7 @@ impl Session {
|
||||
anchor_path_labels: self.prefs.anchor_path_labels,
|
||||
measurement_labels: self.prefs.measurement_labels,
|
||||
transform_tools_guides: self.prefs.transform_tools_guides,
|
||||
spacing_guides: self.prefs.spacing_guides,
|
||||
snapping_tolerance: self.prefs.snapping_tolerance,
|
||||
construction_angles: if self.prefs.construction_guides {
|
||||
vectorcraft_tools::guides::construction_angles(&self.prefs.construction_angles)
|
||||
|
||||
@@ -206,14 +206,17 @@ fn shrink_to_fit(db: &FontDb, t: &TextObject, opts: &LayoutOptions, min: f64) ->
|
||||
Some(best.unwrap_or_else(|| at(lo)))
|
||||
}
|
||||
|
||||
/// `t` with every run's size, explicit leading and baseline shift scaled by `f` (auto leading
|
||||
/// follows the size; paragraph spacing stays).
|
||||
/// `t` with every run's size, explicit leading and baseline shift scaled by `f`, inline art's own
|
||||
/// shift included (auto leading and the art's size follow the size; paragraph spacing stays).
|
||||
fn scaled(t: &TextObject, f: f64) -> TextObject {
|
||||
let mut s = t.clone();
|
||||
for r in &mut s.runs {
|
||||
r.style.size *= f;
|
||||
r.style.leading = r.style.leading.map(|l| l * f);
|
||||
r.style.baseline_shift *= f;
|
||||
if let Some(a) = &mut r.inline {
|
||||
a.baseline_shift *= f;
|
||||
}
|
||||
}
|
||||
s
|
||||
}
|
||||
@@ -595,6 +598,15 @@ fn align_vertically(cx: &mut Ctx<'_>, paras: &[Range<usize>], t: &TextObject, re
|
||||
g.origin.y += d;
|
||||
}
|
||||
}
|
||||
// Inline art moves with its glyph's line.
|
||||
for i in &mut cx.out.inlines {
|
||||
let d = cx.out.glyphs.get(i.glyph).and_then(|g| offs.get(g.line)).copied().unwrap_or(0.0);
|
||||
if d != 0.0 {
|
||||
let m = Affine::translate((0.0, d));
|
||||
i.xf = m * i.xf;
|
||||
i.bounds = m.transform_rect_bbox(i.bounds);
|
||||
}
|
||||
}
|
||||
return;
|
||||
}
|
||||
let laid_out = |out: &TextLayout| out.lines.last().map_or(0, |l| l.end);
|
||||
@@ -624,12 +636,17 @@ fn align_vertically(cx: &mut Ctx<'_>, paras: &[Range<usize>], t: &TextObject, re
|
||||
return;
|
||||
}
|
||||
let before = laid_out(&cx.out);
|
||||
let prev = (std::mem::take(&mut cx.out.glyphs), std::mem::take(&mut cx.out.lines), std::mem::replace(&mut cx.out.overflow, false));
|
||||
let prev = (
|
||||
std::mem::take(&mut cx.out.glyphs),
|
||||
std::mem::take(&mut cx.out.lines),
|
||||
std::mem::take(&mut cx.out.inlines),
|
||||
std::mem::replace(&mut cx.out.overflow, false),
|
||||
);
|
||||
flow(cx, paras, t, Some(regions));
|
||||
if laid_out(&cx.out) < before {
|
||||
// Text no longer fits (lines got narrower, or flow around a wrap object): undo the
|
||||
// pass and try a smaller step.
|
||||
(cx.out.glyphs, cx.out.lines, cx.out.overflow) = prev;
|
||||
(cx.out.glyphs, cx.out.lines, cx.out.inlines, cx.out.overflow) = prev;
|
||||
for (r, (shift, gap)) in regions.iter_mut().zip(saved) {
|
||||
r.shift = shift;
|
||||
r.gap = gap;
|
||||
|
||||
@@ -502,6 +502,8 @@ mod tests;
|
||||
#[cfg(test)]
|
||||
mod tests_bidi;
|
||||
#[cfg(test)]
|
||||
mod tests_combos;
|
||||
#[cfg(test)]
|
||||
mod tests_embed;
|
||||
#[cfg(test)]
|
||||
mod tests_fit;
|
||||
|
||||
@@ -0,0 +1,574 @@
|
||||
//! The text engine's newer features combined, two at a time and all together: ligatures under
|
||||
//! tracking, the paragraph composer, area type vertical alignment, Shrink Text to Fit,
|
||||
//! per-paragraph attributes and inline graphics. Each feature has its own tests; these check that
|
||||
//! one doesn't undo or skip another (as vertical alignment once left inline art behind).
|
||||
|
||||
use super::*;
|
||||
use kurbo::Shape;
|
||||
use vectorcraft_doc::{AreaFit, CharStyle, Composer, InlineArt, Justify, TextKind, TextRun, VerticalAlign};
|
||||
use vectorcraft_geom::PathData;
|
||||
|
||||
const COPY: &str = "Typography is the craft of arranging type to make written language legible, readable and appealing when displayed. \
|
||||
The arrangement of type involves selecting typefaces, point sizes, line lengths, line spacing and letter spacing.";
|
||||
|
||||
/// Words full of `fi` (Source Serif 4 ligates it).
|
||||
const FI: &str = "fine fish finish first in fifty fields of fireflies, a fitting finale for the final fiddler";
|
||||
|
||||
/// Two lines that single-line and every-line composers break differently (see
|
||||
/// `every_line_composer_balances_ragged_lines`).
|
||||
const RAG: &str = "Destroy all creatures with toughness X or less.";
|
||||
|
||||
fn db() -> &'static FontDb {
|
||||
FontDb::global()
|
||||
}
|
||||
|
||||
fn sans(size: f64) -> CharStyle {
|
||||
CharStyle { size, ..CharStyle::default() }
|
||||
}
|
||||
|
||||
fn serif(size: f64, tracking: f64) -> CharStyle {
|
||||
CharStyle { font_family: "Source Serif 4".into(), size, tracking, ..CharStyle::default() }
|
||||
}
|
||||
|
||||
fn run(text: &str, style: CharStyle) -> TextRun {
|
||||
TextRun::new(text, style)
|
||||
}
|
||||
|
||||
/// A square symbol, `scale` × the run's size tall, raised `shift` points.
|
||||
fn art(scale: f64, shift: f64) -> InlineArt {
|
||||
InlineArt { scale, baseline_shift: shift, bounds: Some(Rect::new(-5.0, -5.0, 5.0, 5.0)), ..InlineArt::new("sym") }
|
||||
}
|
||||
|
||||
fn sym(scale: f64, shift: f64, style: CharStyle) -> TextRun {
|
||||
TextRun::inline(art(scale, shift), style)
|
||||
}
|
||||
|
||||
/// Area type in `frame` holding `runs`.
|
||||
fn area(runs: Vec<TextRun>, frame: Rect) -> TextObject {
|
||||
let mut t = TextObject::point(Point::ZERO, "", sans(12.0));
|
||||
t.runs = runs;
|
||||
t.kind = TextKind::Area { frame: PathData::from_bezpath(&frame.to_path(0.1)) };
|
||||
t.xf = Affine::IDENTITY;
|
||||
t
|
||||
}
|
||||
|
||||
/// `t` as Shrink Text to Fit lays it out at factor `f`, without fitting: sizes, explicit leading
|
||||
/// and baseline shifts scaled (inline art's own shift too), paragraph spacing kept.
|
||||
fn scaled_by(t: &TextObject, f: f64) -> TextObject {
|
||||
let mut s = t.clone();
|
||||
s.area.fit = AreaFit::None;
|
||||
for r in &mut s.runs {
|
||||
r.style.size *= f;
|
||||
r.style.leading = r.style.leading.map(|l| l * f);
|
||||
r.style.baseline_shift *= f;
|
||||
if let Some(a) = &mut r.inline {
|
||||
a.baseline_shift *= f;
|
||||
}
|
||||
}
|
||||
s
|
||||
}
|
||||
|
||||
fn line_texts(t: &TextObject, l: &TextLayout) -> Vec<String> {
|
||||
let text = t.plain_text();
|
||||
l.lines.iter().map(|li| text[li.start..li.end].trim_end().to_string()).collect()
|
||||
}
|
||||
|
||||
/// Ligature clusters: glyphs standing for more than one character.
|
||||
fn ligatures(l: &TextLayout) -> usize {
|
||||
l.glyphs.iter().filter(|g| g.len > 1 && !g.outline.elements().is_empty()).count()
|
||||
}
|
||||
|
||||
/// Every inline graphic drawn once, where its glyph is: left edge on the glyph's origin, the
|
||||
/// scaled height, centred half the (scaled) cap height above the glyph's baseline plus its own
|
||||
/// (scaled) shift.
|
||||
fn assert_inlines_on_their_glyphs(t: &TextObject, l: &TextLayout, what: &str) {
|
||||
let want = t.runs.iter().filter(|r| r.inline.is_some()).count();
|
||||
assert_eq!(l.inlines.len(), want, "{what}: one placement per inline run");
|
||||
let mut glyphs: Vec<usize> = l.inlines.iter().map(|i| i.glyph).collect();
|
||||
glyphs.dedup();
|
||||
assert_eq!(glyphs.len(), want, "{what}: no inline drawn twice");
|
||||
for i in &l.inlines {
|
||||
let g = &l.glyphs[i.glyph];
|
||||
assert_eq!(g.run, i.run, "{what}");
|
||||
let r = &t.runs[i.run];
|
||||
let a = r.inline.as_ref().unwrap();
|
||||
let size = r.style.size * l.fit_scale;
|
||||
let face = db().face(&r.style.font_family, &r.style.font_style).unwrap();
|
||||
let cap = face.cap_height * size / face.upem;
|
||||
let b = i.bounds;
|
||||
assert!((b.height() - a.scale * size).abs() < 1e-6, "{what}: height {} vs {}", b.height(), a.scale * size);
|
||||
assert!((b.x0 - g.origin.x).abs() < 1e-6, "{what}: {b:?} vs origin {:?}", g.origin);
|
||||
let centre = g.origin.y - cap * 0.5 - a.baseline_shift * l.fit_scale;
|
||||
assert!((b.center().y - centre).abs() < 1e-6, "{what}: centre {} vs {centre} (line {})", b.center().y, g.line);
|
||||
assert!(l.lines[g.line].glyph_start <= i.glyph && i.glyph < l.lines[g.line].glyph_end, "{what}");
|
||||
assert!(l.bounds.contains(b.center()), "{what}: layout bounds {:?} miss {b:?}", l.bounds);
|
||||
}
|
||||
}
|
||||
|
||||
/// Space left below the last line of a one-cell frame.
|
||||
fn slack(l: &TextLayout, frame: Rect) -> f64 {
|
||||
let last = l.lines.last().unwrap();
|
||||
frame.y1 - (last.baseline + last.descent)
|
||||
}
|
||||
|
||||
fn baselines(l: &TextLayout) -> Vec<f64> {
|
||||
l.lines.iter().map(|li| li.baseline).collect()
|
||||
}
|
||||
|
||||
// ---------- ligatures under tracking × … ----------
|
||||
|
||||
#[test]
|
||||
fn ligatures_x_composer() {
|
||||
// Justified (where every-line spreads word space) and ragged, with tracking inside the limits
|
||||
// (kept) and letterspaced (dropped), whichever composer breaks the lines.
|
||||
for justify in [Justify::Left, Justify::JustifyLeft] {
|
||||
for (tracking, kept) in [(0.0, true), (20.0, true), (100.0, false)] {
|
||||
let mut counts = vec![];
|
||||
for composer in [Composer::SingleLine, Composer::EveryLine] {
|
||||
let mut t = area(vec![run(&FI.repeat(3), serif(12.0, tracking))], Rect::new(0.0, 0.0, 170.0, 1000.0));
|
||||
t.para.justify = justify;
|
||||
t.para.composer = composer;
|
||||
let l = layout(db(), &t);
|
||||
assert!(l.lines.len() > 3, "several lines to compose");
|
||||
counts.push(ligatures(&l));
|
||||
}
|
||||
assert_eq!(counts[0], counts[1], "{justify:?} {tracking}: composers shape alike");
|
||||
assert_eq!(counts[0] > 0, kept, "{justify:?} {tracking}: {counts:?}");
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn ligatures_x_vertical_align() {
|
||||
let frame = Rect::new(0.0, 0.0, 200.0, 400.0);
|
||||
for tracking in [20.0, 100.0] {
|
||||
let mut t = area(vec![run(FI, serif(12.0, tracking))], frame);
|
||||
let top = layout(db(), &t);
|
||||
for a in [VerticalAlign::Center, VerticalAlign::Bottom, VerticalAlign::Justify] {
|
||||
t.area.vertical_align = a;
|
||||
let l = layout(db(), &t);
|
||||
let gids = |l: &TextLayout| l.glyphs.iter().map(|g| (g.gid, g.byte)).collect::<Vec<_>>();
|
||||
assert_eq!(gids(&l), gids(&top), "{tracking} {a:?}: moving lines doesn't reshape them");
|
||||
assert!(l.lines[0].baseline > top.lines[0].baseline + 1.0 || a == VerticalAlign::Justify, "{a:?}");
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn ligatures_x_shrink_text() {
|
||||
// Tracking is in 1/1000 em, so scaling the size doesn't move it across the limits.
|
||||
let frame = Rect::new(0.0, 0.0, 150.0, 60.0);
|
||||
for (tracking, features, kept) in [(40.0, vec![], true), (100.0, vec![], false), (100.0, vec!["liga".to_string()], true)] {
|
||||
let st = CharStyle { features, ..serif(14.0, tracking) };
|
||||
let mut t = area(vec![run(&FI.repeat(2), st)], frame);
|
||||
t.area.fit = AreaFit::ShrinkText { min_percent: 10.0 };
|
||||
let l = layout(db(), &t);
|
||||
assert!(!l.overflow && l.fit_scale < 1.0, "{tracking}: {}", l.fit_scale);
|
||||
assert_eq!(ligatures(&l) > 0, kept, "{tracking}");
|
||||
assert_eq!(ligatures(&l), ligatures(&layout(db(), &scaled_by(&t, l.fit_scale))), "{tracking}");
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn ligatures_x_paragraph_attrs() {
|
||||
// Paragraph attributes don't touch shaping: a centred, indented, every-line paragraph keeps
|
||||
// its ligatures and a letterspaced run in the next paragraph loses them.
|
||||
let mut t = area(vec![run(&format!("{FI}\n"), serif(12.0, 10.0)), run(FI, serif(12.0, 120.0))], Rect::new(0.0, 0.0, 240.0, 600.0));
|
||||
let mut second = t.para.clone();
|
||||
second.justify = Justify::Center;
|
||||
second.left_indent = 20.0;
|
||||
second.space_before = 12.0;
|
||||
t.set_paragraph_styles(vec![t.para.clone(), second]);
|
||||
let l = layout(db(), &t);
|
||||
let split = FI.len() + 1;
|
||||
let ligs = |first: bool| l.glyphs.iter().filter(|g| g.len > 1 && (g.byte < split) == first).count();
|
||||
assert!(ligs(true) > 0, "tracking 10 keeps them");
|
||||
assert_eq!(ligs(false), 0, "tracking 120 drops them");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn ligatures_x_inline_graphics() {
|
||||
// An inline graphic between ligated words neither breaks their ligatures nor takes them: its
|
||||
// own letterspaced run tracks the art without touching its neighbours.
|
||||
let st = serif(14.0, 0.0);
|
||||
let runs = vec![run("fine fish ", st.clone()), sym(1.0, 0.0, serif(14.0, 200.0)), run(" first fifty", st.clone())];
|
||||
let t = area(runs, Rect::new(0.0, 0.0, 400.0, 100.0));
|
||||
let l = layout(db(), &t);
|
||||
let without = area(vec![run("fine fish ", st.clone()), run(" first fifty", st.clone())], Rect::new(0.0, 0.0, 400.0, 100.0));
|
||||
assert_eq!(ligatures(&l), ligatures(&layout(db(), &without)), "the same ligatures as without the art");
|
||||
assert!(ligatures(&l) >= 4, "fi in fine, fish, first and fifty");
|
||||
assert_inlines_on_their_glyphs(&t, &l, "between ligatures");
|
||||
let g = &l.glyphs[l.inlines[0].glyph];
|
||||
assert!((g.advance - (14.0 + 200.0 / 1000.0 * 14.0)).abs() < 1e-6, "art width plus its tracking: {}", g.advance);
|
||||
}
|
||||
|
||||
// ---------- composer × … ----------
|
||||
|
||||
#[test]
|
||||
fn composer_x_vertical_align() {
|
||||
let w = natural_width(RAG, 12.0) * 0.9;
|
||||
let frame = Rect::new(0.0, 0.0, w, 200.0);
|
||||
for composer in [Composer::SingleLine, Composer::EveryLine] {
|
||||
let mut t = area(vec![run(RAG, sans(12.0))], frame);
|
||||
t.para.composer = composer;
|
||||
let top = layout(db(), &t);
|
||||
for a in [VerticalAlign::Center, VerticalAlign::Bottom, VerticalAlign::Justify] {
|
||||
t.area.vertical_align = a;
|
||||
let l = layout(db(), &t);
|
||||
assert_eq!(line_texts(&t, &l), line_texts(&t, &top), "{composer:?} {a:?}: the same breaks");
|
||||
let want = match a {
|
||||
VerticalAlign::Center => slack(&top, frame) * 0.5,
|
||||
_ => slack(&top, frame),
|
||||
};
|
||||
let moved = l.lines.last().unwrap().baseline - top.lines.last().unwrap().baseline;
|
||||
assert!((moved - want).abs() < 1e-6, "{composer:?} {a:?}: last line moved {moved}, want {want}");
|
||||
}
|
||||
}
|
||||
// And the two composers still differ there.
|
||||
let breaks = |c: Composer| {
|
||||
let mut t = area(vec![run(RAG, sans(12.0))], frame);
|
||||
t.para.composer = c;
|
||||
t.area.vertical_align = VerticalAlign::Center;
|
||||
line_texts(&t, &layout(db(), &t))
|
||||
};
|
||||
assert_ne!(breaks(Composer::SingleLine), breaks(Composer::EveryLine));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn composer_x_shrink_text() {
|
||||
// Each composer shrinks to the largest size at which its own breaks fit.
|
||||
for justify in [Justify::Left, Justify::JustifyLeft] {
|
||||
for composer in [Composer::SingleLine, Composer::EveryLine] {
|
||||
let mut t = area(vec![run(COPY, sans(14.0))], Rect::new(0.0, 0.0, 180.0, 90.0));
|
||||
t.para.composer = composer;
|
||||
t.para.justify = justify;
|
||||
t.area.fit = AreaFit::ShrinkText { min_percent: 20.0 };
|
||||
let l = layout(db(), &t);
|
||||
assert!(!l.overflow && l.fit_scale < 1.0, "{justify:?} {composer:?}");
|
||||
let size = 14.0 * l.fit_scale;
|
||||
assert!(layout(db(), &scaled_by(&t, (size + 0.1) / 14.0)).overflow, "{justify:?} {composer:?}: maximal at {size}");
|
||||
let same = layout(db(), &scaled_by(&t, l.fit_scale));
|
||||
assert_eq!(line_texts(&t, &same), line_texts(&t, &l), "{justify:?} {composer:?}");
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn composer_x_paragraph_attrs() {
|
||||
// Each paragraph breaks with its own composer.
|
||||
let w = natural_width("Destroy all creatures with toughness X or", 12.0) + 2.0;
|
||||
let mut t = area(vec![run(&format!("{RAG}\n{RAG}\n{RAG}"), sans(12.0))], Rect::new(0.0, 0.0, w, 400.0));
|
||||
let p = |c: Composer| vectorcraft_doc::ParaStyle { composer: c, ..t.para.clone() };
|
||||
t.set_paragraph_styles(vec![p(Composer::SingleLine), p(Composer::EveryLine), p(Composer::SingleLine)]);
|
||||
let l = layout(db(), &t);
|
||||
let greedy = ["Destroy all creatures with toughness X or", "less."];
|
||||
let every = ["Destroy all creatures with toughness X", "or less."];
|
||||
let want: Vec<&str> = [greedy, every, greedy].concat();
|
||||
assert_eq!(line_texts(&t, &l), want);
|
||||
// The object-wide override still wins over every paragraph.
|
||||
let forced = layout_with(db(), &t, &LayoutOptions { composer: Some(Composer::SingleLine), ..Default::default() });
|
||||
assert_eq!(line_texts(&t, &forced), [greedy, greedy, greedy].concat());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn composer_x_inline_graphics() {
|
||||
// An inline graphic is a word's worth of box to the composers: each one breaks around it as
|
||||
// around the letter it replaces, and the art follows its glyph to whichever line it lands on.
|
||||
let st = sans(12.0);
|
||||
let runs = |x: TextRun| vec![run("Destroy all creatures with toughness ", st.clone()), x, run(" or less.", st.clone())];
|
||||
let with_art = runs(sym(0.7, 0.0, st.clone()));
|
||||
let mut probe = area(with_art.clone(), Rect::new(0.0, 0.0, 10_000.0, 100.0));
|
||||
probe.runs.truncate(2);
|
||||
probe.runs.push(run(" or", st.clone()));
|
||||
let w = layout(db(), &probe).lines[0].x1 + 2.0;
|
||||
let sym_text = INLINE.to_string();
|
||||
for (composer, first, second) in [
|
||||
(Composer::SingleLine, format!("Destroy all creatures with toughness {sym_text} or"), "less."),
|
||||
(Composer::EveryLine, format!("Destroy all creatures with toughness {sym_text}"), "or less."),
|
||||
] {
|
||||
let mut t = area(with_art.clone(), Rect::new(0.0, 0.0, w, 200.0));
|
||||
t.para.composer = composer;
|
||||
let l = layout(db(), &t);
|
||||
assert_eq!(line_texts(&t, &l), [first.as_str(), second], "{composer:?}");
|
||||
assert_inlines_on_their_glyphs(&t, &l, &format!("{composer:?}"));
|
||||
}
|
||||
}
|
||||
|
||||
const INLINE: char = vectorcraft_doc::text::INLINE_CHAR;
|
||||
|
||||
// ---------- vertical alignment × … ----------
|
||||
|
||||
#[test]
|
||||
fn vertical_align_x_shrink_text() {
|
||||
let frame = Rect::new(0.0, 0.0, 200.0, 100.0);
|
||||
let mut t = area(vec![run(©.repeat(2), sans(14.0))], frame);
|
||||
t.area.fit = AreaFit::ShrinkText { min_percent: 10.0 };
|
||||
let top = layout(db(), &t);
|
||||
assert!(!top.overflow && top.fit_scale < 1.0);
|
||||
for a in [VerticalAlign::Center, VerticalAlign::Bottom] {
|
||||
t.area.vertical_align = a;
|
||||
let l = layout(db(), &t);
|
||||
assert_eq!(l.fit_scale, top.fit_scale, "{a:?}: aligning doesn't change the fit");
|
||||
assert_eq!(line_texts(&t, &l), line_texts(&t, &top), "{a:?}");
|
||||
let want = if a == VerticalAlign::Center { slack(&top, frame) * 0.5 } else { slack(&top, frame) };
|
||||
for (b, b0) in baselines(&l).iter().zip(baselines(&top)) {
|
||||
assert!((b - b0 - want).abs() < 1e-6, "{a:?}: {b} vs {b0} + {want}");
|
||||
}
|
||||
if a == VerticalAlign::Bottom {
|
||||
assert!(slack(&l, frame).abs() < 1e-6, "the shrunk block sits on the bottom");
|
||||
}
|
||||
}
|
||||
// Still overflowing at the minimum: aligned like any full frame (the same lines, moved by
|
||||
// less than a line, inside the frame), at the same scale.
|
||||
let frame = Rect::new(0.0, 0.0, 120.0, 40.0);
|
||||
let mut t = area(vec![run(©.repeat(4), sans(14.0))], frame);
|
||||
t.area.fit = AreaFit::ShrinkText { min_percent: 90.0 };
|
||||
let top = layout(db(), &t);
|
||||
assert!(top.overflow && (top.fit_scale - 0.9).abs() < 1e-9);
|
||||
for a in [VerticalAlign::Center, VerticalAlign::Bottom, VerticalAlign::Justify] {
|
||||
t.area.vertical_align = a;
|
||||
let l = layout(db(), &t);
|
||||
assert!(l.overflow && l.fit_scale == top.fit_scale, "{a:?}");
|
||||
assert_eq!(line_texts(&t, &l), line_texts(&t, &top), "{a:?}");
|
||||
let first = &top.lines[0];
|
||||
assert!(l.lines[0].baseline - first.baseline < first.ascent + first.descent, "{a:?}");
|
||||
assert!(slack(&l, frame) >= -1e-6, "{a:?}");
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn vertical_align_x_paragraph_attrs() {
|
||||
// Per-paragraph spacing and alignment survive the move: lines keep their x and their
|
||||
// paragraph gaps, and the block lands where the alignment puts it.
|
||||
let frame = Rect::new(0.0, 0.0, 260.0, 500.0);
|
||||
let mut t = area(vec![run(&format!("{COPY}\n{COPY}\n{COPY}"), sans(11.0))], frame);
|
||||
let mut mid = t.para.clone();
|
||||
mid.justify = Justify::Center;
|
||||
mid.space_before = 18.0;
|
||||
mid.left_indent = 24.0;
|
||||
let mut last = t.para.clone();
|
||||
last.justify = Justify::Right;
|
||||
last.space_before = 6.0;
|
||||
t.set_paragraph_styles(vec![t.para.clone(), mid, last]);
|
||||
let top = layout(db(), &t);
|
||||
for a in [VerticalAlign::Center, VerticalAlign::Bottom] {
|
||||
t.area.vertical_align = a;
|
||||
let l = layout(db(), &t);
|
||||
assert_eq!(line_texts(&t, &l), line_texts(&t, &top));
|
||||
let d = l.lines[0].baseline - top.lines[0].baseline;
|
||||
assert!(d > 1.0, "{a:?}");
|
||||
for (li, l0) in l.lines.iter().zip(&top.lines) {
|
||||
assert!((li.baseline - l0.baseline - d).abs() < 1e-6, "{a:?}: every line moves alike");
|
||||
assert!((li.x0 - l0.x0).abs() < 1e-6 && (li.x1 - l0.x1).abs() < 1e-6, "{a:?}: x stays");
|
||||
}
|
||||
for (g, g0) in l.glyphs.iter().zip(&top.glyphs) {
|
||||
assert!((g.origin.x - g0.origin.x).abs() < 1e-6 && (g.origin.y - g0.origin.y - d).abs() < 1e-6);
|
||||
}
|
||||
}
|
||||
// Justify: spacing is shared out on top of each paragraph's own space before, never less.
|
||||
t.area.vertical_align = VerticalAlign::Justify;
|
||||
let l = layout(db(), &t);
|
||||
assert!(slack(&l, frame).abs() < 1e-6, "justified to the bottom");
|
||||
for (pair, pair0) in l.lines.windows(2).zip(top.lines.windows(2)) {
|
||||
assert!(pair[1].baseline - pair[0].baseline >= pair0[1].baseline - pair0[0].baseline - 1e-6);
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn vertical_align_x_inline_graphics() {
|
||||
// Inline art moves with its line however the lines are aligned, in one cell or several, in a
|
||||
// rectangle or a frame the text flows into again.
|
||||
let st = sans(12.0);
|
||||
let mut runs = vec![];
|
||||
for i in 0..6 {
|
||||
runs.push(run(&format!("{} ", ©[i * 20..i * 20 + 20]), st.clone()));
|
||||
runs.push(sym(1.0 + i as f64 * 0.1, i as f64 - 2.0, st.clone()));
|
||||
if i == 2 {
|
||||
runs.push(run("\n", st.clone()));
|
||||
}
|
||||
}
|
||||
let mut tri = BezPath::new();
|
||||
tri.move_to((0.0, 0.0));
|
||||
tri.line_to((600.0, 0.0));
|
||||
tri.line_to((300.0, 400.0));
|
||||
tri.close_path();
|
||||
for (name, frame, columns) in [
|
||||
("rect", Rect::new(0.0, 0.0, 160.0, 400.0).to_path(0.1), 1),
|
||||
("columns", Rect::new(0.0, 0.0, 400.0, 300.0).to_path(0.1), 2),
|
||||
("triangle", tri, 1),
|
||||
] {
|
||||
for a in VerticalAlign::ALL {
|
||||
let mut t = area(runs.clone(), Rect::ZERO);
|
||||
t.kind = TextKind::Area { frame: PathData::from_bezpath(&frame) };
|
||||
t.area.columns = columns;
|
||||
t.area.vertical_align = a;
|
||||
let l = layout(db(), &t);
|
||||
assert!(!l.overflow, "{name} {a:?}");
|
||||
assert_inlines_on_their_glyphs(&t, &l, &format!("{name} {a:?}"));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// ---------- Shrink Text to Fit × … ----------
|
||||
|
||||
#[test]
|
||||
fn shrink_text_x_paragraph_attrs() {
|
||||
// Shrinking scales the type, not each paragraph's spacing and indents: the fitted layout is
|
||||
// the unfitted one at the scaled size.
|
||||
let mut t = area(vec![run(&format!("{COPY}\n{COPY}"), sans(13.0))], Rect::new(0.0, 0.0, 220.0, 160.0));
|
||||
let mut second = t.para.clone();
|
||||
second.space_before = 14.0;
|
||||
second.left_indent = 30.0;
|
||||
second.first_line_indent = 12.0;
|
||||
second.justify = Justify::JustifyLeft;
|
||||
second.composer = Composer::SingleLine;
|
||||
t.set_paragraph_styles(vec![t.para.clone(), second]);
|
||||
t.area.fit = AreaFit::ShrinkText { min_percent: 10.0 };
|
||||
let l = layout(db(), &t);
|
||||
assert!(!l.overflow && l.fit_scale < 1.0);
|
||||
let same = layout(db(), &scaled_by(&t, l.fit_scale));
|
||||
assert_eq!(baselines(&l), baselines(&same));
|
||||
assert_eq!(line_texts(&t, &l), line_texts(&t, &same));
|
||||
// The second paragraph's indents are unscaled points.
|
||||
let split = COPY.len() + 1;
|
||||
let first_of_second = l.lines.iter().find(|li| li.start == split).unwrap();
|
||||
assert!((first_of_second.x0 - 42.0).abs() < 1e-6, "{}", first_of_second.x0);
|
||||
assert!(l.lines.iter().filter(|li| li.start > split).all(|li| (li.x0 - 30.0).abs() < 1e-6));
|
||||
// A paragraph's space before alone can make the text overflow; shrinking still finds a fit.
|
||||
let mut tall = t.clone();
|
||||
tall.edit_paras(Some(1..2), |p| p.space_before = 100.0);
|
||||
let l = layout(db(), &tall);
|
||||
assert!(!l.overflow && l.fit_scale < layout(db(), &t).fit_scale);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn shrink_text_x_inline_graphics() {
|
||||
// Inline art shrinks with the type, its shift included, and stays centred on the cap height.
|
||||
let st = sans(14.0);
|
||||
let mut runs = vec![];
|
||||
for i in 0..8 {
|
||||
runs.push(run(©[i * 25..i * 25 + 25], st.clone()));
|
||||
runs.push(sym(1.2, 1.5, st.clone()));
|
||||
}
|
||||
let mut t = area(runs, Rect::new(0.0, 0.0, 200.0, 80.0));
|
||||
t.area.fit = AreaFit::ShrinkText { min_percent: 10.0 };
|
||||
let l = layout(db(), &t);
|
||||
assert!(!l.overflow && l.fit_scale < 1.0, "{}", l.fit_scale);
|
||||
assert_inlines_on_their_glyphs(&t, &l, "shrunk");
|
||||
let same = layout(db(), &scaled_by(&t, l.fit_scale));
|
||||
for (i, i0) in l.inlines.iter().zip(&same.inlines) {
|
||||
assert!((i.bounds.y0 - i0.bounds.y0).abs() < 1e-6 && (i.bounds.x0 - i0.bounds.x0).abs() < 1e-6, "{:?} vs {:?}", i.bounds, i0.bounds);
|
||||
}
|
||||
// Large art makes lines taller; shrinking still fits it.
|
||||
for r in &mut t.runs {
|
||||
if let Some(a) = &mut r.inline {
|
||||
a.scale = 3.0;
|
||||
}
|
||||
}
|
||||
let big = layout(db(), &t);
|
||||
assert!(!big.overflow && big.fit_scale < l.fit_scale);
|
||||
assert_inlines_on_their_glyphs(&t, &big, "shrunk, big art");
|
||||
}
|
||||
|
||||
// ---------- paragraph attributes × inline graphics ----------
|
||||
|
||||
#[test]
|
||||
fn paragraph_attrs_x_inline_graphics() {
|
||||
// Inline art in paragraphs of each alignment and indent sits on its glyph, and an inline
|
||||
// graphic opening a paragraph takes that paragraph's first-line indent.
|
||||
let st = sans(12.0);
|
||||
let runs = vec![
|
||||
run("Left aligned ", st.clone()),
|
||||
sym(1.0, 0.0, st.clone()),
|
||||
run(" text.\n", st.clone()),
|
||||
sym(1.0, 0.0, st.clone()),
|
||||
run(" centred with art first\nright ", st.clone()),
|
||||
sym(1.5, -1.0, st.clone()),
|
||||
run(" aligned\nfull justified text with ", st.clone()),
|
||||
sym(1.0, 0.0, st.clone()),
|
||||
run(" in the middle of a long line that wraps", st.clone()),
|
||||
];
|
||||
let mut t = area(runs, Rect::new(0.0, 0.0, 200.0, 400.0));
|
||||
let base = t.para.clone();
|
||||
let with = |j: Justify, first: f64| vectorcraft_doc::ParaStyle { justify: j, first_line_indent: first, left_indent: 6.0, ..base.clone() };
|
||||
t.set_paragraph_styles(vec![base.clone(), with(Justify::Center, 0.0), with(Justify::Right, 0.0), with(Justify::JustifyLeft, 18.0)]);
|
||||
let l = layout(db(), &t);
|
||||
assert_inlines_on_their_glyphs(&t, &l, "paragraphs");
|
||||
let opening = &l.glyphs[l.inlines[1].glyph];
|
||||
let line = &l.lines[opening.line];
|
||||
assert!((opening.origin.x - line.x0).abs() < 1e-6, "the art opens its line");
|
||||
assert!(((line.x0 + line.x1) * 0.5 - (6.0 + 200.0) * 0.5).abs() < 1e-6, "the centred paragraph: {line:?}");
|
||||
let right = &l.lines[l.glyphs[l.inlines[2].glyph].line];
|
||||
assert!((right.x1 - 200.0).abs() < 1e-6, "{right:?}");
|
||||
let full = l.lines.iter().find(|li| li.start == t.plain_text().find("full").unwrap()).unwrap();
|
||||
assert!((full.x0 - 24.0).abs() < 1e-6, "left indent + first-line indent: {full:?}");
|
||||
}
|
||||
|
||||
// ---------- all of them ----------
|
||||
|
||||
/// One area type object with everything on: two paragraphs with their own attributes (the first
|
||||
/// ragged every-line with inline symbols and lightly tracked ligatures, the second single-line,
|
||||
/// justified and spaced away), centred vertically, shrunk to fit.
|
||||
#[test]
|
||||
fn every_feature_at_once() {
|
||||
let rules = serif(14.0, 15.0);
|
||||
let flavor = CharStyle { font_style: "Italic".into(), ..serif(14.0, 0.0) };
|
||||
let mut runs = vec![];
|
||||
for (i, words) in
|
||||
["Sacrifice a fine fish", "First strike. When this finishes fighting, draw a card", "Fifty fireflies fill the field"].iter().enumerate()
|
||||
{
|
||||
runs.push(sym(0.8, 0.0, rules.clone()));
|
||||
runs.push(run(&format!(": {words}. "), rules.clone()));
|
||||
if i == 1 {
|
||||
runs.push(sym(0.8, 0.5, rules.clone()));
|
||||
runs.push(run(" Then fight again.", rules.clone()));
|
||||
}
|
||||
}
|
||||
runs.push(run("\nThe finest fishers find their fortune in the fjords, if they first fix their nets.", flavor));
|
||||
let frame = Rect::new(0.0, 0.0, 240.0, 110.0);
|
||||
let mut t = area(runs, frame);
|
||||
let mut flav = t.para.clone();
|
||||
flav.space_before = 10.0;
|
||||
flav.justify = Justify::JustifyLeft;
|
||||
flav.composer = Composer::SingleLine;
|
||||
t.para.composer = Composer::EveryLine;
|
||||
t.set_paragraph_styles(vec![t.para.clone(), flav]);
|
||||
t.area.fit = AreaFit::ShrinkText { min_percent: 30.0 };
|
||||
|
||||
let top = layout(db(), &t);
|
||||
t.area.vertical_align = VerticalAlign::Center;
|
||||
let l = layout(db(), &t);
|
||||
assert!(!l.overflow && l.fit_scale < 1.0, "{}", l.fit_scale);
|
||||
assert_eq!(l.fit_scale, top.fit_scale);
|
||||
// Shrunk: the same as laying out the scaled text, then centring it.
|
||||
let mut unfit = scaled_by(&t, l.fit_scale);
|
||||
unfit.area.vertical_align = VerticalAlign::Top;
|
||||
let plain = layout(db(), &unfit);
|
||||
assert_eq!(line_texts(&t, &l), line_texts(&t, &plain));
|
||||
let d = slack(&plain, frame) * 0.5;
|
||||
assert!(d > 0.0);
|
||||
for (b, b0) in baselines(&l).iter().zip(baselines(&plain)) {
|
||||
assert!((b - b0 - d).abs() < 1e-6, "centred: {b} vs {b0} + {d}");
|
||||
}
|
||||
// Every symbol on its glyph; ligatures kept at tracking 15.
|
||||
assert_inlines_on_their_glyphs(&t, &l, "everything");
|
||||
assert_eq!(l.inlines.len(), 4);
|
||||
assert!(ligatures(&l) >= 6, "{}", ligatures(&l));
|
||||
// The flavor paragraph: justified (all but its last line fill the measure) and spaced away.
|
||||
let split = t.plain_text().find('\n').unwrap() + 1;
|
||||
let flavor_lines: Vec<&LineInfo> = l.lines.iter().filter(|li| li.start >= split).collect();
|
||||
assert!(flavor_lines.len() >= 2);
|
||||
for li in &flavor_lines[..flavor_lines.len() - 1] {
|
||||
assert!((li.x1 - li.x0 - 240.0).abs() < 0.5, "justified: {li:?}");
|
||||
}
|
||||
// Deterministic.
|
||||
let again = layout(db(), &t);
|
||||
assert_eq!(baselines(&again), baselines(&l));
|
||||
assert_eq!(again.inlines.iter().map(|i| i.bounds).collect::<Vec<_>>(), l.inlines.iter().map(|i| i.bounds).collect::<Vec<_>>());
|
||||
}
|
||||
|
||||
/// The natural width of `s` set in one line at `size`.
|
||||
fn natural_width(s: &str, size: f64) -> f64 {
|
||||
let l = layout(db(), &TextObject::point(Point::ZERO, s, sans(size)));
|
||||
l.lines[0].x1 - l.lines[0].x0
|
||||
}
|
||||
@@ -296,3 +296,33 @@ fn top_to_top_leading_spaces_inline_art_by_its_run() {
|
||||
let (tall0, tall1) = lines(3.0);
|
||||
assert!((small0 - tall0).abs() < 1e-6 && (small1 - tall1).abs() < 1e-6, "{small0} {small1} / {tall0} {tall1}");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn inline_art_moves_with_vertically_aligned_lines() {
|
||||
use vectorcraft_doc::text::{AreaOptions, VerticalAlign};
|
||||
// A rectangle (lines shift) and a triangle (text flows again lower down).
|
||||
let rect = Rect::new(0.0, 0.0, 400.0, 400.0).to_path(0.1);
|
||||
let mut tri = kurbo::BezPath::new();
|
||||
tri.move_to((0.0, 0.0));
|
||||
tri.line_to((800.0, 0.0));
|
||||
tri.line_to((400.0, 400.0));
|
||||
tri.close_path();
|
||||
for frame in [rect, tri] {
|
||||
for align in [VerticalAlign::Center, VerticalAlign::Bottom] {
|
||||
let mut t = text("A", art(1.0), "B", 20.0);
|
||||
t.kind = TextKind::Area { frame: PathData::from_bezpath(&frame) };
|
||||
t.area = AreaOptions { vertical_align: align, ..AreaOptions::default() };
|
||||
let l = layout(db(), &t);
|
||||
assert_eq!(l.inlines.len(), 1, "{align:?}");
|
||||
let g = inline_glyph(&l);
|
||||
let line = &l.lines[g.line];
|
||||
assert!(line.baseline > 100.0, "{align:?}: not aligned, baseline {}", line.baseline);
|
||||
// Still centred on the cap height above its (moved) baseline.
|
||||
let face = db().face("Source Sans 3", "Regular").unwrap();
|
||||
let cap = face.cap_height * 20.0 / face.upem;
|
||||
let b = l.inlines[0].bounds;
|
||||
assert!((b.center().y - (line.baseline - cap * 0.5)).abs() < 1e-6, "{align:?}: {b:?} baseline {}", line.baseline);
|
||||
assert!((b.x0 - g.origin.x).abs() < 1e-6, "{align:?}: {b:?}");
|
||||
}
|
||||
}
|
||||
}
|
||||
+185
-7
@@ -79,6 +79,9 @@ pub struct Targets {
|
||||
segments: Vec<(Rect, PathSeg)>,
|
||||
/// Ruler guides, which pull a point into line where they run (Snap to Point).
|
||||
rulers: Vec<Ruler>,
|
||||
/// The bounds of the objects a moved selection spaces itself evenly with (Spacing Guides):
|
||||
/// gathered only for moves ([`Self::for_move`]).
|
||||
boxes: Vec<Rect>,
|
||||
/// How the guides these targets produce look.
|
||||
style: GuideStyle,
|
||||
}
|
||||
@@ -145,11 +148,47 @@ fn lines_near(lines: &[(f64, Point, Kind)], v: f64, tol: f64) -> &[(f64, Point,
|
||||
within(lines, |l| l.0, v, tol)
|
||||
}
|
||||
|
||||
/// `r`'s extent along the x axis (`x`) or the y axis.
|
||||
fn span(r: &Rect, x: bool) -> (f64, f64) {
|
||||
if x { (r.x0, r.x1) } else { (r.y0, r.y1) }
|
||||
}
|
||||
|
||||
/// The objects a moved selection (`moving`) spaces itself evenly with, by their bounds: each
|
||||
/// visible object on a layer as a whole (a group too), and inside a group holding some of the
|
||||
/// moving objects its other objects. At most [`BUDGET`].
|
||||
fn object_boxes(doc: &Document, moving: &[NodeId]) -> Vec<Rect> {
|
||||
fn push(nodes: &[Arc<Node>], moving: &HashSet<NodeId>, holders: &HashSet<NodeId>, out: &mut Vec<Rect>) {
|
||||
for n in nodes.iter().filter(|n| n.visible && !moving.contains(&n.id)) {
|
||||
if out.len() >= BUDGET {
|
||||
return;
|
||||
}
|
||||
match n.children() {
|
||||
Some(ch) if n.is_layer() || holders.contains(&n.id) => push(ch, moving, holders, out),
|
||||
_ => out.extend(n.geometric_bounds()),
|
||||
}
|
||||
}
|
||||
}
|
||||
let holders: HashSet<NodeId> = moving.iter().filter_map(|id| doc.ancestry(*id)).flatten().collect();
|
||||
let mut out = vec![];
|
||||
push(&doc.layers, &moving.iter().copied().collect(), &holders, &mut out);
|
||||
out
|
||||
}
|
||||
|
||||
impl Targets {
|
||||
pub fn collect(doc: &Document, exclude: &[NodeId], visible: Option<Rect>) -> Self {
|
||||
Self::collect_inner(doc, exclude, None, visible, Gather::Bounds)
|
||||
}
|
||||
|
||||
/// Targets for moving the selection of `cx`: [`Self::collect`]'s, styled as `cx` asks, and with
|
||||
/// Smart Guides › Spacing Guides the objects it spaces itself evenly with ([`Self::snap_rect`]).
|
||||
pub fn for_move(cx: &ToolContext) -> Self {
|
||||
let mut t = Self::collect(cx.doc, &cx.selection.objects, None).styled(cx);
|
||||
if cx.spacing_guides {
|
||||
t.boxes = object_boxes(cx.doc, &cx.selection.objects);
|
||||
}
|
||||
t
|
||||
}
|
||||
|
||||
/// Targets for a drawn point: the art in `visible` (all of it for None) but `exclude`, its
|
||||
/// anchors, centres, edges and path segments, its anchors in line too. The anchors and
|
||||
/// segments of `exclude` (the path being drawn, whose bounds grow with it) stay targets.
|
||||
@@ -508,7 +547,7 @@ impl Targets {
|
||||
let rects: Vec<Rect> = std::iter::once(Vec2::ZERO).chain(offsets.iter().copied()).map(|o| Rect::from_points(p + o, p + o)).collect();
|
||||
let (adj, mut ov, aligned) = self.align_rects(&rects, tol);
|
||||
let out = p + adj;
|
||||
if aligned {
|
||||
if aligned.contains(&true) {
|
||||
ov.extend(self.label(out, "align"));
|
||||
}
|
||||
(out, ov)
|
||||
@@ -520,15 +559,107 @@ impl Targets {
|
||||
}
|
||||
|
||||
/// Snap rectangles that move together (an artboard and its bleed): the edge or centre of any
|
||||
/// of them nearest a target, per axis. Returns the shift and the guides.
|
||||
/// of them nearest a target, per axis. A single moved selection with Spacing Guides
|
||||
/// ([`Self::for_move`]) is spaced evenly along an axis that lines up with nothing
|
||||
/// ([`Self::even_spacing`]). Returns the shift and the guides.
|
||||
pub fn snap_rects(&self, rects: &[Rect], tol: f64) -> (Vec2, Vec<Overlay>) {
|
||||
let (d, ov, _) = self.align_rects(rects, tol);
|
||||
let (mut d, mut ov, aligned) = self.align_rects(rects, tol);
|
||||
if let [r] = rects
|
||||
&& !self.boxes.is_empty()
|
||||
{
|
||||
let moved = *r + d;
|
||||
let mut spaced = false;
|
||||
for (x, lined_up) in [true, false].into_iter().zip(aligned) {
|
||||
if let Some((shift, _)) = self.even_spacing(moved, x, tol).filter(|_| !lined_up) {
|
||||
*(if x { &mut d.x } else { &mut d.y }) += shift;
|
||||
spaced = true;
|
||||
}
|
||||
}
|
||||
// The equal gaps, marked where the rectangle ends up.
|
||||
if spaced {
|
||||
let done = *r + d;
|
||||
for (x, lined_up) in [true, false].into_iter().zip(aligned) {
|
||||
let gaps = if lined_up { None } else { self.even_spacing(done, x, tol) };
|
||||
ov.extend(gaps.into_iter().flat_map(|(_, gaps)| gaps).flat_map(|g| self.gap_marks(g, x, tol)));
|
||||
}
|
||||
}
|
||||
}
|
||||
(d, ov)
|
||||
}
|
||||
|
||||
/// [`Self::snap_rects`], also saying whether an axis lined up (even with Alignment Guides
|
||||
/// off, or already in line, when there is no line or shift to tell).
|
||||
fn align_rects(&self, rects: &[Rect], tol: f64) -> (Vec2, Vec<Overlay>, bool) {
|
||||
/// Spacing Guides along the x axis (`x`) or the y axis for the moved rectangle `r`, among the
|
||||
/// objects of its row (column): the shift (within `tol`) that leaves it as far from its
|
||||
/// neighbour before or after it as two other objects of the row are apart, or as far from both
|
||||
/// neighbours; and the equal gaps then, as (start, end, where across) along that axis.
|
||||
fn even_spacing(&self, r: Rect, x: bool, tol: f64) -> Option<(f64, Vec<[f64; 3]>)> {
|
||||
let (r0, r1) = span(&r, x);
|
||||
let len = r1 - r0;
|
||||
let (c0, c1) = span(&r, !x);
|
||||
// The objects beside it, before or after, overlapping it across, by where they start.
|
||||
let mut row: Vec<(Rect, f64, f64)> = self
|
||||
.boxes
|
||||
.iter()
|
||||
.map(|b| (*b, span(b, x).0, span(b, x).1))
|
||||
.filter(|(b, a0, a1)| span(b, !x).0 < c1 && span(b, !x).1 > c0 && (*a1 <= r0 + tol || *a0 >= r1 - tol))
|
||||
.collect();
|
||||
row.sort_by(|a, b| a.1.total_cmp(&b.1));
|
||||
// Where two boxes overlap across: the middle of that (or of the space between them).
|
||||
let mid = |a: &Rect, b: &Rect| (span(a, !x).0.max(span(b, !x).0) + span(a, !x).1.min(span(b, !x).1)) / 2.0;
|
||||
// Each object and the nearest one after it, unless the moved rectangle sits between them.
|
||||
let pairs: Vec<(f64, [f64; 3])> = row
|
||||
.iter()
|
||||
.filter_map(|(p, _, p1)| {
|
||||
let next = row.partition_point(|(_, a0, _)| *a0 < *p1);
|
||||
let (q, q0, _) = row.get(next)?;
|
||||
let straddles = *p1 <= r0 + tol && *q0 >= r1 - tol;
|
||||
(*q0 > *p1 && !straddles).then(|| (q0 - p1, [*p1, *q0, mid(p, q)]))
|
||||
})
|
||||
.collect();
|
||||
let before = row.iter().filter(|(_, _, a1)| *a1 <= r0 + tol).max_by(|a, b| a.2.total_cmp(&b.2));
|
||||
let after = row.iter().filter(|(_, a0, _)| *a0 >= r1 - tol).min_by(|a, b| a.1.total_cmp(&b.1));
|
||||
// Where it could start, and the gap it repeats (None: halfway between its neighbours).
|
||||
let mut starts: Vec<(f64, Option<f64>)> = vec![];
|
||||
if let (Some(a), Some(b)) = (before, after)
|
||||
&& b.1 - a.2 > len
|
||||
{
|
||||
starts.push(((a.2 + b.1 - len) / 2.0, None));
|
||||
}
|
||||
for (g, _) in &pairs {
|
||||
starts.extend(before.map(|a| (a.2 + g, Some(*g))));
|
||||
starts.extend(after.map(|b| (b.1 - g - len, Some(*g))));
|
||||
}
|
||||
let (start, repeats) =
|
||||
starts.into_iter().filter(|(t, _)| (t - r0).abs() <= tol).min_by(|a, b| (a.0 - r0).abs().total_cmp(&(b.0 - r0).abs()))?;
|
||||
let at = r + if x { Vec2::new(start - r0, 0.0) } else { Vec2::new(0.0, start - r0) };
|
||||
let (end, mut gaps) = (start + len, vec![]);
|
||||
if let Some((a, _, a1)) = before
|
||||
&& repeats.is_none_or(|g| (start - a1 - g).abs() <= 1e-9)
|
||||
{
|
||||
gaps.push([*a1, start, mid(a, &at)]);
|
||||
}
|
||||
if let Some((b, b0, _)) = after
|
||||
&& repeats.is_none_or(|g| (b0 - end - g).abs() <= 1e-9)
|
||||
{
|
||||
gaps.push([end, *b0, mid(b, &at)]);
|
||||
}
|
||||
if let Some(g) = repeats {
|
||||
gaps.extend(pairs.iter().filter(|(pg, _)| (pg - g).abs() <= 1e-9).map(|(_, gap)| *gap));
|
||||
}
|
||||
Some((start - r0, gaps))
|
||||
}
|
||||
|
||||
/// A Spacing Guides mark: a line across the gap (start, end, where across) along the x axis
|
||||
/// (`x`) or the y axis, with a tick `tick` long either side of it at each end.
|
||||
fn gap_marks(&self, [u0, u1, c]: [f64; 3], x: bool, tick: f64) -> [Overlay; 3] {
|
||||
let pt = |u: f64, c: f64| if x { Point::new(u, c) } else { Point::new(c, u) };
|
||||
let line = |a: Point, b: Point| Overlay::Line { a, b, color: self.style.color, dashed: false };
|
||||
[line(pt(u0, c), pt(u1, c)), line(pt(u0, c - tick), pt(u0, c + tick)), line(pt(u1, c - tick), pt(u1, c + tick))]
|
||||
}
|
||||
|
||||
/// [`Self::snap_rects`] before Spacing Guides, also saying whether each axis (x, y) lined up
|
||||
/// (even with Alignment Guides off, or already in line, when there is no line or shift to
|
||||
/// tell).
|
||||
fn align_rects(&self, rects: &[Rect], tol: f64) -> (Vec2, Vec<Overlay>, [bool; 2]) {
|
||||
let nearest = |targets: &[(f64, Point, Kind)], along: fn(&Rect) -> [f64; 3]| {
|
||||
rects
|
||||
.iter()
|
||||
@@ -553,7 +684,7 @@ impl Targets {
|
||||
let (x0, x1) = (from.x.min(r.x0), from.x.max(r.x1));
|
||||
ov.extend(self.line(Point::new(x0, y), Point::new(x1, y)));
|
||||
}
|
||||
(d, ov, best_x.is_some() || best_y.is_some())
|
||||
(d, ov, [best_x.is_some(), best_y.is_some()])
|
||||
}
|
||||
|
||||
/// Snap a bounding-box resize. `a` is the scale [`crate::bbox::scale_for_drag`] gave for
|
||||
@@ -1064,6 +1195,53 @@ mod tests {
|
||||
assert!(anchor(&ov), "{ov:?}");
|
||||
}
|
||||
|
||||
/// Smart Guides › Spacing Guides (#394): a moved selection lands as far from its neighbour as
|
||||
/// two other objects of its row are apart, or halfway between its two neighbours, and the
|
||||
/// equal gaps are marked; up and down the same in a column. Off, it stays where it is dragged.
|
||||
#[test]
|
||||
fn spacing_guides_space_a_moved_selection_evenly() {
|
||||
let mut d = Document::new(500.0, 500.0);
|
||||
let l = d.layers[0].id;
|
||||
// A and B 20 apart in a row at y 300–340, C and D 30 apart in a column at x 400–440.
|
||||
for r in [
|
||||
Rect::new(20.0, 300.0, 60.0, 340.0),
|
||||
Rect::new(80.0, 300.0, 120.0, 340.0),
|
||||
Rect::new(400.0, 20.0, 440.0, 50.0),
|
||||
Rect::new(400.0, 80.0, 440.0, 110.0),
|
||||
] {
|
||||
let id = d.alloc_id();
|
||||
d.insert(Some(l), 0, Node::path(id, vectorcraft_geom::shapes::rectangle(r), Default::default())).unwrap();
|
||||
}
|
||||
let (s, p) = (Selection::default(), paint());
|
||||
let lines = |ov: &[Overlay]| ov.iter().filter(|o| matches!(o, Overlay::Line { color, .. } if *color == MAGENTA)).count();
|
||||
let t = Targets::for_move(&cx(&d, &s, &p));
|
||||
// 21 after B: 20, as A and B, with both gaps marked (a line and two ticks each).
|
||||
let (dv, ov) = t.snap_rect(Rect::new(141.0, 305.0, 181.0, 345.0), 4.0);
|
||||
assert_eq!(dv, Vec2::new(-1.0, 0.0));
|
||||
assert_eq!(lines(&ov), 6, "{ov:?}");
|
||||
assert!(ov.iter().any(|o| matches!(o, Overlay::Line { a, b, .. } if (a.x, b.x) == (120.0, 140.0) && a.y == b.y)), "{ov:?}");
|
||||
assert!(ov.iter().any(|o| matches!(o, Overlay::Line { a, b, .. } if (a.x, b.x) == (60.0, 80.0) && a.y == b.y)), "{ov:?}");
|
||||
// Halfway between B and a box at 220–260: 50 either side.
|
||||
let mut wide = d.clone();
|
||||
let id = wide.alloc_id();
|
||||
wide.insert(Some(l), 0, Node::path(id, vectorcraft_geom::shapes::rectangle(Rect::new(220.0, 300.0, 260.0, 340.0)), Default::default()))
|
||||
.unwrap();
|
||||
let (dv, ov) = Targets::for_move(&cx(&wide, &s, &p)).snap_rect(Rect::new(148.0, 305.0, 188.0, 345.0), 4.0);
|
||||
assert_eq!(dv, Vec2::new(2.0, 0.0));
|
||||
assert!(lines(&ov) >= 6, "{ov:?}");
|
||||
// A column: 28 under D, as C and D are 30 apart.
|
||||
let (dv, ov) = t.snap_rect(Rect::new(405.0, 138.0, 445.0, 168.0), 4.0);
|
||||
assert_eq!(dv, Vec2::new(0.0, 2.0));
|
||||
assert!(ov.iter().any(|o| matches!(o, Overlay::Line { a, b, .. } if (a.y, b.y) == (110.0, 140.0) && a.x == b.x)), "{ov:?}");
|
||||
// Above C, 32 over it: 30.
|
||||
let (dv, _) = t.snap_rect(Rect::new(405.0, -42.0, 445.0, -12.0), 4.0);
|
||||
assert_eq!(dv, Vec2::new(0.0, 2.0));
|
||||
// Off: nowhere to go, and no marks.
|
||||
let off = ToolContext { spacing_guides: false, ..cx(&d, &s, &p) };
|
||||
let (dv, ov) = Targets::for_move(&off).snap_rect(Rect::new(141.0, 305.0, 181.0, 345.0), 4.0);
|
||||
assert_eq!((dv, lines(&ov)), (Vec2::ZERO, 0));
|
||||
}
|
||||
|
||||
/// Preferences › Smart Guides › Display Options (#394): the colour, and Alignment Guides and
|
||||
/// Anchor/Path Labels off, change what shows and never where a point lands.
|
||||
#[test]
|
||||
|
||||
@@ -322,6 +322,10 @@ pub struct ToolContext<'a> {
|
||||
pub measurement_labels: bool,
|
||||
/// Smart Guides → Transform Tools: the readouts while scaling, rotating and shearing.
|
||||
pub transform_tools_guides: bool,
|
||||
/// Smart Guides → Spacing Guides: a moved selection snaps to spacing equal to the gap between
|
||||
/// two other objects in its row or column, or evenly between its two neighbours, and the
|
||||
/// equal gaps show.
|
||||
pub spacing_guides: bool,
|
||||
/// Smart Guides → Snapping Tolerance (screen pixels): how near a smart guide target pulls the
|
||||
/// pointer, a dragged edge or a drawn point.
|
||||
pub snapping_tolerance: f64,
|
||||
@@ -695,6 +699,7 @@ pub(crate) mod testutil {
|
||||
anchor_path_labels: true,
|
||||
measurement_labels: true,
|
||||
transform_tools_guides: true,
|
||||
spacing_guides: true,
|
||||
snapping_tolerance: 4.0,
|
||||
construction_angles: guides::construction_angles(guides::DEFAULT_CONSTRUCTION_ANGLES),
|
||||
screen: None,
|
||||
|
||||
@@ -87,7 +87,7 @@ impl MoveSnap {
|
||||
pub(crate) fn new(cx: &ToolContext) -> Self {
|
||||
Self {
|
||||
bounds: selection_bounds(cx),
|
||||
targets: cx.smart_guides.then(|| Targets::collect(cx.doc, &cx.selection.objects, None).styled(cx)),
|
||||
targets: cx.smart_guides.then(|| Targets::for_move(cx)),
|
||||
points: Targets::snap_to_point(cx, &cx.selection.objects),
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1723,6 +1723,7 @@ fn home(app: &mut VectorcraftApp, ui: &mut Ui, rect: egui::Rect) {
|
||||
app.run("file.open", json!({})).ok();
|
||||
}
|
||||
});
|
||||
recent(app, ui);
|
||||
ui.add_space(28.0);
|
||||
ui.label(egui::RichText::new(tl!("Quickly start a new file")).font(theme::semibold(14.0)).color(t.text));
|
||||
ui.add_space(10.0);
|
||||
@@ -1743,6 +1744,35 @@ fn home(app: &mut VectorcraftApp, ui: &mut Ui, rect: egui::Rect) {
|
||||
crate::community::links(app, ui);
|
||||
}
|
||||
|
||||
/// The Home screen's Recent Files (#663): the first of File › Open Recent Files, each its name and
|
||||
/// folder; a click opens it. Nothing when there are none.
|
||||
fn recent(app: &mut VectorcraftApp, ui: &mut Ui) {
|
||||
const SHOWN: usize = 6;
|
||||
let files: Vec<String> = crate::io::recent_files(app).iter().take(SHOWN).cloned().collect();
|
||||
if files.is_empty() {
|
||||
return;
|
||||
}
|
||||
let t = Tokens::get(ui.ctx());
|
||||
ui.add_space(28.0);
|
||||
ui.label(egui::RichText::new(tl!("Recent Files")).font(theme::semibold(14.0)).color(t.text));
|
||||
ui.add_space(8.0);
|
||||
for path in files {
|
||||
let p = std::path::Path::new(&path);
|
||||
let name = p.file_name().map_or_else(|| path.clone(), |n| n.to_string_lossy().into_owned());
|
||||
let folder = p.parent().map(|f| f.to_string_lossy().into_owned()).unwrap_or_default();
|
||||
ui.horizontal(|ui| {
|
||||
crate::icons::icon(ui, "history", 16.0, t.icon);
|
||||
let r = ui.add(egui::Button::new(egui::RichText::new(&name).color(t.accent).size(13.0)).frame(false)).on_hover_text(&path);
|
||||
ui.add(egui::Label::new(egui::RichText::new(&folder).size(12.0).color(t.text_dim)).truncate());
|
||||
if r.clicked()
|
||||
&& let Err(e) = crate::io::open_path(app, &path)
|
||||
{
|
||||
app.status(e);
|
||||
}
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
fn kurbo_flatten(p: &BezPath, tol: f64, f: &mut impl FnMut(PathEl)) {
|
||||
vectorcraft_geom::kurbo::flatten(p.elements().iter().copied(), tol, f);
|
||||
}
|
||||
|
||||
@@ -190,7 +190,7 @@ fn show(app: &mut VectorcraftApp, ctx: &egui::Context) {
|
||||
ui.vertical(|ui| {
|
||||
ui.set_width(640.0);
|
||||
ui.set_min_height(HEIGHT - 32.0);
|
||||
presets(app, ui, &mut d);
|
||||
b.create |= presets(app, ui, &mut d);
|
||||
});
|
||||
});
|
||||
egui::Frame::NONE.fill(t.panel_darker).inner_margin(egui::Margin::same(18)).show(ui, |ui| {
|
||||
@@ -205,8 +205,9 @@ fn show(app: &mut VectorcraftApp, ctx: &egui::Context) {
|
||||
b.finish(app, ctx, d);
|
||||
}
|
||||
|
||||
/// The category tabs and the chosen category's preset cards.
|
||||
fn presets(app: &VectorcraftApp, ui: &mut egui::Ui, d: &mut Dialog) {
|
||||
/// The category tabs and the chosen category's preset cards: a click chooses one, a double-click
|
||||
/// also creates it (true then).
|
||||
fn presets(app: &VectorcraftApp, ui: &mut egui::Ui, d: &mut Dialog) -> bool {
|
||||
let t = Tokens::get(ui.ctx());
|
||||
let names: Vec<&str> = newdoc::category_names().collect();
|
||||
let cat = names.iter().position(|n| n.eq_ignore_ascii_case(&d.str("category"))).unwrap_or(0);
|
||||
@@ -227,20 +228,24 @@ fn presets(app: &VectorcraftApp, ui: &mut egui::Ui, d: &mut Dialog) {
|
||||
if list.is_empty() {
|
||||
let hint = if cat == 1 { tl!("Presets you save with the Save Preset button appear here.") } else { tl!("Documents you create appear here.") };
|
||||
ui.label(egui::RichText::new(hint).color(t.text_dim));
|
||||
return;
|
||||
return false;
|
||||
}
|
||||
let mut create = false;
|
||||
egui::ScrollArea::vertical().id_salt(("newdoc-presets", cat)).max_height(HEIGHT - 110.0).auto_shrink([false, false]).show(ui, |ui| {
|
||||
ui.horizontal_wrapped(|ui| {
|
||||
ui.spacing_mut().item_spacing = egui::vec2(12.0, 12.0);
|
||||
let (w, h, preset) = (d.f64("width", 0.0), d.f64("height", 0.0), d.str("preset"));
|
||||
for s in &list {
|
||||
let selected = d.fields.contains_key(APPLIED) && s.name == preset && s.width == w && s.height == h;
|
||||
if preset_card(ui, s, selected).clicked() {
|
||||
let card = preset_card(ui, s, selected);
|
||||
if card.clicked() || card.double_clicked() {
|
||||
apply(d, s);
|
||||
}
|
||||
create |= card.double_clicked();
|
||||
}
|
||||
});
|
||||
});
|
||||
create
|
||||
}
|
||||
|
||||
/// Is `name` a built-in preset's? Those are ours (translated); Recent and Saved hold the names of
|
||||
@@ -345,7 +350,7 @@ fn details(app: &mut VectorcraftApp, ui: &mut egui::Ui, d: &mut Dialog, b: &mut
|
||||
// Close and Create at the bottom right.
|
||||
ui.add_space((HEIGHT - (ui.cursor().top() - top) - 28.0).max(12.0));
|
||||
ui.allocate_ui_with_layout(egui::vec2(ui.available_width(), 28.0), egui::Layout::right_to_left(egui::Align::Center), |ui| {
|
||||
b.create = widgets::primary_button(ui, tl!("Create")).clicked();
|
||||
b.create |= widgets::primary_button(ui, tl!("Create")).clicked();
|
||||
ui.add_space(8.0);
|
||||
b.close = widgets::secondary_button(ui, tl!("Close")).clicked();
|
||||
});
|
||||
@@ -558,7 +563,7 @@ fn show_more(app: &mut VectorcraftApp, ctx: &egui::Context) {
|
||||
ui.horizontal(|ui| {
|
||||
templates = widgets::secondary_button(ui, tl!("Templates…")).on_hover_text(tl!("New from Template")).clicked();
|
||||
ui.with_layout(egui::Layout::right_to_left(egui::Align::Center), |ui| {
|
||||
b.create = widgets::primary_button(ui, tl!("Create Document")).clicked();
|
||||
b.create |= widgets::primary_button(ui, tl!("Create Document")).clicked();
|
||||
ui.add_space(8.0);
|
||||
// Cancel goes back to New Document.
|
||||
if widgets::secondary_button(ui, tl!("Cancel")).clicked() {
|
||||
@@ -610,6 +615,51 @@ mod tests {
|
||||
app.ui.dialog.as_ref().unwrap().fields.get(k).cloned().unwrap_or_default()
|
||||
}
|
||||
|
||||
/// A double-click on a preset card creates the document from it (#663); a click only chooses it.
|
||||
#[test]
|
||||
fn a_double_clicked_preset_creates_the_document() {
|
||||
let mut app = VectorcraftApp::new(Session::new(), Default::default());
|
||||
app.run("file.newDialog", json!({})).unwrap();
|
||||
set(&mut app, "category", json!("Mobile"));
|
||||
let ctx = egui::Context::default();
|
||||
crate::theme::install_fonts(&ctx);
|
||||
// Frames 50 ms apart, so two clicks a frame apart make a double-click.
|
||||
let mut time = 0.0;
|
||||
let mut run = |app: &mut VectorcraftApp, events| {
|
||||
time += 0.05;
|
||||
let screen_rect = Some(egui::Rect::from_min_size(egui::Pos2::ZERO, egui::vec2(1400.0, 1000.0)));
|
||||
let raw = egui::RawInput { screen_rect, events, time: Some(time), ..Default::default() };
|
||||
let mut out = ctx.run_ui(raw, |ui| crate::dialogs::show(app, ui.ctx()));
|
||||
out.textures_delta.clear();
|
||||
out
|
||||
};
|
||||
run(&mut app, vec![]);
|
||||
// The first card of the category, found by its size line.
|
||||
let card = |app: &mut VectorcraftApp, run: &mut dyn FnMut(&mut VectorcraftApp, Vec<egui::Event>) -> egui::FullOutput| {
|
||||
let out = run(app, vec![]);
|
||||
let mut texts = vec![];
|
||||
fn walk(s: &egui::Shape, out: &mut Vec<(String, egui::Rect)>) {
|
||||
match s {
|
||||
egui::Shape::Text(t) => out.push((t.galley.text().to_string(), t.visual_bounding_rect())),
|
||||
egui::Shape::Vec(v) => v.iter().for_each(|s| walk(s, out)),
|
||||
_ => {}
|
||||
}
|
||||
}
|
||||
out.shapes.iter().for_each(|c| walk(&c.shape, &mut texts));
|
||||
texts.into_iter().find(|(t, _)| t.starts_with("Phone 393")).map(|(_, r)| r.center()).unwrap()
|
||||
};
|
||||
let at = card(&mut app, &mut run);
|
||||
let press = |pressed| egui::Event::PointerButton { pos: at, button: egui::PointerButton::Primary, pressed, modifiers: Default::default() };
|
||||
run(&mut app, vec![egui::Event::PointerMoved(at), press(true)]);
|
||||
run(&mut app, vec![press(false)]);
|
||||
assert!(app.ui.dialog.is_some() && app.session.documents().is_empty(), "a click only chooses it");
|
||||
assert!(field(&app, "preset").as_str().is_some_and(|p| p == "Phone 393×852"), "{:?}", field(&app, "preset"));
|
||||
run(&mut app, vec![press(true)]);
|
||||
run(&mut app, vec![press(false)]);
|
||||
assert!(app.ui.dialog.is_none(), "the double-click created it: {:?}", app.ui.status);
|
||||
assert_eq!(app.session.documents().len(), 1);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn a_preset_fills_the_details_and_create_makes_the_document() {
|
||||
let mut app = VectorcraftApp::new(Session::new(), Default::default());
|
||||
|
||||
@@ -90,3 +90,46 @@ fn cmd_n_opens_the_new_document_dialog() {
|
||||
assert_eq!(app.ui.dialog.as_ref().map(|d| d.kind.as_str()), Some("newDocument"));
|
||||
assert_eq!(app.session.documents().len(), 1, "no document is made until the dialog's OK");
|
||||
}
|
||||
|
||||
/// One Home screen frame (no document open) with `events`: the texts drawn and where.
|
||||
fn home_texts(app: &mut VectorcraftApp, ctx: &egui::Context, events: Vec<egui::Event>) -> Vec<(String, egui::Rect)> {
|
||||
fn walk(s: &egui::Shape, out: &mut Vec<(String, egui::Rect)>) {
|
||||
match s {
|
||||
egui::Shape::Text(t) => out.push((t.galley.text().to_string(), t.visual_bounding_rect())),
|
||||
egui::Shape::Vec(v) => v.iter().for_each(|s| walk(s, out)),
|
||||
_ => {}
|
||||
}
|
||||
}
|
||||
let raw =
|
||||
egui::RawInput { screen_rect: Some(egui::Rect::from_min_size(egui::Pos2::ZERO, egui::vec2(1000.0, 900.0))), events, ..Default::default() };
|
||||
let mut out = ctx.run_ui(raw, |ui| canvas::show(app, ui));
|
||||
out.textures_delta.clear();
|
||||
let mut texts = vec![];
|
||||
out.shapes.iter().for_each(|c| walk(&c.shape, &mut texts));
|
||||
texts
|
||||
}
|
||||
|
||||
/// The Home screen lists the first recent files (#663), each by name and folder; a click opens it,
|
||||
/// and one that can't be opened says so. With none, there is no Recent Files section.
|
||||
#[test]
|
||||
fn home_lists_recent_files_and_a_click_opens_one() {
|
||||
let mut app = VectorcraftApp::new(vectorcraft_engine::Session::new(), crate::Services::default());
|
||||
let ctx = egui::Context::default();
|
||||
crate::theme::install_fonts(&ctx);
|
||||
let has = |texts: &[(String, egui::Rect)], s: &str| texts.iter().any(|(t, _)| t == s);
|
||||
assert!(!has(&home_texts(&mut app, &ctx, vec![]), "Recent Files"), "none: no section");
|
||||
let dir = std::env::temp_dir().join("vectorcraft-home-recent");
|
||||
let missing = dir.join("Gone.svg").to_string_lossy().into_owned();
|
||||
app.ui.recent_files = (0..9).map(|i| dir.join(format!("Drawing {i}.svg")).to_string_lossy().into_owned()).collect();
|
||||
app.ui.recent_files.insert(0, missing);
|
||||
let texts = home_texts(&mut app, &ctx, vec![]);
|
||||
assert!(has(&texts, "Recent Files") && has(&texts, "Gone.svg") && has(&texts, "Drawing 4.svg"), "{texts:?}");
|
||||
assert!(!has(&texts, "Drawing 5.svg"), "the first six only");
|
||||
assert!(has(&texts, &dir.to_string_lossy()), "with its folder");
|
||||
let at = texts.iter().find(|(t, _)| t == "Gone.svg").map(|(_, r)| r.center()).unwrap();
|
||||
let press = |pressed| egui::Event::PointerButton { pos: at, button: egui::PointerButton::Primary, pressed, modifiers: Default::default() };
|
||||
home_texts(&mut app, &ctx, vec![egui::Event::PointerMoved(at), press(true)]);
|
||||
home_texts(&mut app, &ctx, vec![press(false)]);
|
||||
assert!(app.session.documents().is_empty());
|
||||
assert!(!app.ui.status.is_empty(), "a file that can't be opened says so");
|
||||
}
|
||||
Reference in new issue
Block a user