Add a pt-BR catalog and persisted language selection, covering UI labels, menus, dialogs, tooltips, accessibility text, and engine menu labels, and update the localization parity docs.
* io: import a MIDI file with stray bytes after its last track (#1528)
Importing a MIDI file read it with craft-midi's strict read_smf, which
refuses any damage. The file in #1528 is whole, its one track ending with
End of Track at its declared length, but two line feeds follow it. The
strict reader took them for the start of another chunk and refused the
file with "unexpected end of data at byte 45281".
Read imported files with read_smf_lenient instead, as other MIDI readers
do: it reads a sound file exactly as read_smf does, ignores bytes after
the last chunk, and keeps what makes sense of a damaged track, bounded by
the same event and track limits. Its warnings are logged. Something that
is not a Standard MIDI File is still refused, and the file is still read
in full before the session changes (#911).
Test: a complete file followed by two line feeds imports its note; it
failed with the issue's error before.
* io: a MIDI file past the reader's limits stays refused (#1528)
Read leniently, a file with more events or tracks than craft-midi reads
kept what came before the limit and left the rest out with only a log
warning, where the strict reader refused it. Import now reads a file
strictly first: a sound file reads as before, a file past the event or
track limit is refused as before, and only other damage (stray bytes
after the last track) falls back to the lenient reader.
Test: a file one track past the limit, its last track holding a note and
stray bytes after it, is refused and leaves the session empty.
* io: refuse a MIDI file past the event limit after a damaged track (#1528)
The strict reader stops at the first damage. When a damaged track came
before the one that goes past MAX_EVENTS, the strict error was not a
limit error, the import fell back to the lenient read, and that read
kept what came before the limit and left the rest out with a warning:
the file was imported cut short.
The lenient read now says when a limit left part of the file out
(LenientRead::over_limit, storytold/craft-libs#1308), and the import
refuses such a file before the session changes, warnings full or not.
The six craft-libs crates pinned at 6a86adb move together to that PR's
commit, as craft-scraft-format uses craft-midi's and craft-audio's
types. They move to its merge commit once it merges.
* deps: keep only the craft-libs source changes in Cargo.lock (#1528)
Moving the craft-libs pins also re-resolved several windows-sys edges
(0.61.2 to 0.52.0) and tempfile's getrandom edge (0.4.3 to 0.3.4).
Restore main's resolution for those, so the lockfile only changes the
source of the craft-libs crates.
* deps: pin craft-libs to the merge of craft-libs#1308 (#1528)
Move the six craft-libs crates from the PR's commit 4db60c4 to its merge
into craft-libs main, 45a8e16. None of these crates, nor craft-zip which
craft-scraft-format uses, changed between the two.
* io: a missing movie is offline with its checked path (#923)
relink_videos resolved a stored movie path, found no file, and then left
the raw stored string in the session with offline unset. The video
worker opened that string as given, relative to the working directory,
so a session path reached the file system without going through
stored_path.
Store the resolved path in that arm and mark the movie offline, as the
refused-path arm already does; the Video track then shows
"media offline: file not found" instead of trying the path. Test: a
relative stored path that names no file.
* io: keep a missing movie's stored path as it was
Review follow-up: the first commit replaced the stored string with the
resolved absolute path. Saving then wrote this folder's path, and a
session moved together with its movie no longer found it under the same
relative path (relinking only looks beside the session and in
"Video Files").
Marking the movie offline is what keeps the Video track from opening the
stored string, so leave the string as stored. The test now saves the
session into another folder, puts the movie back there under the same
relative path and checks it opens.
* Test: every outcome of relinking a movie
Its file is there; it is gone with a copy next to the session or in Video
Files (relinked); it is gone with no copy (offline, path kept); its stored
path is refused, with or without a copy.
---------
Co-authored-by: ashokram-si <347905169+ashokram-si@users.noreply.github.com>
* io: check a MIDI file in full before the session changes (#911)
import_midi_bytes wrote the file's tempo and meter changes and added a
track per SMF track as it went, then returned an error for a track
longer than a day. Through execute the session is restored on error,
but the web shell calls the function directly and only pushes its undo
step on success, so a refused file left the earlier tracks and the new
tempo map in place with no way back.
Build the tempo map apart from the session, check every track's length
with it, and only then commit the map and place the clips. Test: a file
whose second track is too long leaves the session equal to before.
* io: a refused MIDI file isn't an edit either
The checks before the import ran after session_mut, which already counts
as an edit: it bumps the revision, marks the engine unsaved and may copy
the session. They now read through session(), and session_mut is taken
only once nothing can fail. The test checks the revision and unsaved
mark too.
---------
Co-authored-by: ashokram-si <347905169+ashokram-si@users.noreply.github.com>
* Dialogs: Enter presses the default button only when no button has the focus
egui treats Enter on a focused button, checkbox, radio button or combo
box as a click, and the dialogs also pressed their default button on the
same key: Enter on a focused Cancel ran the dialog's OK (Strip Silence
stripped the clips, Bounce Mix started the bounce), Enter on Don't Save
saved first, and Enter on Browse... opened the picker and then pressed
OK or Bounce.
- Enter presses the default button only on a new key press, and only
when no widget has the keyboard focus or a text field has it, so a
held Enter's repeats do not press it.
- On the first frame a dialog is drawn, it clears the keyboard focus a
widget in the main window may still hold, and ignores Enter: that
Enter opened the dialog from a menu item or the command palette.
- Every way a dialog opens goes through Dialogs::set, so a dialog that
replaces an open one, the Unsaved Changes prompt, the Spot dialog and
Tempo Change get the same first frame.
* Dialogs: a Spot dialog that a clip click opens also ignores the Enter of its first frame
With the Grabber or Trim tool in Spot mode, a click on a clip set the
open dialog directly, so a Spot dialog that replaced an open dialog kept
the shown state and could take an Enter pressed in the same frame. Both
clicks now open it through Dialogs::set.
* Tests: Enter right after Strip Silence and Rename Selected Clips switch presses the new default button
* Tests: Enter on a focused default button, and the first frame of the remaining dialogs that replace another
A focused Create runs its command once. Clear, Auto Rename, Modify Group, the unsaved changes question and Tempo Change each ignore the Enter of their first frame when they replace an open dialog. Enter on a focused Browse in Bounce Mix starts no bounce.
* mix.volume: say what each track got and when a value was clamped
The fader stops at -144 and +12 dB, and mix.volume replied only with a track
count, so +15 dB played at +12 with nothing to show it. The reply now lists
each target's volume and sets clamped when a target or a group member was
held at a stop.
* mix.volume: list every requested track in the reply
A target moved as a group sibling of an earlier one was skipped before it was
added to volumes, so tracks [3, 6] in one group listed only track 3. Build
volumes after the loop from each requested track's final volume.
* Add missing VST3 paths for Linux
* Add missing VST3 paths for Windows
* Add missing VST3 paths for macOS
* Make os_search_paths private
* Use hermetic search_paths in unix test and remove os_search_paths
* Rewrote the Unix test to use the hermetic search_paths with a fixed executable, a None case, and no process state.
* Replaced os_search_paths with default_search_paths_with, injecting the environment lookup and executable so tests
now cover the COMMONPROGRAMW6432 → COMMONPROGRAMFILES fallback, COMMONPROGRAMFILES(X86), LOCALAPPDATA, app-local folders, and VST3_PATH.
* Add docstring to env_from
---------
Co-authored-by: Gennadij Yatskov <gennadij@yatskov.de>
On Windows the client's 800 ms connect timeout can expire before a closed
loopback port is refused, so the CLI reports "connection timed out" without
an "(os error N)" suffix. Both assert_refused helpers now accept either
reason, and still check exit 1, empty stdout and the exact address prefix.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The help for mix.send said `level_db?: 0`, but a new send has always started
at -144 dB (silent): SendSlot::new sets it, the Mix window relies on it, and
Preferences > Mixing shows "Sends Default to -inf dB". The help now gives the
range and the real default, and a test checks the help and a new send agree.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A line that was not JSON got a "bad JSON" error reply and the server kept
reading the same connection. A JSON value that was not an object, or had no
string `method`, was forwarded to the UI as a request with an empty method.
Now a line that is not a JSON object with a string `method` gets one error
reply and the connection is closed, as in the other Craft apps' control
servers. Control clients send one request object per line, so a peer that
sends anything else is not one, and nothing it sends after that line is run.
Valid requests and blank lines are handled as before.
The protocol doc says so next to the error format.
* Strip Silence: the sliders move a tenth as far while Ctrl or Command is held
While Ctrl (Command on a Mac) is held, a drag on one of the four Strip
Silence sliders moves the value a tenth as far as the same drag
without the key, on the slider and on its value box. Pressing or
releasing the key during a drag leaves the value where it is, and the
drag goes on from there. Releasing the mouse button leaves the value
too. A drag without the key works as before.
The new widgets::fine_slider uses the modifier test and the tenth of
widgets::fader. Threshold and Clip Start Pad show one decimal place,
and a drag on the slider during which the key was held rounds the
value to the places the box shows.
* Plugins: parameter sliders move a tenth as far while Ctrl or Command is held
While Ctrl (Command on a Mac) is held, a drag on a parameter slider in
the plugin window, the Clip Effects window or an AudioSuite plugin's
window moves the value a tenth as far as the same drag without the key,
as the Strip Silence sliders do. A logarithmic slider moves a tenth as
far along the slider, and a whole-number slider, such as the Sampler's
Root Note, stays on whole numbers. A drag without the key works as
before.
widgets::FineSlider is a new builder with the slider options these
windows use (no value box, logarithmic, whole numbers, a salt for
unlabeled sliders); widgets::fine_slider keeps its signature and calls
it.
* Plugins: Alt-click returns a parameter to its default value
An Alt-click (Option-click on a Mac) on a parameter in the plugin window,
the Clip Effects window or an AudioSuite plugin's window sets the
parameter's default value, as an Alt-click sets a fader to 0 dB. It works
on a slider, on a slider's value box and on a choice list. The click on a
value box does not open it for typing, and the click on a choice list does
not open the list. In the plugin window and the Clip Effects window the
reset runs the same command as a drag, so it is one undo step. While Alt
is held, a drag on one of these sliders leaves the value where it is.
widgets::FineSlider has a new default_value option for this.
* Plugins: FineSlider::default_value describes what a held Alt does
While Alt is held, a drag leaves the value where it is, and an Alt-click
on the value box does not open it for typing. An Alt-click on the rail
sets the default.
* Dialogs: Enter on a focused Cancel or Don't Save no longer runs OK
Enter on a focused button clicks it and also presses the dialog's OK.
In Strip Silence, Enter on Cancel closed the dialog and still stripped
the selected clips. Cancel and Escape now drop the command and the save
that OK asked for, in every dialog. In Unsaved Changes, Enter on a
focused Don't Save closes without saving instead of opening Save.
* Read send destinations only while the menu is open
* Tests: pressing Ctrl during a value-box drag keeps the value
The rest of the drag on the Threshold value box moves as far as a drag
with Ctrl held from the start.
* Bounce Mix: Cancel starts no bounce; fine adjust on more AudioSuite sliders
Enter on a focused Cancel also pressed Bounce, which started the bounce
before the Cancel check ran. The bounce now starts after that check.
The Normalize, Time Shift and Pitch Shift sliders in the AudioSuite
window move a tenth as far while Ctrl or Command is held.
* Tests: give the Enter-on-Cancel bounce test its own scratch folder
It shared bounce-cancel with cancel_or_escape_stops_a_bounce_and_leaves_no_file,
so the two tests removed each other's folder when run in parallel.
* Clip Effects: log-taper parameter sliders use a logarithmic rail
The EQ and Dynamics sliders in the Clip Effects window now follow the
parameter's taper, as the plug-in window does, so a frequency, Q, ratio,
attack or release slider moves along a logarithmic rail.
* Dialogs: leave Enter on a focused Cancel or Don't Save to its own pull request
The dialog changes for Enter on a focused Cancel or Don't Save, the
Bounce Mix change that started the bounce after the Cancel check, and
their tests in save_changes.rs, strip_silence_dialog.rs and bounce.rs
are removed from this branch. The fine adjustment on the sliders stays.
* Plugins: tests cover Alt reset and Ctrl fine adjustment on more slider kinds
Tests now cover Ctrl without Command, Alt pressed during a drag, one
undo step for a choice-list reset, whole-number and logarithmic sliders,
Alt-click and Ctrl-drag on the AudioSuite and Clip Effects value boxes,
and Alt on a Strip Silence slider, which behaves like a plain click or
drag.
The ROADMAP entry limits the choice-list reset to the plugin window, and
the docs/ui-parity.md fine-adjustment row names the Clip Effects and
AudioSuite sliders.
* Plugins: a short Ctrl-drag at the low end of a log slider with a value box moves the value
A fine drag rounded to at most three decimal places, so a one-point
drag near the bottom of a range such as Attack at 0.01 ms rounded back
to where it started. The rounding now allows up to six places.
* Strip Silence: the fine slider's response reports each change of a drag
The value moved by a drag that the key has touched is set before the
slider reads it, so the Response's changed() stayed false on those
passes. fine_slider now marks the response when the value changed.
Tests: a Control-only drag, and changed() on every pass of a Ctrl-drag.
The value box test releases the button once and checks the value after.
* Tests: plugin sliders with Control alone and with Ctrl toggled during a drag
The plugin window's logarithmic and whole-number sliders keep their value
when Ctrl is pressed or released during a drag, and a drag with Control
alone is fine. The tenth-as-far test names the parameters it drags and
checks the others do not change, and the low-end test checks the value
after the release.
* Review fixes after the craft-audio switch; pin craft-audio at craft-libs main
Follow-up to #1506, for its review comments:
- convert: a decode that concealed damaged packets is reported as a warning,
and --in-place refuses to replace the source with it.
- convert: the decoded speaker layout goes to the encoder, so 5.1 with side
surrounds stays side surrounds in WAV and FLAC.
- FileFormat::of names an MP4 or QuickTime file by its codec: AAC or HE-AAC
is Aac, ALAC is Alac, anything else (Opus, AC-3, PCM) is Other.
- Bounce keeps a picked extension that already names the format (Mix.aifc,
Mix.AIFF), so the file written is the one the save dialog confirmed.
- rust-version is 1.95: craft-audio, craft-media and craft-ui declare it, so
1.90 was not a version the workspace builds with.
craft-audio and craft-media move to craft-libs main 7db4645d.
* MIDI: take Standard MIDI Files and the sequence model from craft-midi
craft-midi in craft-libs was moved from this crate (storytold/craft-libs#884):
smf.rs, sequence.rs, the error type and their tests. soundcraft-midi now
re-exports them, so every caller keeps its imports, and keeps what is
SoundCraft's own: the editing operations, the display names and XorShift.
The SMF and Sequence tests are deleted here; they run in craft-midi, which
also adds one for the track limit. The serde names do not change (the same
derives behind craft-midi's serde feature), so sessions read as before.
craft-audio in craft-libs was built from audio-io and FilmCraft's codecs, so
each format has one implementation that every Craft app shares. Call sites use
its API directly: EncodeOptions::new(format).with_*(), EncodeFormat,
DECODE_EXTENSIONS, ENCODE_EXTENSIONS, encode_format_for, AudioInfo's container,
codec and layout.
soundcraft_model::FileFormat stays as the kind of file a session records for
each source: its variant names are part of the session format. It maps from
craft-audio's AudioInfo.
craft-audio and craft-media are pinned to the craft-libs branch of
storytold/craft-libs#824, which adds the extension tables SoundCraft had in
FileFormat and fixes the quadratic WAV chunk scan (#893).
Behaviour that changes: AAC, ALAC, Opus, AC-3/E-AC-3 and MP2 decode with
craft-audio's own decoders; MP4 and Matroska tracks import at their
presentation length; .opus, .ac3, .eac3, .ec3, .mov, .mka and .mpa are
importable names; .aifc is a writable name; FLAC files come from craft-audio's
encoder.
release.yml also runs nightly on main with craft-common-actions' dry-run: every release build
except macOS, with nothing signed, pushed or drafted. Breakage that only the release build hits
(riscv64, Flatpak, FreeBSD, packaging) then shows up the next morning instead of on release
day, as it did on 11 Nov 2026.
* fix(engine): create output files exclusively and check read access before probing
* address review: canonicalize through the checked io gateway, treat any occupied export name as taken
* address review: read group audio through the validated file handle
* address review: document that a write-only root writes a new numbered WAV per save
* address review: clip-group audio is opened without waiting for a FIFO writer
* Strip Silence: cut and remove pieces in one pass over the playlist
* address review: document the sorted-points order and test stretched audio offsets
* fix(ui): check movie read access and file type; private take folder without settings
* address review: make the fallback take folder exclusively under an unguessable name; qualify the owner-only claim to Unix
* address review: unique folder prefix must be one name; no fallback take folder for a saved session
* add tests for the take folder and the movie open checks
* fix(ui): bound MIDI grid lines and Video Universe thumbnails per repaint
* address review: grid fallback stays on snap positions and bars; thumbnail positions in f64
* address review: no thumbnails for an empty shown span
* fix(audio-io): bound packet samples and MP4 audio timing runs
* address review: decide MP4 audio timing bound from the stsd entry and bound PCM packets by their byte size
* address review: the last stsd in a stbl decides whether the stts bound applies
* fix(video): check MJPEG frame size from its header and budget H.264 frame requests
* address review: check the sample budget before reading, keep the decoder from skipping a refused sample, stop on a failed read
* address review: restore lenient MJPEG sizing and unreadable-sample skipping; per-request sample cap 2 GiB
* address review: an unreadable sample counts toward the no-picture budget