daniel543x/soundcraft
1
0 Fork 0
mirror of https://github.com/storytold/soundcraft.git synced 2026-11-08 11:21:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clamp the minimum beat before conversion

Browse Source 
Found while testing crates/time/src/tempo.rs:304

Co-Authored-By: GPT-6-Luna <noreply@openai.com>
This commit is contained in:
Max MittelstädtandGPT-6-Luna committed 2026-10-29 09:05:48 +00:00
1 parent 8ca6939981
commit 0ede26f5bc
1 file changed
+7 -1
Download Patch File Download Diff File Expand all files Collapse all files
crates/time/src/tempo.rs
+7 -1
View File
@@ -301,7 +301,7 @@ impl TempoMap {
pub fn tick_at_bar_beat(&self, bb: BarBeat) -> i64 {
let start = self.bar_start_tick(bb.bar);
let m = self.meter_at_tick(start);
start.saturating_add((bb.beat - 1).max(0).saturating_mul(m.ticks_per_beat())).saturating_add(bb.tick)
start.saturating_add(bb.beat.saturating_sub(1).max(0).saturating_mul(m.ticks_per_beat())).saturating_add(bb.tick)
}
pub fn bar_beat_at(&self, s: Samples, sr: SampleRate) -> BarBeat {
@@ -344,6 +344,12 @@ mod tests {
assert_eq!(m.bar_start_tick(0), -TICKS_PER_QUARTER * 4);
}
#[test]
fn minimum_beat_is_clamped_without_overflow() {
let m = TempoMap::default();
assert_eq!(m.tick_at_bar_beat(BarBeat { bar: 1, beat: i64::MIN, tick: 0 }), 0);
}
#[test]
fn bar_beat_at_min_tick_does_not_overflow() {
let m = TempoMap::default();