mirror of
https://github.com/storytold/photocraft.git
synced 2026-11-21 01:18:43 +00:00
- gpu: the test modules share one GPU_LOCK, and timing and vector_mask take it too, so one process drives one wgpu device at a time. - ui-egui: the wgpu tests in pattern_preview_canvas, adjust_preview_gpu, marquee_autoscroll and layout_perf take gpu_lock(). - affinity compound_limits: the child process selects its test by the module path (compound_limits::<name>); with --exact, the bare name matches no test and the child passes without running the check. - xtask scorecard reads crates/io/tests/it/corpus.rs. - Docs and comments name the new test paths and the --test it filters.
35 lines
2.1 KiB
Markdown
35 lines
2.1 KiB
Markdown
# photocraft-heif
|
|
|
|
The optional HEIF/HEIC decoder of PhotoCraft: iPhone and Mac photos. A thin, panic-guarded wrapper
|
|
around [`heic-rs`](https://github.com/tbraun96/heic-rs), a pure-Rust HEVC still-picture decoder
|
|
(no `unsafe`, MIT OR Apache-2.0): single pictures and grid-tiled photos, 8- and 10-bit (10-bit
|
|
decodes to 16-bit), alpha auxiliary images, the container's rotation/mirror/crop, ICC, EXIF and XMP.
|
|
Read-only: writing would need an HEVC encoder.
|
|
|
|
```rust
|
|
let info = photocraft_heif::probe(&bytes)?; // size, depth, alpha: check limits first
|
|
let img = photocraft_heif::decode(&bytes, &photocraft_heif::Options::default())?;
|
|
// img.width, img.height, img.has_alpha, img.sixteen_bit, img.data (RGB/RGBA), img.icc, img.exif, img.xmp
|
|
```
|
|
|
|
Errors are `Error::Unsupported` (image sequences, overlays, …), `Error::Limit` or
|
|
`Error::Malformed`. It never panics: every call into heic-rs runs under `catch_unwind`, and a panic
|
|
inside it (fuzzing found two in 0.1.1) becomes `Error::Malformed`.
|
|
|
|
## Why it is a separate, optional crate
|
|
|
|
- **A young decoder.** heic-rs is new and has a single maintainer. It is pinned exactly
|
|
(`=0.1.1`); moving the pin is a reviewed change (re-run `cargo fuzz run decode_heif` in
|
|
`crates/codecs` and `cargo xtask test-corpus`).
|
|
- **HEVC patents are a distributor's call.** HEVC is patent-encumbered in some jurisdictions, so
|
|
whether a build includes an HEVC decoder is a build-time choice. `photocraft-codecs` uses this
|
|
crate only behind its non-default `heif` feature; the apps forward it
|
|
(`cargo build -p photocraft --features heif`). Official PhotoCraft builds and CI enable it.
|
|
Without it, HEIC files are still recognised and opening one is a clear "HEIC/HEIF support isn't
|
|
included in this build" error.
|
|
|
|
The crate depends on no other PhotoCraft crate and knows nothing of `photocraft-codecs`' types;
|
|
`codecs` → `heif` is the one allowed dependency between standalone crates (`cargo xtask layers`).
|
|
Tests on real files live in `photocraft-codecs` (`tests/it/heif.rs`, features `corpus,heif`, files
|
|
fetched by `cargo xtask corpus --heif`).
|