Commit Graph
7925 Commits
Author SHA1 Message Date
ReviewerB de48ca6818 Merge main into fix/apprun-preserve-custom-launcher-2905
Resolve the packaging/linux/AppRun conflict by keeping both sides: main's early
`--cli` / `photocraft-cli` ARGV0 dispatch runs first, then this branch's
valid_baseline() check for the desktop-integration launcher.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-30 17:10:05 +01:00
Dylan M. Taylor b1cfff9d30 Merge pull request #10204 from FredApps/integration/approved-bugfix-parity-2026-10-29
Integrate 87 reviewed bugfix and Photoshop-parity PRs
2026-10-30 08:06:22 -04:00
FredApps 722a9bd5cf Merge current main and remove app-local integration workflow additions 2026-10-30 12:22:42 +01:00
Dylan M. Taylor 382b047c30 Merge pull request #10223 from FredApps/ci/test-runtime-2026-10-29
test: partition long parity matrices without dropping cases
2026-10-30 07:12:16 -04:00
Dylan M. Taylor 28be431b4a UPD.1: honor app pretend versions in update checks (#10254) 2026-10-30 03:00:13 -04:00
FredApps 0f120bbda1 Merge current main, reconcile streamed PNG profiles and workflow inputs 2026-10-30 06:52:05 +01:00
Dylan M. Taylor 249d126626 Update prompt shows the app icon and accent color instead of a letter (#10243)
UPDATE_APP (native builds; craft-update is a native-only dependency) carries our 128 px icon and accent (#2f7bf5, its colour in ArtCraft Launcher). The updater, the self-update
helper and craft-update's startup prompt all get them through crate::UPDATE_APP; the
prompt draws the icon, the accent and "by ArtCraft" (craft-update's default developer).

craft-update is pinned to storytold/craft-libs main at 1065653e7 (#434).
Clippy fixes for Rust 1.99 in untouched code (same logic):
- apps/photocraft/src/app_dirs.rs
- crates/codecs/src/codecs/via_image.rs
- crates/engine/src/canvas_geom/tests.rs
- crates/ui-egui/src/panels/blend_preview.rs
2026-10-30 01:27:27 -04:00
FredApps 287aad4cbf test: partition font acceptance matrix and schedule GPU budget stress 2026-10-30 06:13:27 +01:00
FredApps 3b352fa217 test: reserve GPU slots for Windows page-eviction stress 2026-10-30 05:07:28 +01:00
FredApps 4b3b5b1634 test: reduce software GPU contention for heavy Windows regressions 2026-10-30 04:06:44 +01:00
Dylan M. Taylor 0379569d00 CI: workflows only call craft-common-actions at @main (#10228)
AGENTS.md (and CLAUDE.md where present) gets a CI workflows section: workflows only call
craft-common-actions at @main, with no other jobs; feature and fix PRs don't touch CI and
link or open a craft-common-actions issue (a PR only for a small fix that is safe for
every app and does not increase CI time); legacy jobs
aren't added to and move only as their own task, staying until a shared workflow runs them.

windows-arm64.yml moves from its SHA pin to @main. The pinned revision is on
craft-common-actions main and the workflow (and the actions it calls) is identical
there, so nothing changes in behaviour.
2026-10-29 22:22:28 -04:00
FredApps a4ab4873e8 Merge current main, retain full-sweep and new benchmark inputs 2026-10-30 03:05:00 +01:00
aiongg 7d66766afb Merge pull request #10157 from FredApps/integration/reviewed-performance-2026-10-29
Integrate 16 reviewed performance and UI fixes
2026-10-29 21:07:40 -04:00
FredApps 4c000a2683 style: match rustfmt for GPU timing closure 2026-10-30 01:54:14 +01:00
FredApps db6e27ac02 Partition GPU theme cases and profile remaining parity bottlenecks 2026-10-30 01:42:18 +01:00
FredApps 7be59770a4 Use persisted animation preference for localization test setup 2026-10-30 00:50:31 +01:00
FredApps 0cb4ec56d3 Merge current main and complete retained Pen messages in Nordic catalogs 2026-10-30 00:48:24 +01:00
FredApps c8c8fc7821 Reduce repeated GPU setup and UI work; partition remaining regression matrices 2026-10-30 00:39:19 +01:00
aiongg c5352f204e Merge pull request #8715 from dotCooCoo/fix/history-trim-keeps-the-cleared-brush-source
History: trimming to the memory budget after Clear History keeps the History Brush source
2026-10-29 19:23:03 -04:00
FredApps 47eaae523f Apply rustfmt layout to subpixel blur regression 2026-10-29 23:54:51 +01:00
Dylan M. Taylor 6fdd6bb1b7 packaging: Flatpak finds and prints to CUPS printers (#10196)
* packaging: Flatpak finds and prints to CUPS printers

The Print dialog listed no printers in the Flatpak: the runtime has libcups but not
lpstat/lp, the sandbox couldn't reach the CUPS socket, and driverless network printers
(lpstat -e) need Avahi. Bundle lpstat/lp/lpoptions from CUPS 2.4.20 (Apache-2.0,
statically linked, licence installed) and grant --socket=cups and
--system-talk-name=org.freedesktop.Avahi in both manifests.

* print: lp takes the job only when CUPS lists a printer; the only printer by default; ~/.cups read-only

Review (CodeRabbit) on bundling lp in the Flatpak:
- With lp present but CUPS down or empty, the job failed on lp instead of reaching the
  IPP route and the print portal. lp_route now gives up the route when lpstat lists no
  printer, before anything is submitted.
- With no printer named, no default and one queue, IPP picked it but lp failed. lp_route
  names the only printer.
- The sandbox ignored the user's default printer, saved options and client.conf server:
  grant ~/.cups read-only in both manifests.

* print: no printers for lp means the portal, not IPP; bounded listing; CUPS socket wrapper

Review:
- When lp is there but CUPS lists no printer, the job went to the IPP route, whose
  server detection ignores ~/.cups/client.conf and could print to a local default
  printer instead of the configured server. It now goes to the print portal, or fails
  with no portal.
- The lpstat listing before a job is bounded (10 s, then lp takes the job as before)
  and runs outside SPOOLER, which guards only Windows driver calls.
- Flatpak mounts the host's CUPS socket at /var/run/cups/cups.sock whatever path
  client.conf or CUPS_SERVER names; the CUPS tools now run through a wrapper that
  points a socket path missing in the sandbox there, leaving server names alone.

* packaging: redirect a custom CUPS socket only when it is the one Flatpak mounted

Review (CodeRabbit): Flatpak picks the socket it mounts at /var/run/cups/cups.sock
with stricter rules than CUPS (flatpak-run-cups.c: a socket CUPS_SERVER, else the
first line spelled exactly "ServerName /path" in ~/.cups/client.conf, else the
default), while CUPS reads the keyword in any case and takes the last ServerName. The
wrapper now redirects only when CUPS' socket is the one Flatpak chose, so a job can't
reach a different server; otherwise CUPS fails on the missing path.

* print: a printer listing past its deadline kills and reaps lpstat

Review: the 10 s limit stopped waiting but left a hung lpstat and its thread
running, so repeated print attempts could pile them up. photocraft now runs the two
lpstat listings itself (craft-print's lpstat_command and an equivalent lpstat -e,
parsed by printers_parsed) and kills and reaps each one at the shared deadline. The
output is read on a thread that ends with the process, so nothing outlives the job.

* packaging: never redirect a CUPS_SERVER the sandbox was given

Review (CodeRabbit): Flatpak picks the socket it mounts from the host's CUPS_SERVER,
so one set by flatpak run --env or an override may not be what it mounted. The
wrapper now leaves any CUPS_SERVER alone and redirects only a client.conf socket that
matches Flatpak's choice; otherwise CUPS fails on the missing path instead of
reaching a different server.

* packaging: point CUPS at the mounted socket only when it is the one Flatpak chose, else fail

Review (CodeRabbit): with a custom socket listed first and the default last in
~/.cups/client.conf, Flatpak mounts the custom one at /var/run/cups/cups.sock while
CUPS picks the last line, finds that path, and talks to the custom server. The
wrapper now compares CUPS' socket with Flatpak's choice even when the path exists:
equal, CUPS is pointed at the mount; different, the tool fails with an error instead
of reaching another server.

Also (CodeRabbit):
- A printer named in the job goes to lp even when CUPS lists none: listing can be
  forbidden while printing is not, and the portal can't honour a name.
- A failed lpstat -e (CUPS unreachable, listing forbidden) means the list can't be
  told, so lp takes the job, instead of an empty list sending it to the portal.
- A listing longer than 1 MiB counts as no answer, instead of growing without bound.
- The kill test checks the process with kill -0, which works on every Unix.
- docs/printing.md: the only-printer fallback is on the lp and IPP routes, and the
  portal is Linux only.
2026-10-29 18:51:10 -04:00
aiongg 7953633e02 Merge main
# Conflicts:
#	crates/ops/src/tests.rs
2026-10-29 22:48:53 +00:00
FredApps c93c0bb36d Merge main into trimmed integration; reconcile blur, pattern and Liquify behavior 2026-10-29 23:47:53 +01:00
aiongg 158389c408 Merge pull request #10199 from davidmann4/fix/autosave-test-deadline
Tests: the autosave outcome test waits up to 5 minutes for a real write (#10198)
2026-10-29 18:46:14 -04:00
aiongg e74bcc4eda Merge pull request #10021 from davidmann4/i18n/swedish-combined
Swedish, Finnish, Danish and Norwegian interface languages, combined from the community catalogs (#10020)
2026-10-29 18:45:28 -04:00
aiongg d64c0e7556 Merge pull request #10212 from aiongg/ci/i18n-never-fails
Tests: a missing translation never fails CI
2026-10-29 18:44:56 -04:00
FredApps 29bf828ec2 Merge upstream main into reviewed performance integration
Preserve both UI parity status entries; retain all reviewed performance changes.
2026-10-29 23:35:19 +01:00
aiongg 45001fc401 Merge pull request #9166 from FedeOlivares/integration/parity-batch-2
Integration test: 24 parity PRs together
2026-10-29 18:31:06 -04:00
FredApps 4f6ebb1b6e test: partition long parity matrices without dropping cases 2026-10-29 23:23:32 +01:00
aiongg 03c35450ea Remove translation-existence and wording tests; a missing translation never fails CI 2026-10-29 21:57:34 +00:00
aiongg cdb7ba0e21 Merge main into the integration batch 2026-10-29 21:46:27 +00:00
FredApps 73502a6b89 Reconcile Arrange no-op regression with retained command contract 2026-10-29 22:28:41 +01:00
Dylan M. Taylor 0d9a0f6613 Enable update checks in Flatpak (#10206) 2026-10-29 17:24:04 -04:00
FredApps 63637c4d80 Merge current main into trimmed integration, preserving exclusions and interpolation behavior 2026-10-29 21:31:18 +01:00
David MannandClaude Opus 5.5 fbf37cb9bd Merge main into i18n/swedish-combined
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-29 21:16:23 +01:00
David MannandClaude Opus 5.5 ce33b19090 Tests: a failed autosave outcome test does not wait for a stuck write
Address CodeRabbit review: dropping the Autosaver joins its worker, which waits
for the write in progress, so a timed-out receive could still hold the test
until nextest kills it. The saver is now ManuallyDrop and only dropped on the
passing path. With a worker that sleeps 60 s per write and a 2 s bound, the
test fails after 2.01 s.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:15:31 +01:00
David MannandClaude Opus 5.5 f39f94aef8 Tests: the autosave outcome test waits up to 5 minutes, not 30 s, for a real write
background_save_outcomes_report_failure_then_recovery failed on main's Windows
integration job: the real (second) autosave write flushes every tile to disk and
took over 30 s on a busy runner (normally 2-3 s; a concurrent autosave test ran
past 60 s too). The bound only exists to turn a worker that never reports into a
failure instead of a hang, so it is now 5 minutes, still under the 10 minutes
after which nextest's ci profile kills a test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 20:53:19 +01:00
aiongg 8a6771a724 Merge pull request #10174 from davidmann4/fix/ar-select-mask-strings
i18n(ar): the Select and Mask workspace strings; main is green again (#10173)
2026-10-29 15:19:38 -04:00
FredApps 8c8c4b95f5 Deduplicate Portuguese catalog and collect all CI test failures
Audited all 22 catalogs (83886 entries) for duplicates, malformed rows, placeholders, plural form counts and ellipses. Keep every test and failure exit status; disable fail-fast so a single run exposes remaining regressions.
2026-10-29 19:57:18 +01:00
David MannandClaude Opus 5.5 29f37b2c40 Localization parity: the Swedish catalog has 4,552 rows
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:52:23 +01:00
David MannandClaude Opus 5.5 26b18056ab Norwegian Bokmål: Custom Pixel Aspect Ratio has no trailing ellipsis
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:50:12 +01:00
David MannandClaude Opus 5.5 bc45ec814b Merge #9025 (Norwegian Bokmål catalog by @Bolla76) into the combined Norwegian Bokmål catalog
Its translations are part of the combined catalog; this merge records the
branch so the PR closes as merged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:34:10 +01:00
David MannandClaude Opus 5.5 27bf2c49f4 Merge #8072 (Norwegian Bokmål catalog by @nikolainyegaard) into the combined Norwegian Bokmål catalog
Its translations are part of the combined catalog; this merge records the
branch so the PR closes as merged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:34:10 +01:00
David MannandClaude Opus 5.5 d2897eec4a Merge #7267 (Danish catalog by @pechnikov2026-star) into the combined Danish catalog
Its translations are part of the combined catalog; this merge records the
branch so the PR closes as merged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:34:10 +01:00
David MannandClaude Opus 5.5 c06e9c4ff3 Merge #6961 (Finnish catalog by @metuuu) into the combined Finnish catalog
Its translations are part of the combined catalog; this merge records the
branch so the PR closes as merged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:34:10 +01:00
David MannandClaude Opus 5.5 03a33ca291 Merge #5666 (Finnish catalog by @Janiz-zzz) into the combined Finnish catalog
Its translations are part of the combined catalog; this merge records the
branch so the PR closes as merged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:34:10 +01:00
c0fb32db24 Finnish, Danish and Norwegian Bokmål interface languages, combined from the community catalogs
Finnish (fi) combines #5666 and #6961, Danish (da) is based on #7267 and
completed for the current UI, Norwegian Bokmål (nb) combines #8072 and
#9025. Each catalog covers the same 4,552 keys as the Swedish one, with one
term per concept. `no` and `nn` locales resolve to Bokmål; `fi-FI` to
Finnish while `sv-FI` stays Swedish.

Co-authored-by: Janiz-zzz <267742026+Janiz-zzz@users.noreply.github.com>
Co-authored-by: metuuu <25014162+metuuu@users.noreply.github.com>
Co-authored-by: pechnikov2026-star <266495960+pechnikov2026-star@users.noreply.github.com>
Co-authored-by: nikolainyegaard <6809008+nikolainyegaard@users.noreply.github.com>
Co-authored-by: Bolla76 <200539769+Bolla76@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:34:10 +01:00
FredApps 5349314b7f Refresh generated scorecard and restore original documentation workflow 2026-10-29 19:30:11 +01:00
FredApps 4d31d3c16f Temporarily expose scorecard regeneration on GitHub for trimmed integration 2026-10-29 19:23:49 +01:00
FredApps a3e504dc62 Preserve glow enum imports required by retained outer-glow regression 2026-10-29 19:14:37 +01:00