Commit Graph
5847 Commits
Author SHA1 Message Date
PerchAnton 8df3ffd307 fix(engine): simplify displacement map predicate for strict Clippy 2026-10-22 10:45:59 +03:00
PerchAnton b165afc332 Merge main into #7721 and retain exact Crystallize and Ripple fields 2026-10-22 10:12:20 +03:00
zuujiscom afa4cc7964 test(panic_hunt): give the panic-counting self-test its own deadline
contained_panics_count_and_graceful_errors_do_not used the 4 s hang
budget meant for fuzzed commands. With RUST_BACKTRACE=1 the panic hook
prints a backtrace, and on loaded Windows runners the first symbol
lookup took long enough (19.6 s) that run_watched returned None instead
of Some(false). The self-test now waits up to 120 s; the fuzz keeps 4 s.
2026-10-22 00:53:45 -05:00
Khawar Zamman WaniandClaude Opus 5.5 b2c5056a08 fix(color-panel): non-finite pointer no longer panics the wheel; ramp drag keeps its ends
triangle_sv returns None for a non-finite point instead of clamping with a
NaN bound. A drag on the Current Colors ramp draws and picks from the ends it
began with, so a held pick no longer drifts toward the background.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 10:28:45 +05:30
Brian TorresandClaude Sonnet 5.5 68245f1cb4 Raw: list the Nikon ColorSpace tag in the clean-room sources and bump the gaps status line (#5987)
The README's clean-room section names every maker-note tag the crate reads and
where it is documented; 0x001E is added, and the code comment now names
ExifTool's Nikon tag documentation as its source.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rj8vs4QyUES3uwgX6SuGGh
2026-10-21 21:57:54 -07:00
Brian TorresandClaude Sonnet 5.5 f530a98406 Raw: a Nikon maker note's ColorSpace sets the preview colour space (#5987)
embedded_preview_color_space only read the EXIF ColorSpace, but Nikon bodies
write none: they say Adobe RGB only in the maker note (tag 0x001E: 1 sRGB,
2 Adobe RGB). A Nikon NEF with Adobe RGB selected had its JPEG preview read as
sRGB by the colour fit.

When the EXIF does not state a colour space, the Nikon maker note's is used
(the EXIF still wins, a DNG still states nothing, other makers' maker notes
are not read). The maker-note locator in tiffep.rs is shared. A packed Nikon
NEF with the tag joins the hostile-input seeds, and rawinfo prints the stated
colour space.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rj8vs4QyUES3uwgX6SuGGh
2026-10-21 21:57:42 -07:00
Brian TorresandClaude Sonnet 5.5 140fe877ce Docs: record the D4 white-level fix in the status lines and file-format revision history (#5978)
AGENTS.md asks for the status line and revision history of the parity docs to move with the change: gaps.md and file-format-parity.md now carry it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rj8vs4QyUES3uwgX6SuGGh
2026-10-21 21:57:32 -07:00
Brian TorresandClaude Sonnet 5.5 db01269fea Raw: the Nikon D4 white level follows the sample depth (#5978)
The D4 profile's saturation level of 15520 was measured on 14-bit files but
applied to the 12-bit files the body also writes, whose samples are the
14-bit values shifted right by two. 12-bit D4 NEFs developed about 2.6 stops
darker than the same scene at 14 bits, with no warning.

The profile now records the depth its level was measured at, and
cameras::apply takes the stored sample depth: 14-bit files keep 15520, 12-bit
files get 3880. A synthetic D4-sized NEF at both depths must develop within
0.2 stop (it was 2.5 stops apart before); on the public 12-bit D4 files the
difference to the 14-bit twin is now within 0.02 stop.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rj8vs4QyUES3uwgX6SuGGh
2026-10-21 21:57:11 -07:00
Nicolas FalesyandClaude Opus 5.5 9451ed7557 test(histogram): build the parallel-path test only off wasm32 (CodeRabbit)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CD2ipSyvx1tYwnHJZyDs59
2026-10-22 00:49:01 -04:00
Nicolas FalesyandClaude Opus 5.5 48fb3064ec perf(camera-raw): scopes under budget, histogram and overlays in parallel (P36)
Every new Camera Raw preview ran three per-pixel passes over the 447k-pixel
proxy on one thread: the RGB histogram (2.7 ms), the clipping warning
overlay (1.5-2 ms) and the selection mask blend (0.7 ms). They now run with
rayon (plain loops on wasm32). Histogram blocks add with saturating integer
sums, so the counts equal one pass.

camera_raw_bench, Core Ultra X7 358H: interactive scope update (P36) p95
11.0 -> 8.1 ms (budget 10), exposure proxy update (P31) p50 6.1 -> 4.1 ms.

Part of #211.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CD2ipSyvx1tYwnHJZyDs59
2026-10-22 00:36:58 -04:00
Khawar Zamman WaniandClaude Opus 5.5 308460fa4e style: cargo fmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 09:57:46 +05:30
aiongg 78b46b1a99 Merge pull request #3283 from abc2cb/codex/github-smart-filters-usability-20261011
Smart Filters: distinct editors, shared disclosure and stable alpha
2026-10-22 00:26:00 -04:00
Khawar Zamman WaniandClaude Opus 5.5 cb56c99fbd Merge main into feat/6000-color-panel-modes
Main's Color panel HSB/RGB slider switch (#7172, #7317) is replaced by this
branch's panel-menu modes, which include RGB Sliders and HSB Sliders; its
control test now sets colorPanel.mode. The panel takes main's shared
photocraft_color HSB conversions and ui.set's f32-range checks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 09:34:24 +05:30
Yonghyuk Choi bea003acd8 Rebuild unrecorded Gradient Overlays from their end colours 2026-10-22 12:38:20 +09:00
Yonghyuk Choi dc029b93c5 Merge main into Gradient Overlay method branch 2026-10-22 12:38:20 +09:00
Khawar Zamman WaniandClaude Opus 5.5 16d1bc2f1f fix(retouch): carry the Smudge pickup neighborhood through with_effect_on
main split LiveDab's constructor into with_effect (session) and
with_effect_on (a prepared document copy) after #7848's fix was written,
so the cherry-picked fix no longer compiled. with_effect_on keeps its
halo signature for the eraser and Pattern Stamp callers; the body moves
to with_neighborhood_on, which Smudge's live stroke reaches through
with_neighborhood.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 08:31:29 +05:30
Ian Swope b0ed288292 Compose: the effect cache estimate counts the maps the builder makes (strokes' distance fields, none for overlays)
fx_region_bytes counted the shape plus one map per enabled effect. Strokes
also build an inside distance and one or two outside fields, and overlays
and strokes build no map of their own, so a stroke-heavy document could
stay under the estimate while thrashing, and an overlay-only one could be
clipped though it fits. effects::map_count, next to build_maps_prepared,
counts what it builds; the test checks it equals FxMaps::bytes per layer.
2026-10-21 21:58:39 -05:00
aiongg 1033aab750 Integration: cargo fmt 2026-10-22 02:56:39 +00:00
skylar taylor-barrick f4cff2780c test(retouch): name live dab replay regressions by behavior 2026-10-22 08:16:51 +05:30
skylar taylor-barrick 0635061b86 fix(retouch): preserve Smudge pickup through live stroke release 2026-10-22 08:16:51 +05:30
aiongg 62d4573609 Integration: cargo fmt 2026-10-22 02:41:49 +00:00
aiongg 995927592b Integration: DDS_PITCH is defined once after #5864 met the DDS writer 2026-10-22 02:36:51 +00:00
aiongg 882cbe1c2c Merge PR #7240: Save As on Linux: the one file type offered gives the name its extension 2026-10-22 02:36:51 +00:00
Khawar Zamman WaniandClaude Opus 5.5 3649a4e6ea docs(ui-parity): a Hand-tool ⌘-drag follows Scrubby Zoom (#6434)
The Hand tool's held Zoom goes through `zoom_tool::drag`, so with Scrubby
Zoom off a ⌘-drag draws a zoom rectangle rather than scrubbing. Say so in
the parity row, and test that case.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 08:06:05 +05:30
aiongg 98d8ada8b9 Integration: cargo fmt 2026-10-22 02:33:11 +00:00
aiongg 624b7ebaf7 Integration: #7262 Clipping Mask export refuses a numeric layer reference, as the other layer events do 2026-10-22 02:32:30 +00:00
aiongg 1e0532c7ff Integration: cargo fmt 2026-10-22 02:31:11 +00:00
aiongg d3cc3a69fb Integration: #8344 compare the Photo Filter dictionary as bytes (the field is Vec<u8> on main) 2026-10-22 02:30:49 +00:00
aiongg de2d5255fc Integration: #5566 the panel-defaults test sets the edit's document (TextEdit gained the field on main) 2026-10-22 02:30:33 +00:00
aiongg 754692c45c Integration: #7638 test's Bevel literal sets gloss_anti_alias, a field main added 2026-10-22 02:28:48 +00:00
aiongg 81fb7e7277 Integration: #6453 the T-icon drag test sets the edit's document 2026-10-22 02:28:23 +00:00
aiongg 82df3f7fe6 Merge PR #8034: fix(format): make Windows native-save publication durable
crates/format/src/store.rs: the Windows tiles/blobs directory flush goes before main's manifest write (main publishes the manifest before removing stale previews), and that write takes the PR's fs argument; the PR's second manifest write is dropped.
2026-10-22 02:28:02 +00:00
aiongg dfde38919e Merge PR #7883: Save As JPEG: JPEG Options dialog (quality 0–12, Baseline / Optimized / Progressive) (FILE-215-19)
crates/ui-egui/src/lib.rs: replay_save doc comment names both Export As and JPEG; replay_save uses the PR's FormatChoices::from_step, after main's export_dialog::replay branch.
docs/file-format-parity.md: header keeps main's text plus the JPEG Options item (last updated 2026-10-19); TIFF row is main's, JPEG row is the PR's; change-log rows once each, newest first.
docs/gaps.md: header keeps main's text plus the G10 item (last updated 2026-10-19).
2026-10-22 02:27:46 +00:00
aiongg 7a25b3f38b Merge PR #7099: test(cli): pin photocraft-cli argument parsing before the clap port (#7071) 2026-10-22 02:27:40 +00:00
aiongg 0ad6cfccd7 Merge PR #7795: Print: Scale to Fit Media fills the driver's printable area (#7782)
Conflicts:
crates/engine/src/print_cmds/tests.rs: appended tests, kept both
2026-10-22 02:27:40 +00:00
aiongg 97ba6b3aa9 Merge PR #5980: Raw: the Nikon D4 white level follows the sample depth (#5978)
Conflicts:
docs/gaps.md: header line is ours plus the PR's missing change item (later Last updated date); change-log rows kept both, newest first
docs/file-format-parity.md: same
2026-10-22 02:27:26 +00:00
aiongg 57028352b4 Merge PR #7662: Preferences: Zoom Resizes Windows resizes floating document windows, and the Zoom tool shows it as Resize Windows to Fit (#204)
crates/engine/src/prefs.rs: neither general.zoomResizesWindows (this PR implements it) nor general.animatedZoom (PR #3698 in this track implements it) stays in HIDDEN_UNTIL_IMPLEMENTED.
crates/ui-egui/src/prefs_ui.rs: kept both is_hidden asserts.
crates/ui-egui/src/i18n/*.tsv (20 catalogs): union of both sides' rows; no duplicate (context, source) keys.
docs/scorecard.md: ours (regenerated at combine).
2026-10-22 02:27:20 +00:00
aiongg 39fbee3dab Merge PR #5988: Raw: a Nikon maker note's ColorSpace sets the preview colour space (#5987)
Conflicts:
docs/gaps.md: header line is ours plus the PR's missing change item (later Last updated date)
2026-10-22 02:27:12 +00:00
aiongg d8865fc682 Merge PR #7638: Map the bevel's shading through its gloss contour, not its light (#7360)
crates/compose/src/effects.rs: kept main's par_units row loop in bevel_maps and ported the PR's change into it: k maps shade and the flat-face level through the gloss contour (lut_at), and the closure returns (hi, sh) without the apply_contour pair.
2026-10-22 02:27:06 +00:00
aiongg 79ff67c3f2 Merge PR #7249: fix(atn): reject non-replace select.rect modes in .atn export (#7194)
Conflicts:
crates/engine/src/atn_cmds/tests.rs: appended tests, kept both
2026-10-22 02:27:06 +00:00
aiongg ed92bfdedb Merge PR #6452: Hand tool: hold Ctrl/Cmd to zoom in, Alt to zoom out (#6434)
Conflicts:
docs/ui-parity.md: header line is ours plus the PR's missing change item (later Last updated date); change-log rows kept both, newest first
2026-10-22 02:27:01 +00:00
aiongg e42cfd2159 Merge PR #7574: Move tool: moving selected pixels shrinks the selection, transform controls and snapping to them (#7538)
crates/engine/src/float_cmds.rs: kept main's cut_piece (parallel, shares full tiles) and try_lift_coverage, and the PR's CutParts::outline; the outline is read from the piece's alpha, which holds min(alpha, selection) as the PR's own lift loop computed, instead of replacing cut_piece with that loop.
crates/engine/src/float_cmds/tests.rs: git interleaved the two sides' new tests; took main's file and appended the PR's added tests whole.
docs/ui-parity.md: header line keeps main's text plus the PR's #7538 item.
2026-10-22 02:26:55 +00:00
aiongg ac0e29ca4c Merge PR #7115: fix(atn): map Apply Layer Comp steps by name (#7101)
Conflicts:
docs/gaps.md: header line is ours plus the PR's missing change item (later Last updated date); change-log rows kept both, newest first
docs/file-format-parity.md: same
2026-10-22 02:26:51 +00:00
aiongg d1f5bae8c3 Merge PR #7232: fix(atn): export recorded layer.select with name parameter (#7185)
Conflicts:
crates/engine/src/atn_cmds/tests.rs: appended tests, kept both
2026-10-22 02:26:31 +00:00
aiongg 8a4fe7c607 Merge PR #7656: Refuse .atn export of resolution-only Image Size without keepPrintSize
Conflicts:
crates/engine/src/atn_cmds/tests.rs: appended tests, kept both
2026-10-22 02:26:26 +00:00
aiongg 1fbf1d8f14 Merge PR #7800: Guides: show the X or Y position beside the pointer while dragging
Conflicts:
docs/ui-parity.md: header line is ours plus the PR's missing change item (later Last updated date); change-log rows kept both, newest first
2026-10-22 02:26:17 +00:00
aiongg d8cf34a6bc Merge PR #8203: Preferences: list the languages alphabetically by their own name 2026-10-22 02:26:11 +00:00
aiongg 4fed3ddc57 Merge PR #8137: Fix tooltip text in scrub_label function 2026-10-22 02:26:09 +00:00
aiongg 02c9e32d1d Merge PR #8088: fix(type): resolve exact PostScript names in type.create 2026-10-22 02:26:06 +00:00
aiongg c68d43a115 Merge PR #7947: Type: hovering a served font fetches it after a short rest, not as the pointer passes 2026-10-22 02:26:04 +00:00