Commit Graph
5847 Commits
Author SHA1 Message Date
aiongg 26919b7a9a Merge PR #8152: fix(ui): grey out Select and Mask in the options bar without a selection (#7520) 2026-10-22 15:37:32 +00:00
aiongg b18d7f1749 Merge PR #7922: Create Rectangle and the other shape dialogs: right-click Width or Height to pick their unit (#7786) 2026-10-22 15:37:31 +00:00
aiongg 05b0ae05e4 Merge PR #6896: fix: detect dominant foregrounds with Object Finder
docs/gaps.md: header and change-log row once each (the PR's row on top).
docs/ui-parity.md: header and change-log row once each; the Selection row keeps main's #6549 sentence and adds the PR's #6548 sentence.
2026-10-22 15:37:31 +00:00
aiongg 7e3517c090 Merge PR #6835: Object Finder: hovering with an empty active layer shows the status-bar hint (#6549) 2026-10-22 15:37:30 +00:00
aiongg 704a420860 Merge PR #6692: Find small objects in large documents with the Object Finder 2026-10-22 15:37:30 +00:00
aiongg a1d23fd2a6 Merge PR #6484: Shapes: the Color panel, Swatches and Gradients fill the selected shape (#5568)
crates/engine/src/presets/tests.rs: tests appended by both sides, kept whole (the PR's before main's persistence sections).
crates/ui-egui/src/swatches_ui.rs: tests appended by both sides, kept whole.
2026-10-22 15:37:30 +00:00
aiongg afc3619b52 Merge PR #6252: Paths panel: rename a path in place, and name the Work Path when saving it
crates/ui-egui/src/vector_ui.rs: kept both sides in paths_panel (main's trash-drag state, the PR's rename id) and both new tests; the PR's tests call path_context_actions with main's added layer argument (None).
2026-10-22 15:37:29 +00:00
aiongg c9173cc9f2 Merge PR #6201: Add hex color input to shape Fill and Stroke popovers
docs/ui-parity.md: header keeps main's date and gains the PR's change entry; change-log rows for both, newest first.
2026-10-22 15:37:29 +00:00
aiongg 26dbd7953b Merge PR #5834: Shapes: rounded corners on live triangles, polygons and stars (TOOL-214-12)
docs/scorecard.md: ours (regenerated at combine).
docs/ui-parity.md: kept main's header and added the PR's change entry once.
2026-10-22 15:37:29 +00:00
aiongg f094216481 Merge PR #5412: fix(pen): an unclosed path stays with its document (#5373)
crates/ui-egui/src/lib.rs: kept both cancel_stale calls (perspective crop from main, pen from the PR).
crates/ui-egui/src/vector_ui.rs pen_down: kept main's resume-at-endpoint block and the PR's pen_doc claim; the claim comes first so a resumed path is claimed by its document too.
2026-10-22 15:37:29 +00:00
aiongg 7654482fd1 Merge PR #3330: Moving a shape keeps its rendering: Artboards to Files matches the reference app
crates/engine/src/layer_multi_cmds.rs: took the PR's call to shift_shape; main's added check that the moved path (plus stroke) stays inside the canvas moved into shift_shape (vector_cmds.rs) so both behaviours hold.
2026-10-22 15:37:29 +00:00
aiongg 1273077cda Merge PR #8296: fix(ui): Free Transform corners show the diagonal resize arrow on wide or tall boxes 2026-10-22 15:37:16 +00:00
aiongg e4d2c0cca6 Merge PR #8201: Warp: a surface drag commits exactly as previewed, now under test (#7885) 2026-10-22 15:37:15 +00:00
aiongg 900606460d Merge PR #8021: Keep previous crop length when normalizing rounds to zero 2026-10-22 15:37:14 +00:00
aiongg 3d7aa3e081 Merge PR #8010: fix(geom): reject extreme warp split indices without overflow 2026-10-22 15:37:14 +00:00
aiongg 3e95fd622b Merge PR #7943: fix(transform): keep artboard paper below child previews
docs/ui-parity.md: header change line: kept main's line and added this PR's item first; Last updated stays 2026-10-21.
2026-10-22 15:37:13 +00:00
aiongg 959a7c369f Merge PR #7798: fix(ui): guides draw over the Puppet Warp, Perspective Warp and Vanishing Point previews (#7781) 2026-10-22 15:37:13 +00:00
aiongg a78dfcf711 Integration: #6936 crop_size::target takes pt_per_in 2026-10-22 15:37:12 +00:00
aiongg 7c08e3d7bb Merge PR #6936: Crop tool: switching tools drops an untouched ratio-fitted frame instead of cropping
crates/algo/src/features.rs: comment-only conflict from a commit already on main; kept main's side.
crates/ui-egui/src/crop_ui.rs: fit_frame conflict; kept the PR's side (its 2-argument crop_size::target call does not compile on main; fixed in the next commit).
2026-10-22 15:37:12 +00:00
aiongg 48ccb21290 Merge PR #6786: Puppet warp: Fix discrepancy between preview and the final state
crates/ui-egui/src/puppet_ui.rs: tests added by both sides in the same place; kept both whole (#6754's pin-deletion tests, then #6786's drag-preview tests).
2026-10-22 15:37:12 +00:00
aiongg 6a257627b1 Merge PR #6754: Puppet warp: Delete and Backspace remove the selected pin 2026-10-22 15:37:12 +00:00
aiongg 9eb30f41a8 Merge PR #6224: Free Transform: a rotated sprite's soft edge keeps its colour instead of a light border 2026-10-22 15:37:11 +00:00
aiongg 3ce61355f1 Merge PR #6186: Free Transform: picking another tool or layer applies a background commit (#5665, #5667) 2026-10-22 15:37:11 +00:00
aiongg 63f3dbfd5b Merge PR #6042: fix(ui): keep Clone Stamp source preview crisp when zoomed in 2026-10-22 15:37:11 +00:00
aiongg 3c329fa530 Merge PR #5545: Keep Free Transform preview colors consistent with the canvas 2026-10-22 15:37:11 +00:00
aiongg 4ec2ef53c9 Merge PR #3926: feat(ui): Free Transform 3x3 reference point widget and projective homography pivot snapping 2026-10-22 15:37:11 +00:00
JGF 2c8929d801 Merge upstream main into CPU pixel alignment fix
Preserve current upstream behavior and existing regressions; refresh hosted validation and SonarCloud configuration.
2026-10-22 11:30:54 -04:00
ebosido444-ai c58c0412fb Merge remote-tracking branch 'origin/main' into perf/oil-paint-lic 2026-10-22 18:30:41 +03:00
1752dc22f6 Integration: pin the damage flag for layers without channel data (#6658)
dc1ced70 makes a layer whose bounds hold pixels but which has no colour
or transparency channel mark the import damaged; no test covered it.
The first test fails with that line back on plain `warn`. The second
pins the ordinary case: a layer with empty bounds (an empty layer, or a
text or shape layer written without a pixel cache) returns before the
check, so it never marks the file damaged, even with no channels. None
of the 737 corpus PSD/PSB files reaches the new branch.

Co-authored-by: DavidBonnier <4418006+DavidBonnier@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 17:27:20 +02:00
Arian100andClaude Opus 5.5 51cd9e1e8c test(atn): check an old BlnW Make keeps its settings; document adjustment_by_class
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 17:08:54 +02:00
JGF 4778942d5d Merge upstream main to refresh adjustment clipping checks
Retain GitHub's clean merge tree and upstream's quick-export formatting correction.
2026-10-22 11:06:10 -04:00
6b551c11e8 Integration: MCP ui_set doc, no update check in Flatpak, DIST-220-1 partial (#5485)
- ui.set gained updatesOpen, but the MCP ui_set description didn't name it, so
  automation's ui_set_description_names_every_accepted_field failed on main.
- The Flatpak grants no network on purpose and `flatpak update` owns updates there,
  yet every launch started a check that could only fail and Help > Check for Updates
  stayed enabled. Flatpak builds now get no update transport (the item is disabled,
  as in the web build); flatpak_builds_have_no_update_transport pins it.
- The PR changed scorecard row DIST-220-1's target from "periodic" to "startup" and
  marked it done. The target is back as written and the row is partial: one check
  per launch, no periodic recheck while the app stays open. gaps.md G17 and the
  parity Platforms row say the same; docs/scorecard.md regenerated.
- Merge leftovers: a doubled Services::inbox doc line, and the Serbian
  release-check rows moved below main's newer rows to the end of sr.tsv.

Co-authored-by: ZhuanTou33212 <285931757+ZhuanTou33212@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 17:01:33 +02:00
1b642e0d64 Integration: merge the new head of #6658, resolve conflicts (#6658)
The author's dc1ced70 (doc comments; a layer with bounds but no channel
data now marks the import damaged) on top of our earlier fix-up. Only
conflict: io/src/lib.rs, where main's import_psd (#5258) sits next to
the new doc comment on import_stages; both kept.

Co-authored-by: DavidBonnier <4418006+DavidBonnier@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 17:01:31 +02:00
6f56a4d750 Integration: merge main, resolve conflicts (#5485)
Main moved about 1,860 commits since the PR's last merge. i18n catalogs keep both
sides' rows; control.rs keeps updatesOpen next to main's strokeTrace (39 fields);
Services keeps check_updates next to main's place_inbox; Cargo.lock is main's,
re-resolved for ureq and semver; docs/gaps.md, docs/target-app-parity.md and
docs/scorecard.md are main's (the PR's entries come back in the next commit).

Co-authored-by: ZhuanTou33212 <285931757+ZhuanTou33212@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 16:36:42 +02:00
Nicolas Falesy 4f50cfb6ad Merge remote-tracking branch 'upstream/main' into perf/gpu-layers-before-caches 2026-10-22 10:08:18 -04:00
aiongg 8f09d122d3 Merge pull request #8562 from aiongg/fmt-main-fix
Format the quick export test (#8535)
2026-10-22 09:53:29 -04:00
aiongg 95e59a99c0 Format the quick export test (#8535) 2026-10-22 13:52:23 +00:00
Nicolas FalesyandClaude Opus 5.5 18eb34b012 fix(gpu): an exact resident budget returns the loan and lends nothing (CodeRabbit)
set_resident_budget now gives the borrowed bytes back to the effect-map
share before setting the exact budget, so memory_budget() stays the total,
and fit_layers lends nothing until the next set_memory_budget.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CD2ipSyvx1tYwnHJZyDs59
2026-10-22 09:48:43 -04:00
JGF 2a5985a5d1 Apply CI formatter output to compact panel test 2026-10-22 09:41:49 -04:00
ebosido444-ai 7ed4b9e0ef Oil Paint: round sample coordinates without the libm call
The line integral convolution takes 21 bilinear samples and 20 tangent lookups per
output pixel, and every one of those computed its coordinate with `f32::floor` or
`f32::round`. On the baseline x86-64 target both lower to library calls (`jmp floorf`
and `jmp roundf` in `rustc --emit asm`), so the filter spent most of its time in 82
call-and-return pairs per pixel.

`sample()` now truncates the coordinate it already clamped to the window, and the
tangent and bristle lookups use `round_i32`/`round_index`, which produce the same
integer for every position a tile can produce.

The output is bit-identical: six 600x400 fixtures (default, short, long, unlit, RGB
without alpha, CMYK) compare sample for sample with `cmp` and a per-channel maximum
delta of 0.0. 24 MP Oil Paint is 1.88x faster on the minimum of five alternating pairs,
measured on a contended 4-core machine; docs/oil-paint-performance.md has the numbers,
that caveat and the alternatives that were measured and rejected.
2026-10-22 16:34:07 +03:00
Martin BallandClaude Opus 5.5 4bfeb7889d Fixes #8519 quick export honours extension (#8535)
* fix(engine): Quick Export writes the format its path names (#8519)

Quick Export as PNG renamed to photo.jpeg in the save dialog wrote PNG
bytes under a JPEG name, which upload checks refuse and file managers
don't preview. The path's extension (.jpg/.jpeg/.png/.gif/.webp) now picks
the format; any other extension is refused with a pointer to Export As;
no extension keeps Export Preferences' format.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* contributors: add benandez's real name

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-22 09:28:42 -04:00
JGF 493c58c67d Match compact Rust formatting for wheel input fixture 2026-10-22 09:27:41 -04:00
JGF 51b9a89348 Test compact adjustment editor and visibility reachability 2026-10-22 09:26:27 -04:00
Nicolas FalesyandClaude Opus 5.5 336c419f2f perf(gpu): layer pages that just miss borrow the effect-map share (P60/P61)
On an integrated GPU, 150 full-canvas 6 MP layers needed 3800 MB of
pages against a 3607 MB page share (the rest of the 4587 MB budget is
reserved for effect maps and lower-stack chunks), so every opacity or
visibility change went to the CPU compositor. Compositor::fit_layers lends
the pages the shortfall from the effect-map share when that covers it; an
evicted effect map is rebuilt by the next refresh that draws it. The
lower-stack share is never lent, and the loan holds across the budget set
before every refresh.

Arc B390: P60 p50 707-768 -> 66-70 ms, P61 704-766 -> 70 ms, peak RSS
7.0 -> 4.5 GB.

Part of #5973.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CD2ipSyvx1tYwnHJZyDs59
2026-10-22 09:18:02 -04:00
fb598b25e8 Integration: merge main, resolve conflicts (#5598)
docs/scorecard.md conflicted with main (a generated file). Regenerated it
with cargo xtask scorecard on the merged tree: settings that do nothing
24 -> 23 of 171, plug_ins.generator_enabled leaves the Unread list.

Co-authored-by: reynold-hu <88558425+reynold-hu@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 15:14:10 +02:00
David Bonnier dc1ced7063 fix(psd): mark layers with no recognized channels as damaged
Use `warn_unreadable_data` instead of `warn` when a layer has no
recognized channel data.

This ensures the import is flagged as damaged and triggers the
interactive confirmation dialog, warning users that saving the
document may discard unrecognized channel data.
2026-10-22 15:08:32 +02:00
David Bonnier 8b2c722dc8 docs: add missing Rustdoc comments for PSD recovery 2026-10-22 15:03:32 +02:00
ebosido444-ai 4c9626167a review: print the real median, regenerate the scorecard
With --reps > 1 the console line printed the last sample and called it the
median. Sort the samples and print the median (mean of the two middle values
for an even count); the JSON report is unchanged.

The four new scenarios also made docs/scorecard.md stale, which failed
'test (ubuntu-latest)': cargo xtask scorecard now lists P64-P67.
2026-10-22 15:20:54 +03:00
6903879111 Integration: Color panel menu in custom workspaces, web-safe ramp pick (#6055)
- A floated Color panel, or one in a custom workspace, had no way to change its mode: the
  shared docking renderer's panel menu had no Color entry, and the in-panel HSB/RGB button
  this PR replaces is gone.
- Make Ramp Web Safe drew each cell from its centre but picked at the raw pointer, so a click
  near a cell's edge set a different web colour (Grayscale Ramp, 5th cell: drawn FF, picked CC).
- A Web Color field took a sign ("+F" set 0F); a click beside the Color Wheel changed the hue
  (Photoshop ignores it); Photoshop's panel menu has no separator before Grayscale Slider.

Each comes with a test that fails without it.

Co-authored-by: Khawar Zamman Wani <28915582+wanikhawar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 14:02:32 +02:00
Eddi Andree Salazar MatosandClaude Opus 5.5 686a4bb93e Merge storytold/photocraft main into fix/windows-reserved-names
Conflict in crates/engine/src/file_cmds/tests.rs: both sides added tests at
the end of the file. Kept all three (sanitize device names, exposure text,
gzipped XCF listing). main's Save for Web slice rework still goes through
`slice_file` / `portable_generated_stem`, so the device-name fix applies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 06:59:58 -05:00