Commit Graph
11477 Commits
Author SHA1 Message Date
David Mann 81236bdfd2 Merge pull request #13079 from davidmann4/fix/default-tool-cursor-complexity
Fix main: split the Pencil outline out of draw_default_tool_cursor (clippy cognitive complexity)
2026-11-11 01:43:13 +01:00
David MannandClaude Fable 5.2 47d3dcde33 Fix main: split the Pencil outline out of draw_default_tool_cursor
main fails the gate at clippy since #12214 landed: its Count arm took
draw_default_tool_cursor to a cognitive complexity of 31 (limit 30).
The Pencil / Block eraser outline moves into pencil_outline_cursor;
behaviour is unchanged.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 01:36:38 +01:00
David Mann e99e07c04a Merge pull request #13022 from ljkx/feat/sponge-flow-field
Sponge: the options bar has a Flow field and strokes use it (#12976)
2026-11-11 01:27:21 +01:00
David Mann 9064c343d1 Merge pull request #13044 from rmsff/fix/warp-split-mode-stays-armed-12498
Warp: a Split button places one split, then its mode ends
2026-11-11 01:27:10 +01:00
David Mann c882bfd832 Merge pull request #13043 from rmsff/fix/red-eye-refuses-non-rgb-12575
Red Eye: refuse CMYK, Grayscale and Indexed Color documents
2026-11-11 01:26:57 +01:00
David Mann e1c5b771ea Merge pull request #13074 from storytold/fix/ruler-new-tuple-pattern
Fix main: match the tuple variant Drag::RulerNew(_) in the ruler Escape check
2026-11-11 01:16:00 +01:00
David MannandClaude Fable 5.2 9653bf1da6 Ruler: match the tuple variant Drag::RulerNew(_) in the Escape check
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 01:13:19 +01:00
David Mann b4383dbeed Merge pull request #13003 from rmsff/fix/sharpen-refusal-alerts-12952
Sharpen: alert on a hidden, locked or group layer
2026-11-11 01:08:19 +01:00
FredApps 847d87bb9b Windows: a pen moves and resizes the window through the custom title bar (#7967) (#12992)
* Windows: a pen or a finger moves and resizes the window through the custom title bar (#7967)

winit takes pen and touch input as WM_POINTER messages and Windows makes no mouse
input from them, so the OS move/size loop that StartDrag/BeginResize start saw no
button down and never ran. winit only clears its dragging flag when that loop ends,
so after one pen try the mouse could no longer move the window either. A pen or
touch press on the title bar's gap or an edge now moves or resizes the window
itself (OuterPosition/InnerSize), restores a maximized window under the pen, and
stops at the minimum size; the mouse still hands the move to the OS.

* Pen title-bar move and resize follow the pen's own screen position (#7967)

On Windows winit moves the window asynchronously (SWP_ASYNCWINDOWPOS), so the
window position egui reads can be ahead of the window-relative pen position and
the drag counted the move twice (an injected pen ran +687/+909 for +200/+120).
The tablet hook now keeps the pen's screen pixels from GetPointerPenInfo
(ptPixelLocation) while the pen is down, and a PenDrag follows that.

A drag that follows the OS position no longer needs egui's pointer position: the
parked mouse cursor can leave the window as it moves away, and egui-winit's
PointerGone ended the drag after a few steps. It ends on release or when no
touch is down.
2026-11-11 01:08:12 +01:00
David Mann c908c79235 Merge pull request #12355 from rmsff/fix/type-mask-off-canvas-12074
fix(engine): a Type Mask keeps the part of its selection past the canvas edge (#12074)
2026-11-11 00:55:07 +01:00
David Mann f1b9b09f29 Merge pull request #13006 from rmsff/fix/make-selection-dialog-12917
Make Selection: Rendering and Operation groups; the dialog's step is Selection Change
2026-11-11 00:54:51 +01:00
David Mann 18ec9b1dc8 Merge pull request #12334 from rmsff/fix/vertical-type-history-name-12058
fix(engine): new vertical text is the history state "New Vertical Type Layer" (#12058)
2026-11-11 00:53:57 +01:00
David Mann d58afecac9 Merge pull request #12244 from ElNeMeR70/fix/gradient-live-drops-selection-12196
fix(engine): drop selection after masking a live Gradient Fill layer
2026-11-11 00:53:39 +01:00
David Mann 00430df4fe Merge pull request #12161 from hectorviov/fix/wand-inside-selection
Magic Wand: a New-mode click inside the selection deselects, a drag moves the outline (#11782)
2026-11-11 00:53:22 +01:00
David Mann 723cd6483e Merge pull request #12165 from hnoerenberg/fix/rotate-dialog-two-decimals-12035
fix(ui): the Arbitrary rotation dialog keeps the ruler's two decimals (#12035)
2026-11-11 00:53:03 +01:00
David Mann 8e104a84ae Merge pull request #12270 from DuBearte/fix/11980-ruler-click-keeps
Ruler: a plain click keeps the current ruler instead of deleting it
2026-11-11 00:52:10 +01:00
David Mann 536d4e7b67 Merge pull request #12214 from hectorviov/fix/count-cursors
Count tool: arrow cursors with 1+, 1 over a marker and 1- with Alt (#11773)
2026-11-11 00:51:50 +01:00
David Mann 5ba0bb0a3a Merge pull request #12201 from hectorviov/fix/eyedropper-zoom-box
Eyedropper: at 100 % zoom and below an N by N Average covers (N+1) x (N+1) screen pixels (#11751)
2026-11-11 00:51:27 +01:00
David Mann e9ab58e1f5 Merge pull request #12209 from DuBearte/fix/11966-auto-erase-exact
Pencil Auto Erase: the start pixel must be exactly the foreground colour
2026-11-11 00:51:02 +01:00
David Mann c4b4afc0a9 Merge pull request #12169 from DuBearte/fix/11886-airbrush-rate
Airbrush: about ten dabs a second while held, and a click lays two dabs
2026-11-11 00:50:39 +01:00
ljkxandClaude Fable 5.2 de5baf8746 Merge main into feat/sponge-flow-field
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 00:15:38 +01:00
rmsff 551f9d2369 Test the Sharpen tool's layer alerts
Makes the Brush alert tests' helpers pub(super) and reuses them.
2026-11-11 02:08:55 +03:00
rmsff 8122d83e7c Test the Make Selection dialog's groups, greyed operations and History step (#12917) 2026-11-11 02:08:55 +03:00
rmsff 72dbfd9725 Sharpen: alert on a hidden, locked or group layer (#12952)
A Sharpen press on a hidden target layer, a layer with Lock All or
Lock Image Pixels, or with a group active opens the reference
application's modal alert instead of a status-bar message. A tool with
a colour-mode alert now gets it first and falls through to the layer
checks otherwise; the Dodge tool still has no layer alerts.
2026-11-11 02:08:55 +03:00
rmsff 8824661f47 Make Selection: Rendering and Operation groups; the dialog's step is Selection Change (#12917)
The Pen's Make Selection dialog (canvas menu, options bar) now has
Photoshop's layout: Rendering with Feather Radius in pixels and
Anti-aliased, then Operation with New / Add to / Subtract from /
Intersect with Selection as radio buttons. The last three are greyed out
without a selection. The fields and params are the same as before.

OK with New Selection names the step it added "Selection Change".
Cmd/Ctrl+Enter, the Paths panel and the combining operations keep
"Make Selection" (not measured).
2026-11-11 02:08:55 +03:00
rmsff 0cb2e8cc99 Test the one-shot Warp split buttons 2026-11-11 02:04:25 +03:00
rmsff 639b446ffe Warp: a Split button places one split, then its mode ends
The options-bar Split buttons stayed armed after the split, so every further
click on the canvas added another line. The release that places a split now
clears split_tool, as in the reference; a release that places none keeps the
mode armed, as today. The existing test now expects the mode to end instead of
staying armed.
2026-11-11 02:04:25 +03:00
rmsff ab19246243 Test the Red Eye tool's colour mode refusal 2026-11-11 02:04:08 +03:00
rmsff 9c7e055957 Red Eye: refuse CMYK, Grayscale and Indexed Color documents (#12575)
A click in these modes opens the reference's alert instead of running, and paint.redEye returns the same text, leaving pixels and History unchanged. The two tests that expected CMYK to run and Grayscale to miss now expect the refusal.
2026-11-11 02:04:08 +03:00
David Mann de9add28b2 Merge pull request #13023 from ljkx/fix/pen-enter-tests-make-labels
Pen Enter tests: look the Make buttons up by their new labels (main red since #12993)
2026-11-11 00:00:07 +01:00
Dylan M. Taylor f45711c749 codecs: check TIFF structural tags, predicted rows and JPEG chunk frames (#10983)
* codecs: check TIFF structural tags, predicted rows and JPEG chunk frames

- Duplicate structural tags: the directory checks read a tag's first
  entry and the tiff crate its last, so a small SamplesPerPixel first
  and a large one last was admitted with one value and sized with the
  other. A repeated structural tag is now refused.
- Floating-point predictor: the tiff crate reads each tile row at its
  full stored width into a buffer of its own, outside the scratch cap.
  That row (TileWidth x samples x sample size) must now fit the cap.
- JPEG-compressed chunks: the tiff crate decodes each chunk into a
  whole JPEG image sized by the embedded frame header, with no limits.
  Each chunk's frame (read from the chunk or JPEGTables, at most 256
  marker segments in) must now fit the nominal strip or tile, as
  libtiff requires, and its decoded size must fit the scratch cap.

* address review: JPEG chunk dedup by count, offset-2 frame, shared fill budget

* address review: bound JPEG chunk list by scratch cap

* address review: reserve JPEG chunk list at the budgeted length
2026-11-10 17:57:55 -05:00
Dylan M. Taylor 4b1055c732 fix(text): validate font table directories in one pass and cap collection faces (#11194) 2026-11-10 17:57:38 -05:00
Dylan M. Taylor 0ff76d6f0c fix(paint): cap the total steps one stroke emits (#11195) 2026-11-10 17:57:21 -05:00
Dylan M. Taylor 73eb06adce Icon themes: parse index.theme once and refuse gzip icons (#11227) 2026-11-10 17:57:02 -05:00
Dylan M. Taylor bbf3ad7fd0 xtask: only follow https redirects when fetching PngSuite (#11231) 2026-11-10 17:56:37 -05:00
ljkxandClaude Fable 5.2 0ef215dc8b Pen Enter tests: look the Make buttons up by their new labels
The Make row's buttons are Selection… and Shape since #12993; the tests of
#12892 still asked for Make Selection and Make Shape and failed on main.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-10 23:18:54 +01:00
ljkxandClaude Fable 5.2 2e13877f43 Sponge: the options bar has a Flow field and strokes use it (#12976)
After Mode the Sponge bar shows Flow: whole numbers 1..100, default 50 %,
with the "Closest value inserted" alert for a value typed past the range
and a slider arrow. The canvas passes it to paint.sponge as flow, which
used the command's default of 100 % before. Reset Tool puts it back to
50 %, and settings saved before the field load as 50 %.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-10 23:02:27 +01:00
David Mann ec40f3912a Merge pull request #12882 from Bobderto/codex/12829-freeform-history
fix: record Freeform Pen strokes with their tool name
2026-11-10 22:14:53 +01:00
David Mann 0ac93368d6 Merge pull request #12815 from TrevorBrown-dev/fix/anchor-tools-targeted-path-12762
Add/Delete Anchor Point: edit only the targeted path (#12762, #12705)
2026-11-10 22:14:39 +01:00
David Mann 8e71892115 Merge pull request #12372 from rmsff/fix/gradient-mode-greyed-12008
fix(ui): a Gradient fill layer greys the Gradient tool's mode choice and is edited live (#12008)
2026-11-10 22:14:26 +01:00
David Mann 3cc12bcb2b Merge pull request #12969 from Bobderto/codex/12936-bracket-size-steps
fix(engine): follow Photoshop bracket-key brush size steps
2026-11-10 22:14:13 +01:00
David Mann 72e17777bc Merge pull request #11170 from DingusMcRinkyDinky/warp-fold-layers
Warp: a fold shows what's under its transparent parts
2026-11-10 22:14:00 +01:00
David Mann e1d3ba223e Merge pull request #13000 from rmsff/fix/pen-menu-free-transform-label-12913
Pen menu: name the transform row after what it acts on
2026-11-10 21:47:01 +01:00
David Mann c76cc5b5ad Merge pull request #12998 from rmsff/fix/sharpen-refuses-indexed-12953
Sharpen: refuse Indexed Color and Bitmap documents
2026-11-10 21:46:48 +01:00
David Mann 6a9495c506 Merge pull request #12993 from ljkx/feat/pen-make-mask-button
Pen options bar: Make: Selection…, Mask, Shape — Mask adds a vector mask from the path (#12904)
2026-11-10 21:42:05 +01:00
David Mann 3dd36011ed Merge pull request #12984 from rmsff/fix/pen-enter-deselects-12892
Pen: Enter deselects the Work Path it finished
2026-11-10 21:41:51 +01:00
David Mann ecfa246f80 Merge pull request #12987 from Bobderto/codex/12881-pattern-stamp-origin
fix(paint): match unaligned Pattern Stamp origins
2026-11-10 21:21:56 +01:00
David Mann d6ead54a81 Merge pull request #12954 from rmsff/fix/object-selection-mode-refusal-12867
Object Selection: refuse Indexed Color and Bitmap documents
2026-11-10 21:21:45 +01:00
Michael Higginsandkayrockscreenprinting 6a676ee1be Save over a flat JPEG: JPEG Options, then in place; transparent ones offered as PNG (#2223)
Fixes #2223. Carries the in-place flat Save of #5865 (closed as superseded by this PR) and revives what #2515 (@kayrockscreenprinting, closed when its author stepped away) added beyond it.

File › Save now writes back over a flat file when that file still holds the document: one plain opaque layer the format can store, and only when the file held a single image. A JPEG (and a TIFF, Targa or DDS) asks its format options first, as Photoshop does; Cancel writes nothing. A JPEG whose lone layer has transparency it can't keep is offered as a PNG. Multi-image files (animations, multi-page TIFFs, multi-size icons, multi-part EXRs) still go through Save As; the source image count is kept through crash recovery.

Co-authored-by: kayrockscreenprinting <257643019+kayrockscreenprinting@users.noreply.github.com>
2026-11-10 20:26:48 +01:00
RickiNano 4258fc838f A click in a text field's padding focuses its editor (#12302) (#12400)
* A click in a text field's padding focuses its editor (#12302)

The shared text field's box sensed hover only, so a click in the outer
point of its 6 pt sides (past egui's 5 pt reach to the editor) did
nothing. The box now senses clicks (not focus, so Tab still stops on the
editor alone); since the editor sits on top, only padding clicks reach
it, and they focus the editor with the caret at the nearest point inside.

* Text field: the editor covers the box, so a padding click is its own (#12302)

The box sensing clicks and placing the caret itself broke on a scrolled
value: pressing the padding takes the focus from the editor, which then
scrolls back to the start before the click lands, so the caret went to
the wrong character. The editor now fills the box but the trailing space,
with the padding as its frame's inner margin, so egui handles a padding
click like any other: focus, caret, scroll, drag and double-click.

Tests from review: corner clicks (fail on main), an empty field, a
scrolled value, a disabled field, the trailing popup arrow keeping its
click, and the editor-click test no longer depends on glyph widths.
2026-11-10 20:08:39 +01:00