Commit Graph
7140 Commits
Author SHA1 Message Date
David MannandClaude Opus 5.5 75bc29f6c5 Tests: the Move marquee test reads the slanted ant edges main's device-pixel ants draw
Main's #7530 draws marching ants as a pixel mesh plus white base segments for slanted edges, so the
rotated Move-tool marquee is no longer one white closed path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 17:02:09 +01:00
David Mann 57bcbfaba9 Merge remote-tracking branch 'origin/main' into HEAD 2026-10-29 16:44:46 +01:00
Khawar Zamman Wani 66ac154d68 perf(algo): select median stack samples without full sorting (#9628) 2026-10-29 11:36:34 -04:00
Khawar Zamman Wani 6b2ad6b620 Reduce Noise: reuse guide statistics with bit-identical output (#9639)
* perf(algo): reuse Reduce Noise guide statistics

* fix(algo): use fixed-size chunks for guide statistics

* Reduce Noise: test that the caller routes the cleaned luma guide and both chroma planes

Review follow-up: compares reduce_noise's output (Lab, so planes pass through) with the
independent guided filters run in order.

* test(algo): assert bit-identical output in Reduce Noise routing test
2026-10-29 11:35:24 -04:00
Khawar Zamman Wani 991ef9907b fix(actions): allow no-op Arrange steps during playback (#8457) 2026-10-29 11:34:13 -04:00
aiongg 5f9b439187 Merge pull request #10006 from davidmann4/i18n/arabic-combined
Arabic interface language, combined from the community catalogs (#10005)
2026-10-28 21:27:43 -04:00
David MannandClaude Opus 5.5 b23e90ac23 Files opened at launch report in the interface language
The command line's files open before the first frame, which is what
applies the interface language, so their status line and notices came
out in English in every language. open_paths now applies it first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 01:30:13 +01:00
David MannandClaude Opus 5.5 573bbbf157 i18n(ar): Hue is درجة اللون
The second questionnaire answer (Algeria). The earlier تدرج اللون read
as "colour gradient" beside Gradient تدرج. Hue, Hue/Saturation, Hue
Jitter and Hue Cube follow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 01:30:13 +01:00
David MannandClaude Opus 5.5 8f80fb9790 Tests: Arabic preset-import results are translated
The plural pair is picked at run time, so the literal-key coverage
check can't see these rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 01:07:46 +01:00
David MannandClaude Opus 5.5 3fa06e0ac0 i18n(ar): brush, pattern and gradient preset-import results
The preset file import status (`preset_files_ui::open`) asks for
"Imported {n} brush/pattern/gradient from {file}" plurals; the Arabic
catalog only had the style one, so these results showed in English.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:21:19 +01:00
David MannandClaude Opus 5.5 fab71caf80 Web build: the interface language's served face goes first in the UI stack
Served script fallbacks were appended to every UI font family in the
order they arrived. A Japanese and a Simplified Chinese face both cover
Han, and egui draws a character with the first face in the stack that has
it, so a Chinese interface drew Han with the Japanese face when that one
had arrived first (fetched for a Japanese text layer, say). ui_faces now
puts the interface language's own served face first, so the stack a
language change rebuilds follows the language; and when that face arrives
after another served face, add_ui_face rebuilds the stack the same way
instead of appending. served::fallback_for_language gives the face.

This orders the served faces only; with an interface language that has
no served face (English), they stay in arrival order.

Review finding on #10006.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 23:45:35 +01:00
David MannandClaude Opus 5.5 97ed3d1d39 Web build: an unreadable served font stays out of the interface
A served script fallback joins every egui font family, and egui panics on
a configured font it cannot parse: a host answering a font's path with an
error page, or serving a truncated file, stopped the web UI on its next
layout or font rebuild. add_ui_face now checks the face with
cjk::font_face_is_readable first, as the system-font fallbacks are
checked, and leaves an unreadable one out with a warning. The regression
test panicked in epaint's family.rs before the check.

Review finding on #10006.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 23:43:08 +01:00
David MannandClaude Opus 5.5 71dda79330 Web build: ask for the interface language's font when the manifest arrives
serve_fonts asks for the interface language's served script font once per
language, but the font manifest loads asynchronously: when the first frame
ran before it arrived, no fallback was registered yet, the request found
nothing, and an Arabic interface on an English browser stayed without its
font until the language changed. The manifest load now asks for the
interface language's font along with the browser languages'.

Review finding on #10006.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 23:41:38 +01:00
David MannandClaude Opus 5.5 250940a4f5 Arabic: terms chosen by a native speaker
The first questionnaire answers (Iraqi Arabic): Filter فلتر, Feather تلاشي
الحواف, Blur ضبابية, Liquify تمويع, Unsharp Mask قناع الحدة, Stroke حدود,
Guides خطوط التوجيه, Canvas مساحة الرسم, Lasso الحبل, Clone Stamp ختم
النسخ, Healing Brush فرشاة التصحيح, Color/Linear Burn تغميق, Content-Aware
مراعٍ للمحتوى, Rasterize تنقيط, Bevel & Emboss شطب ونقش, Pattern نقشة,
Posterize تقليل درجات اللون, Halftone أنصاف الألوان, Lens Flare وميض
العدسة, Texture الملمس, Glyphs الرموز, Gamut النطاق اللوني; every row
using them follows, with adjectives agreeing. Select › Modify › Border
becomes حدود التحديد so it no longer reads like Stroke.

Opacity (الشفافية, "transparency", would read 100% as fully transparent)
and Crop (قص is Edit › Cut) keep العتامة and اقتصاص for now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:33:37 +01:00
David MannandClaude Opus 5.5 f66f749f96 Merge main
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:18:30 +01:00
David MannandClaude Opus 5.5 15dc4092f8 Web build: served script fonts draw the interface too
The web build has no system fonts and embeds no craft fonts, so an Arabic
(or Japanese, Chinese, Korean, Hindi) interface had no font for its labels:
served fonts were registered only in the document text engine. A served
script fallback now also joins the end of every egui font family, and the
font stack theme::install_fonts rebuilds on a language change includes it
again. The web shell asks for the interface language's script font, not
only the browser languages'.

Review finding on #10006.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:18:28 +01:00
aiongg 69b8fd9c14 Merge pull request #9943 from brennanMKE/perf/9328-slow-frames
Perf: every frame records its stages; slow frames are kept, logged and reported (#9328)
2026-10-28 17:00:30 -04:00
aiongg e2f9ae6bfb Merge main into perf/9328-slow-frames
Conflicts in perf/budgets.toml and docs/scorecard.md: both sides added perf rows (P80 here, P81 and P82 from #9942). Kept all three; scorecard regenerated with cargo xtask scorecard.
2026-10-28 20:30:50 +00:00
aiongg a8580ff0ca Merge pull request #9942 from brennanMKE/perf/9329-tile-damage
Engine: a pixel change damages only the tiles that changed (#9329)
2026-10-28 16:27:10 -04:00
David MannandClaude Opus 5.5 d30464c3c7 Merge main
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:23:17 +01:00
David MannandClaude Opus 5.5 2e2a460992 Merge #6287 (Arabic catalog by @test-bit-sys) into the combined Arabic catalog
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:57 +01:00
David MannandClaude Opus 5.5 4f76fb4a9f Merge #6092 (Arabic catalog by @syrrevshin4202-prog) into the combined Arabic catalog
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:57 +01:00
David MannandClaude Opus 5.5 1bbce88cef Merge #5915 (Arabic catalog by @vfggf95565) into the combined Arabic catalog
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:57 +01:00
David MannandClaude Opus 5.5 677bf61944 Merge #5593 (Arabic catalog by @NibrasAz7) into the combined Arabic catalog
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:57 +01:00
David MannandClaude Opus 5.5 718d87bb01 Merge #4569 (Arabic catalog by @hasan-sdaif) into the combined Arabic catalog
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:57 +01:00
David MannandClaude Opus 5.5 1cb30ec9c8 Merge #4520 (Arabic catalog by @hicbest) into the combined Arabic catalog
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:56 +01:00
David MannandClaude Opus 5.5 54bf8c78c2 Merge #2505 (Arabic catalog by @azizr12) into the combined Arabic catalog
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:56 +01:00
David MannandClaude Opus 5.5 73ac7d9a25 Arabic layer names and title read right to left again on egui 0.37
egui 0.37 lays text out with the Unicode Bidirectional Algorithm, so the
display-order rewrite #5385 added for egui 0.36 now reverses Arabic and
Hebrew layer names and the in-app title a second time. Names go to egui
as typed; the title line asks for a left-to-right paragraph so
"— PhotoCraft" stays at the right; bidi_text::elide cuts a right-to-left
name at its logical end and egui puts the "…" at the left.

Tests lay the text out with egui and compare glyph positions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:26 +01:00
bd9590d060 Arabic interface language, combined from the community catalogs
Adds Arabic (ar, العربية) as an interface language. The catalog combines
the open Arabic catalogs of #2505, #4520, #4569, #5593, #5915, #6092 and
#6287: each row takes the best of their translations, with one Arabic
term per concept across the UI, and the strings added since are filled
in. Modern Standard Arabic, Western digits, the six CLDR plural forms
(zero|one|two|few|many|other).

The two tests that used ar-SA as an unsupported locale now use sw-KE, and
the direction test expects Arabic to be the one right-to-left catalog.

Co-authored-by: azizr12 <163084230+azizr12@users.noreply.github.com>
Co-authored-by: hicbest <213873494+hicbest@users.noreply.github.com>
Co-authored-by: hasan-sdaif <306196098+hasan-sdaif@users.noreply.github.com>
Co-authored-by: NibrasAz7 <34162952+NibrasAz7@users.noreply.github.com>
Co-authored-by: vfggf95565 <74471233+vfggf95565@users.noreply.github.com>
Co-authored-by: syrrevshin4202-prog <243624842+syrrevshin4202-prog@users.noreply.github.com>
Co-authored-by: test-bit-sys <336050374+test-bit-sys@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:26 +01:00
Dylan M. Taylor 8988161e90 Honor CARGO_BUILD_TARGET in FreeBSD packaging for aarch64 release builds (#9989)
* Honor CARGO_BUILD_TARGET in FreeBSD packaging for aarch64 release builds

package.sh took the arch from uname -m. The release VM is an x86_64 guest that
cross-compiles aarch64 with CARGO_BUILD_TARGET set, so an aarch64 build was
named freebsd-x86_64 and read binaries from the host target dir.

Read the arch from CARGO_BUILD_TARGET when it is set, and read binaries from
target/<triple>/release. Skip the man-page example and the --version run when
cross-building, since the aarch64 binaries cannot run on the x86_64 guest.
Unset CARGO_BUILD_TARGET keeps the old behavior.

* Reject unsupported CARGO_BUILD_TARGET and resolve host-tuple in FreeBSD packaging

Accept only x86_64-unknown-freebsd and aarch64-unknown-freebsd. Any other
target exits 2 before any build, so a non-FreeBSD target cannot be packaged
as an x86_64 FreeBSD archive.

Resolve cargo's host-tuple alias to the real host triple before choosing the
binary dir, so the path matches cargo's output.

* Skip the photocraft-cli --version run when CARGO_BUILD_TARGET is set

A target build's binary may not run on the host (aarch64 on the x86_64 VM),
and under set -e the smoke run would fail the release after the archive is
written. The native path (CARGO_BUILD_TARGET unset) still runs it.
2026-10-28 15:48:48 -04:00
Dylan M. Taylor 2fccdcba8e Correct update_transport comment: Flatpak sandbox now has network (#9983) 2026-10-28 13:21:15 -04:00
Dylan M. Taylor f1866aed06 Grant network access so update checks can reach GitHub (#9982)
* Grant network access so update checks can reach GitHub

* Fix Flatpak network comment: --share=network is for --control, not update checks
2026-10-28 13:19:42 -04:00
Brandon ThomasandClaude Opus 5.5 b8c3f3aa8e Release 0.17.0
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v0.17.0
2026-10-28 12:25:48 -04:00
Brennan StehlingandClaude Opus 5.5 e2855fddd7 test: P81/P82 count only timed refreshes; mask undo must upload a partial rect (#9329)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-28 02:04:54 -07:00
azizr12 8a64ae4049 Delete mod.rs 2026-10-28 08:02:07 +00:00
azizr12 e5565bc815 ar 2175/2175 2026-10-28 08:00:59 +00:00
azizr12 350b6904ec Update i18n.rs 2026-10-28 07:57:57 +00:00
azizr12 d825abbd75 Merge branch 'storytold:main' into main 2026-10-28 07:44:07 +00:00
azizr12 36c5e7207c fix 2026-10-28 07:34:49 +00:00
Brennan StehlingandClaude Opus 5.5 c855685c7f test: cover group and clip-base effect damage, and mask undo coverage (#9329)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:09:58 -07:00
Brennan StehlingandClaude Opus 5.5 2119158a5e perf: a pixel change damages only the tiles that changed; command rects become checked hints (#9329)
step_damage narrows a layer whose only change is in its surfaces (pixels, mask, type,
smart-object and fill caches) to the bounding box of the tiles that differ: a merge walk of
the two tile maps, pointer compares only. A mask's tiles grow by its feather, all of them by
the layer's effects and the effects of the groups around it, never past the layer's whole
extents. A frame-spanning effect whose frame moved keeps the whole extents (#4053). Undo,
redo and History jumps get it for free: undoing a 60 px dab on a full-canvas layer redraws
its tiles, not the canvas, and so does a fill or filter on a small selection.

The painting commands' own damage rects go through one door, Session::hint_damage, which
intersects them with the edit's damage. Debug and test builds count a hint that misses a
changed tile in Session::damage_misses and log it; nothing panics. refresh_type_layers reports
step_damage instead of None.

Deleted: note_damage and layers_damage (identical to step_damage after layer.setProps and
layer.translate), note_inert_insert (step_damage already steps over inert layers, #1771),
and the engine's siblings_of they used.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:09:58 -07:00
Brennan StehlingandClaude Opus 5.5 a9c26551f1 perf: add P81/P82 redraw-area rows on full-canvas layers (#9329)
Track-only rows that check they hit the whole-document-redraw path and
print the refreshed pixel count: undo of a brush dab on a 16-bit
15000x10000 full-canvas layer (reps capped at 5) and a fill of a 2 %
selection on a 24 MP full-canvas layer.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:08:30 -07:00
Brennan StehlingandClaude Opus 5.5 fc6d8b0ec2 Perf: a frame counts each command once, and every frame closes its stage record (#9328)
Only the outermost run_command writes the frame's command stage, so a nested
run (file.save -> layer.smartObjects.saveContents, actions.play -> its view
steps) isn't counted twice. ui_frame's UI moves into ui_body and finish_frame
runs after it on every path, including the screen picker's wait modal; the
pass before fonts are ready closes it too.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:08:27 -07:00
Brennan StehlingandClaude Opus 5.5 ce8f3e719e Docs: perf.slowFrames, and the stroke trace reads the shared frame stages (#9328)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:08:06 -07:00
Brennan StehlingandClaude Opus 5.5 b1ffb9a423 Control: perf lists the last slow frames and their stages as slowFrames (#9328)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:07:54 -07:00
Brennan StehlingandClaude Opus 5.5 5c94fb2074 Perf: every frame records its stages, slow ones are kept and logged; the stroke trace reads the same record (#9328)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:07:39 -07:00
Brennan Stehling 00522c852e Perf: P80, app frame time for a full CPU refresh of a 24 MP document (#9328)
Track-only row, the slow-frame recorder's worst case. A 24 MP photo plus
three full-canvas blended copies (Multiply, Screen, Overlay); each sample
toggles the top copy and times one harness.step(), so every frame
recomposites all 24 MP on the CPU (the photo's tiles are never uniform,
which keeps the reduced render's one-colour shortcut out of the way).
The row errors unless each frame recorded a CPU refresh covering at least
95 % of the canvas, so it can't silently take a fast path. 10 samples.
2026-10-27 23:06:56 -07:00
aiongg 1f7fc0f536 Merge pull request #6463 from osaidahmed/split-filter-adjust-crop-fx-builders
refactor: split oversized filter, adjustment, crop and effect builders
2026-10-28 01:01:25 -04:00
aiongg 2b1c6b93c3 Merge main into split-filter-adjust-crop-fx-builders
crop_ui.rs moved to tools/; the PR's builders replace main's Clippy extractions of the same code; #6723's Color Lookup save carried into the moved encoder.
2026-10-28 04:22:40 +00:00
aiongg d453c7d12b Merge pull request #9564 from brennanMKE/perf/7494-baseline-guard
xtask perf: a baseline knows how trustworthy it is (#7494)
2026-10-27 23:56:45 -04:00