Commit Graph
11447 Commits
Author SHA1 Message Date
David Mann 723cd6483e Merge pull request #12165 from hnoerenberg/fix/rotate-dialog-two-decimals-12035
fix(ui): the Arbitrary rotation dialog keeps the ruler's two decimals (#12035)
2026-11-11 00:53:03 +01:00
David Mann 8e104a84ae Merge pull request #12270 from DuBearte/fix/11980-ruler-click-keeps
Ruler: a plain click keeps the current ruler instead of deleting it
2026-11-11 00:52:10 +01:00
David Mann 536d4e7b67 Merge pull request #12214 from hectorviov/fix/count-cursors
Count tool: arrow cursors with 1+, 1 over a marker and 1- with Alt (#11773)
2026-11-11 00:51:50 +01:00
David Mann 5ba0bb0a3a Merge pull request #12201 from hectorviov/fix/eyedropper-zoom-box
Eyedropper: at 100 % zoom and below an N by N Average covers (N+1) x (N+1) screen pixels (#11751)
2026-11-11 00:51:27 +01:00
David Mann e9ab58e1f5 Merge pull request #12209 from DuBearte/fix/11966-auto-erase-exact
Pencil Auto Erase: the start pixel must be exactly the foreground colour
2026-11-11 00:51:02 +01:00
David Mann c4b4afc0a9 Merge pull request #12169 from DuBearte/fix/11886-airbrush-rate
Airbrush: about ten dabs a second while held, and a click lays two dabs
2026-11-11 00:50:39 +01:00
David Mann de9add28b2 Merge pull request #13023 from ljkx/fix/pen-enter-tests-make-labels
Pen Enter tests: look the Make buttons up by their new labels (main red since #12993)
2026-11-11 00:00:07 +01:00
Dylan M. Taylor f45711c749 codecs: check TIFF structural tags, predicted rows and JPEG chunk frames (#10983)
* codecs: check TIFF structural tags, predicted rows and JPEG chunk frames

- Duplicate structural tags: the directory checks read a tag's first
  entry and the tiff crate its last, so a small SamplesPerPixel first
  and a large one last was admitted with one value and sized with the
  other. A repeated structural tag is now refused.
- Floating-point predictor: the tiff crate reads each tile row at its
  full stored width into a buffer of its own, outside the scratch cap.
  That row (TileWidth x samples x sample size) must now fit the cap.
- JPEG-compressed chunks: the tiff crate decodes each chunk into a
  whole JPEG image sized by the embedded frame header, with no limits.
  Each chunk's frame (read from the chunk or JPEGTables, at most 256
  marker segments in) must now fit the nominal strip or tile, as
  libtiff requires, and its decoded size must fit the scratch cap.

* address review: JPEG chunk dedup by count, offset-2 frame, shared fill budget

* address review: bound JPEG chunk list by scratch cap

* address review: reserve JPEG chunk list at the budgeted length
2026-11-10 17:57:55 -05:00
Dylan M. Taylor 4b1055c732 fix(text): validate font table directories in one pass and cap collection faces (#11194) 2026-11-10 17:57:38 -05:00
Dylan M. Taylor 0ff76d6f0c fix(paint): cap the total steps one stroke emits (#11195) 2026-11-10 17:57:21 -05:00
Dylan M. Taylor 73eb06adce Icon themes: parse index.theme once and refuse gzip icons (#11227) 2026-11-10 17:57:02 -05:00
Dylan M. Taylor bbf3ad7fd0 xtask: only follow https redirects when fetching PngSuite (#11231) 2026-11-10 17:56:37 -05:00
ljkxandClaude Fable 5.2 0ef215dc8b Pen Enter tests: look the Make buttons up by their new labels
The Make row's buttons are Selection… and Shape since #12993; the tests of
#12892 still asked for Make Selection and Make Shape and failed on main.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-10 23:18:54 +01:00
David Mann ec40f3912a Merge pull request #12882 from Bobderto/codex/12829-freeform-history
fix: record Freeform Pen strokes with their tool name
2026-11-10 22:14:53 +01:00
David Mann 0ac93368d6 Merge pull request #12815 from TrevorBrown-dev/fix/anchor-tools-targeted-path-12762
Add/Delete Anchor Point: edit only the targeted path (#12762, #12705)
2026-11-10 22:14:39 +01:00
David Mann 8e71892115 Merge pull request #12372 from rmsff/fix/gradient-mode-greyed-12008
fix(ui): a Gradient fill layer greys the Gradient tool's mode choice and is edited live (#12008)
2026-11-10 22:14:26 +01:00
David Mann 3cc12bcb2b Merge pull request #12969 from Bobderto/codex/12936-bracket-size-steps
fix(engine): follow Photoshop bracket-key brush size steps
2026-11-10 22:14:13 +01:00
David Mann 72e17777bc Merge pull request #11170 from DingusMcRinkyDinky/warp-fold-layers
Warp: a fold shows what's under its transparent parts
2026-11-10 22:14:00 +01:00
David Mann e1d3ba223e Merge pull request #13000 from rmsff/fix/pen-menu-free-transform-label-12913
Pen menu: name the transform row after what it acts on
2026-11-10 21:47:01 +01:00
David Mann c76cc5b5ad Merge pull request #12998 from rmsff/fix/sharpen-refuses-indexed-12953
Sharpen: refuse Indexed Color and Bitmap documents
2026-11-10 21:46:48 +01:00
David Mann 6a9495c506 Merge pull request #12993 from ljkx/feat/pen-make-mask-button
Pen options bar: Make: Selection…, Mask, Shape — Mask adds a vector mask from the path (#12904)
2026-11-10 21:42:05 +01:00
David Mann 3dd36011ed Merge pull request #12984 from rmsff/fix/pen-enter-deselects-12892
Pen: Enter deselects the Work Path it finished
2026-11-10 21:41:51 +01:00
David Mann ecfa246f80 Merge pull request #12987 from Bobderto/codex/12881-pattern-stamp-origin
fix(paint): match unaligned Pattern Stamp origins
2026-11-10 21:21:56 +01:00
David Mann d6ead54a81 Merge pull request #12954 from rmsff/fix/object-selection-mode-refusal-12867
Object Selection: refuse Indexed Color and Bitmap documents
2026-11-10 21:21:45 +01:00
Michael Higginsandkayrockscreenprinting 6a676ee1be Save over a flat JPEG: JPEG Options, then in place; transparent ones offered as PNG (#2223)
Fixes #2223. Carries the in-place flat Save of #5865 (closed as superseded by this PR) and revives what #2515 (@kayrockscreenprinting, closed when its author stepped away) added beyond it.

File › Save now writes back over a flat file when that file still holds the document: one plain opaque layer the format can store, and only when the file held a single image. A JPEG (and a TIFF, Targa or DDS) asks its format options first, as Photoshop does; Cancel writes nothing. A JPEG whose lone layer has transparency it can't keep is offered as a PNG. Multi-image files (animations, multi-page TIFFs, multi-size icons, multi-part EXRs) still go through Save As; the source image count is kept through crash recovery.

Co-authored-by: kayrockscreenprinting <257643019+kayrockscreenprinting@users.noreply.github.com>
2026-11-10 20:26:48 +01:00
RickiNano 4258fc838f A click in a text field's padding focuses its editor (#12302) (#12400)
* A click in a text field's padding focuses its editor (#12302)

The shared text field's box sensed hover only, so a click in the outer
point of its 6 pt sides (past egui's 5 pt reach to the editor) did
nothing. The box now senses clicks (not focus, so Tab still stops on the
editor alone); since the editor sits on top, only padding clicks reach
it, and they focus the editor with the caret at the nearest point inside.

* Text field: the editor covers the box, so a padding click is its own (#12302)

The box sensing clicks and placing the caret itself broke on a scrolled
value: pressing the padding takes the focus from the editor, which then
scrolls back to the start before the click lands, so the caret went to
the wrong character. The editor now fills the box but the trailing space,
with the padding as its frame's inner margin, so egui handles a padding
click like any other: focus, caret, scroll, drag and double-click.

Tests from review: corner clicks (fail on main), an empty field, a
scrolled value, a disabled field, the trailing popup arrow keeping its
click, and the editor-click test no longer depends on glyph widths.
2026-11-10 20:08:39 +01:00
RickiNano 65bd584259 fix(ui): Reset Tool gives the Dodge tool a 65 px soft tip at 25 % spacing (#12684) (#12793)
fresh_brush gave the Dodge tool the plain 20 px hard default at 10 %
spacing. It now gets the reference's 65 px soft round at 25 % spacing
after Reset Tool and Reset All Tools, and on its first pick. The Burn
tool has the same measured tip, so both share TONING_TOOL_TIP.
2026-11-10 20:08:31 +01:00
RickiNano 4af62e8abb fix(ui): Delete on an anchor selected with Add Anchor Point removes it, not the layer (#12703) (#12796)
* fix(ui): Delete on an anchor selected with Add Anchor Point removes it, not the layer (#12703)

With the Add Anchor Point tool and one anchor selected (Ctrl+click), Delete
and Backspace fell through to Edit > Clear and deleted the active layer.
They now remove the anchor and its two segments, as in the reference
application: a closed subpath opens there. One history step, Delete Anchor
Point.

- vector: edit::delete_anchor_and_segments (a closed subpath opens at the
  anchor; an open one loses an end or splits at an inner anchor)
- engine: path.deleteAnchor takes "segments": bool (default false keeps
  joining the neighbours, as the tool's click does)
- ui: delete_key_deletes_anchor next to delete_key_deletes_work_path, and a
  Delete/Backspace branch before the work path's

* test(vector): Delete on one anchor of a closed two-anchor subpath leaves the other, open (#12703)

The kept anchor retains its handles and smooth flag, and the subpath keeps its path operation.
2026-11-10 20:08:21 +01:00
RickiNano 3e55928e63 Smudge Strength: alert when a typed value is out of range (#12982)
* fix(ui): Sharpen Strength alerts when a typed value is out of range (#12949)

With the Sharpen tool, Strength now takes whole numbers 1 to 100 and a
value typed past either end becomes the closest one with the "Closest
value inserted" alert, as the Blur tool's does since #12650. Smudge keeps
its silent clamp. The field edits a copy, so showing the Sharpen bar does
not round a fraction already in the shared Strength.

* fix(ui): Smudge Strength alerts when a typed value is out of range (#12962)

With the Smudge tool, Strength now takes whole numbers 1 to 100 and a
value typed past either end becomes the closest one with the "Closest
value inserted" alert, as the Blur (#12650) and Sharpen (#12949) tools'
do. All three tools now share one path through the field, which edits a
copy, so showing the Smudge bar does not round a fraction already in the
shared Strength.
2026-11-10 20:07:25 +01:00
David Mann 0d08cb7dd6 Merge pull request #6215 from davidmann4/feat/ui-217-4-columns-unit
Image Size: a Columns width unit from the Column Size preference (#6214)
2026-11-10 19:36:23 +01:00
rmsff a37665f4f3 Test the Pen menu's Free Transform row labels
Covers no path, a path being drawn, a closed path, a path that exists but
isn't active, and the unchanged Path Selection and Direct Selection menus,
on screen and in ui.inspect. Reuses the canvas tool menu test helpers (app,
choose_open, harness, right_click) instead of copying them.
2026-11-10 21:13:40 +03:00
rmsff 01a2a3455b Pen menu: name the transform row after what it acts on
The Pen's canvas menu now reads Free Transform (greyed) when the document
has no path, Free Transform Points while a path is being drawn, and Free
Transform Path on a finished path, as in the reference application. A path
that exists but isn't active keeps Free Transform Path, as do the Path
Selection and Direct Selection menus. ui.inspect lists the same label.
2026-11-10 21:13:40 +03:00
rmsff cbff770f0e Test the Sharpen tool's Indexed Color and Bitmap refusal
Makes the Dodge refusal tests' session, steps and pixels helpers
pub(super) and reuses them.
2026-11-10 21:03:11 +03:00
rmsff 3b5a62e75f Sharpen: refuse Indexed Color and Bitmap documents (#12953)
paint.sharpen and its live stroke fail with the reference application's
alert text, and a press with the Sharpen tool opens that alert, as the
Dodge tool does since #12686.
2026-11-10 21:03:11 +03:00
ljkxandClaude Fable 5.2 e530d6c9f4 Pen options bar: Make: Selection…, Mask, Shape; Mask adds a vector mask from the path (#12904)
Path mode now shows the caption "Make:" followed by Selection…, Mask and
Shape, all greyed without an active path. Mask runs
layer.vectorMask.fromPath on the path being drawn (finished first) or the
active path: one History step, Add Vector Mask, with the Background
turned into Layer 0 inside it.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-10 19:00:42 +01:00
FredApps 96581039a8 Merge main into feat/ui-217-4-columns-unit 2026-11-10 18:41:49 +01:00
David Mann 609e2aa727 Merge pull request #12883 from rmsff/fix/warp-split-default-thirds-12495
Warp: a one-way split on the Default grid keeps only the thirds across it
2026-11-10 18:38:59 +01:00
DingusMcRinkyDinkyandClaude 54ea149f2f Warp: working out a fold's order can't stall the thread pool
Tiles are drawn on the thread pool, and the first tile that meets a fold works
out the fold's order while the others that need it wait. The order's sort was
shared with the pool, so while the working thread waited for its halves the
pool could hand it another folded tile, which then waited for the order on the
same thread: the warp never finished. It needed some tiles folding and others
not, and showed about once in ten 24 MP warps on 16 threads.

The sort now runs on the working thread alone. It costs nothing measurable:
a 24 MP fold in stacking order takes 0.28 s, as before.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EZbgszHyuEuWAzxaamteuU
2026-11-10 18:36:10 +01:00
Dan ea771f39e0 fix(paint): match unaligned Pattern Stamp origins 2026-11-10 17:29:12 +00:00
rmsff a22cc8a525 Test Enter deselecting the Pen's Work Path 2026-11-10 20:11:07 +03:00
rmsff 901286fef3 Pen: Enter deselects the Work Path it finished
Enter now ends the path and hides the Work Path, as Make Selection does, so
the next path replaces it instead of joining it. Esc keeps it selected.
The #5702 Delete test now ends its path with Esc, which keeps it selected.
2026-11-10 20:11:07 +03:00
Trevor BrownandClaude Sonnet 5.5 f8127a31e5 Anchor tools: a shown shape layer inside a group stays a target, as on main (#12762, #12705)
Both items mark shape layers inside a group as not measured, so they keep today's behaviour. With no path selected in the Paths panel, hit_active now also searches every shown, unlocked shape layer inside a group after the targeted paths, front first, as candidates lists them. A top-level shape layer that is not active is still left alone, and a path selected in the Paths panel is still the only target.

Tests: a_shape_inside_a_group_that_is_not_active_keeps_todays_behaviour in both test files, and the guard a_shape_inside_a_hidden_group_is_not_edited.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Fable 5.1 decided; Sonnet 5.5 wrote at medium
2026-11-10 12:07:30 -05:00
David Mann de7e1eec45 Merge pull request #12963 from RickiNano/fix/sharpen-strength-alert-12949
Sharpen Strength: alert when a typed value is out of range
2026-11-10 18:07:00 +01:00
rmsff 75bf0de77f test(ui): a fill layer in a hidden group keeps the Gradient mode choice (#12008) 2026-11-10 19:56:07 +03:00
rmsff 1355564e19 fix(ui): a Gradient fill layer in a hidden group keeps the stored mode choice (#12008) 2026-11-10 19:56:07 +03:00
David Mann 8a9bb9d1f4 Merge pull request #12966 from rmsff/fix/rasterize-prompt-history-name-12888
Rasterize prompt: a painting tool's type prompt adds "Rasterize Layer"
2026-11-10 17:49:11 +01:00
rmsff 8c87346ff4 test(ui): the Gradient mode tests' harness is tall enough for the open list (#12008) 2026-11-10 19:41:04 +03:00
rmsff ec7b612c77 fix(ui): a mode list left open when a fill layer becomes active doesn't overwrite the stored choice (#12008) 2026-11-10 19:41:04 +03:00
rmsff b8eb311de4 test(ui): the re-enabled Gradient mode dropdown stores a new choice (#12008) 2026-11-10 19:41:04 +03:00
rmsff 5883169f93 fix(ui): a Gradient fill layer greys the Gradient tool's mode choice and is edited live (#12008) 2026-11-10 19:41:04 +03:00