Commit Graph
11425 Commits
Author SHA1 Message Date
Federico Olivares e386cc2ae9 Format the acceptance tests 2026-10-24 02:33:02 -03:00
Khawar Zamman Wani 3450ca20bc select-mask: bind the preview's base cache to the document revision
A preview job still running when the document changed stored its base
selection back, and the next preview reused it for the new pixels.
BaseCache now records its revision and compute reuses it only on a match.
Also describe TOOL-214-1 as the full-window workspace.
2026-10-24 11:02:59 +05:30
Khawar Zamman Wani 4bd6638cc4 fix(ui): Liquify, Content-Aware Fill and Filter Gallery are modal, like Camera Raw
An agent's ui.menu.invoke reached the main window's menus while a full-window workspace was
open: window.document.N switched documents and the workspace closed, dropping its work.
Photoshop makes these dialogs modal.

menus::modal_allows now refuses other menu commands while one is open (distort_ui::
modal_workspace), so ui.menu.invoke and the macOS menu bar wait for OK or Cancel. The
control channel's Camera Raw continuation is generalised: the open workspace's own
{"ui": {...}} requests still pass, unless another dialog, a discard prompt or a crop is
pending. The menus' cache key includes the open workspace, so opening or cancelling one
without input rebuilds them. engine.execute (MCP run_command) is not a menu click and is
not gated.

Puppet Warp, Perspective Warp and Vanishing Point are on-canvas modes here, with the
in-window menus live, so they stay out.
2026-10-24 10:40:51 +05:30
Federico Olivares aad49d3213 Acceptance tests: drop the BMP header check, its PR left the batch 2026-10-24 00:55:36 -03:00
Khawar Zamman Wani eda6e71835 fix(ui): Select and Mask applies its work only to the document and layer it opened on
The workspace kept the document's index and the layer, but OK ran select.refineEdge on
whatever was active. A document switch and OK queued on the control channel with no frame
between them applied the first document's edits to the second, and selecting another layer
in the same document sent a layer-mask OK to that layer.

The workspace now stores its DocId. OK, control requests, the preview and pointer events
check that the active document and layer are the ones it opened on; when they are not, the
workspace closes with the reason in the status bar and nothing is edited. distort_ui's
cancel_stale drops it like Liquify and Puppet, and the pointer route has the same on_doc
guard (review by FredApps and aiongg on #8896).
2026-10-24 09:22:48 +05:30
Khawar Zamman Wani cbc55433fd Merge remote-tracking branch 'origin/main' into select-mask-workspace
# Conflicts:
#	crates/ui-egui/src/distort_ui.rs
#	crates/ui-egui/src/i18n/cs.tsv
#	crates/ui-egui/src/i18n/de.tsv
#	crates/ui-egui/src/i18n/el.tsv
#	crates/ui-egui/src/i18n/es.tsv
#	crates/ui-egui/src/i18n/fr.tsv
#	crates/ui-egui/src/i18n/hu.tsv
#	crates/ui-egui/src/i18n/id.tsv
#	crates/ui-egui/src/i18n/it.tsv
#	crates/ui-egui/src/i18n/ja.tsv
#	crates/ui-egui/src/i18n/ko.tsv
#	crates/ui-egui/src/i18n/nl.tsv
#	crates/ui-egui/src/i18n/pl.tsv
#	crates/ui-egui/src/i18n/pt-br.tsv
#	crates/ui-egui/src/i18n/ru.tsv
#	crates/ui-egui/src/i18n/sr.tsv
#	crates/ui-egui/src/i18n/tr.tsv
#	crates/ui-egui/src/i18n/uk.tsv
#	crates/ui-egui/src/i18n/vi.tsv
#	crates/ui-egui/src/i18n/zh-hans.tsv
#	crates/ui-egui/src/i18n/zh-hant.tsv
#	docs/gaps.md
#	docs/target-app-parity.md
2026-10-24 09:22:48 +05:30
Federico Olivares 7e4ff3222d Acceptance test: Gaussian Blur radius starts at 0.1 2026-10-24 00:51:31 -03:00
Federico Olivares 35c6c82b2d Add cross-PR acceptance tests for the parity batch 2026-10-24 00:51:31 -03:00
Federico Olivares fd440c7383 Merge PR #8903 into integration batch 2026-10-24 00:51:30 -03:00
Federico Olivares af83232e83 Merge PR #8902 into integration batch 2026-10-24 00:51:30 -03:00
Federico Olivares 1d7e8eeb83 Merge PR #8901 into integration batch 2026-10-24 00:51:30 -03:00
Federico Olivares 7367dc58e5 Merge PR #8807 into integration batch 2026-10-24 00:51:29 -03:00
Federico Olivares 3dd1525463 Merge PR #8791 into integration batch 2026-10-24 00:51:29 -03:00
Federico Olivares 88b4de4a08 Merge PR #8779 into integration batch 2026-10-24 00:51:28 -03:00
Federico Olivares 9b4f4a7a7b Merge PR #8715 into integration batch 2026-10-24 00:51:28 -03:00
Federico Olivares f863d9bd21 Merge PR #8811 into integration batch 2026-10-24 00:51:27 -03:00
Federico Olivares 466627872f Merge PR #8548 into integration batch 2026-10-24 00:51:27 -03:00
Federico Olivares 3b318e4dad Merge PR #8640 into integration batch 2026-10-24 00:51:26 -03:00
Federico Olivares 0c9bfc76ca Merge PR #9030 into integration batch 2026-10-24 00:51:26 -03:00
Federico Olivares e132058998 Merge PR #8978 into integration batch 2026-10-24 00:51:26 -03:00
Federico Olivares 30d638a0b9 Merge PR #8892 into integration batch 2026-10-24 00:51:25 -03:00
Federico Olivares 629f340655 Merge PR #8912 into integration batch 2026-10-24 00:51:25 -03:00
Federico Olivares 6cba11edc0 Merge PR #8923 into integration batch 2026-10-24 00:51:24 -03:00
Federico Olivares 4e8b040cc1 Merge PR #8935 into integration batch 2026-10-24 00:51:24 -03:00
Federico Olivares b0b2dc489e Merge PR #8963 into integration batch 2026-10-24 00:51:24 -03:00
Federico Olivares 4617bb941e Merge PR #8776 into integration batch 2026-10-24 00:51:23 -03:00
Federico Olivares 0c2d829edf Merge PR #8888 into integration batch 2026-10-24 00:51:23 -03:00
Federico Olivares 2fd051036b Merge PR #9031 into integration batch 2026-10-24 00:51:22 -03:00
Federico Olivares 222eb2592e Merge PR #8685 into integration batch 2026-10-24 00:51:22 -03:00
Federico Olivares aecd686fef Merge PR #8823 into integration batch 2026-10-24 00:51:22 -03:00
Federico Olivares c79909910b Merge PR #8770 into integration batch 2026-10-24 00:51:21 -03:00
Federico Olivares 73f4129c0a Merge PR #8728 into integration batch 2026-10-24 00:51:20 -03:00
Ratul Paul 2818bc1e7c Merge upstream main and preserve UI scale progress
Keep all upstream contributor entries, progress notes and current document
dates alongside the existing intermediate UI scale feature.

Validation: fmt, locked engine/UI tests (6389 passed), Clippy, layers, wasm,
scorecard generation/check, and panic_hunt all passed.
2026-10-24 09:41:37 +06:00
jonathanwxh-cell 3ddf80566a Merge main into document-offset fix
Resolve overlapping gap documentation while preserving opening-order activation and current upstream changes. Retain both sets of regression tests.
2026-10-24 11:32:50 +08:00
dotCooCoo 3e4e7aee5d Merge main into fix/paste-svg-from-clipboard 2026-10-23 20:04:13 -07:00
Jeremy YaoandClaude Opus 5.5 a32d700f62 Animation Effects: a trackpad gesture keeps its direction in every window
CodeRabbit found that with `smooth` off, wheel_nav::read_with read the
trackpad-gesture state but never recorded it, and its snap, zoom and
not-hovered paths returned before even reading it. Outside the main window,
where `unsmooth` doesn't run, a gesture's begin was never noted. So a gesture
begun with ⇧ held turned into a vertical pan once ⇧ was let go, where egui
keeps it sideways.

- this_frames_scroll now records the state it computes, and read_with calls
  it up front with its other per-frame tracking, then reuses the result.
- The state is kept per window (keyed by viewport id). The main window and a
  second document window have input of their own, and must not overwrite
  each other's gestures.
- The canvas test without `unsmooth` gains a phased Start/Move/End case: begun
  with ⇧ and released mid-gesture, the canvas pans 24 points sideways and not
  at all vertically. It fails without the fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 22:33:06 -04:00
Dylan M. Taylor 1c3db2e5c3 security(engine): bound script, batch, adjustment, import and export work (#8954)
* security(engine): bound script, batch, adjustment, import and export work from file input

Scripts calling scripts share depth and step budgets; batch inside a played action charges the playback tree; destructive adjustments and mask adjustments visit stored tiles when the content bounds are a huge sparse grid; Copy Layers checks group depth; aux flattening and brush import refuse oversized canvases; video footage frames are budgeted, Render Video names frames after the leaf of the document name and reads no linked files for restricted sessions; ATN names are clipped; profile paths are read as regular files only; prefs.set no longer treats colorSettingsX as colorSettings.

* style(engine): rustfmt

* engine: address review - refuse unbounded sparse adjustments, carry batch playback charges, charge played steps to scripts, clip ATN targets, stricter colorSettings paths, cap image-sequence frames
2026-10-23 22:09:29 -04:00
Jeremy YaoandClaude Opus 5.5 e332010d92 Merge branch 'main' into feature/animation-effects
Brings in 412 commits from main (cf9ff2a2). Two conflicts:
- crates/ui-egui/src/lib.rs: main added updates_ui::tick right after
  prefs_ui::tick, where this branch calls wheel_nav::unsmooth. Both stay,
  main's first; the update tick reads no input.
- Cargo.lock: main's, with cargo adding back this branch's one line (the
  desktop app's direct windows dependency).

docs/scorecard.md is regenerated; it differs from main only in UI-217-10.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 22:08:50 -04:00
VishnuByrraju d0b08abc65 fix(gpu): use NVIDIA_VENDOR in the cross-platform parser test, not a bare literal
cargo clippy --all-targets on Windows (and the same would hit macOS) found the constant
dead: the functions that use it outside tests are Linux-only, and the test exercising
parse_nvidia_smi was written against the literal 0x10de instead of the constant, so
nothing referenced it under cfg(test) on a non-Linux target.
2026-10-24 07:37:06 +05:30
aiongg cf9ff2a20d Merge pull request #9035 from davidmann4/fix/9033-cmyk-dissolve
CMYK: Dissolve and post-adjustment rounding match the RGB compositor (#9033)
2026-10-23 21:59:28 -04:00
VishnuByrraju 0efeadc1ee perf(gpu): NVIDIA's own memory on Linux, so many-layer documents stay off the CPU budget penalty
video_memory() on Linux only ever read amdgpu's sysfs mem_info_vram_total file. NVIDIA's
proprietary driver never writes it, so every NVIDIA Linux user still had the document's
pixels charged against the GPU memory budget that #5973 stopped charging discrete cards
for elsewhere - P60/P61 (opacity/hide among 150 full-canvas layers) measured 1.5 s against
a 30 ms budget here, same as before that fix.

detect_video_memory now falls back to nvidia-smi's own CSV report when the vendor id is
NVIDIA's and the sysfs file is absent: parsed by a pure, unit-tested function against this
machine's real nvidia-smi output; an absent or failing nvidia-smi degrades to the old
(correct, if pessimistic) behaviour, never a panic or a hang.
2026-10-24 07:23:59 +05:30
Dylan M. Taylor 8931277070 security(io): charge sparse layers, shape caches and shared decodes (#8955)
* security(io): charge sparse layers, shape caches and shared decodes

ORA and PSD export refuse dense boxes past a cap; PSD import and ABR mapping decode shared masks/tips once; Affinity and SVG shape caches are charged to the import budget; SVG embedded JPEG size is probed; Krita tiles are charged for the backing tiles they land in.

* fix(io): clippy range pattern; align the sparse Krita test tiles to the backing grid

* io: address review - offset-aware KRA tile budget, saturating stroke reach, OpenRaster entry limit, PSD retained-surface budget, halved PSD gather cap
2026-10-23 21:52:25 -04:00
David MannandClaude Opus 5.5 c080783c00 Autosave: replace a recovery sidecar in one step, so a listing never misses or doubles it (#9034)
On Windows the recovery sidecar was written through store::write_atomic, which replaces the
old file with ReplaceFileW: it moves the old sidecar to a backup name first and only then moves
the new one in. A recovery listing in between saw the bundle without its sidecar and listed the
entry twice, or not at all (so a recovery prompt could miss a document). The flaky
autosave::recovered_entries_survive_a_second_crash_until_saved_or_closed on Windows CI was this.

The sidecar now goes through one AtomicFs on every platform whose replace is a plain rename
(one step); Unix keeps its 0600 temp file, Windows still refuses a read-only sidecar up front.
Recovery data is private to the app, so ReplaceFileW's ACL/stream preservation isn't needed.

Test: a_listing_during_an_autosave_sees_the_entry_exactly_once lists the recovery folder while
an autosaver rewrites the entry 200 times. With the old code it failed 3 of 3 runs on Windows
(two entries, once none); with the fix it passes 3 of 3.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-24 03:48:25 +02:00
David MannandClaude Opus 5.5 0b3cab2eba CMYK: Dissolve and post-adjustment rounding match the RGB compositor (#9033)
The CMYK proptests failed on main now and then (the_split_route_agrees_with_the_exact_path
after #8663). Three gaps, each found by the proptests at 5000 cases:

- cmyk.rs: a clipped Dissolve layer blended like Normal; it now shows each pixel fully or not
  at all by the compositor's noise, as the RGB compositor does since #3052.
- cmyk.rs: a Dissolve adjustment layer mixed by its opacity; opacity and mask are now the chance
  a pixel takes the adjustment, as on the RGB compositor (#3050).
- native.rs: the display/Flatten ink route didn't round to the document's levels after an
  adjustment layer, where the RGB compositor and cmyk.rs do; coverage in a pass-through group
  then differed by up to half a level.

The test reference model had the same two Dissolve gaps (ref_clip passed no position, so
Dissolve fell back to Normal), which is why random_documents_match_the_reference never caught
the first one. Three named regression tests cover the minimal cases.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-24 03:34:07 +02:00
David MannandClaude Opus 5.5 adb9298341 Give main's new Group literals in the asset tests a frame_stroke
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-24 03:16:48 +02:00
David MannandClaude Opus 5.5 09d80b1a27 Move the frame-stroke tests into each crate's single test binary
Main now links each crate's integration tests into one tests/it binary;
the two new test files of this PR join it as modules.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-24 03:13:02 +02:00
David Mann 23d8f053cb Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/compose/src/shape_split.rs
2026-10-24 03:12:55 +02:00
David Mann 6914464b9d Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/ui-egui/src/panels.rs
#	docs/ui-parity.md
2026-10-24 03:09:54 +02:00
David Mann feb20ebc60 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/gpu/src/plan.rs
#	crates/io/src/adjust_map.rs
2026-10-24 02:59:10 +02:00
David Mann 1226df9633 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/ui-egui/src/i18n/cs.tsv
#	crates/ui-egui/src/i18n/de.tsv
#	crates/ui-egui/src/i18n/ko.tsv
#	crates/ui-egui/src/i18n/vi.tsv
#	crates/ui-egui/src/i18n/zh-hans.tsv
#	crates/ui-egui/src/i18n/zh-hant.tsv
#	crates/ui-egui/src/panels.rs
#	docs/scorecard.md
#	docs/ui-parity.md
2026-10-24 02:57:47 +02:00