Commit Graph
11425 Commits
Author SHA1 Message Date
Ayan 47d9266fa1 Make Crystallize 4x and Pointillize 3x faster on 24 MP layers (#6200)
* Speed up Crystallize and Pointillize with cell-space rasterization

* Measure pixelate commands on unlocked layers and Background separately

* Record pixel-exact 24 MP filter and command benchmarks
2026-10-24 11:13:03 -04:00
GyoJoong Kum b367dfb6a9 Merge upstream main and resolve scorecard and UI parity conflicts 2026-10-24 14:09:34 +00:00
dotCooCoo 2f63183908 Hand tool: Scroll All Windows, or Shift while dragging, scrolls every shown document
The Hand tool's options bar has a Scroll All Windows checkbox. With it on,
or with Shift held while dragging, a Hand drag in one document view also
scrolls the other documents that are shown: the main window's document, or
its Window > Arrange tiles, and the document windows. After each step of
the drag, each of those views puts its center at the same relative
location as the dragged view's center, the same fraction of its own
document's width and height, and keeps its own zoom and rotation.
Documents in hidden tabs keep their views. With Overscroll off, they
follow the dragged view's center after it is held at its pan limit. A
flick-panning glide moves them too, also after Space or Shift is let go
with the button.

The option is a Hand tool option, so Reset Tool and tool presets include
it. Document windows read their view when they are drawn, so a drag in
one window moves a window drawn after it in the same frame.
2026-10-24 07:09:30 -07:00
Finn NewickandClaude Opus 5.5 34f031e313 fix(ui): draw a channel overlay over a size-changing preview's area
The overlay is rendered from the live preview, but the CPU canvas drew
it over the document's bounds, stretching a rotated preview's overlay.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 14:52:03 +01:00
Marco Arnulfo 8e695caf88 Color field cursor test: assert the rings sit at the expected corner, not just inside the field (#8968) 2026-10-24 15:49:04 +02:00
squirrelnoobandClaude Opus 5.5 3eebdec501 Merge upstream/main into feat/histogram-panel-parity
Conflicts resolved by keeping both sides:
- ui-egui control.rs: UI_SET_FIELDS has main's updatesOpen and the
  histogramPanel, histogramRange and histogramRefresh fields (42).
- automation server.rs: the ui_set description names all of them.
- docs/ui-parity.md: main's header, with the Histogram panel entry
  added to its change list.
- docs/scorecard.md: regenerated with `cargo xtask scorecard`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 16:41:46 +03:00
squirrelnoobandClaude Opus 5.5 049abb7d42 Histogram panel: views, channels, statistics, source, Uncached Refresh and live preview
- Compact, Expanded and All Channels views; the channel is kept across views.
- Channels per colour mode, plus Luminosity and Colors (overlaid, mixed where
  channels overlap); Show Channels in Color and Show Statistics in the panel menu.
- Statistics for the level under the pointer or a dragged range: Mean, Std Dev,
  Median, Pixels, Level, Count, Percentile, Cache Level.
- Source (Entire Image, Selected Layer, Adjustment Composite) for multilayer
  documents.
- Adjustment previews counted live, with the original outlined over them.
- Cached-data warning and Uncached Refresh; Preferences > Performance > Cache
  Levels (1-8) caps the cache level.
- ui.set histogramPanel / histogramRange / histogramRefresh, ui.inspect histogram.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 16:41:46 +03:00
David MannandClaude Opus 5.5 d55964bfb3 ui.click / ui.move reject coordinates beyond the screen range (#9137)
A finite x or y past f32's range became inf; on the next frame egui's
pointer delta inf - inf was NaN and its Vec2 equality assert panicked
outside the dispatch guard, closing the app. Both now lie within
+-MAX_SCREEN_POINT (1e6 points) and a larger one is an error naming the
field, with nothing queued.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-24 15:41:38 +02:00
Marco Arnulfo d31f2952dc Color field cursor: drop the Photoshop comparison, test the Color Picker marker too (#8968) 2026-10-24 15:28:54 +02:00
Marco Arnulfo e32d70c239 Color panel and Color Picker: clip the round cursor to the colour field (fixes #8968) 2026-10-24 15:28:45 +02:00
Roni Balthazar 81d842d307 fix(tiff): preserve PSD byte order in layered TIFF text descriptors (#9098) 2026-10-24 13:37:31 +01:00
vangel76andClaude Sonnet 5.5 47fa9fa3a5 Keep TOOL-214-14 partial and regenerate docs/scorecard.md
The row's own note says the window's Marquee tool and the Stamp's Heal modes
are still missing, so it stays partial; the scorecard is regenerated to match.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-24 14:32:41 +02:00
vangel76 053e1e0d03 Merge upstream/main into fix/3290-filter-mask-paint 2026-10-24 14:24:45 +02:00
vangel76 8c855f3fcd Merge upstream/main into fix/vp-stamp-tearoff 2026-10-24 13:56:35 +02:00
Davit MatchakhelidzeandClaude Opus 5.5 3136b11eb8 Georgian draws on its own: SF Georgian fallback on macOS, Geor served fallback on the web
The same scripts.rs/served.rs/tests.rs lines as #8812, so either merges first; the craft-fonts pin stays in #8812.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YMTAbGNRxnMEzRvYnQGphF
2026-10-24 15:52:06 +04:00
Davit MatchakhelidzeandClaude Opus 5.5 3d0ec178c3 i18n(ka): translate main's new strings (update checks, Color panel modes, .asl styles, damaged PSD prompt)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YMTAbGNRxnMEzRvYnQGphF
2026-10-24 15:16:27 +04:00
Davit Matchakhelidze 5b2fc01284 Merge upstream main into ka-language 2026-10-24 15:13:46 +04:00
David MannandClaude Opus 5.5 94244cf91a Address CodeRabbit review: check every autosave result and never hang the listing test
The writer thread now asserts each take_completed() result, so an earlier failed write
can't hide behind flush()'s last result, and a drop guard sets the done flag however the
thread ends, so a writer panic is reported by join instead of the listing loop spinning.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-24 13:09:17 +02:00
David Mann 92e73943c1 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/io/src/psd_export.rs
2026-10-24 13:06:42 +02:00
Andee CollardandClaude Opus 5.5 d065b7647b macOS menu tests: hold on Linux and Windows, where Hide Layers owns Cmd+, by default
Outside macOS, Hide Layers' default key is Cmd+, (Ctrl+,) and Settings
uses Cmd+K, so three Cmd+, tests found a second owner or Settings' own
key. Unbind Hide Layers where it isn't the subject, and check that
Settings doesn't show Cmd+, rather than that it has no key.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 11:44:47 +01:00
berce a1d656a0f0 fix(text): write raw EngineData strings back as the same bytes
EngineData strings without the FE FF mark were parsed into a String and written back as FE FF + UTF-16BE, so an unedited save rewrote raw strings in Txt2 (like /2 (0100...)), which makes Photoshop reject the file. Parse them into Value::RawString and write them back unchanged.

Refs #9091
2026-10-24 13:24:18 +03:00
Khawar Zamman Wani 254e501de9 fix(engine): a recorded several-layer Free Transform replays on the selection
The canvas box commits `edit.transform` with the `layers` it opened on, and
the Action recorder kept those ids verbatim, so replaying in another document
failed with NoLayer or moved unrelated layers. When the listed layers are the
ones the selection gives the command, the recorded step drops `layers` and
replays on the layers selected then; other explicit lists keep their ids.

Claude-Session: https://claude.ai/code/session_01D8r6W6haR5FWJyxUakMEfA
2026-10-24 14:47:13 +05:30
azizr12 a81e7b2f15 Update localization.md 2026-10-24 09:15:41 +00:00
dotCooCoo 55df342307 Batch: folder sources take every format PhotoCraft opens
The folder listing behind Batch and the other folder inputs used a
hand-kept extension list that lacked formats PhotoCraft opens: Cineon,
DICOM, Amiga IFF, PCX, XPM, DDS, PBM, PAM, PFM, Photoshop templates and
the CR3, ORF, RW2, RAF, SRF and SR2 raws. Those files were left out of a
batch without a message. The listing now takes every extension of a
format photocraft-codecs reads in the build and every camera raw
extension, and keeps its own list only for the document and vector
formats.

With Format "Same", inputs that PhotoCraft opens but does not write
(DICOM, Amiga IFF, GIMP's .xcf and .xcf.gz, .psdt, and any codec format
without a writer) are saved as PSD, as camera raws already were. Without this,
each such file would fail to save.
2026-10-24 01:54:23 -07:00
azizr12 6f5feed046 Update LICENSE-translations.txt 2026-10-24 08:41:33 +00:00
Daniel 8e1cf9dc97 Merge latest upstream main and preserve GNOME titlebar defaults
Retain PhotoCraft's updated UI and preferences, while preserving explicit saved titlebar settings, Linux frame dependencies, regression tests, packaging notices and roadmap entry.
2026-10-24 10:32:26 +02:00
azizr12 355f5b6666 1996/1996 2026-10-24 08:12:58 +00:00
129e6aec90 Integration: blank Group 4 fax pages pass the TIFF bomb guard (#8536)
The guard now bounds the decoded size by the bytes the strip tables hold
(x4096), not by the file length. CCITT Group 4 codes a blank row in one
bit, so a blank 600 dpi A4 landscape (7016x4961) or A3 page compresses
past 4096:1. With ordinary metadata or other pages in the file, main
opened such a page; this PR refused it ("the strips or tiles in this
file hold 624 bytes, too few for a 7016x4961 image"). Group 4
(compression 4, the only CCITT variant the decoder reads) now gets a
ratio of the strip or tile width, capped at the decoder's 65535.

Test: a_blank_fax_page_wider_than_4096_px_passes_the_bomb_guard fails
without the change, and checks a Group 4 strip too short for its page
is still refused.

Co-authored-by: wanikhawar <28915582+wanikhawar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 13:41:11 +05:30
Khawar Zamman Wani 069d14d998 Merge remote-tracking branch 'origin/main' into pen-path-operations
# Conflicts:
#	crates/ui-egui/src/control.rs
#	crates/ui-egui/src/tool_reset.rs
#	docs/ui-parity.md
2026-10-24 13:39:11 +05:30
Khawar Zamman Wani 55a6ce34fa Merge remote-tracking branch 'origin/main' into fix/8169-huge-tiff-open
# Conflicts:
#	crates/io/src/flat.rs
#	docs/file-format-parity.md
#	docs/gaps.md
2026-10-24 13:37:01 +05:30
azizr12 9d2fdb2d65 Update mod.rs 2026-10-24 08:04:39 +00:00
jonathnwxh 050ac592d4 Merge main preserving CSH, ASL and contour imports and translations 2026-10-24 15:57:08 +08:00
devstivi d9f97862af Let a control client's answer replace a stale Apply to All
A save that fails at once leaves the automatic answer in place until the prompt is drawn again. A control client answering in between now clears it, so the next document is asked about instead of taking the old answer.
2026-10-24 14:50:19 +07:00
devstivi 5fae9a15ee Ask afresh about documents found after Apply to All
Close All and quitting look for documents dirtied while the prompt was up once the first ones are answered. Apply to All only covers the documents it was given, so the stored answer is cleared when that second list is asked about.
2026-10-24 14:50:19 +07:00
devstivi d6ab8131f8 Offer Apply to All in the unsaved-changes prompt (#8983)
Closing several unsaved documents (Close All, Close Others, quitting) asked about each one in turn. With more than one document left the prompt now has an Apply to All box, as in Photoshop: Yes or No then answers for every remaining document. A document whose save is cancelled or fails is asked about again instead of retrying. Control clients get saveAll and dontSaveAll.
2026-10-24 14:50:19 +07:00
Khawar Zamman Wani 754c61fd7f feat(ui-egui): change the operation of drawn path components; carry on open shape paths
Feedback on #7648 from testing a vector portrait workflow:

- Path Selection selects path components: a click selects the one under the pointer, ⇧-click
  adds or removes one, a click off every component deselects, and a drag moves only the
  selected components (one `path.moveAnchors`). Their anchors show solid, as in Photoshop.
- Path Selection gets the Path Operations menu. With components selected, the menu changes
  their operation through the new engine command `path.setOperation` (Work Path, saved path,
  shape layer or vector mask; one History step), and its icon shows their operation.
- `+` (Combine Shapes) and `-` (Subtract Front Shape) pick the operation with the Pen tools and
  Path Selection, on the selected components and for the next path. `+` is ⇧= on a US layout, so
  with these tools it no longer steps the blend mode.
- The Pen carries on an open path from its endpoint in Shape mode (the selected shape layer)
  and on a targeted vector mask, as it already did on the Work Path and saved paths. Closing the
  open path a stroked-only shape layer was made of gives it the options bar's fill and stroke,
  as if it had been drawn closed.
2026-10-24 13:20:17 +05:30
azizr12 e61bd909c9 Update live_tests.rs 2026-10-24 07:48:52 +00:00
azizr12 a6b9135ba5 Update mod.rs 2026-10-24 07:47:33 +00:00
eiketre f074016208 Merge remote-tracking branch 'upstream/main' into fix/multilayer-transform-handles
# Conflicts:
#	crates/engine/src/transform_cmds.rs
#	crates/ui-egui/src/transform_tool.rs
#	docs/ui-parity.md
2026-10-24 09:39:37 +02:00
ArjenS-LA 81988038ff Execute Average through the shared smart-filter pipeline 2026-10-24 00:38:17 -07:00
ArjenS-LA 8e0fc5299a Fix Average colour weighting and preserve per-pixel alpha 2026-10-24 00:38:17 -07:00
Khawar Zamman WaniandClaude Opus 5.5 f3e66beea6 Merge origin/main into fix/6501-multi-layer-free-transform
Main's smart-object cache handling in edit.transform (take_caches /
restore_unrendered) now covers every transformed layer; the params doc
keeps both the layers field and main's bicubic variants.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 13:07:24 +05:30
azizr12 7a49e6317f Merge branch 'main' into main 2026-10-24 07:19:26 +00:00
Janiz-zzzandClaude Opus 5.5 5ecaf1d486 Add Finnish interface language
Adds a Finnish (Suomi, `fi`) catalog with 4,169 entries: every key of
the other bundled catalogs, written in sentence case from the English
labels with ordinary Finnish image-editing vocabulary. It is registered
with complete_menus, and xtask's source-key coverage check includes it.
Plurals are one/other with the partitive singular after any number but
1 (1 taso, 2 tasoa).

Any fi-* locale selects Finnish; sv-FI does not. Tests cover locale
tags, system-language resolution, id and context overrides, and plurals.

Clean-room, AI-assisted (Claude Code) translation; a native speaker
checked it in the running app, but it has not been proofread line by
line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 10:14:10 +03:00
Khawar Zamman Wani f01e2dd9c8 Merge remote-tracking branch 'origin/main' into fix/8842-hard-round-spacing 2026-10-24 12:10:25 +05:30
denstu473 2f15dd673b fix(io): preserve unfamiliar Halftone descriptor classes
Reject nested Halftone descriptors with unexpected class IDs before mapping
them into editable filters, so saving preserves the original Gallery stack.
Add a regression covering standalone and mixed stacks, and document the
Halftone test helpers and cases flagged by CodeRabbit.
2026-10-24 08:37:08 +02:00
Khawar Zamman Wani 6a74abbe09 Merge remote-tracking branch 'origin/main' into save-for-web-webp 2026-10-24 12:04:57 +05:30
Khawar Zamman WaniandClaude Opus 5.5 3466d93204 docs(control): workspace continuations wait for dialogs, prompts and blocking crops; cargo fmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 12:00:39 +05:30
Khawar Zamman Wani af5bf81f90 select-mask: refuse requests whole, drop old-revision previews, no brush on an empty selection
- control: tool, mode and stroke are parsed before anything changes, so a refused request leaves
  the workspace as it was.
- A preview made from an older document revision is dropped (even mid-stroke), and a revision
  change clears the shown texture and the pending result too.
- Show Edge applies the Refine Edge Brush only when the selection has content, as OK
  (matting::refine_area) does.
- control-protocol.md documents `hideView`.
2026-10-24 11:53:15 +05:30
Khawar Zamman WaniandClaude Opus 5.5 e466b9bd53 fix(ui): ui.menu.list greys what the modal gate refuses, like the native menu
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 11:12:15 +05:30