Commit Graph
11425 Commits
Author SHA1 Message Date
Khawar Zamman Wani a8d2d7cd90 Type tool IME test: the font field is its own text input 2026-10-26 11:57:46 +05:30
RickiNanoandClaude Opus 5.5 bcd8f89168 Prefs: startup reads Graphics Adapter through the typed Performance section
Graphics Adapter (performance.gpuAdapter) always took effect, but startup read it by its raw
JSON key, which the scorecard prefs audit can't see, so it was counted as a setting that does
nothing. read_gpu_adapter now deserialises the performance section into prefs::Performance, as
read_display_server already does. A malformed value elsewhere in the section falls back to
automatic, as the display server does.

Settings that do nothing: 12 -> 11 of 178. Scorecard regenerated; gaps G9, ui-parity and
target-app-parity updated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-26 07:14:21 +01:00
Khawar Zamman Wani 36aaca100a Frame tool: name its number fields; font picker IME test: a name the test fonts can draw 2026-10-26 11:23:10 +05:30
skylar taylor-barrick 3f2229b9ad M0.37: cover CJK fallback and font cache edge cases 2026-10-26 06:42:19 +01:00
dotCooCoo 3d8652d08f Merge main into feat/hand-scroll-all-windows 2026-10-25 22:35:24 -07:00
Brennan StehlingandClaude Opus 5.5 f342dba86e xtask perf: a row that failed in any run gets no baseline; judge contention on the load before the build (#7494)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-25 22:33:56 -07:00
Khawar Zamman Wani 57fa742f5d Save for Web WebP test: the Quality label now names a slider as well 2026-10-26 11:02:16 +05:30
Khawar Zamman Wani c484971fdf Adapt to egui 0.37 renames (Id::unique, scope_id, Role, IdSalt, dropdown names) 2026-10-26 10:53:01 +05:30
Khawar Zamman Wani ea0a447df1 Adapt to egui 0.37 renames (Id::unique, scope_id, Role, IdSalt, dropdown names) 2026-10-26 10:52:41 +05:30
Khawar Zamman Wani 5295017732 Adapt to egui 0.37 renames (Id::unique, scope_id, Role, IdSalt, dropdown names) 2026-10-26 10:52:23 +05:30
Khawar Zamman Wani 8bbffe7760 Merge origin/main into fix/font-name-editable-9338 2026-10-26 10:22:36 +05:30
Khawar Zamman Wani 56008a682d Merge origin/main into select-mask-workspace 2026-10-26 10:20:37 +05:30
Khawar Zamman Wani 6fc599dea9 Merge origin/main into save-for-web-webp 2026-10-26 10:20:32 +05:30
Khawar Zamman Wani 07549fd6a6 Merge origin/main into pen-path-operations 2026-10-26 10:20:27 +05:30
Khawar Zamman Wani cdc3bdbd2f Merge origin/main into fix/8169-huge-tiff-open 2026-10-26 10:20:12 +05:30
Khawar Zamman Wani 34b6a94b0c Merge origin/main into fix/6501-multi-layer-free-transform 2026-10-26 10:20:08 +05:30
Hector VillarrealandClaude Opus 5.5 6cc516a3d2 Color panel: a preference change made outside the panel is kept
CodeRabbit on #9606 (inline 4373831220): prefs.set or a reset changed
the stored Color panel options, and the next frame's persist wrote the
panel's stale options back over them. persist now remembers what it
last synced; a stored value that differs from it came from outside and
is taken into the live panel. An empty value (a reset) restores the
defaults.

Also covers the Color panel in the dock lifecycle test (CodeRabbit
nitpick), which runs real frames and a preferences JSON round trip.

Tests: an_outside_preference_change_reaches_the_live_panel,
dragging_the_splitter_resizes_and_survives_a_ui_state_round_trip

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 22:32:28 -06:00
Hector VillarrealandClaude Opus 5.5 a7b412d422 docs: regenerate the scorecard
The gate's scorecard check failed on #9606: the new remembered Color
panel option is one more preference (179). Regenerated with
`cargo xtask scorecard`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 22:03:16 -06:00
Hector VillarrealandClaude Opus 5.5 d1c875072a fix(ui): the Color panel remembers its options across restarts (#9592)
The Color panel's mode, ramp, Web-safe ramp and edited chip were never
saved, so every launch reset them. They now live in the preferences
(colorPanel), written when they change and restored at launch next to
the dock layout, independent of workspaces.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 21:54:36 -06:00
Hector VillarrealandClaude Opus 5.5 e2d0965d20 docs: keep the parity history newest first
Rebasing onto main put this PR's history row above main's newer rows
(CodeRabbit flagged the same on #9282).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 21:43:18 -06:00
Hector VillarrealandClaude Opus 5.5 20803d1f15 docs: keep ui-parity's history newest first
CodeRabbit on #9282 (inline 4373668508): the rebase put this PR's
2026-10-24 row above main's 2026-10-25 rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 21:42:34 -06:00
Hector VillarrealandClaude Opus 5.5 1eb98b319e fix(ui): Camera Raw's Color Mixer Hue tracks show the neighbouring hues (#9550)
Every Color Mixer slider's track ran from grey to its band's colour. A
Hue slider turns its band towards the neighbouring colours, so its
track now runs from the previous band's hue through its own to the next
(Reds: magenta, red, orange). Saturation and Luminance keep grey to the
colour.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 21:42:29 -06:00
Hector VillarrealandClaude Opus 5.5 47aea89e92 fix(ui): Liquify's Twirl Counterclockwise gets a mirrored twirl icon (#9547)
Twirl Counterclockwise used Lucide's undo-2 arrow, which reads as Undo.
It now uses rotate-ccw, Twirl Clockwise's rotate-cw mirrored (path data
mirrored about x = 12), registered in icon_data and listed in
ATTRIBUTION.md with the other Lucide icons.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 21:39:43 -06:00
Hector VillarrealandClaude Opus 5.5 9429df26b3 fix(ui): the layer list doesn't move with no layer selected (#9546)
With no layer selected, the greyed-out Blend/Opacity and Lock/Fill rows
sat in one add_enabled_ui wrapper, which added an item gap under them:
in themes whose docks keep item spacing (Studio, Classic) the first
layer row moved down 6 points. Each row now disables itself and is laid
out as the active layer's rows are.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 21:36:57 -06:00
Hector VillarrealandClaude Opus 5.5 a9744ed44d PSD contours: inputs a few ulps apart still span a segment
CodeRabbit on #9590 (inline 4373620552): the selection treated inputs
closer than f32::EPSILON as one, so a point on a tiny straight span got
a deviation from the flat line and was kept over a genuine bend. Only
equal inputs (a vertical step) have no span now.

Test: a_point_on_a_tiny_straight_span_is_not_a_bend

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 21:28:07 -06:00
skylar taylor-barrick 819d863c4e ci: restore craft-common-actions tracking main 2026-10-26 04:27:36 +01:00
Hector VillarrealandClaude Opus 5.5 e62013cfd6 fix(io): drop a kept Txt2 once no type layers are left (#9563)
A PSD opened with type layers keeps its document-level Txt2 (fonts and
layout caches). With type layers the export regenerates it, but once
all were deleted the old block was written back unchanged, describing
text that no longer exists (86% of one reported file). Photoshop drops
it; so does the export now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 21:25:39 -06:00
Hector VillarrealandClaude Opus 5.5 98956cfba1 Tests: the cube modes' gamut alert sets the background chip too
CodeRabbit nitpick on #9154 (color_panel_tests.rs 229-248): the test
only covered the foreground chip. With the background chip active, the
alert's click now must set the background and leave the foreground.

Test: cube_modes_warn_when_the_colour_cannot_print

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 21:22:30 -06:00
Hector VillarrealandClaude Opus 5.5 75fa71a4f5 fix(compose, gpu): a Pass Through group with Blend If renders isolated (#9554)
A Pass Through group composites its children straight into the
backdrop, so an Invert inside it changed the layer beneath even when
the group had Blend If. Photoshop renders such a group isolated, as it
does below 100% Fill: the backdrop stays (64,128,192) under a group
holding an Invert with Red Underlying white at 110. The CPU and GPU
pass-through shortcuts are now skipped for a group with Blend If.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 21:20:48 -06:00
Hector VillarrealandClaude Opus 5.5 46512521fe fix(engine): copied type keeps its size across resolutions after an edit (#9560)
Layers copied to another document were fitted to its mode, depth and
canvas but not its resolution: a type layer kept the source's point
size and box, so its next text edit re-laid it out at the destination's
dpi (24 pt from 72 to 300 ppi grew about 4.2 times). adapt_copies, used
by copy-to-document and paste, now applies the same compensation as an
Image Size resolution change (canvas_geom::set_resolution).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 21:16:19 -06:00
aiongg 59cb4c49bd Panels: remove the native dock's drawing, strip and drag code (#9583)
craft-ui's docking draws every layout, the default one included, so the
native dock's own renderer no longer runs. Remove dock::show with its
per-frame group and strip records, peek, splitter resize, group and tab
drag and drop; the column height solver it used; DockLayout's move_group
and move_tab, which only it called; panel_docking's drag promotion from
the native strip and its extra strip menu; the card widgets that drew the
native groups and the Pro tab strip; and the tab drag and reorder paths
of the strip the Studio Properties card still uses.

The native dock's state, the commands that change it, the default layout
built from it and workspace loading and saving stay as they are. Tests
of the removed code go; the default-height test runs on the drawn layout.
2026-10-25 23:13:32 -04:00
dotCooCoo 96b93148f2 Merge main into feat/layers-filter-by-artboard 2026-10-25 20:13:31 -07:00
dotCooCoo 58d11d91ea Equalize: with a selection, choose the selected area only or the entire image based on it
Image > Adjustments > Equalize with an active selection now opens a dialog
with Photoshop's two choices. Equalize Selected Area Only, the default,
changes only the selected pixels, as Equalize did before. Equalize Entire
Image Based On Selected Area maps every pixel of the layer within the
canvas by the selected pixels' histogram.

image.adjustments.equalize takes selectedAreaOnly (default true), and a
script that passes it runs without the dialog. .atn save writes the Eqlz
step without this setting, so it refuses a step with selectedAreaOnly false.
2026-10-25 20:12:03 -07:00
Hector VillarrealandClaude Opus 5.5 c47a8a4967 Preset menus: say they are PhotoCraft's own presets
FredApps on #9282 (changes requested): the menus showed familiar preset
names with PhotoCraft's own settings and nothing in the product said so.
The caption now reads "PhotoCraft Preset:", and its tooltip says these
are PhotoCraft's settings for the looks, not Photoshop's presets of the
same names. The preview, one-step history and Custom detection are
unchanged.

Test: preset_menus_say_they_are_photocrafts_own

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 20:54:58 -06:00
Hector VillarrealandClaude Opus 5.5 bcbf693cf6 Preset menus: egui 0.37's dropdown label
Main moved to egui 0.37 (#9363): dropdown takes an accessible label.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 20:53:45 -06:00
Hector VillarrealandClaude Opus 5.5 e614f7d39b fix(io): PSD layer-effect contours keep at most 16 points (#9556)
Photoshop reads at most 16 points in an effect contour; a longer one
makes it fail to read the layer and drop all its effects. Six built-in
contours are longer (Ring - Double has 27). The PSD writer now keeps
both ends and then the points farthest from the curve through those
kept, up to 16, so peaks survive; the document itself is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 20:53:27 -06:00
Hector VillarrealandClaude Opus 5.5 da15794507 fix(compose, gpu): an adjustment layer's This Layer range judges its result before Opacity (#9542)
Blend If on an adjustment layer judged This Layer by the composite after
Opacity and the mask had mixed the result into the backdrop. Photoshop
judges the adjustment's result itself: Invert at 40% over (64,128,192)
with Red This Layer black 150 keeps the effect, (115,128,140), as
Invert's red 191 passes 150. The CPU and the GPU now apply the
adjustment to the backdrop and judge that.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 20:48:06 -06:00
Hector VillarrealandClaude Opus 5.5 3183dd4efd docs: the cube modes' gamut alert needs a 53 pt field
CodeRabbit on #9154: the Hue Cube and Brightness Cube draw the ⚠ only when
the chips column is at least 53 pt tall; the slider modes always do. The
ui-parity row, history entry and status line now say so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 20:34:26 -06:00
Hector VillarrealandClaude Opus 5.5 9d46aa7503 Re-run CI
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 20:34:26 -06:00
Hector VillarrealandClaude Opus 5.5 2a83a24f2b Color panel: the cube modes warn when a colour can't print (#8672)
Photoshop's Color panel shows the out-of-gamut warning and a chip of the
nearest printable colour under the foreground/background chips in its
Hue Cube, the default mode. PhotoCraft drew it only in the slider modes.
The Hue and Brightness Cube now draw the same alerts (a click takes the
nearest printable colour), when the field is tall enough to hold them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 20:34:26 -06:00
Hector VillarrealandClaude Opus 5.5 85d7a2492c Tests: preset menus load every setting, in the dialog and Properties
CodeRabbit nitpick on #9282 (adjust_dialog.rs 787-827): the dialog test
now compares every setting of each preset, and a Properties-panel test
picks each of the four presets on an adjustment layer and checks every
setting and a single history step.

Tests: adjustment_preset_menus_load_presets_and_read_custom_after_an_edit,
properties_preset_menus_load_every_setting_in_one_step

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 20:34:20 -06:00
Hector VillarrealandClaude Opus 5.5 5a432c2b7e feat(ui): Preset menus for Levels, Exposure, Black & White and Channel Mixer
Fixes #9263, #9265, #9268, #9270. Each of these adjustments gains a
Preset menu at the top of its editor (dialog and Properties), with the
preset names Photoshop uses and Custom once edited; a choice is one edit.

The settings are PhotoCraft's own, designed for each look: Levels
presets lift, lower or stretch the tones; Exposure presets are whole
stops; the Black & White and Channel Mixer "filter" presets follow what a
coloured lens filter does on black-and-white film. None is taken or
measured from another application's presets.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 20:34:19 -06:00
Hector VillarrealandClaude Opus 5.5 fc0f7b1132 fix(compose, gpu): Blend If Gray uses Photoshop's weights and rounding (#9522)
Gray was Rec. 601 luma, unrounded, so mixed 8-bit colours near a hard
Gray point landed on the wrong side: (123,126,151) read 127.95 and was
hidden by a black point at 128. Photoshop's Gray, measured on pure
channels at three cutoffs, is (30R + 59G + 11B) / 100 rounded half down
on whole levels; it keeps both of the reporter's colours.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 20:20:50 -06:00
Dylan M. Taylor d3b0a76c3f lint: drop blank lines after doc comments and attributes; tidy IME else, closure, shell tests (#9576)
- Remove blank lines between doc comments or #[test] attributes and the item (S8855, S8856)
- type_tool: drop the redundant else after continue in the IME event arm (S8862)
- ui_state: pass OsStr::to_os_string instead of an equivalent closure (S1612)
- macos packaging: [[ ]] for the attempt test (S7688); bind validate_staple's argument to a local (S7679)
2026-10-25 22:08:50 -04:00
aiongg b078e0e8a6 Panels: review follow-ups to the shared docking and egui 0.37 merges (#9575) 2026-10-25 22:03:26 -04:00
GyoJoong Kum 242d5d23a1 fix(ui): merge initial tool color saves against default swatches 2026-10-26 02:02:20 +00:00
GyoJoong Kum 55c3ee1038 Merge latest upstream main and resolve app lifecycle and documentation conflicts 2026-10-26 01:39:08 +00:00
aiongg 6a199e224f Merge pull request #9366 from aiongg/docking-adopt
Panels: move onto craft-ui's shared docking
2026-10-25 21:23:10 -04:00
dotCooCoo 7a69ff3ef2 Merge main into feat/layers-filter-by-artboard 2026-10-25 17:38:27 -07:00
dotCooCoo c11b25db46 Layers panel: the Artboard filter walks each artboard's layers once
board_rows looked up each selected layer's artboard with a search from the document root. It now walks every top-level artboard once and keeps the artboards that hold a selected layer. The filter still clears when a selected layer is in no artboard.
2026-10-25 17:26:49 -07:00