Graphics Adapter (performance.gpuAdapter) always took effect, but startup read it by its raw
JSON key, which the scorecard prefs audit can't see, so it was counted as a setting that does
nothing. read_gpu_adapter now deserialises the performance section into prefs::Performance, as
read_display_server already does. A malformed value elsewhere in the section falls back to
automatic, as the display server does.
Settings that do nothing: 12 -> 11 of 178. Scorecard regenerated; gaps G9, ui-parity and
target-app-parity updated.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CodeRabbit on #9606 (inline 4373831220): prefs.set or a reset changed
the stored Color panel options, and the next frame's persist wrote the
panel's stale options back over them. persist now remembers what it
last synced; a stored value that differs from it came from outside and
is taken into the live panel. An empty value (a reset) restores the
defaults.
Also covers the Color panel in the dock lifecycle test (CodeRabbit
nitpick), which runs real frames and a preferences JSON round trip.
Tests: an_outside_preference_change_reaches_the_live_panel,
dragging_the_splitter_resizes_and_survives_a_ui_state_round_trip
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The gate's scorecard check failed on #9606: the new remembered Color
panel option is one more preference (179). Regenerated with
`cargo xtask scorecard`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Color panel's mode, ramp, Web-safe ramp and edited chip were never
saved, so every launch reset them. They now live in the preferences
(colorPanel), written when they change and restored at launch next to
the dock layout, independent of workspaces.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rebasing onto main put this PR's history row above main's newer rows
(CodeRabbit flagged the same on #9282).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CodeRabbit on #9282 (inline 4373668508): the rebase put this PR's
2026-10-24 row above main's 2026-10-25 rows.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every Color Mixer slider's track ran from grey to its band's colour. A
Hue slider turns its band towards the neighbouring colours, so its
track now runs from the previous band's hue through its own to the next
(Reds: magenta, red, orange). Saturation and Luminance keep grey to the
colour.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Twirl Counterclockwise used Lucide's undo-2 arrow, which reads as Undo.
It now uses rotate-ccw, Twirl Clockwise's rotate-cw mirrored (path data
mirrored about x = 12), registered in icon_data and listed in
ATTRIBUTION.md with the other Lucide icons.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With no layer selected, the greyed-out Blend/Opacity and Lock/Fill rows
sat in one add_enabled_ui wrapper, which added an item gap under them:
in themes whose docks keep item spacing (Studio, Classic) the first
layer row moved down 6 points. Each row now disables itself and is laid
out as the active layer's rows are.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CodeRabbit on #9590 (inline 4373620552): the selection treated inputs
closer than f32::EPSILON as one, so a point on a tiny straight span got
a deviation from the flat line and was kept over a genuine bend. Only
equal inputs (a vertical step) have no span now.
Test: a_point_on_a_tiny_straight_span_is_not_a_bend
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A PSD opened with type layers keeps its document-level Txt2 (fonts and
layout caches). With type layers the export regenerates it, but once
all were deleted the old block was written back unchanged, describing
text that no longer exists (86% of one reported file). Photoshop drops
it; so does the export now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CodeRabbit nitpick on #9154 (color_panel_tests.rs 229-248): the test
only covered the foreground chip. With the background chip active, the
alert's click now must set the background and leave the foreground.
Test: cube_modes_warn_when_the_colour_cannot_print
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A Pass Through group composites its children straight into the
backdrop, so an Invert inside it changed the layer beneath even when
the group had Blend If. Photoshop renders such a group isolated, as it
does below 100% Fill: the backdrop stays (64,128,192) under a group
holding an Invert with Red Underlying white at 110. The CPU and GPU
pass-through shortcuts are now skipped for a group with Blend If.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Layers copied to another document were fitted to its mode, depth and
canvas but not its resolution: a type layer kept the source's point
size and box, so its next text edit re-laid it out at the destination's
dpi (24 pt from 72 to 300 ppi grew about 4.2 times). adapt_copies, used
by copy-to-document and paste, now applies the same compensation as an
Image Size resolution change (canvas_geom::set_resolution).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
craft-ui's docking draws every layout, the default one included, so the
native dock's own renderer no longer runs. Remove dock::show with its
per-frame group and strip records, peek, splitter resize, group and tab
drag and drop; the column height solver it used; DockLayout's move_group
and move_tab, which only it called; panel_docking's drag promotion from
the native strip and its extra strip menu; the card widgets that drew the
native groups and the Pro tab strip; and the tab drag and reorder paths
of the strip the Studio Properties card still uses.
The native dock's state, the commands that change it, the default layout
built from it and workspace loading and saving stay as they are. Tests
of the removed code go; the default-height test runs on the drawn layout.
Image > Adjustments > Equalize with an active selection now opens a dialog
with Photoshop's two choices. Equalize Selected Area Only, the default,
changes only the selected pixels, as Equalize did before. Equalize Entire
Image Based On Selected Area maps every pixel of the layer within the
canvas by the selected pixels' histogram.
image.adjustments.equalize takes selectedAreaOnly (default true), and a
script that passes it runs without the dialog. .atn save writes the Eqlz
step without this setting, so it refuses a step with selectedAreaOnly false.
FredApps on #9282 (changes requested): the menus showed familiar preset
names with PhotoCraft's own settings and nothing in the product said so.
The caption now reads "PhotoCraft Preset:", and its tooltip says these
are PhotoCraft's settings for the looks, not Photoshop's presets of the
same names. The preview, one-step history and Custom detection are
unchanged.
Test: preset_menus_say_they_are_photocrafts_own
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Photoshop reads at most 16 points in an effect contour; a longer one
makes it fail to read the layer and drop all its effects. Six built-in
contours are longer (Ring - Double has 27). The PSD writer now keeps
both ends and then the points farthest from the curve through those
kept, up to 16, so peaks survive; the document itself is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Blend If on an adjustment layer judged This Layer by the composite after
Opacity and the mask had mixed the result into the backdrop. Photoshop
judges the adjustment's result itself: Invert at 40% over (64,128,192)
with Red This Layer black 150 keeps the effect, (115,128,140), as
Invert's red 191 passes 150. The CPU and the GPU now apply the
adjustment to the backdrop and judge that.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CodeRabbit on #9154: the Hue Cube and Brightness Cube draw the ⚠ only when
the chips column is at least 53 pt tall; the slider modes always do. The
ui-parity row, history entry and status line now say so.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Photoshop's Color panel shows the out-of-gamut warning and a chip of the
nearest printable colour under the foreground/background chips in its
Hue Cube, the default mode. PhotoCraft drew it only in the slider modes.
The Hue and Brightness Cube now draw the same alerts (a click takes the
nearest printable colour), when the field is tall enough to hold them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CodeRabbit nitpick on #9282 (adjust_dialog.rs 787-827): the dialog test
now compares every setting of each preset, and a Properties-panel test
picks each of the four presets on an adjustment layer and checks every
setting and a single history step.
Tests: adjustment_preset_menus_load_presets_and_read_custom_after_an_edit,
properties_preset_menus_load_every_setting_in_one_step
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixes#9263, #9265, #9268, #9270. Each of these adjustments gains a
Preset menu at the top of its editor (dialog and Properties), with the
preset names Photoshop uses and Custom once edited; a choice is one edit.
The settings are PhotoCraft's own, designed for each look: Levels
presets lift, lower or stretch the tones; Exposure presets are whole
stops; the Black & White and Channel Mixer "filter" presets follow what a
coloured lens filter does on black-and-white film. None is taken or
measured from another application's presets.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gray was Rec. 601 luma, unrounded, so mixed 8-bit colours near a hard
Gray point landed on the wrong side: (123,126,151) read 127.95 and was
hidden by a black point at 128. Photoshop's Gray, measured on pure
channels at three cutoffs, is (30R + 59G + 11B) / 100 rounded half down
on whole levels; it keeps both of the reporter's colours.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Remove blank lines between doc comments or #[test] attributes and the item (S8855, S8856)
- type_tool: drop the redundant else after continue in the IME event arm (S8862)
- ui_state: pass OsStr::to_os_string instead of an equivalent closure (S1612)
- macos packaging: [[ ]] for the attempt test (S7688); bind validate_staple's argument to a local (S7679)
board_rows looked up each selected layer's artboard with a search from the document root. It now walks every top-level artboard once and keeps the artboards that hold a selected layer. The filter still clears when a selected layer is in no artboard.