Commit Graph
11425 Commits
Author SHA1 Message Date
Khawar Zamman Wani 8a2acd5ad6 fix: guard cropped selection bounds against corrupt tile coordinates 2026-10-26 19:26:33 +05:30
David Mann 17d9572865 Merge fix/5495-dropdown-height (with main 59cb4c49bd) into fix/5532-blend-separators
# Conflicts:
#	crates/ui-egui/src/panels.rs
#	crates/ui-egui/src/widgets.rs
2026-10-26 14:47:54 +01:00
David Mann 08190ed581 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/ui-egui/src/prefs_ui.rs
#	crates/ui-egui/src/sizing.rs
#	docs/gaps.md
#	docs/scorecard.md
#	docs/ui-parity.md
2026-10-26 14:46:28 +01:00
David MannandClaude Opus 5.5 bfa718f20b Dropdowns: a list opening above its box is in place from its first visible frame (#5495)
egui placed an upward list's bottom by the size it had the frame before, so
it moved up by ~46 pt as it settled and a click two frames after opening
missed the row (main's intermediate_ui_scale_choices test). Its top is now
placed from the rows' measured height plus the popup frame's margin.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-26 14:43:48 +01:00
Khawar Zamman Wani c66899e0a5 test: simplify selection fixtures for strict Clippy 2026-10-26 19:08:28 +05:30
David MannandClaude Opus 5.5 57c6652cfc Docs: regenerate the scorecard after merging main (#9480)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-26 14:36:11 +01:00
David MannandClaude Opus 5.5 ce56441f38 Address CodeRabbit review: the unsmoothed pan ignores wheel events outside the Move phase (#9480)
egui scrolls only by `TouchPhase::Move` wheel events; a trackpad's Start, End or Cancel
event with a delta no longer pans the canvas.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-26 14:35:57 +01:00
Khawar Zamman Wani 9282b12257 ci: run the GPU performance suite on its macOS runner class 2026-10-26 19:05:27 +05:30
David MannandClaude Opus 5.5 68c0f034d5 Plug-ins: refuse a code section with no functions but many bytes instead of panicking (#9679)
wasmi 2.0's strict limits divide the code section's size by its function
count before validating it, so a module whose code section declares 0
functions but more than 1000 bytes (crafted, truncated inside the section,
or a duplicate code section) panicked in Plugin::load. Check every code
section for that one case before handing the bytes to wasmi and return
Error::Module; everything else is still left to wasmi.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-26 14:34:41 +01:00
NaufalDzzandClaude Opus 5.5 207f83d6f3 Free Transform readout: offscreen test across ruler units
Drags a Free Transform edge with real pointer events in the offscreen
app and checks the W/H readout in pixels, centimeters and percent, and
that the old percent readout is gone for the other units. Set
PHOTOCRAFT_TRANSFORM_READOUT_EVIDENCE_DIR to save the frames as PNGs.

Also note on Readout::Scale why the size is the scaled width and height
rather than the skewed edge lengths.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-26 20:33:04 +07:00
Khawar Zamman Wani be43268ffa perf: crop Modify command mask conversion and selection replacement 2026-10-26 19:02:43 +05:30
David Mann 01adff1e5c Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/io/src/psd_export.rs
#	crates/io/src/tiff_layers.rs
2026-10-26 14:32:07 +01:00
David Mann 7e4ceba5df Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/cms/src/lutfile.rs
2026-10-26 14:26:50 +01:00
David Mann b7dcc15f46 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/ui-egui/src/crop_presets.rs
#	crates/ui-egui/src/widgets.rs
2026-10-26 14:26:30 +01:00
David MannandClaude Opus 5.5 6c2e90c8bb Address CodeRabbit review: Windows tests follow the SystemRoot fallback
The tests built the expected explorer.exe / reg.exe path from SystemRoot with unwrap(),
so they panicked when it was unset and ignored the C:\Windows fallback for an unset or
relative value. The rule is now a small pure function windows_root(value) in each crate;
the tests use it and check the absolute, unset, relative, rooted-without-drive and empty
cases without touching the process environment.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-26 14:22:38 +01:00
NaufalDzzandClaude Opus 5.5 dbdd5da271 Free Transform: show the live W/H readout in the ruler unit (#9400)
While a handle is dragged, the W/H readout beside the pointer showed
the scale in percent whatever the Units & Rulers unit. It now shows the
box's transformed size in the ruler unit at the document's resolution,
as Photoshop does, through the marquee's `size_readout`. With the
rulers in percent it keeps showing the scale of the original box,
since a percent of the document size means nothing for the box.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-26 20:16:30 +07:00
David Mann f78ab789e3 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/engine/src/canvas_geom/tests.rs
2026-10-26 14:12:47 +01:00
Khawar Zamman Wani 977585aa24 test: retain allocation reuse in the Contract performance baseline 2026-10-26 18:41:04 +05:30
David Mann 7451739eef Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/ui-egui/src/canvas.rs
#	crates/ui-egui/src/wheel_nav.rs
#	docs/scorecard.md
2026-10-26 14:10:11 +01:00
Khawar Zamman Wani d781e3ae09 ci: install native dependencies for the quick performance suite 2026-10-26 18:34:50 +05:30
Khawar Zamman Wani 4244ec2b9e perf: crop selection morphology and bound small-radius distances 2026-10-26 18:33:35 +05:30
David MannandClaude Opus 5.5 da87348f86 SVG: the fallback font search reads each font's character map once (#9671)
A character the text's font lacks made usvg's fallback search ask every
face in the database whether it has the character, and for a face loaded
from a file (every system font) that reads the whole font file. Once per
text element: 20 elements with U+10FF00 took 3 s with 273 installed faces.

The fallback selector is now our own copy of usvg's loop (same order,
used-face exclusion and style filter), and the per-face check answers
from a per-process cache of each file face's cmap table, picked as
ttf-parser's Face::parse picks it (last record of a linear walk, so an
unsorted table directory gives the same table) and looked up the same
way. Bounded at 64 MiB; a file that doesn't load isn't remembered.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-26 14:02:04 +01:00
David MannandClaude Opus 5.5 21d0ac3a10 Tests: a .pcraft smart object with a hostile SVG source does not abort Image Size or a PSD save
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-26 13:27:52 +01:00
mahefanante 8c2e269cf9 Fix: ajout des dernières modifications 2026-10-26 12:26:27 +00:00
David Mann b8203b81ad Merge remote-tracking branch 'origin/main' into fix/svg-markup-check 2026-10-26 13:22:35 +01:00
David MannandClaude Opus 5.5 e47b2d8514 Windows: fall back to C:\Windows when SystemRoot is unset, as printing and fonts do
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-26 13:18:58 +01:00
David MannandClaude Opus 5.5 0a55ee65ef Windows: run explorer.exe and reg.exe by full path (#9666)
Reveal in Explorer and the CJK locale lookup started `explorer` and `reg`
by bare name, and Windows looks in the app's own folder first: an
explorer.exe or reg.exe next to a portable PhotoCraft ran instead.
Both now start from %SystemRoot%.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-26 13:14:01 +01:00
mahefanante 1eda417bdf Merge branch 'main' of https://github.com/storytold/photocraft into main 2026-10-26 12:02:41 +00:00
mahefanante df91a8555b Fix: ajout des dernières modifications 2026-10-26 11:44:01 +00:00
mahefanante 3d4c205881 Fix: résolution du conflit dans vector_cmds.rs 2026-10-26 11:25:44 +00:00
SofiaAFigueredoandClaude Sonnet 5.5 9e1b140bf3 JPEG Options: remember the last quality and format (#9631)
The dialog now starts at the quality and Format Options it was last answered
with, also after a restart, as Photoshop's does. The answer is kept in the
remembered dialog settings (prefs.dialogs) when OK is pressed; Cancel keeps
nothing, and a stored value that no longer fits is ignored.

An opened JPEG still starts at its own quality (File > Save keeps it, #4032),
with the remembered format; leaving that quality as it is does not replace the
quality remembered for other documents.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-26 08:16:24 -03:00
Khawar Zamman Wani 2b6734911f Type options bar test: a layer of mixed families shows no family once the edit ends 2026-10-26 16:33:19 +05:30
Daniel bef973a1c5 test(docs): preserve integrated Linux title bar and remove redundant NOTICE install 2026-10-26 11:57:54 +01:00
Daniel 7a9ee62567 test(docs): preserve integrated Linux title bar and remove redundant NOTICE install 2026-10-26 11:57:50 +01:00
Daniel a0e1e4d836 test(docs): preserve integrated Linux title bar and remove redundant NOTICE install 2026-10-26 11:57:47 +01:00
Daniel 17c5fb36af test(docs): preserve integrated Linux title bar and remove redundant NOTICE install 2026-10-26 11:57:44 +01:00
Daniel 6927d058fc test(docs): preserve integrated Linux title bar and remove redundant NOTICE install 2026-10-26 11:57:40 +01:00
Daniel 5833b153e4 test(docs): preserve integrated Linux title bar and remove redundant NOTICE install 2026-10-26 11:57:37 +01:00
Daniel 56c7201055 fix(linux): retain integrated CSD as default title bar 2026-10-26 11:57:34 +01:00
Khawar Zamman Wani d9851ee6e8 Type options bar test: find the family field and style menu by role 2026-10-26 16:09:20 +05:30
Khawar Zamman Wani f974dc850b Type options bar test: font and style follow the selected run, not the first (#9024 scenario) 2026-10-26 15:44:00 +05:30
jonathanwxh-cell 963bc8ab4e Merge upstream main into the action document-offset branch
Keep the #7103 opening-order note with main's newer gap status.
2026-10-26 10:06:28 +00:00
jonathanwxh-cell 9e81ec3576 fix(shapes): store CSH display names and report the group used
Localization keys such as $$$/Presets/Shapes/Tiger=Tiger were kept raw, so the Shapes panel showed the key. File → Open now reports the group the importer stored, including a suffix when that name was already taken.
2026-10-26 09:50:13 +00:00
jonathanwxh-cell 059940c993 Merge upstream main into the CSH shape import branch
Keep the custom-shape translations and the CSH import notes with main's newer format and gap status.
2026-10-26 09:50:13 +00:00
Khawar Zamman Wani 490396f87e Type font field: ⌘/Ctrl+Enter resolves a pending query like Enter
commit_shortcut skipped the highlighted row and fell back to the first
match, so with the current family highlighted it applied a different
family than the menu showed. Both paths now share accept_row (exact name,
then the highlighted row, then the first). Also remove the blank line
that split the ui-parity revision-history table.
2026-10-26 14:58:33 +05:30
Khawar Zamman Wani 67666bdf72 bench(engine): add bench_sharpen_tool example 2026-10-26 14:33:41 +05:30
Khawar Zamman Wani 9e13779e63 perf(algo): row-parallel local_sharpen with fast-path protect_detail (#5426)
Refs #5426. Follow-up to #5499.

Cause:
While #5499 parallelized local_blur and the per-dab mix in DabTool::Focus,
local_sharpen in crates/algo/src/retouch.rs remained single-threaded.
In addition, protect_detail redundantly evaluated coordinate clamping
and strided memory lookups across 8 neighbors inside the per-channel
inner loop for every pixel in the dab. On large brush sizes (e.g. 1000–2500 px),
strokes took seconds and stalled the application.

Change:
- Process local_sharpen window rows in parallel with Rayon across threads,
  with wasm32 serial fallback matching local_blur.
- Hoist protect_detail 3x3 neighborhood offset calculations outside the
  channel loop.
- Fast-path interior pixels (x > 0 && x + 1 < w && y > 0 && y + 1 < h)
  with direct stride offsets, skipping boundary clamping entirely for >99.9%
  of pixels in large brush dabs.
- Add retouch_sharpen_exact integration test verifying bit-for-bit parity
  against the frozen scalar implementation across layouts, edges, and channels.
2026-10-26 14:29:47 +05:30
Khawar Zamman Wani 810e9b1af5 Type tool IME test: typed text follows the field's current family 2026-10-26 12:29:34 +05:30
NetterSilverandClaude Opus 5.5 652075f4da Pencil: keep a 1 px freehand line connected where it turns
Fixes #8040

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-26 07:57:16 +01:00
RickiNanoandClaude Opus 5.5 8103d35dee Prefs: startup reads the Performance section leniently, as the app does
Review (CodeRabbit on #9618): deserialising the whole performance section strictly meant one
wrongly typed value (say "cacheLevels": "four") reset Graphics Adapter to automatic at startup,
while the app, which loads the file through read_lenient (#6611), kept the user's adapter.
read_display_server had the same flaw.

prefs::read_section exposes the engine's lenient reader for one section; gpu_startup's
read_performance uses it for both the graphics adapter and the Linux display server. Tests: a
valid adapter and display server survive a malformed sibling value.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-26 07:39:04 +01:00