Commit Graph
11425 Commits
Author SHA1 Message Date
dotCooCoo 4c26572d7f Merge main into fix/history-trim-keeps-the-cleared-brush-source
main moved the crates/ops tests from lib.rs into tests.rs; the new
test goes to tests.rs.
2026-10-27 15:50:09 -07:00
aiongg eb6c1abf75 Merge pull request #9756 from Jeremy8776/feat/install-scope-policy
Windows installation policy: PhotoCraft
2026-10-27 17:57:55 -04:00
Brennan StehlingandClaude Opus 5.5 285944de8d Perf: P79's row name leaves out the document size, which --quick changes
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 14:38:45 -07:00
Brennan StehlingandClaude Opus 5.5 e43762ac0d Perf: rename P79 to the reduced composite it times (#7494)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 14:38:45 -07:00
Brennan StehlingandClaude Opus 5.5 72b53ffebe Perf: P78 times a hide on every run, showing the layer again untimed first (#7494)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 14:38:45 -07:00
Brennan Stehling 5b057e2247 Scorecard: regenerate for the cliff rows (#7494) 2026-10-27 14:38:45 -07:00
Brennan Stehling 6beffc0fb9 Perf: P78 forces the GPU budget to 512 MB, so hiding the top adjustment layer takes the CPU fallback (#7494) 2026-10-27 14:38:45 -07:00
Brennan StehlingandClaude Opus 5.5 8cecf418e5 Perf: cliff rows for the CPU compositor, Advanced Blending, adjustment toggles and a huge document (#7494)
Reported only (enforce = false), so the off-happy-path cliffs have a "before":
- perf_scenarios_cpu: the layered rows on the forced CPU compositor (P68-P74, #9330)
- P75 opacity with Advanced Blending on another layer (#6689), P76 adjustment toggle (#6535)
- P77 hiding an adjustment among many full-canvas layers (#6533), added after P60/P61 run
- P78 zoomed-out reduced refresh of a 30000x30000 painted document (#1015, #9330)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 14:38:45 -07:00
RickiNanoandClaude Opus 5.5 599b85a7cd Merge main into prefs/gpu-adapter-typed-read
Integration batch 9 (#9775) raised the preference count to 181 and
added its own 2026-10-27 status lines and history rows to gaps.md and
ui-parity.md. Both sides are kept: the scorecard regenerates to 11 of
181 do nothing, the branch's entries say 181 and are dated 2026-10-27,
above main's 12-of-181 rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 22:30:17 +01:00
Claude f84111c2d8 Merge storytold/photocraft main into the Fill/Stroke popover branch
i18n and ui-parity conflicts were append-only: upstream's entries first,
this branch's after. docs/scorecard.md regenerated (12 of 182).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TYsCL5E2GM6hUabP9dmYAv
2026-10-27 21:13:57 +00:00
Jeremy 768ca7ce63 docs(installer): limit the silent per-user default to new installs
Maintenance keeps the existing installation context, and a major upgrade of an
existing per-machine installation without ALLUSERS=1 is rejected rather than
installed per-user.
2026-10-27 21:13:30 +00:00
Jeremy 40310f10ea test(installer): cover the compiled folder searches, resolver chains and wizard folder replay
The policy check now reads the compiled AppSearch and RegLocator rows for the
remembered-folder properties (registry root, key, value name and type for both
scopes) and runs the DIR, FOLDER, PATH and legacy exe actions in sequence order
against seeded values, so their precedence and the preset-folder guard cannot
regress. It also replays the wizard folder actions in sequence order (a
remembered folder beats the new-install default, a typed folder beats both) and
requires the machine restore action between the scope page and costing.
2026-10-27 21:13:29 +00:00
Claude 957e7d3347 Merge storytold/photocraft main into the Fill/Stroke popover branch
Upstream moved the touched modules (dialogs/, tools/, widgets/ split) and
added its own Gradient tab to the shape Fill/Stroke swatches. Resolved by
porting this branch's changes onto the new layout:

- widgets/color.rs: color_edit_button* open the full Color Picker dialog
  (tests in widgets/color_button_tests.rs).
- tools/paint_picker.rs (was paint_picker.rs): the popover reuses
  shape_paint_ui::PaintChange (plus OpenPicker) and upstream's
  shape_gradient_ui Gradient tab instead of its own gradient preset list,
  so gradients now also work for the next shape's defaults.
- shape_paint_ui::swatch draws the popover; shape_options and
  vector_ui/options handle OpenPicker and Recently Used Colors.
- adjust_editors, caf_ui, file_ui call sites and tests moved to their
  new files; i18n entries appended after upstream's.
- docs/scorecard.md regenerated (12 of 181 settings unread).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TYsCL5E2GM6hUabP9dmYAv
2026-10-27 21:04:03 +00:00
Matthias Schlich 3577eeb914 Merge origin/main into feat/lens-flare-look 2026-10-27 21:59:26 +01:00
aiongg 52f338e2df Merge pull request #9775 from davidmann4/integration-batch-9
Integration batch: 21 PRs on main
2026-10-27 16:53:43 -04:00
dotCooCoo 6f5d929d61 Merge main into fix/liquify-smart-filter-reopens-workspace 2026-10-27 13:51:57 -07:00
aiongg b8b3586904 ci: use storytold/craft-common-actions at the merged installer-policy commit 2026-10-27 20:51:50 +00:00
Davit MatchakhelidzeandClaude Opus 5.5 5ea00fe3f1 i18n(ka): bring the Georgian catalog up to date
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 00:39:17 +04:00
Davit Matchakhelidze 75d5545371 Merge upstream main into ka-language 2026-10-28 00:39:17 +04:00
Taylor BurkeandClaude Opus 5.5 af31ea090a Extra windows share the main window's app id, so Wayland docks and window rules see them (#6697)
Document windows (Window › New Window), Camera Raw and the screen color
picker were built from ViewportBuilder::default() with no app id, so on
Wayland their class was empty: Hyprland rules couldn't match them and docks
couldn't map them to the .desktop file. They now use the same app id as the
main window, defined once in photocraft_ui_egui::os_window.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 15:31:30 -05:00
David Mann 71c6a64fd2 Merge PR #9455: raw: develop the default rendering band by band, without the f32 RGB frame
The author's new head 9bb0ecec97 is our fix-up 0b09eb43a5 plus main dacecbfea1, tree for tree, so this merge changes no file; it keeps #9455 marked merged with the batch.
2026-10-27 21:16:55 +01:00
Vlad Grankovsky df76a8c22f Merge origin/main into codex/multi-channel-editing
Integrate main dacecbfea, retaining selected-colour and explicit clipboard targets alongside CMYK and spot-channel tone fixes. Cover explicit spot copying while multiple colour rows are selected.
2026-10-27 21:15:06 +01:00
Taylor BurkeandClaude Opus 5.5 c139d3dbe6 Screen picker: a Wayland desktop picks through the portal when the window runs on Xwayland (#8977)
With a pen attached, or Preferences › Performance › Linux display server set
to X11, the window opens through Xwayland on a Wayland desktop. The picker
followed the window's display server and grabbed Xwayland's root window,
which holds no desktop pixels: GetImage failed with BadMatch. Choose the
backend from the desktop session instead, so Wayland always uses the
portal's PickColor.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 14:44:34 -05:00
RickiNanoandClaude Opus 5.5 3aff459ad8 Merge main into prefs/gpu-adapter-typed-read
Picks up the export speed work (#9877) and the rest of main. Main's
prefs audit now counts 180 preferences, so the regenerated scorecard
reads 11 of 180 do nothing, and the branch's doc entries say 180 to
match; the 2026-10-25 history rows keep their 178.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 20:27:58 +01:00
David MannandClaude Opus 5.5 1992cfcb9c Integration: parity docs dated 2026-10-27 with a history row for the scorecard count
CodeRabbit on #9775: the 12-of-181 count changed today, so ui-parity.md and gaps.md get the date in their status lines and a revision-history row, as AGENTS.md asks.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 20:21:26 +01:00
David MannandClaude Opus 5.5 f56ae19522 Integration: Save As from an opened .pgm suggests .pnm on every platform (#3609)
CodeRabbit on #9775: the Linux portal swaps the extension for the picked type, but macOS and rfd keep the suggested name, so an opened image.pgm could still be saved as image.pgm holding P6 data. The suggested name itself now takes .pnm for any Netpbm subtype; the services test fails without it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 20:21:26 +01:00
David MannandClaude Opus 5.5 8b0a8da8b1 Integration: flate2 at least 1.1.10, the first with runtime_detection (#7689)
CodeRabbit on #9775 (nitpick): #7689 enables flate2's runtime_detection feature, which 1.1.9 and older don't have, under a "1" requirement; a lock-less consumer (the publishable psd crate) could resolve an older 1.x and fail. Cargo.lock already pins 1.1.10 and is unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 20:21:25 +01:00
Brennan StehlingandClaude Opus 5.5 1382a240a6 Render path: an adjustment preview on a software adapter records its reason (#9328)
A software adapter still runs the GPU canvas, so an adjustment dialog that
previews through the CPU proxy is its own cause, as a document's reason is.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 12:20:25 -07:00
vangel76andClaude Sonnet 5.5 e9a8bbd307 Merge upstream/main into fix/6578-polygon-close-small
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-27 20:17:05 +01:00
Jeremy f82028c00d fix(installer): check the exact architecture-specific machine folder
The pre-signing check matched any folder named Program Files, so it rejected
a valid MSI when Windows resolves Program Files elsewhere, accepted the 64-bit
root for an x86 package and accepted a different app name. Build the expected
folder from the package architecture's resolved root and the policy name.
2026-10-27 19:13:14 +00:00
David MannandClaude Opus 5.5 5ccb6fb723 Merge main
Conflicts with main's batch #9880:
- psd file.rs / layer.rs: #5287 (PSB by encoded size, RLE tables widened on
  promotion) against #6583's lazy reader. Main's new widening and length code
  read `.data`, which #6583 leaves empty while the bytes stay in the source;
  it now goes through `encoded()` / `encoded_len()` (also the auto-merged
  lines in `rle_widening`, `encoded_len` and `LayerRecord::write`), and the
  lazy reader sets `write_as_psb: false`. New test
  `a_lazy_psd_promotes_to_the_same_psb_as_an_eager_one`: a lazily read PSD
  writes the same PSB bytes as an eager one; it fails with a `.data` read.
- direct_select.rs / vector_ui.rs: #9321's Type Path and #6353's hidden
  Work Path both kept.
- io tests main.rs: both modules. scorecard.md regenerated (12 of 181);
  ui-parity.md and gaps.md follow it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 19:49:42 +01:00
vangel76 9bb0ecec97 Merge upstream/main into perf/9434-fused-develop 2026-10-27 19:44:48 +01:00
6d62da9043 Integration: per-band AHD balancing, memory-capped fused bands (#9455)
`for_bands_grouped` always split the bands into `min(workers, jobs)` static
chunks, so on the default develop (jobs == workers) a worker held up on the
shared pool kept a fixed share of the bands waiting, where main's
`chunks_mut_limited` runs one rayon task per band. Now, when every worker may
hold a scratch, each band is its own task and borrows a scratch from a pool
(`par::chunks_mut_pooled`, at most one per worker, dropped as soon as no
waiting band can use it); the grouping stays for memory-limited jobs.

The fused bilinear/MHC, X-Trans and LinearRaw paths ran one band per worker
with no memory cap: a 262144 x 455 Bayer frame with bilinear needed 2.92 GB
at 15+ workers and failed with LimitExceeded under the default 2 GiB.
`working_memory` now caps those bands like AHD's and the fused paths use the
returned jobs. The fused LinearRaw and X-Trans band buffers are `band.min(h)`
rows, as charged (CodeRabbit, develop.rs:414).

Tests: a_slow_band_does_not_hold_up_the_bands_after_it and
fused_bands_at_once_are_capped_by_the_memory_limit fail without the fix;
for_bands_keeps_at_most_jobs_scratches_alive, chunks_mut_pooled_makes_one_state_per_worker_at_most,
multi-band and short X-Trans/LinearRaw fused-vs-full cases.

Co-authored-by: Valentin Klein <271991477+vangel76@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 19:44:48 +01:00
aiongg dacecbfea1 Merge pull request #9880 from aiongg/batch-1027
Integration batch: 22 PRs on main
2026-10-27 14:25:13 -04:00
David MannandClaude Opus 5.5 c955e51b7f Integration: the parity docs name the locked-group exception for new layers (#4329)
CodeRabbit on #9775: Place::AutoEditable puts type, shapes, pastes, placed files and frames above a group whose lock would refuse them; ui-parity.md's status line and checklist row said every new layer goes into an open active group.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 19:13:57 +01:00
David MannandClaude Opus 5.5 9426231d72 Integration: Save As from a Netpbm subtype's name starts on .pnm (#3609)
CodeRabbit on #9775: save_filters adds an unlisted suggested extension as its own type, so Save As on an opened .pgm offered .pgm again, though the encoder writes P6 for an RGB document. A suggested .pbm/.pgm/.ppm/.pam/.pfm now starts on the Netpbm type as .pnm; the services test checks every subtype name and fails without this.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 19:13:57 +01:00
David Mann 8bc71f924b Merge main
# Conflicts:
#	crates/format/src/store.rs
2026-10-27 19:10:28 +01:00
aiongg 55effab1aa Merge #9689: CMYK: the test reference keeps a fully covered type pixel's ink exact (#9688) 2026-10-27 17:44:31 +00:00
aiongg 0bc6abc783 Merge #9680: Plug-ins: refuse a code section with no functions but many bytes instead of panicking (#9679) 2026-10-27 17:44:30 +00:00
aiongg c1f3219dfb Merge #9445: Automation: refuse to replace a non-image file in the write root (#9439) 2026-10-27 17:44:26 +00:00
aiongg c284e78c40 Merge #9425: Automation: refuse every Windows device name in request paths (#9424) 2026-10-27 17:44:25 +00:00
aiongg 0e3a6f7e8d Merge #9421: XML: deeply nested ORA, KRA, Camera Raw XMP, .kys and layer XMP are an error, not a crash (#9419) 2026-10-27 17:44:23 +00:00
aiongg 3e0ec5004c Merge #9398: SVG: an embedded data-URL SVG gets the nesting-depth check (#9397) 2026-10-27 17:44:19 +00:00
aiongg 9547aec94a Merge #9395: Color panel: the Color Wheel fits the panel at its default height (#9394) 2026-10-27 17:44:18 +00:00
aiongg d01f2de508 Merge #9393: Preferences: the Generator checkbox reads Enable Generator, as in the reference application (#9392) 2026-10-27 17:44:16 +00:00
aiongg 2f6392574d Merge #9385: Actions: save and read the Lab Lightness channel as Lght (#9384) 2026-10-27 17:44:15 +00:00
aiongg b57b64207e Merge #9340: Tests: the effect-map deadlock watchdog waits 120 s for each render, not for all 101 2026-10-27 17:44:13 +00:00
aiongg ae661394b2 Merge #9036: Autosave: replace a recovery sidecar in one step, so a listing never misses or doubles it (#9034) 2026-10-27 17:44:12 +00:00
aiongg a78414a720 Merge #7412: Print: list printers and spool from one thread at a time 2026-10-27 17:44:09 +00:00
aiongg fa86237e63 Merge #7154: Paste: a drawing copied as SVG markup pastes its pixels 2026-10-27 17:44:07 +00:00