Commit Graph
11425 Commits
Author SHA1 Message Date
Nikolai Nyegaard a049906e43 i18n: Norwegian Bokmål catalog (nb)
- nb.tsv covers every enforced key: menus, tl! literals, blend modes, brush sections, font weights, camera data and the generated preference labels (cargo xtask i18n-coverage: 1905/1905)
- Registered with the one|other plural rule; nb-NO, the macrolanguage no and Nynorsk nn-NO locales resolve to it
- License, attribution and localization docs updated
2026-10-28 12:34:46 +01:00
Khawar Zamman Wani a79057f6e4 perf(segment): solve GrabCut and the band re-cut with Boykov-Kolmogorov
GrabCut's colour-model grids have few terminal links and short paths, where
BK beats the push/relabel solver the default dispatch picks for graphs of
4096+ nodes. Quick Selection keeps push/relabel.

24 MP synthetic, release, median of 3: Select Subject 480 -> 207 ms,
Object Selection 337 -> 140 ms, Quick Selection unchanged. IoU unchanged.
2026-10-28 17:01:21 +05:30
Daniel 480fc6186b Merge current PhotoCraft main and preserve font-free Wayland frame feature
Reapply Linux Adwaita no-title winit feature and its lockfile,
keep integrated title bar as default, and port compatible tests/docs.
Preserve upstream's preferences UI refactor rather than restoring
its removed prefs_ui.rs file.
2026-10-28 11:35:18 +01:00
Khawar Zamman Wani 4e7dc407f8 Import texture_quad where transform_tool/begin.rs uses it 2026-10-28 15:58:41 +05:30
Brennan StehlingandClaude Opus 5.5 e2855fddd7 test: P81/P82 count only timed refreshes; mask undo must upload a partial rect (#9329)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-28 02:04:54 -07:00
dotCooCoo d9e30037f8 Hand tool: a pan under an open dialog scrolls the other shown views too
With Scroll All Windows on, or Shift held, a Hand, Space or middle-button
pan under an open dialog now moves the other shown documents to the same
relative location, as a pan on the free canvas does.
2026-10-28 01:43:57 -07:00
Claude 1505c42605 fix(ui): address review notes on the shape Fill/Stroke popover
- The Stroke Color Picker on a shape whose stroke is off (none or 0 px)
  previews the stroke its OK turns on, at the enabled width, even for the
  colour it opened on (CodeRabbit).
- No Color's diagonal uses the theme's danger token, not a fixed red.
- docs/ui-parity.md: the history entry notes Recently Used Colors is a new
  preference, so 12 of 182 do nothing (matching the row).
- The Fill/Stroke swatches clip their checker to the rounded corners, so
  dark themes no longer show white specks there (#8741).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TYsCL5E2GM6hUabP9dmYAv
2026-10-28 08:23:00 +00:00
SimoneRecchiaandClaude Opus 5.5 1920ca66b8 Contributors: add my own people.toml entry (Simone Recchia)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TYsCL5E2GM6hUabP9dmYAv
2026-10-28 08:16:17 +00:00
azizr12 8a64ae4049 Delete mod.rs 2026-10-28 08:02:07 +00:00
azizr12 e5565bc815 ar 2175/2175 2026-10-28 08:00:59 +00:00
azizr12 350b6904ec Update i18n.rs 2026-10-28 07:57:57 +00:00
Claude 30abc52781 Merge storytold/photocraft main into the Fill/Stroke popover branch
Upstream's strict-Clippy refactor removed glob imports and split the
Content-Aware Fill properties into caf_props_panel: the swatch title moved
there, and the frame loop calls crate::color_picker_ui::widget_tick.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TYsCL5E2GM6hUabP9dmYAv
2026-10-28 07:55:52 +00:00
azizr12 d825abbd75 Merge branch 'storytold:main' into main 2026-10-28 07:44:07 +00:00
SvenCarstensen e7acfbfc52 Merge branch 'main' into codex/guide-position-units 2026-10-28 08:40:49 +01:00
azizr12 36c5e7207c fix 2026-10-28 07:34:49 +00:00
Ikki Nishihara 1dc98f80f6 docs(control): associate brush mode gesture with ui.pointer
Signed-off-by: Ikki Nishihara <223786623+haranishi@users.noreply.github.com>
2026-10-28 16:24:15 +09:00
Ikki Nishihara ca17e9b627 Merge current main and preserve brush mode picker behavior
Signed-off-by: Ikki Nishihara <223786623+haranishi@users.noreply.github.com>
2026-10-28 15:55:25 +09:00
Brennan StehlingandClaude Opus 5.5 c855685c7f test: cover group and clip-base effect damage, and mask undo coverage (#9329)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:09:58 -07:00
Brennan StehlingandClaude Opus 5.5 2119158a5e perf: a pixel change damages only the tiles that changed; command rects become checked hints (#9329)
step_damage narrows a layer whose only change is in its surfaces (pixels, mask, type,
smart-object and fill caches) to the bounding box of the tiles that differ: a merge walk of
the two tile maps, pointer compares only. A mask's tiles grow by its feather, all of them by
the layer's effects and the effects of the groups around it, never past the layer's whole
extents. A frame-spanning effect whose frame moved keeps the whole extents (#4053). Undo,
redo and History jumps get it for free: undoing a 60 px dab on a full-canvas layer redraws
its tiles, not the canvas, and so does a fill or filter on a small selection.

The painting commands' own damage rects go through one door, Session::hint_damage, which
intersects them with the edit's damage. Debug and test builds count a hint that misses a
changed tile in Session::damage_misses and log it; nothing panics. refresh_type_layers reports
step_damage instead of None.

Deleted: note_damage and layers_damage (identical to step_damage after layer.setProps and
layer.translate), note_inert_insert (step_damage already steps over inert layers, #1771),
and the engine's siblings_of they used.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:09:58 -07:00
Kaedo17 8828808882 Merge storytold/main into fix/zoom-tool-context-menu
Resolves the canvas.rs conflict by adopting the handle_primary_canvas_input
refactor and porting the menu-dismissal gates into it: the buttons starve,
the Crop press gate, the capture-press gate, the live-paint press gate, the
stroke started/moves/stopped/press-release gates, the zoom-hold on_canvas
gate, the release-click consume in the click handler, and the release
clear below the click handling. menu_dismiss_pass is computed once in
canvas_view and passed through CanvasToolInput.
2026-10-28 14:08:51 +08:00
Brennan StehlingandClaude Opus 5.5 a9c26551f1 perf: add P81/P82 redraw-area rows on full-canvas layers (#9329)
Track-only rows that check they hit the whole-document-redraw path and
print the refreshed pixel count: undo of a brush dab on a 16-bit
15000x10000 full-canvas layer (reps capped at 5) and a fill of a 2 %
selection on a 24 MP full-canvas layer.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:08:30 -07:00
Brennan StehlingandClaude Opus 5.5 fc6d8b0ec2 Perf: a frame counts each command once, and every frame closes its stage record (#9328)
Only the outermost run_command writes the frame's command stage, so a nested
run (file.save -> layer.smartObjects.saveContents, actions.play -> its view
steps) isn't counted twice. ui_frame's UI moves into ui_body and finish_frame
runs after it on every path, including the screen picker's wait modal; the
pass before fonts are ready closes it too.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:08:27 -07:00
Brennan StehlingandClaude Opus 5.5 ce8f3e719e Docs: perf.slowFrames, and the stroke trace reads the shared frame stages (#9328)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:08:06 -07:00
Brennan StehlingandClaude Opus 5.5 b1ffb9a423 Control: perf lists the last slow frames and their stages as slowFrames (#9328)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:07:54 -07:00
Brennan StehlingandClaude Opus 5.5 5c94fb2074 Perf: every frame records its stages, slow ones are kept and logged; the stroke trace reads the same record (#9328)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:07:39 -07:00
Brennan Stehling 00522c852e Perf: P80, app frame time for a full CPU refresh of a 24 MP document (#9328)
Track-only row, the slow-frame recorder's worst case. A 24 MP photo plus
three full-canvas blended copies (Multiply, Screen, Overlay); each sample
toggles the top copy and times one harness.step(), so every frame
recomposites all 24 MP on the CPU (the photo's tiles are never uniform,
which keeps the reduced render's one-colour shortcut out of the way).
The row errors unless each frame recorded a CPU refresh covering at least
95 % of the canvas, so it can't silently take a fast path. 10 samples.
2026-10-27 23:06:56 -07:00
dotCooCoo ddd11aaa9a Format: a full-size composite that fails is left out, and pcraftFullComposite takes only booleans
- The PNG encoder gets a fallibly reserved copy of the composite's pixels instead of a
  clone, and a full-size composite that cannot be copied or encoded is left out of the
  ZIP or directory bundle and out of its manifest; the save goes on without it.
- The ZIP size limit for keeping the full-size composite counts the central directory
  and end record as well as the entries.
- `pcraftFullComposite` that is not true, false or null is a bad parameter of
  `file.saveACopy`, the other engine saves and the automation `doc.save`.
- MCP `doc_save` in bridge mode refuses `pcraftFullComposite: false` as well as `true`.
  The app's `app.save` does not take the option.
2026-10-27 22:02:30 -07:00
aiongg 1f7fc0f536 Merge pull request #6463 from osaidahmed/split-filter-adjust-crop-fx-builders
refactor: split oversized filter, adjustment, crop and effect builders
2026-10-28 01:01:25 -04:00
jacabusandClaude Sonnet 4.6 d719adb48e ARTCRAFT-PC-2026-001: gradient layer import — midpoint passthrough (Fix 1)
Add gradient_midpoints() which reads Mdpn (0–100) from each color stop
descriptor, converts to the engine's 0..1 range, and returns one value
per segment (n-1 for n stops; the last stop's Mdpn is irrelevant). Returns
None when all segments are at the default (0.5) so the key is omitted.

gradient_layer_set_params now inserts "midpoints" when any segment differs
from the default, passing it to gradient.fill.set which accepts a flat
float array at that key.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-10-28 16:00:10 +11:00
jacabusandClaude Sonnet 4.6 4afbfef2ae ARTCRAFT-PC-2026-001: gradient layer import — one-stop guard and explicit defaults
Fix 2: gradient_color_stops now returns None when fewer than 2 color stops
are present, preventing a partial broken gradient layer from being created
from a malformed descriptor.

Fix 3: gradient_layer_set_params now always writes explicit values for
reverse (true/false), dither (true/false), scale (value or 100.0), offset
([h, v] always, defaulting to [0, 0]), and transparency stops (always
included, even if all opacities are 100).

Fix 1 (midpoints) not applied: gradient.fill.set does not accept midpoints
as a third element on individual stops. It accepts them via a separate
"midpoints" array parameter — that conversion is deferred.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-10-28 15:56:22 +11:00
Kaedo17 2aa62a81d2 fix: gate the Hand and flick pans on the menu-dismissal press too
The flick-pan frame and the Hand pan read response.dragged() directly,
before menu_dismiss_press is computed, and live in the hand_pan branch
where the zeroed buttons never arrive: with the menu dismissed and the
dismissing button still down, holding Space (or the selected Hand tool)
and dragging panned the view. The gate is now computed up front and
guards both pan sites (CodeRabbit, #9841).

Regression test a_held_menu_dismissal_press_cannot_pan_the_view fails
on the previous commit and passes now.
2026-10-28 12:39:39 +08:00
aiongg 2b1c6b93c3 Merge main into split-filter-adjust-crop-fx-builders
crop_ui.rs moved to tools/; the PR's builders replace main's Clippy extractions of the same code; #6723's Color Lookup save carried into the moved encoder.
2026-10-28 04:22:40 +00:00
Kaedo17 78b1dfe448 fix: consume the dismissal gesture through its release and block the zoom hold
Addresses the two remaining CodeRabbit findings on PR #9841:

- The dismissal flag is cleared below the click handling, so a later-frame
  release over the canvas is consumed by the flag check first (clearing it
  before let that release zoom). canvas_tool_menu::show does not arm the flag
  when the frame already contains the release, so a fast same-frame click
  cannot eat the next ordinary click.
- The blocked gesture now persists in canvas_tool_menu_dismissed until its
  release instead of being re-derived from the open menu each frame, so a held
  dismissal press stays blocked after the menu closes. Navigation is blocked
  too: the animated zoom hold cannot arm on it, and zoom drags, Rotate View
  and other button-driven gestures are starved.

Regression tests (fail on the previous commit, pass now):
- dismissing_the_view_menu_consumes_the_whole_gesture
- a_held_menu_dismissal_press_never_arms_the_zoom_hold
2026-10-28 12:02:46 +08:00
aiongg d453c7d12b Merge pull request #9564 from brennanMKE/perf/7494-baseline-guard
xtask perf: a baseline knows how trustworthy it is (#7494)
2026-10-27 23:56:45 -04:00
Khawar Zamman Wani 4af5b3a669 Split Select and Mask's workspace closure into paint/cursor/input helpers (cognitive complexity) 2026-10-28 09:26:13 +05:30
Khawar Zamman Wani b18274f6d7 Fix imports lost in the vector_ui module split; Esc handler returns bool 2026-10-28 09:25:56 +05:30
Khawar Zamman Wani a2364b20d0 Fix imports lost when transform_tool was split into a module tree 2026-10-28 09:25:49 +05:30
Khawar Zamman Wani 8b835a103c Merge origin/main into pen-path-operations 2026-10-28 09:22:55 +05:30
Khawar Zamman Wani e729ead4b2 Merge origin/main into fix/6501-multi-layer-free-transform 2026-10-28 09:22:55 +05:30
Khawar Zamman Wani 0ce7991aaa Merge origin/main into fix/8169-huge-tiff-open 2026-10-28 09:22:54 +05:30
Khawar Zamman Wani 4e22d214dc Merge origin/main into select-mask-workspace 2026-10-28 09:22:54 +05:30
Khawar Zamman Wani eccc20d1b2 Merge origin/main into perf/cropped-selection-blurs 2026-10-28 09:22:52 +05:30
aiongg 54f7f2c374 Merge pull request #9566 from brennanMKE/perf/9328-fallback-reason
Render path: one place records why a view left the GPU (#9328)
2026-10-27 23:52:38 -04:00
dotCooCoo 3c0e4708da Merge main into feat/hand-scroll-all-windows 2026-10-27 20:13:58 -07:00
aiongg b4e69af424 Merge main into perf/9328-fallback-reason 2026-10-28 03:00:01 +00:00
aiongg af0d8a5cc4 Merge main into perf/7494-baseline-guard 2026-10-28 02:56:50 +00:00
Dylan M. Taylor d5be9b8aef Merge pull request #9770 from dylanmtaylor/sonar/enforce-clippy-standards
Enforce Rust coding standards via Clippy
2026-10-27 22:55:30 -04:00
Khawar Zamman Wani fe6b95f172 fix(ci): compare padded mixer benchmark rows 2026-10-28 08:21:22 +05:30
Khawar Zamman Wani 5f03f1424b perf(paint): skip dry mixer canvas sampling 2026-10-28 08:09:49 +05:30
aiongg a9e6f73ac5 Merge remote-tracking branch 'upstream/main' into HEAD 2026-10-28 02:31:52 +00:00