Every mapped event was checked against the reference application: the corpus sets'
5 296 recorded steps and factory descriptors went through Load and Save Actions and were
compared with the original, and the forms PhotoCraft writes were played there. The new
section lists the settings mapped events still lose (transform reference point, show
only this layer, group names, clipping and colour labels on Make, shape layers, layer
via copy options, load selection from another layer, Background by property, Close that
asks, Lab Photo Filter colours) and the settings the commands do not have yet.
The supported table showed 15 direct adjustment events with shifted columns.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The dialog grows to fit its contents, and the preview panes were sized in
fractional points, so they came out a fraction of a pixel wider than the room
given. Every repaint (any pointer move) widened the dialog a little and the
fitted zoom followed. The preview area and pane sizes are now floored to whole
physical pixels.
The new test moves the pointer over the preview at 5 scales x 3 screens x 3
views: 15 of the 45 cases drifted before the fix, none after.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Bound PSD import pixel storage before decoding
* Include ZIP inflater workspace in PSD preflight
* PSD import: budget unknown-mode layers, stop after a fatal layer error, keep best-effort for non-allocation limits (#8593 review)
A guide on the same device pixel as a selection edge hid it, at some zoom
levels and not others: the ants were painted in paint_canvas and the guides
after them in paint_primary_overlays. The ants are still traced in
paint_canvas from the frame's snapshot, but returned as shapes and painted
right after the grid and guides; a secondary view paints them where it did.
Free Transform's carried ants come from transform_tool::selection_ants
(was draw_selection), which returns shapes instead of painting.
Test: canvas::guide_ants_tests checks the paint order at three display
scales and nine zoom levels; it fails without the fix.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lab's three channels and Gray's one: in-range digits select by position,
keys past the list select nothing, are consumed and keep the earlier pick.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Color picker, gradient map and font list labels; with them the catalog
covers every key `cargo xtask i18n-coverage` measures, as
`complete_menus: true` claims.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Color picker, gradient map and font list labels; with them the catalog
covers every key `cargo xtask i18n-coverage` measures, as
`complete_menus: true` claims.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Color picker, gradient map and font list labels; with them the catalog
covers every key `cargo xtask i18n-coverage` measures, as
`complete_menus: true` claims.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The shared Swatches / Gradients / Patterns footer drew New Group as
`folder-plus` and New as `plus` at 24 pt, while the Layers footer uses
`folder` and `square-plus` at 26 pt. Both footers now take shared
`icons::FOOTER_*` constants, so they can't drift apart again; a test
checks the glyphs are bundled (a misspelt name draws the fallback square).
The footer grows from 28 to 30 pt, still under the 32 pt first-frame
guess; the #4790 footer-fit test passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The playback test counted three steps run, which a step that succeeds
without changing anything also passes (Select Sky reports "changed":
false when it finds no sky). Each step now plays on its own over a smooth
blue sky above textured ground, with a textured disc: Focus Area must
select the ground and not the sky, Select Sky the sky and not the ground,
and Remove Background must mask the layer.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A descriptor may hold the same key more than once. `only_keys` admitted
both and `setting` read the first, so a Smart Sharpen step with two `Amnt`
(or `Rds` and `Rds `) played the first and saved back one. Oil Paint and
Select Sky read through the same `setting`. It now treats a key recorded
more than once, compared without its space padding, as a value it can't
take, so the step stays a Photoshop step (as #10629 does for Distort).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- free_group's brush check builds the set of group names once instead of
scanning every preset for each numbered candidate.
- reimporting_a_gradient_file_asks_before_touching_its_group covers the
gradient branch of the prompt: no prompt for a new group, Cancel imports
nothing, Import as New Group adds "Fire (2)", Replace swaps "Fire" alone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
filter.stylize.oilPaint takes a stylization and scale of 0.1..10 and a
cleanliness, bristle detail and shine of 0..10, and clamps anything else
when it plays. The importer accepted any finite value, so such a step
played clamped and saved back unchanged. It now keeps the Photoshop step,
and export refuses those values instead of writing them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After a group-name clash the status read "Imported 2 brushes from Kit (2)",
naming the destination group as if it were the file. Keep the translated
"… from {file}" message and add the group only when it differs:
"Imported 2 brushes from Kit into “Kit (2)”".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
filter.other.custom plays a scale of 1..9999, an offset of -9999..9999
and kernel cells of -999..999, and clamps anything else when it plays,
so Scl 0 played as 1 and saved back as 0. Such a step now keeps the
Photoshop step, and export refuses those values. The matrix length is
checked before its cells are collected.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Importing an .abr or .grd whose name matched an existing group silently
deleted that group's user presets (edited or moved-in ones included); the
preset libraries are outside document history, so it could not be undone.
- brush.presets.importAbr / gradient.presets.importGrd: `replace` now
defaults to false; a taken group name imports beside it as "Kit (2)",
"Kit (3)"…, and the result's `group` names the one it landed in.
- UI: when the group already holds the user's presets, a prompt asks
Import as New Group (default) / Replace (can't be undone) / Cancel.
Agents drive it with ui.dialog.set {"choice":"replace"} / confirm / cancel.
- The status bar names the group the file landed in.
Fixes#10640
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
filter.sharpen.smartSharpen takes an amount of 1..500 % and a radius of
0.1..64 px and rejects anything else. The importer accepted any finite
value, so such a step mapped and then failed when it played. It now keeps
the Photoshop step, and export refuses those values instead of writing
them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With no action and no set selected, New Action makes an action in no
set even when sets, empty ones included, exist. Closing the Actions
panel (Window › Actions) and opening it again keeps the selected set and
the empty New Set sets, and New Action still records into the selected
one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The suggested file was "{set}.atn" with the set's name as it is, so a
set named with `/`, `\` or `:` suggested a path in another folder (or
an invalid name). Those characters, and the others a file name can't
hold, become `_` in the suggestion, as Keyboard Shortcuts' Save does for
a set name; the .atn keeps the set's own name.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An empty set made with New Set lasted only the session, and Save
Actions… on it failed with "no actions in a set named …". Photoshop
saves an empty set to the .atn, and the ATN writer handles a set with no
actions, so `actions.save` now writes it; loading such a file brings it
back as an empty folder (once, however often it is loaded). Saving every
action with none is still refused, as is a set that doesn't exist.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A set name with surrounding spaces comes from a Photoshop .atn (load
keeps the file's name) or an older actions.json, and New Action records
into such a set under that exact name. `actions.save` trimmed the name
it was given and then compared exactly, so Save Actions… on that set
failed with "no actions in a set named …". It now takes an existing
set's exact name, as `actions.record` does, and trims any other.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
While the brush is resized its circle stays at the drag's start at the new
size and the Diameter/Hardness readout follows the pointer; after the drag
the circle follows the pointer again and the readout is gone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Esc during an Alt+right-drag or Control+Alt-drag resize closed the whole
workspace. As in Photoshop it now puts the size and hardness back to where
the drag began and ends only the resize; egui drops the drag on Esc, so the
rest of it does nothing. Esc with Control+Alt still held (the macOS
gesture) reaches it too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review follow-up. show_frame ends the hidden state and makes the
default frame at once, so:
- picking the Crop tool, even while it is picked, shows the frame;
- a ratio or size chosen after a commit fits a frame, so ✓ crops;
- a press records the default frame as its box Undo step, so Undo
then Redo of the first crop after a commit keeps the drawn frame.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A Neon Glow step recorded without `Clr ` glows in Photoshop's default
colour, (0, 0, 255) per the event reference, but loaded without
`glowColor` and so played PhotoCraft's own default (0, 158, 255). It now
loads with `glowColor` "#0000ff", which saves back as that RGBC colour. A
PhotoCraft step without `glowColor` still saves the colour it plays with.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Match Color's Luminance and Color Intensity take 1..200 and Fade 0..100. The
event reference records no clamp for them, so a recorded value outside those
ranges is kept as a Photoshop step instead of loading as a step the command
plays clamped. Export refuses such a value instead of writing it unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After a committed crop the Crop tool drew a new default frame with
corner handles around the cropped canvas at once, so the crop looked
like it never applied. A successful commit now hides the frame for the
cropped document until a press on the canvas, re-picking the tool, or
another document (or size of this one), keyed by document id and size
as in #10396.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Photoshop clamps a Trap width above 32767 px, but its minimum wasn't measured,
so a recorded width below the command's 1 px is kept as a Photoshop step
instead of loading as a Trap that rounds to 0 px and does nothing. Export
refuses such a width as it does one above 32767 px.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review follow-up: W and H share one formatter (wh_readout) for the
selection and the crop frame; tests cover the ratio's rounding and
degenerate frames, W and H in each ruler unit, and W and H after the
crop is cancelled, committed or the tool is left.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>