Commit Graph
11425 Commits
Author SHA1 Message Date
David MannandClaude Opus 5.5 a23b30edd2 Docs (atn): known gaps in mapped events; fix the adjustment rows of the supported table
Every mapped event was checked against the reference application: the corpus sets'
5 296 recorded steps and factory descriptors went through Load and Save Actions and were
compared with the original, and the forms PhotoCraft writes were played there. The new
section lists the settings mapped events still lose (transform reference point, show
only this layer, group names, clipping and colour labels on Make, shape layers, layer
via copy options, load selection from another layer, Background by property, Close that
asks, Lab Photo Filter colours) and the settings the commands do not have yet.

The supported table showed 15 direct adjustment events with shifted columns.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 13:49:32 +01:00
RickiNanoandClaude Opus 5.5 0f85d429d7 Save for Web: keep its size and zoom while the pointer moves (#10675)
The dialog grows to fit its contents, and the preview panes were sized in
fractional points, so they came out a fraction of a pixel wider than the room
given. Every repaint (any pointer move) widened the dialog a little and the
fitted zoom followed. The preview area and pane sizes are now floored to whole
physical pixels.

The new test moves the pointer over the preview at 5 scales x 3 screens x 3
views: 15 of the 45 cases drifted before the fix, none after.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 12:49:27 +01:00
Khawar Zamman Wani 97a83f074f Bound PSD layer and mask import memory before decoding (#10503)
* Bound PSD import pixel storage before decoding

* Include ZIP inflater workspace in PSD preflight

* PSD import: budget unknown-mode layers, stop after a fatal layer error, keep best-effort for non-allocation limits (#8593 review)
2026-11-01 12:33:09 +01:00
RickiNanoandClaude Opus 5.5 44f356c6de Paint the marching ants over the guides (#10671)
A guide on the same device pixel as a selection edge hid it, at some zoom
levels and not others: the ants were painted in paint_canvas and the guides
after them in paint_primary_overlays. The ants are still traced in
paint_canvas from the frame's snapshot, but returned as shapes and painted
right after the grid and guides; a secondary view paints them where it did.

Free Transform's carried ants come from transform_tool::selection_ants
(was draw_selection), which returns shapes instead of painting.

Test: canvas::guide_ants_tests checks the paint order at three display
scales and nine zoom levels; it fails without the fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 12:27:19 +01:00
Hector VillarrealandClaude Opus 5.5 8988b6bfd0 Actions: play Remove Background with no selection in the playback test (CodeRabbit review on tests.rs:3491)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 05:25:26 -06:00
qvest-sselsandClaude Opus 5.5 5714d2a802 test(curves): Alt+digit channel keys in Lab and Gray
Lab's three channels and Gray's one: in-range digits select by position,
keys past the list select nothing, are consumed and keep the earlier pick.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 12:10:29 +01:00
qvest-sselsandClaude Opus 5.5 48dc361afa test(crop): menu Cancel hides the frame like Esc; leaving the tool and undo after Esc (review)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 11:52:17 +01:00
tronicumandClaude Opus 5.5 7fb5ad5857 i18n(ro): table test for the Romanian plural rule
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 11:46:05 +01:00
tronicumandClaude Opus 5.5 8ab4478b1e i18n(ro): translate the four strings main added recently
Color picker, gradient map and font list labels; with them the catalog
covers every key `cargo xtask i18n-coverage` measures, as
`complete_menus: true` claims.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 11:42:30 +01:00
tronicumandClaude Opus 5.5 3bd1826226 i18n(ur): translate the four strings main added recently
Color picker, gradient map and font list labels; with them the catalog
covers every key `cargo xtask i18n-coverage` measures, as
`complete_menus: true` claims.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 11:42:29 +01:00
tronicumandClaude Opus 5.5 ff680ee437 i18n(he): translate the four strings main added recently
Color picker, gradient map and font list labels; with them the catalog
covers every key `cargo xtask i18n-coverage` measures, as
`complete_menus: true` claims.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 11:42:29 +01:00
vngocvan 0a93d46ac1 fix(ui): clear custom crop ratio fields explicitly 2026-11-01 17:21:53 +07:00
RickiNanoandClaude Opus 5.5 ef36604c3c Preset panel footers use the Layers footer's glyphs and size (#10656)
The shared Swatches / Gradients / Patterns footer drew New Group as
`folder-plus` and New as `plus` at 24 pt, while the Layers footer uses
`folder` and `square-plus` at 26 pt. Both footers now take shared
`icons::FOOTER_*` constants, so they can't drift apart again; a test
checks the glyphs are bundled (a misspelt name draws the fallback square).

The footer grows from 28 to 30 pt, still under the 32 pt first-frame
guess; the #4790 footer-fit test passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 11:09:29 +01:00
Hector VillarrealandClaude Opus 5.5 f2e7ced6c2 Actions: check the Remove Background mask's values in the playback test (CodeRabbit review on tests.rs:3489)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 03:47:25 -06:00
yoriswind de858167e9 Make inherited Batch action effect observable in regression 2026-11-01 01:40:43 -08:00
Hector VillarrealandClaude Opus 5.5 df7e673309 Actions: check that Focus Area, Select Sky and Remove Background steps do their work (CodeRabbit review on tests.rs:3433)
The playback test counted three steps run, which a step that succeeds
without changing anything also passes (Select Sky reports "changed":
false when it finds no sky). Each step now plays on its own over a smooth
blue sky above textured ground, with a textured disc: Focus Area must
select the ground and not the sky, Select Sky the sky and not the ground,
and Remove Background must mask the layer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 03:23:25 -06:00
Hector VillarrealandClaude Opus 5.5 e1fb19f4d0 Actions: keep a Smart Sharpen, Oil Paint or Select Sky step that records a key twice (CodeRabbit review on steps_image.rs:629)
A descriptor may hold the same key more than once. `only_keys` admitted
both and `setting` read the first, so a Smart Sharpen step with two `Amnt`
(or `Rds` and `Rds `) played the first and saved back one. Oil Paint and
Select Sky read through the same `setting`. It now treats a key recorded
more than once, compared without its space padding, as a value it can't
take, so the step stays a Photoshop step (as #10629 does for Distort).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 03:19:57 -06:00
RickiNanoandClaude Opus 5.5 586563fc2b Address review: one group-name set for clashes, test the .grd prompt (#10640)
- free_group's brush check builds the set of group names once instead of
  scanning every preset for each numbered candidate.
- reimporting_a_gradient_file_asks_before_touching_its_group covers the
  gradient branch of the prompt: no prompt for a new group, Cancel imports
  nothing, Import as New Group adds "Fire (2)", Replace swaps "Fire" alone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 10:18:24 +01:00
yoriswind a5636fa3e7 Preserve embedded Batch action scopes in droplets 2026-11-01 01:14:25 -08:00
Hector VillarrealandClaude Opus 5.5 d7bedfdd97 Actions: keep an Oil Paint step outside the command's ranges (FredApps review)
filter.stylize.oilPaint takes a stylization and scale of 0.1..10 and a
cleanliness, bristle detail and shine of 0..10, and clamps anything else
when it plays. The importer accepted any finite value, so such a step
played clamped and saved back unchanged. It now keeps the Photoshop step,
and export refuses those values instead of writing them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 03:08:49 -06:00
RickiNanoandClaude Opus 5.5 2ab2ab2f0d Name the source file in the preset import status (#10640)
After a group-name clash the status read "Imported 2 brushes from Kit (2)",
naming the destination group as if it were the file. Keep the translated
"… from {file}" message and add the group only when it differs:
"Imported 2 brushes from Kit into “Kit (2)”".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 10:05:41 +01:00
Hector VillarrealandClaude Opus 5.5 72eb3a0451 Actions: test every Filter Gallery effect's defaults round trip and match the command's schema (FredApps review)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 02:59:32 -06:00
Hector VillarrealandClaude Opus 5.5 4ed3f5b591 Actions: keep a Custom step outside the command's scale, offset or cell range (FredApps review)
filter.other.custom plays a scale of 1..9999, an offset of -9999..9999
and kernel cells of -999..999, and clamps anything else when it plays,
so Scl 0 played as 1 and saved back as 0. Such a step now keeps the
Photoshop step, and export refuses those values. The matrix length is
checked before its cells are collected.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 02:54:18 -06:00
RickiNanoandClaude Opus 5.5 122e55a4a0 Ask before re-importing a brush or gradient file over its group (#10640)
Importing an .abr or .grd whose name matched an existing group silently
deleted that group's user presets (edited or moved-in ones included); the
preset libraries are outside document history, so it could not be undone.

- brush.presets.importAbr / gradient.presets.importGrd: `replace` now
  defaults to false; a taken group name imports beside it as "Kit (2)",
  "Kit (3)"…, and the result's `group` names the one it landed in.
- UI: when the group already holds the user's presets, a prompt asks
  Import as New Group (default) / Replace (can't be undone) / Cancel.
  Agents drive it with ui.dialog.set {"choice":"replace"} / confirm / cancel.
- The status bar names the group the file landed in.

Fixes #10640

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 09:49:33 +01:00
Hector VillarrealandClaude Opus 5.5 b774a20b23 Actions: test that a Match Color step naming a source is kept (FredApps review)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 02:48:39 -06:00
Hector VillarrealandClaude Opus 5.5 244082fb2c Actions: test that Wave's generators above 999 load clamped (FredApps review)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 02:42:54 -06:00
Hector VillarrealandClaude Opus 5.5 05bbed220d Actions: play mapped Focus Area, Select Sky and Remove Background steps (FredApps review)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 02:37:44 -06:00
Hector VillarrealandClaude Opus 5.5 cfc4c19eb8 Actions: keep a Smart Sharpen step outside the command's amount and radius limits (FredApps review)
filter.sharpen.smartSharpen takes an amount of 1..500 % and a radius of
0.1..64 px and rejects anything else. The importer accepted any finite
value, so such a step mapped and then failed when it played. It now keeps
the Photoshop step, and export refuses those values instead of writing
them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 02:35:44 -06:00
Taxperia 081dd26d57 i18n: limit language contribution to Azerbaijani 2026-11-01 11:27:12 +03:00
yoriswind da2c9a0a5d Retain nested Batch results and capture Batch action dependencies 2026-11-01 01:20:13 -07:00
yoriswind 1f486f73e8 Document nested Batch result retention 2026-11-01 00:22:02 -07:00
yoriswind 27d8b91759 Compare saved Batch output paths by path identity 2026-11-01 00:16:02 -07:00
Hector VillarrealandClaude Opus 5.5 b67fb07557 Actions panel: Save Actions… suggests a Windows-safe name for device and control-character sets (CodeRabbit review on crates/ui-egui/src/panels/actions/tests.rs:883)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 01:07:16 -06:00
Hector VillarrealandClaude Opus 5.5 7e00310493 Actions panel: Save Set… on an empty set folder opens the save dialog (CodeRabbit review on crates/ui-egui/src/panels/actions.rs:945)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 01:07:16 -06:00
Hector VillarrealandClaude Opus 5.5 36404b7843 Actions panel: Save Actions… is enabled for a selected empty set (CodeRabbit review on crates/engine/src/cmd/atn_cmds/files.rs:112)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 01:07:16 -06:00
Hector VillarrealandClaude Opus 5.5 b544021d49 Actions: recording into an empty loaded set keeps its exact name (CodeRabbit review on crates/engine/src/cmd/atn_cmds/files.rs:65)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 00:59:36 -06:00
yoriswind fe1d1c5d70 Keep nested Batch outcomes in failed action results 2026-10-31 23:45:42 -07:00
Hector VillarrealandClaude Opus 5.5 8a5ce6fa24 Actions panel: test New Action with no set and reopening the panel (FredApps review)
With no action and no set selected, New Action makes an action in no
set even when sets, empty ones included, exist. Closing the Actions
panel (Window › Actions) and opening it again keeps the selected set and
the empty New Set sets, and New Action still records into the selected
one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 00:34:54 -06:00
Hector VillarrealandClaude Opus 5.5 740ebe5d8c Actions panel: Save Actions… suggests a file name without path characters (FredApps review)
The suggested file was "{set}.atn" with the set's name as it is, so a
set named with `/`, `\` or `:` suggested a path in another folder (or
an invalid name). Those characters, and the others a file name can't
hold, become `_` in the suggestion, as Keyboard Shortcuts' Save does for
a set name; the .atn keeps the set's own name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 00:32:48 -06:00
Hector VillarrealandClaude Opus 5.5 63c541342e Actions: Save Actions… writes an empty New Set set (FredApps review)
An empty set made with New Set lasted only the session, and Save
Actions… on it failed with "no actions in a set named …". Photoshop
saves an empty set to the .atn, and the ATN writer handles a set with no
actions, so `actions.save` now writes it; loading such a file brings it
back as an empty folder (once, however often it is loaded). Saving every
action with none is still refused, as is a set that doesn't exist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 00:29:37 -06:00
Hector VillarrealandClaude Opus 5.5 d244f11a85 Actions: Save Actions… finds a set by its exact name (FredApps review)
A set name with surrounding spaces comes from a Photoshop .atn (load
keeps the file's name) or an older actions.json, and New Action records
into such a set under that exact name. `actions.save` trimmed the name
it was given and then compared exactly, so Save Actions… on that set
failed with "no actions in a set named …". It now takes an existing
set's exact name, as `actions.record` does, and trims any other.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 00:28:04 -06:00
yoriswind 036d37f90d Clarify current and historical ATN documentation counts 2026-10-31 23:07:10 -07:00
Hector VillarrealandClaude Opus 5.5 a78c313fb0 Select and Mask: test the brush resize circle and readout (FredApps review)
While the brush is resized its circle stays at the drag's start at the new
size and the Diameter/Hardness readout follows the pointer; after the drag
the circle follows the pointer again and the readout is gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 00:07:02 -06:00
Hector VillarrealandClaude Opus 5.5 d17d8950a8 Select and Mask: Esc mid brush resize restores the brush and keeps the workspace (FredApps review)
Esc during an Alt+right-drag or Control+Alt-drag resize closed the whole
workspace. As in Photoshop it now puts the size and hardness back to where
the drag began and ends only the resize; egui drops the drag on Esc, so the
rest of it does nothing. Esc with Control+Alt still held (the macOS
gesture) reaches it too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 00:04:29 -06:00
D-monizedandClaude Opus 5.5 ea8ba0b315 Crop: a hidden frame comes back on re-picking, a ratio or a press
Review follow-up. show_frame ends the hidden state and makes the
default frame at once, so:
- picking the Crop tool, even while it is picked, shows the frame;
- a ratio or size chosen after a commit fits a frame, so ✓ crops;
- a press records the default frame as its box Undo step, so Undo
  then Redo of the first crop after a commit keeps the drawn frame.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 00:03:40 -06:00
Hector VillarrealandClaude Opus 5.5 f8ec05858a Actions: load Neon Glow without a colour in Photoshop's blue (CodeRabbit review on steps_gallery.rs:559)
A Neon Glow step recorded without `Clr ` glows in Photoshop's default
colour, (0, 0, 255) per the event reference, but loaded without
`glowColor` and so played PhotoCraft's own default (0, 158, 255). It now
loads with `glowColor` "#0000ff", which saves back as that RGBC colour. A
PhotoCraft step without `glowColor` still saves the colour it plays with.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 23:54:53 -06:00
Hector VillarrealandClaude Opus 5.5 77d72957dd Actions: keep a Match Color step outside the command's range (CodeRabbit review on steps_channels.rs:113)
Match Color's Luminance and Color Intensity take 1..200 and Fade 0..100. The
event reference records no clamp for them, so a recorded value outside those
ranges is kept as a Photoshop step instead of loading as a step the command
plays clamped. Export refuses such a value instead of writing it unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 23:51:12 -06:00
D-monizedandClaude Opus 5.5 0125925ee3 Crop: no frame around the cropped image until the next press
After a committed crop the Crop tool drew a new default frame with
corner handles around the cropped canvas at once, so the crop looked
like it never applied. A successful commit now hides the frame for the
cropped document until a press on the canvas, re-picking the tool, or
another document (or size of this one), keyed by document id and size
as in #10396.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 23:51:10 -06:00
Hector VillarrealandClaude Opus 5.5 889f3e2e77 Actions: keep a Trap step narrower than 1 px (CodeRabbit review on steps_channels.rs:72)
Photoshop clamps a Trap width above 32767 px, but its minimum wasn't measured,
so a recorded width below the command's 1 px is kept as a Photoshop step
instead of loading as a Trap that rounds to 0 px and does nothing. Export
refuses such a width as it does one above 32767 px.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 23:50:32 -06:00
Cristi RaduandClaude Opus 5.5 2a7ab4aa98 Crop: test the Info panel's crop size, units and ratio (#3145)
Review follow-up: W and H share one formatter (wh_readout) for the
selection and the crop frame; tests cover the ratio's rounding and
degenerate frames, W and H in each ruler unit, and W and H after the
crop is cancelled, committed or the tool is left.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 07:46:58 +02:00