Commit Graph
11425 Commits
Author SHA1 Message Date
David MannandClaude Opus 5.5 4614b3e119 Integration: build two ATN test files with defaults (#8714, #8858, #8327)
#8327 adds `AtnFile::encoding`. Two tests from other PRs in the batch
build an AtnFile literal without it (#8714 fix-up's Camera Raw save-back
test, #8858's Vibrance string-class test), so the engine's lib tests
didn't compile on the batch. They now fill the rest with
`..Default::default()`, as the other literals in the file do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 15:46:37 +01:00
midasdf 52d4292624 Merge remote-tracking branch 'origin/main' into pr
# Conflicts:
#	docs/target-app-parity.md
2026-11-01 23:42:30 +09:00
David MannandClaude Opus 5.5 2e0c0f9a69 Docs (atn): how Insert Menu Item and Insert Path are recorded
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 15:40:20 +01:00
yoriswind 775dc0c070 Keep document lifecycle tests consistent with wrapped offsets 2026-11-01 06:39:03 -08:00
yoriswind ca60678754 Describe CAF action conversion and regression witnesses 2026-11-01 06:37:14 -08:00
David MannandClaude Opus 5.5 ceb5ddf6c5 Docs (atn): events measured through dialogs and recordings, Batch file naming, panel menu
Recorded in the reference application through its menus and read back from the saved Actions
panel, or returned by the dialog on OK: Custom, Fibers, Displace (with ranges), Color Lookup,
Shape Blur, Lighting Effects, Blur Gallery, Liquify, Camera Raw Filter, Vanishing Point,
Calculations; how Image Size, Canvas Size, Convert Mode and New Group are recorded. The Batch
descriptor with its file naming components, and the Actions panel menu and Playback Options.

Known gaps gain four rows: Convert Mode is saved with an enum the reference application
rejects, adjustment layer opacity on Make, Canvas Size in percent, Image Size in cm/inches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 15:37:04 +01:00
David Mann bb8edaf596 Merge PR #8327: Actions: read .atn step names in the code page Photoshop wrote them in (#6743)
# Conflicts:
#	contributors/people.toml
#	crates/engine/src/cmd/atn_cmds/tests.rs
2026-11-01 15:36:45 +01:00
7e50896afb Integration: drop the glued-letter rule again (#8327)
The previous fix-up counted a letter glued to an ASCII letter as common
only when it was Latin. That turned ordinary windows-1251 names such as
"CMYKканал" or Ukrainian "Копiя" (Latin i) into a windows-1252 (or GBK)
reading of the whole set, with no warning, where the PR read them right.

Back to the PR's scoring for single-byte pages; the ¥ removal stays.
windows-1252 "Fläche m²" / "Preis £5" reading as windows-1251 is the
PR's own known limitation, now noted in the code. A Russian set plus
"CMYKканал" is pinned as windows-1251.

Co-authored-by: regexer <3689390+regexer@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 15:35:14 +01:00
yoriswind 376949a6f3 Preserve Content-Aware Fill options in ATN actions 2026-11-01 06:34:22 -08:00
yoriswind abb28e4d37 Correct mapped ATN identifiers and wrap document offsets 2026-11-01 06:24:58 -08:00
yoriswind da496ec03f Document Content-Aware Fill adaptation helpers 2026-11-01 06:23:16 -08:00
bd04a88292 Integration: keep Mac Roman bullets and Latin words out of the wrong page (#8327)
Mac Roman 0xA5 is the bullet, windows-1252 0xA5 is ¥: with ¥ counted in
the windows-1252 re-weigh, Mac "Ebene • Kopie" read as "Ebene ¥ Kopie".
Drop ¥; the other kept symbols are no letter or typographic mark in Mac
Roman.

windows-1251 has І і д where windows-1252 has ² ³ ä, so "Fläche m²" read
as "Flдche mІ" (already so in the PR head; main showed it right). In a
single-byte page, a letter glued to an ASCII letter now counts as common
only when it is a Latin letter. Real Cyrillic names ("Новый слой",
"Копия слоя 2", "Канал RGB") still read as windows-1251. "Preis £5"
(Ј between a space and a digit) still reads as windows-1251; documented.

Co-authored-by: regexer <3689390+regexer@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 15:19:58 +01:00
David Mann 6aba9ddfd8 Merge PR #10459: Actions panel: New Set, and New Action records into the selected set (#7535)
# Conflicts:
#	crates/engine/src/cmd/atn_cmds/tests.rs
2026-11-01 15:13:27 +01:00
yoriswind 4875f94ebb Expose Content-Aware Fill scale and mirror options 2026-11-01 06:13:03 -08:00
yoriswind de9c5e743e Preserve Image Size style scaling through ATN actions 2026-11-01 06:13:02 -08:00
yoriswind d7bce26deb Add optional layer-style scaling to Image Size 2026-11-01 06:13:00 -08:00
e2789c041c Integration: a set stops at a called action's dialog; folders toggle without a pointer (#10459)
- A set whose action paused at a step dialog inside an action it calls handed the rest of
  the set to the called action's dialog, which resumes alone: after OK the set's next
  action ran and the caller's own remaining steps never did. The rest of a set now rides
  only on a pause of the target action itself; otherwise the set stops there.
- Set folders could only be collapsed with the pointer on the triangle: a keyboard or
  accessibility activation always just selected. Without a pointer it now selects and
  toggles, as before, and the row reports whether it is selected (not whether it is expanded).

Co-authored-by: hectorviov <1501713+hectorviov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 15:11:33 +01:00
1d0bc23c3e Integration: don't count symbols on Mac Roman letters as windows-1252 (#8327)
The previous fix-up counted § ® ¾ ¿ (and ¹ » ¼ ½) as common windows-1252
text, but those bytes are Mac Roman ß Æ æ ø (π ª º Ω). Mac names with no
Unicode copy such as "Weiß", "Gaußscher Weichzeichner", "Størrelse",
"Lærredstørrelse" and "Æble" then tied and read as windows-1252 ("Wei§",
"St¿rrelse"), where the PR read them right.

Keep only the 12 symbols whose byte is not a letter in Mac Roman
(¡ ¢ £ ¥ © « ° ± ² ³ ¶ ·). Windows "Größe »", "50 °" and "« auto »" still
read as windows-1252; a name whose only non-ASCII character is ® ("Logo
®") reads as Mac Roman "Logo Æ" again, as on the PR head (tested as a
known limitation).

Co-authored-by: regexer <3689390+regexer@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 15:00:36 +01:00
yoriswind 04cf63f68c Preserve recorded ATN settings across load and save 2026-11-01 05:58:42 -08:00
aiongg 84732d09bc Merge pull request #9618 from RickiNano/prefs/gpu-adapter-typed-read
Prefs: startup reads Graphics Adapter through the typed Performance section
2026-11-01 08:56:16 -05:00
aiongg dbe24c7e92 Merge pull request #10658 from RickiNano/fix/10640-preset-group-reimport
Ask before re-importing a brush or gradient file over its group (#10640)
2026-11-01 08:55:56 -05:00
David MannandClaude Opus 5.5 fe3d8db7e3 Docs (atn): reference forms, newer events, version 12 files, wrong codes in the mapping
- Known gaps: every exported step of the round-trip test was played in the reference
  application (128 of 151 ran); six codes the mapping writes are wrong there (Vibrance and
  Gradient Map events, Stroke Outside, Pass Through, canvas extension colour, Absolute
  Colorimetric), and a document offset wraps around there.
- Reference forms: layers and documents by index, id, offset and ordinal, measured.
- Newer events: 63 candidates from the menu catalogue run in the reference application;
  which need no settings, which were measured with settings, which need their dialog.
- Version 12 files: the older descriptor layout, checked on 325 real sets.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:55:29 +01:00
a89b7cc4a7 Integration: set playback continues after a step dialog; the triangle only collapses (#10459)
Three gaps in the set selection the fix-up added:
- Play on a set whose action paused at a step dialog dropped the rest of the set after OK.
  The pause now carries the remaining actions (also across a second dialog of the same
  action), and OK plays them under the same gate. Cancel still stops the whole set.
- A collapse or expand selected the set and cleared the action, so Play then ran a whole
  other set. As on action rows, the triangle's column now only collapses or expands, and
  the rest of the folder row selects the set.
- Selecting a step (or an action through Load, Insert Stop, a drag or recording) kept an old
  selected set, which came back after Delete. Every action selection now clears it.

Co-authored-by: hectorviov <1501713+hectorviov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:54:25 +01:00
midasdf d1a02c7f2f Merge remote-tracking branch 'origin/main' into pr
# Conflicts:
#	docs/target-app-parity.md
2026-11-01 22:50:04 +09:00
af59f65b82 Integration: keep windows-1252 symbols in .atn step names (#8327)
The code-page guess counted only letters and typographic marks as common
text in single-byte pages, so a Windows step name with no Unicode copy and
a Latin-1 symbol read better as Mac Roman, whose letters sit on those
bytes: "Logo ®" showed as "Logo Æ", "Größe »" as "Grˆfle ª" (main showed
them right), and Save Actions wrote that text back.

When the guess lands on Mac Roman, weigh it against windows-1252 once more
with common Latin-1 symbols (© ® ° § « » ± ½ …) counted and the letters
windows-1252 has only at 0x80-0x9F left out. Mac Roman keeps the names
only when it still reads better; a tie goes to windows-1252, confident
with a Latin hint and flagged uncertain otherwise. Mac Roman "Größe",
"Ändern", "Contrôle", "Arrière-plan" and the corpus French sets still read
as Mac Roman.

Co-authored-by: regexer <3689390+regexer@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:43:03 +01:00
David Mann acddb90d47 Merge PR #8736: Refuse exporting an adjustment edit that names its layer to .atn
Conflict: main moved crates/engine/src/atn_cmds.rs into crates/engine/src/cmd/atn_cmds/; the refusal is ported into steps_make.rs set_to's layer.setAdjustment arm unchanged. The tests followed the rename.
2026-11-01 14:41:56 +01:00
David Mann f2fd6efdc0 Merge PR #7642: Prefer an installed pattern ID over a colliding name in ATN import 2026-11-01 14:41:19 +01:00
David Mann 2c0ad3fc34 Merge PR #8714: feat(actions): import recorded Camera Raw Filter steps as filter.cameraRaw 2026-11-01 14:41:16 +01:00
David Mann 1b308ca411 Merge PR #8858: fix(atn): import Photoshop's string class for Vibrance adjustment Sets 2026-11-01 14:41:14 +01:00
David Mann da6b7d55ff Merge PR #7561: test(atn): add native parser matrix and contract fixtures 2026-11-01 14:41:11 +01:00
David Mann fa69a54f74 Merge PR #10424: ATN export: Stroke steps write the settings they leave at default (#8303) 2026-11-01 14:41:09 +01:00
David Mann 53aa1a4a2c Merge PR #10417: fix(engine): refuse strict .atn export of a partial Levels edit (#8530) 2026-11-01 14:41:06 +01:00
David Mann a2510804c1 Merge main into integration batch 11
# Conflicts:
#	contributors/people.toml
2026-11-01 14:40:45 +01:00
adc4e45fe7 Integration: look up a recorded pattern id by id alone before the name (#7642)
`resolve_or_named` resolved the recorded `Idnt` with `resolve`, which also
matches by name in each collection. So a document pattern named like the
id beat the library pattern with that id, and a foreign id equal to some
pattern's name (`Idnt "Red"`, `Nm "Blue"`) played "Red" and never tried
the recorded name. The id is now looked up by id only (document, then
library), then the name decides. A library pattern found by id whose
pixels can't be read reports that instead of falling back, main's
paintable check still runs, and a pattern installed neither way is named
in the error (`no pattern "My Wood" (id "...")`) instead of only its UUID.

Co-authored-by: Silvertree2010 <133535268+Silvertree2010@users.noreply.github.com>
Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:36:29 +01:00
92ec412f54 Integration: Play with a set selected plays that set (#10459)
A click on a set folder row (also how a set collapses or expands) now clears the selected
action, so Play fell back to the first action of the whole list, often from another set,
and Batch and Create Droplet started on it too. Example: select Resize (set Web), collapse
Retouch, press Play: Retouch's first action ran instead.

With a set selected, Play now plays every action of that set in order, stopping at the
first that fails or pauses for a dialog (an empty set plays nothing), as the reference
application plays a selected set. Batch and Create Droplet start on the selected set's
first action. A click on an action row clears the selected set, so a later Delete doesn't
bring the old set back as the target of New Action or Play.

Co-authored-by: hectorviov <1501713+hectorviov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:36:09 +01:00
68b869eac4 Integration: save Vibrance adjustment steps with the string class vibrance (#8858)
Vibrance's adjustment class is now Photoshop's string id `vibrance`, so Set and Make steps
save back with the class Photoshop runs instead of the `Vbrn` code it refuses (#8383).
`Vbrn` moves to LEGACY_CLASSES, so actions saved before still load. A recorded Vibrance
with non-zero temperature or tint stays a kept step and saves back unchanged.

Co-authored-by: jturnbach <70334515+jturnbach@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:34:17 +01:00
aiongg 8442c105e5 Merge pull request #10681 from RickiNano/fix/10671-ants-over-guides
Paint the marching ants over the guides (#10671)
2026-11-01 08:31:13 -05:00
4d2fd2214d Integration: Camera Raw Filter steps save back and refuse unknown keys (#8714)
A loaded Camera Raw Filter step became an import-only filter.cameraRaw, so
Save Actions dropped it (skipUnsupported) or failed, where before it was
written back byte for byte. Keys outside the table (e.g. PerV = 20, a
profile name) were ignored, so the step replayed a different look without
being reported.

The step now keeps its recorded descriptor in a hidden param and saves back
as that descriptor while its params are still what it imports as; edited or
PhotoCraft-recorded steps are still refused. A step with any unknown key, or
with no settings, stays a kept Photoshop step, as the PSD mapping does.

Co-authored-by: FinnNk <1424666+FinnNk@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:31:13 +01:00
5ff10e120d Integration: keep the NaN-safe .atn fuzz invariant (#7561)
The previous fix-up put main's atn fuzz target back. It compares the
parsed actions with assert_eq!, so any valid file holding a NaN double
fails the fuzzer falsely (NaN != NaN); the PR's own contract test
nan_payloads_signed_zero_and_infinities_survive_without_false_fuzz_failures
covers exactly that. The target now calls the shared check again, at its
new path under tests/it/common.

Co-authored-by: denstu473 <63150090+denstu473@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:30:55 +01:00
aiongg c79efbe05b Merge pull request #10685 from RickiNano/fix/save-for-web-zoom-creep-10675
Save for Web: keep its size and zoom while the pointer moves (#10675)
2026-11-01 08:30:53 -05:00
aiongg e5ca16c86b Merge pull request #10672 from RickiNano/fix/10656-preset-footer-glyphs
Preset panel footers use the Layers footer's glyphs and size (#10656)
2026-11-01 08:30:05 -05:00
David Mann d86f678325 Merge main into #8327 2026-11-01 14:27:37 +01:00
4b053e15ae Integration: keep the ATN contract tests, drop the extra workflow (#7561)
The contract tests no longer compiled on main (AtnItem::dictionary is now
Vec<u8>, so it is compared with b"Future event"), sat outside main's
tests/it layout, and the new atn.yml added six legs (two macOS) to every
PR against ci.yml's policy. Move the tests into tests/it so the existing
CI runs them, drop atn.yml and docs/atn-testing.md, keep main's ci.yml and
fuzz target, and note the committed fixtures in ATTRIBUTION.md.

Co-authored-by: denstu473 <63150090+denstu473@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:25:51 +01:00
David Mann 0ee627e2fc Merge main into #8858 2026-11-01 14:22:49 +01:00
David Mann 893d12bee2 Merge main into #7561 2026-11-01 14:19:49 +01:00
David Mann 115d20fd74 Merge main into #7642 2026-11-01 14:18:26 +01:00
aiongg 713197635d Merge origin/main into prefs/gpu-adapter-typed-read 2026-11-01 13:16:28 +00:00
aiongg af404cfb9f Trim the preset file name like the engine, and list the clash prompt's plural forms for translation (#10640) 2026-11-01 13:14:09 +00:00
Lcoding15 cc41902216 Window > Arrange: drag the borders between arranged documents (#10101)
In 2-up, 3-up, 4-up, 6-up and the tiled layouts the border between two
documents now drags, as in Photoshop: the documents either side take the
new sizes, no cell goes narrower than 80 pt, and a border stops short of
its neighbours. The positions are kept in ViewOptions::arrange_splits,
checked before use (count, order, 0-1, finite) so a damaged or stale list
lays out even cells; choosing an arrangement starts from even cells.
Grabbing a border inside another document's edge no longer activates it.
2026-11-01 14:04:42 +01:00
Khawar Zamman WaniandFredApps 5d815c5a4b Stream PSD user and real masks into tile rows (#10532)
* Bound PSD import pixel storage before decoding

* Include ZIP inflater workspace in PSD preflight

* PSD import: budget unknown-mode layers, stop after a fatal layer error, keep best-effort for non-allocation limits (#8593 review)

* Stream PSD user and real masks into tile rows

* Correct streamed-mask fixture metadata and test lint issues

---------

Co-authored-by: FredApps <FredApps@users.noreply.github.com>
2026-11-01 14:03:08 +01:00