Commit Graph
11425 Commits
Author SHA1 Message Date
harrisonoconnorhover 5d8980222a actions: add editable PhotoCraft Essentials presets
Seed starter actions once, preserve custom libraries, and expose a restore command in the Actions panel and automation APIs.

Generated with Codex.
2026-10-13 10:47:06 -04:00
Claude ce94ac430d test(algo): pin seam carving's tall-image output; bench_seam timing example
The reduced-height seam search for tall images (P28's path) had no
bit-exact test: output_bits_are_pinned and carver_matches_reference only
cover images under 2048 rows. Pin five proxy-path carves (widths and,
through the transposed pass, heights; with and without protection) from
the current code, so the speed work that follows can't change which
seams are chosen.

bench_seam times the carver alone on a synthetic 24 MP photo (P28's
width change, its height change) and two exact-path sizes, and prints a
hash of each output. Before (4 cores, release): 2279 ms, 4872 ms,
1542 ms and 658 ms p50.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LELc5BQzgV5dA7dxdMejkK
2026-10-13 14:24:55 +00:00
MarekSpodBiedry 5244ee7c86 fix(mixer-brush): Alt-click samples the foreground colour like the Brush (#4873) 2026-10-13 16:23:48 +02:00
Lorenzo Fasolino b4664381ed chore(contributors): credit LorenzoFasolino as Lorenzo Fasolino
Contributors entry for the About window: real name and display name. The public GitHub profile name is empty, so sync_github_name stays false rather than falling back to nothing.
2026-10-13 16:16:05 +02:00
Lorenzo Fasolino dde4b8dca8 docs(perf): how to measure one scenario and read its numbers
Task T-0003 del lab artcraft-lab.

File toccati:
   docs/development.md | 34 ++++++++++++++++++++++++++++++++++
   1 file changed, 34 insertions(+)

Evidenze: artifacts/T-0003/ (nel lab, non in questo repo).
2026-10-13 16:15:28 +02:00
Lorenzo Fasolino 5035aa4116 fix(i18n): Italian Screen blend mode and Dodge tool names were swapped
Task T-0001 del lab artcraft-lab.

File toccati:
   crates/ui-egui/src/i18n/it.tsv |  8 ++++----
   crates/ui-egui/src/i18n/mod.rs | 16 ++++++++++++++++
   docs/localization-it.md        |  9 +++++++++
   docs/localization-parity.md    |  1 +
   4 files changed, 30 insertions(+), 4 deletions(-)

Evidenze: artifacts/T-0001/ (nel lab, non in questo repo).
2026-10-13 16:15:27 +02:00
Fabio Lissi bc08629d29 Batch: subfolders, open documents, file naming, stop on error, error log, progress and cancel (#219)
File › Automate › Batch now covers Photoshop's dialog (AUTO-219-5):

- Source: a folder with Include All Subfolders (the output mirrors the
  folder tree, so same-named files in different subfolders don't
  collide), or the open documents (`"source": "open"`: the steps run on
  every open document as history steps; with an output folder a copy of
  each is saved there).
- File Naming: a template with Photoshop's fields as tokens: {name}
  {NAME} {Name}, {serial} to {serial:4} from startSerial, {letter}
  {LETTER}, {date:mmddyy|mmdd|yyyymmdd|yymmdd|yyddmm|ddmmyy}, {ext}
  {EXT}, other text literal. Default {name}.{ext}, the old naming.
- Errors: stopOnError stops at the first failing file and reports the
  skipped ones; errorLog writes the failures to a text file.
- The command runs as a job: the status bar shows "n of total: file"
  and Cancel stops after the current file.

The options live in the new engine module `batch` and are shared by
Image Processor, the Lens Correction batch and the CLI's `batch`
(--recursive --naming --start-serial --stop-on-error --error-log).
The generic form dialog takes an `__order` hint so the Batch dialog is
grouped as Photoshop's (Play, Source, Destination, Errors). chrono
(clock, native only) supplies the local date for the date tokens.

Tests: 9 in batch/tests.rs (tokens and rejected templates, recursive
listing, mirrored output, stop/skip/log, cancelled context, background
job, open-documents source), one CLI test, one form-order test. The
batch_export_options helpers pick the nearest field on a label's row,
since the taller dialog's Quality row now shares a height with the
Layers panel's opacity field. Scorecard AUTO-219-5 done; gaps, parity
and development docs updated.
2026-10-13 08:37:12 -05:00
Fabio Lissi a8c8036f49 Record actions in a document-independent form (#219)
Journal entries are what Actions record, so a step must mean the same
thing on another document. The UI names the layer it clicked by id,
which only replays on the document the recording came from.

Before an entry is journaled (actions_record.rs):
- a `layer` id that was the active (and only selected) layer is dropped,
  so the step acts on the active layer when played;
- any other id becomes the layer's name when unique in the document
  (`layer.select` always, like Photoshop's "Select layer"); an
  ambiguous name keeps the id;
- Type tool keystrokes (`type.edit` with `replace` and the session's
  `coalesce` key) fold into the `type.create` that made the layer or
  into one `type.edit` with the whole text, as Photoshop records "Make
  text layer" and "Set current text layer".

The dispatcher captures the document before the command, also for
background jobs, and remembers which text layer the last entry typed
into, since the Type tool selects a clicked layer without a command.

Tests: 11 in actions_record/tests.rs, including a recording that
replays on a document whose layers have other ids. Scorecard
AUTO-219-1 done; gaps, parity and protocol docs updated.
2026-10-13 08:36:45 -05:00
Gustavo Ziger 7f72cb8156 Merge main into feat/zoom-animation-566 2026-10-13 10:32:21 -03:00
Fabio Lissi 74ad8ee5bc Pin a corpus of real Photoshop Actions sets and test the .atn parser and import on it (#219)
- corpus/atn: 16 sets from seven public repositories (MIT, BSD, Unlicense), fetched at pinned
  commits by cargo xtask corpus --atn, verified against xtask/atn-corpus.sha256, licences next to
  the files, rows in ATTRIBUTION.md and docs/development.md. photocraft-corpus takes only our own
  generated files, so third-party sets are pins here, like psd-tools and ag-psd.
- photocraft-psd corpus_atn: every set parses and rewrites byte for byte (floor 16 files).
  photocraft-engine corpus_atn: every set loads, saves and reloads to the same actions; the
  steps still kept as Photoshop steps are capped (517 of 5 296 measured; generative AI and
  scripts), and the first differing step is named on a mismatch.
- What the corpus found: localised panel names are platform legacy bytes (Mac Roman), now kept
  verbatim with AtnItem::label from the descriptor's Unicode class name; exporters emitted
  Photoshop defaults the importer had not read (now symmetric); setAdjustment carries its kind;
  and 300 more steps map: transform without a reference, selection nudges, moves to the bottom,
  View menu items, toolbox colours, clipping masks, ungroup, copy/paste styles, collapse groups,
  layer comps. New example atn_roundtrip shows the first differing byte.
2026-10-13 08:29:38 -05:00
zenjabba 3a77519ce2 Merge pinned main and preserve Smart Filter row selection 2026-10-13 13:17:12 +00:00
OctaNebulaandClaude Opus 5.5 4099ee046f fix(layer-style): Blend If's first bar reads Current Layer, as in Photoshop 2026
Photoshop 2026 labels the first Blend If bar "Current Layer:" (it was
"This Layer:"). The dialog field stays `thisLayer`, so automation is
unchanged. "Current Layer:" is translated in the 20 complete catalogs
(from each one's existing "Current Layer"), replacing the five "This
Layer:" entries, and "Underlying Layer:" is filled in for the 15 that
lacked it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 14:27:46 +02:00
OctaNebulaandClaude Opus 5.5 bb47f7da39 feat(layer-style): Photoshop's layout
Layer Style was tall and narrow: OK / Cancel in a bottom row, Preview and
New Style… on the pages, each slider on a line under its label. It now has
Photoshop's three columns: the effect list, the page, and a right-hand
column with OK, Cancel, New Style…, Preview and a preview swatch, at
Photoshop's shape (800x550; Photoshop is ~777x525), every page fitting.

- widgets::slider_line / row_label: label (right-aligned column), slider
  and field on one line; the angle dial (angle_dial_line), dropdowns,
  colours and contours share the column; check boxes sit under controls.
- Preview swatch: the pending style on presets::styles::thumbnail's sample
  square, built on a scratch layer like the canvas preview, cached by the
  style; at point size while the mouse is down.
- List bar: fx (the Layers panel's button) adds or shows an effect, the
  arrows move the selected instance within its kind, the bin deletes it.
- + on every multi-instance kind, also before the layer has one.
- The dialog draws its own OK / Cancel and takes Enter (like Guide Layout).
- Three new tooltips translated in the 20 complete catalogs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 14:17:59 +02:00
webdevtodayjason 1e6a9f27b9 Codecs: PCX runs may cross plane boundaries within a scanline 2026-10-13 07:15:13 -05:00
webdevtodayjason 6f3db89321 Contributors: add Jason Brashear 2026-10-13 07:15:13 -05:00
David MannandClaude Opus 5.5 6ceb0dbae2 panel-commands: follow main's move of the HSB sliders into hsb_sliders
Main split the Color panel's HSB sliders out of color_picker (#4399), so the
allowlist entry moves with them; regenerate docs/scorecard.md after the merge.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-13 14:06:39 +02:00
OctaNebulaandClaude Opus 5.5 719946c6f0 fix(layer-style): one dialog size on every page, and it fits short screens
Layer Style was sized by its content, so its height jumped with each page
(Photoshop's keeps one size), and Bevel & Emboss (~732 pt) pushed OK /
Cancel off the bottom of a short window, with nothing scrolling.

It is now drawn in a fixed-size egui::Resize area, the path the web-page
dialog already used (a small per-dialog Sizing: size, minimum, resizable
or not, outline): 600x760, at most the window less a margin. Not
resizable, as in Photoshop; the web-page dialog keeps its grip. The effect
list and the settings page each scroll in the height the dialog leaves
them, the separator follows it, and the settings column (sliders, Blend If
bars) takes the dialog's width.

A Resize clips its contents to its area, which cut off the title band's
reach into the frame's padding (#1921, #1945) on the web-page dialog
already: the clip now covers that band (TITLE_REACH).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 13:45:36 +02:00
David MannandClaude Opus 5.5 5bdd9f773e History snapshot options: Serbian labels
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-13 13:26:50 +02:00
Nigel Ihza Firdausy d821e548de fix(compose): use the same linear Dissolve mix as unclipped layers 2026-10-13 18:21:41 +07:00
Nigel Ihza Firdausy 2de95cd553 refactor(compose): keep clipped Dissolve mixing branch local 2026-10-13 18:18:05 +07:00
Nigel Ihza Firdausy 81964dc5ef fix(control): block engine commands while a modal dialog is open (#4919) 2026-10-13 18:17:27 +07:00
Nigel Ihza Firdausy c728d013cb fix(compose): honor Dissolve coverage on clipped layers (#4921) 2026-10-13 18:15:29 +07:00
mighty-programmer 42a03e2c97 Constrain model guidance to the visible Preferences pane 2026-10-13 14:13:00 +03:00
Nigel Ihza Firdausy b2fbdb1c2d fix(ui): deselect layers when clicking outside the canvas (#4923) 2026-10-13 18:12:49 +07:00
David MannandClaude Opus 5.5 511b55bec3 History Brush source: Serbian labels
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-13 13:10:26 +02:00
David MannandClaude Opus 5.5 1ad95dd84a History Options: Serbian labels
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-13 13:10:14 +02:00
haranishi 67b7f1208e feat(ui): add Shift+right-click brush mode picker 2026-10-13 20:07:49 +09:00
David MannandClaude Opus 5.5 c4a30b02a9 Merge origin/main into feat/auto-219-8-panel-command-check
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-13 12:59:44 +02:00
mighty-programmer 54502d09de Retain channel composite allocation across visibility changes 2026-10-13 13:56:51 +03:00
David MannandClaude Opus 5.5 716e398ede Regenerate docs/scorecard.md after merging main
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-13 12:47:44 +02:00
David MannandClaude Opus 5.5 09af99c6f3 History panel menu: Serbian labels
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-13 12:41:44 +02:00
David MannandClaude Opus 5.5 c951480e99 Merge origin/main into feat/tool-213-7-live-retouch
Background Eraser: main now samples and matches against the pre-stroke pixels (#4552); the
shared dab effect takes the pre-stroke surface so the live preview, whose working areas are
per dab, reads the same pixels as the commit.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-13 12:33:25 +02:00
mighty-programmer 7f4a5e37a9 Wrap optional model guidance in translated preferences 2026-10-13 13:33:07 +03:00
Gert Pellin 772cf39c09 PSD Duotone: read and write the ink block (names, colours, curves)
The Duotone Color Mode Data is undocumented. From files Photoshop 2025
made it is 524 bytes: version 1, ink count, four 10-byte ink colours (as
in swatch files, space 0xFFFF = none), four 64-byte Pascal names, four
transfer curves (13 i16 values in tenths of a percent at 0, 5, 10, 20,
..., 90, 95, 100 % gray density, -1 = no point, then an i16), dot gain
and eleven overprint colours.

- Import interprets the inks, so an opened duotone shows them instead of
  its grey plate; the block is still kept raw and written back while the
  inks are unedited. A colour-book ink (not readable here) shows as black
  with a warning.
- Export writes a block for duotones made in PhotoCraft (RGB ink colours,
  curves on the 13-point grid or sampled at it, default dot gain,
  computed overprints), so every 8/16-bit Duotone is saved as Duotone.

Photoshop opens such files as Duotone, and a black monotone whose curve
is 0 up to 60 % density stays white exactly up to 60 % there.

Refs #4814
2026-10-13 12:19:37 +02:00
mighty-programmer f03816a616 Refresh optional models with upstream selection caches and catalogs 2026-10-13 13:19:02 +03:00
DeWarePebandClaude Opus 5.5 a0936a5c7a Merge upstream main into fix/4178-theme-tool-options
lib.rs: keep both tool_options_theme_tests and tool_shortcut_tests.
panels.rs: main's #4537 (Brush Mode dropdown in every theme) and the
Gradient icon/wheel-dropdown changes re-applied onto the reindented
options bar.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017vRzAzCFPtectZadDNswPn
2026-10-13 12:15:33 +02:00
David MannandClaude Opus 5.5 576e3043d0 Merge main into feat/history-snapshot-options
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-13 12:08:58 +02:00
David MannandClaude Opus 5.5 03f929bffb Merge main into fix/history-brush-source
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-13 12:08:08 +02:00
David MannandClaude Opus 5.5 c2d491ae3a Merge main into fix/history-options
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-13 12:07:37 +02:00
David MannandClaude Opus 5.5 402d005e05 Merge origin/main into docs/scorecard-stale-rows-2
Conflicts in docs/gaps.md, docs/target-app-parity.md and docs/ui-parity.md:
kept main's status lines and rows and this branch's Type, selection-modifier
and Alt-wheel evidence. docs/scorecard.md regenerated.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-13 12:04:36 +02:00
David MannandClaude Opus 5.5 71ea169a84 Merge main into fix/history-panel-menu
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-13 12:04:26 +02:00
Gert Pellin 5f59f0671a Layered TIFF: Indexed, Bitmap and Duotone layers are modelled in their pixel format
The layered TIFF export builds its layer data through the PSD exporter,
which now writes these modes in their own PSD mode (palette, 1 bit,
duotone). TIFF has no such layout and interleaves the merged image in
the pixel format, so the PSD model for it is made in that format (RGB or
Grayscale), as before.

Refs #4814
2026-10-13 11:51:34 +02:00
Jannik Wappler ab84cab735 Merge main and resolve translation and progress-doc conflicts 2026-10-13 12:10:28 +03:00
Jeremy YaoandClaude Opus 5.5 a128094e93 chore: opt JeremyYao into public profile credit
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 04:26:42 -04:00
Jeremy YaoandClaude Opus 5.5 7a823bf741 Merge branch 'main' into feature/animation-effects
Brings in 240 commits from main. One conflict, in the generated
docs/scorecard.md: main changed the row next to this branch's (UI-217-11, the
Soft themes). Resolved by regenerating it with cargo xtask scorecard from the
merged scorecard/ui.toml; it differs from main only in the UI-217-10 note.

main also added the Serbian catalog with the Enable animations label this
branch replaces: it gets Animation effects and Use system setting instead, like
the other 19.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 04:26:26 -04:00
Nigel Ihza Firdausy 5f4ca2f0a8 feat(status): report selection or layer bounds in document pixels 2026-10-13 14:55:30 +07:00
itsF4LCON 56c0a72f1c Merge remote-tracking branch 'upstream/main' into feat/2966-snapshot-dialog
# Conflicts:
#	crates/ui-egui/src/dialogs.rs
2026-10-13 09:19:06 +02:00
Nicolas FalesyandClaude Opus 5.5 6f85054288 fix(clipboard): paste JPEG, BMP and other non-PNG images on Wayland (#2546) (#4752)
arboard 3.6 asks the clipboard for image/png only, so a screenshot tool or
clipboard manager that offers just image/jpeg, image/bmp or image/webp pasted
nothing ("the clipboard holds no image"). When arboard finds no image, read
the other image/* types through wl-clipboard-rs (already in Cargo.lock via
arboard's wayland-data-control) and decode them with photocraft-codecs.
Reads are capped at 1 GiB; TGA is trusted only when its type says so.


Claude-Session: https://claude.ai/code/session_01AbyXia7KGdFgbNjBeggY8J

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 03:06:34 -04:00
Nigel Ihza Firdausy c0e62673f8 fix(macos): default droplets to a writable user directory (#4746) 2026-10-13 03:06:27 -04:00
Gert Pellin 2a10524d53 PSD: save Indexed Color, Bitmap and Duotone documents in their own mode
Indexed Color (mode 2): the flattened document as palette indices, the
Color Table as Color Mode Data (256 reds, greens, blues), its length in
resource 1046 and the transparent entry in 1047; the importer now reads
both back. Bitmap (mode 0): 1 bit per pixel, 1 = black. Neither mode has
layers in Photoshop, so both are written flat, like Multichannel; the
layerless file building is shared with multichannel_map.

A Duotone keeps the ink data it was imported with (undocumented, kept
verbatim in Duotone::psd_raw) over its grey plate. Duotones whose inks
were set in PhotoCraft have no such data and stay Grayscale with the
warning, as before.

Fixes #4814
2026-10-13 09:00:20 +02:00