mirror of
https://github.com/storytold/photocraft.git
synced 2026-11-21 01:18:43 +00:00
panel-commands: follow main's move of the HSB sliders into hsb_sliders
Main split the Color panel's HSB sliders out of color_picker (#4399), so the allowlist entry moves with them; regenerate docs/scorecard.md after the merge. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
c4a30b02a9
commit
6ceb0dbae2
3 files changed
+8
-8
No files matched your search
+2
-2
@@ -11,7 +11,7 @@ Generated by `cargo xtask scorecard` from `perf/budgets.toml`, `perf/baseline.js
|
||||
| [Tools](#tools) | 28 | 14 | 1 | |
|
||||
| [Workspace and UI](#workspace-and-ui) | 13 | 6 | 4 | settings that do nothing: 26 of 156 (target 0) |
|
||||
| [Type](#type) | 4 | 3 | 2 | |
|
||||
| [Automation](#automation) | 5 | 2 | 4 | 631 of 631 menu items live (100.0%) |
|
||||
| [Automation](#automation) | 5 | 3 | 3 | 631 of 631 menu items live (100.0%) |
|
||||
| [Reliability](#reliability) | 5 | 2 | 0 | never-crash lints on 28 of 28 crates; panic_hunt present |
|
||||
| [Distribution](#distribution) | 5 | 4 | 2 | |
|
||||
| [Open bugs](#open-bugs) | 29 | 2 | 1 | |
|
||||
@@ -234,7 +234,7 @@ Menu wiring (`docs/parity-checklist.md`): 631 of 631 menu items live (100.0%). T
|
||||
| AUTO-219-5 | Batch: subfolders, open documents, naming template, progress/cancel, error log, stop | partial | [#219](https://github.com/storytold/photocraft/issues/219) | file_cmds.rs:590-631 folder/array input, per-file errors; no recursion, template or cancel |
|
||||
| AUTO-219-6 | Plug-in ABI v2: panel kind, progress/cancel calls, read other layers, Last Filter repeats | missing | [#219](https://github.com/storytold/photocraft/issues/219) | runtime.rs:15 ABI_VERSION = 1; manifest.rs:18 Kind::Filter only |
|
||||
| AUTO-219-7 | Local ONNX models behind a flag, managed in Preferences; subject select, background removal | missing | [#219](https://github.com/storytold/photocraft/issues/219) | No ONNX runtime dependency |
|
||||
| AUTO-219-8 | xtask check that every panel button routes through a command id | missing | [#219](https://github.com/storytold/photocraft/issues/219) | No such xtask check |
|
||||
| AUTO-219-8 | xtask check that every panel button routes through a command id | partial | [#219](https://github.com/storytold/photocraft/issues/219) | cargo xtask panel-commands (run by xtask ci and CI) fails on a shell click handler that changes the document or session directly; 2 allowlisted functions left (panels.rs hsb_sliders, color_field assign the foreground/background colour instead of tools.setColors) |
|
||||
| AUTO-219-9 | Headless commands for in-canvas type editing, Liquify/Puppet strokes, transform handles | done | [#219](https://github.com/storytold/photocraft/issues/219) | type.hitTest, type.caret, type.navigate; filter.liquify strokes, edit.puppetWarp pins, type.edit, edit.transform |
|
||||
| AUTO-219-10 | Agent acceptance suite grown to 30-50 workflows | partial | [#219](https://github.com/storytold/photocraft/issues/219) | automation/tests/agent_tasks.rs runs 10 workflows over MCP |
|
||||
|
||||
|
||||
@@ -65,7 +65,7 @@ id = "AUTO-219-8"
|
||||
target = "xtask check that every panel button routes through a command id"
|
||||
status = "partial"
|
||||
issue = 219
|
||||
note = "cargo xtask panel-commands (run by xtask ci and CI) fails on a shell click handler that changes the document or session directly; 2 allowlisted functions left (panels.rs color_picker, color_field assign the foreground/background colour instead of tools.setColors)"
|
||||
note = "cargo xtask panel-commands (run by xtask ci and CI) fails on a shell click handler that changes the document or session directly; 2 allowlisted functions left (panels.rs hsb_sliders, color_field assign the foreground/background colour instead of tools.setColors)"
|
||||
|
||||
[[item]]
|
||||
id = "AUTO-219-9"
|
||||
|
||||
@@ -43,13 +43,13 @@ pub struct Allowed {
|
||||
/// Existing click handlers that change the document directly. Shrink only: each entry is a
|
||||
/// follow-up (route it through an engine command), never a place to park new code.
|
||||
pub const ALLOWLIST: &[Allowed] = &[
|
||||
// Window › Color: the HSB sliders and the hex/RGB readout set the foreground colour by
|
||||
// assignment, so the change never reaches the journal, action recording or the control
|
||||
// channel's event log. Fix: dispatch `tools.setColors` (it already exists).
|
||||
// Window › Color: the HSB sliders set the foreground colour by assignment, so the change
|
||||
// never reaches the journal, action recording or the control channel's event log.
|
||||
// Fix: dispatch `tools.setColors` (it already exists).
|
||||
Allowed {
|
||||
file: "crates/ui-egui/src/panels.rs",
|
||||
func: "color_picker",
|
||||
reason: "Color panel sliders and readout assign session.tools.foreground; dispatch tools.setColors",
|
||||
func: "hsb_sliders",
|
||||
reason: "Color panel HSB sliders assign session.tools.foreground; dispatch tools.setColors",
|
||||
},
|
||||
// The Color panel's colour field and hue strip (and their readout) assign the foreground or
|
||||
// background colour on every drag frame. Fix: dispatch `tools.setColors`.
|
||||
|
||||
Reference in new issue
Block a user