Commit Graph
11425 Commits
Author SHA1 Message Date
ZhuanTou33212 ac3cac0b95 Add opt-out startup release checks and manual update status 2026-10-14 17:31:43 +08:00
Nigel Ihza Firdausy 6eb48e4e3a style(jxl): keep header validation closure rustfmt-clean 2026-10-14 16:04:46 +07:00
Nigel Ihza Firdausy 17ee754eb4 test(jxl): cover 16-bit alpha at JPEG XL dimension boundaries 2026-10-14 16:00:08 +07:00
Nigel Ihza Firdausy b94d49e5d3 docs(jxl): clarify 16-bit alpha lossless behavior 2026-10-14 16:00:05 +07:00
Nigel Ihza Firdausy a317ab02c5 docs(jxl): describe 16-bit alpha header correction 2026-10-14 16:00:02 +07:00
Nigel Ihza Firdausy c99e5de0e2 style(jxl): fix format registration rustfmt mismatch 2026-10-14 15:59:59 +07:00
Nigel Ihza Firdausy 9e82e7a314 fix(jxl): write accurate 16-bit extra alpha channel metadata 2026-10-14 15:58:58 +07:00
Finn NewickandClaude Opus 5.5 7fae49548d Merge remote-tracking branch 'origin/main' into fix/tiff-alpha-compression
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 09:34:37 +01:00
augrclkandGPT-6 25f12c5009 Merge upstream main into PR #5317
Keep both sets of progress notes and preserve the automatic source merge.

Co-authored-by: GPT-6 <noreply@openai.com>
2026-10-14 11:33:35 +03:00
augrclkandGPT-6 b5528efc72 Merge upstream main into PR #5365
Keep both sets of progress notes and preserve the automatic source merge.

Co-authored-by: GPT-6 <noreply@openai.com>
2026-10-14 11:33:34 +03:00
augrclkandGPT-6 b355dacc77 Merge upstream main into PR #5269
Keep both sets of progress notes and preserve the automatic source merge.

Co-authored-by: GPT-6 <noreply@openai.com>
2026-10-14 11:33:32 +03:00
augrclkandGPT-6 cf87e8a7f8 Merge upstream main into PR #5250
Keep both sets of progress notes and preserve the automatic source merge.

Co-authored-by: GPT-6 <noreply@openai.com>
2026-10-14 11:33:32 +03:00
augrclkandGPT-6 16fb0f50e3 Merge upstream main into PR #5199
Keep both sets of progress notes and preserve the automatic source merge.

Co-authored-by: GPT-6 <noreply@openai.com>
2026-10-14 11:33:32 +03:00
augrclkandGPT-6 8cc08cdd52 Merge upstream main into PR #5224
Keep both sets of progress notes and preserve the automatic source merge.

Co-authored-by: GPT-6 <noreply@openai.com>
2026-10-14 11:32:51 +03:00
jonathnwxh 77d889850c Translate custom shape import labels and status messages 2026-10-14 16:28:46 +08:00
Vikram Bhaskaran 10220c97fc Translate New Action, Start Recording, and Stop Recording.
The Actions panel menu added those labels; complete-menu locales must cover every tl! literal.
2026-10-14 19:14:56 +11:00
MarekSpodBiedry ed7df56a24 fix(format): recover autosaves with missing sidecars
Discover committed autosave bundles whose JSON sidecar was never published. Rebuild recovery metadata from the readable manifest and retain these bundles during orphan cleanup.

Fixes #4967
2026-10-14 02:02:34 -06:00
jonathnwxh 2a02350cda Restrict CSH automation imports to inline data 2026-10-14 15:47:42 +08:00
Vikram Bhaskaran f784275180 Open Affinity files renamed .psd with the Affinity loader.
Magic 8BPS still goes to the PSD reader. A .psd suffix without that signature is PSD only after Affinity (and other native) magic is ruled out, so a renamed Affinity preview does not fail as an invalid PSD.
2026-10-14 18:34:48 +11:00
SBaksa e93e9f5b02 Merge main into cmyk-native-composite 2026-10-14 18:28:19 +11:00
jonathnwxh 88efb46eb7 Import Photoshop custom shape sets into the Shapes library
Add bounded CSH version 2 reading and a persistent engine import command,
with Shapes-panel and File Open integration. Preserve the existing library
on malformed sets and disambiguate imported names.

Focused checks: 6 engine, 4 parser, 3 UI routing, 6 preset reader tests;
explicit GPU rendering; strict affected-crate Clippy; panic_hunt; layering;
parity generation (unchanged output). Original generated fixture cross-read
with ag-psd. Photoshop-written CSH fixtures and export remain out of scope.

Full repository CI is verified separately before upstream submission.
Prepared with OpenAI Codex assistance for jonathnwxh.
2026-10-14 15:27:52 +08:00
Vikram Bhaskaran a042bd373d Show Load Actions and the rest of the Actions panel menu.
The docked Actions panel menu already had Load/Save, but it omitted New Action, Play, Record, and Delete, so it looked like only docking commands. Match the Actions panel id in both casings and list the Photoshop-parity items.
2026-10-14 18:23:51 +11:00
Gert Pellin 1c7989f607 Merge remote-tracking branch 'upstream/main' into feat/4814-duotone-inks 2026-10-14 09:22:02 +02:00
Gert Pellin 2c5ed1c91d Layered TIFF corpus test: a flat Duotone is expected with its inks rendered
With the ink block read, an opened duotone has its real inks. A
single-layer one is saved flat, which writes the inks rendered as RGB
(flat.rs); the test compared that with the grey plate.

Refs #4814
2026-10-14 09:22:00 +02:00
Vikram Bhaskaran 478c986972 IO: open .psd/.psb/.psdt through the PSD reader, not codecs (#5258)
File › Open sent Photoshop extensions that lacked an 8BPS prefix (or
reached import by name) to photocraft-codecs, which reports
"unrecognized image format". Route them like other native formats, and
offer a Photoshop filter in the open dialog.
2026-10-14 18:04:46 +11:00
abc2cbandClaude Opus 5.5 b14d492378 smart_map test: panic! instead of unreachable! (clippy::unreachable)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 10:01:46 +03:00
Gustavo Ziger e6d3c70835 Merge main into feat/zoom-animation-566 2026-10-14 03:56:28 -03:00
Finn NewickandClaude Opus 5.5 4c4138d6eb docs: TIFF alpha channels and compression (#5301)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 07:38:36 +01:00
Finn NewickandClaude Opus 5.5 4121ff4dc1 fix(tiff): keep a TIFF's alpha channel, and add a tiffCompression save option
Photoshop writes a document's alpha channel as an unspecified extra sample (ExtraSamples 0). The decoder dropped it, so such a TIFF opened without its channel and a save never wrote one. With no extra sample marked as transparency, the first unspecified one is now decoded as the alpha and flagged as an alpha channel (Metadata::alpha_is_channel): flat TIFFs open it as a named alpha channel over an opaque Background, layered ones through their Photoshop channel names. Saving writes the first alpha channel as an unspecified extra sample when the document has no transparency (flat and layered), naming the channels it leaves out; extra samples beyond the alpha are dropped with a warning. Saves also take tiffCompression (none, lzw, zip) and the CLI --tiff-compression. Fixes #5301.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 07:37:09 +01:00
Daktyl198andClaude Opus 5.5 a8845f37ca Actions: a recorded Save As or Save for Web with the suggested name saves each document under its own (#5305)
Keeping the name Save As or Save for Web suggests records only the folder
(and Save As's extension), so playing the action saves each document under
its own name in that folder, as in Photoshop. A name typed in is still
recorded as typed. Before, every played document was written over the one
recorded file.

Save for Web takes a `folder` param for this, and .atn export writes it as
a "save in directory" step that imports back.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-14 06:14:20 +00:00
abc2cbandClaude Opus 5.5 53e12c04a8 Merge upstream main into feat/psd-distort-invert-smart-filters
Resolve docs/file-format-parity.md: keep both the smart-filter and the
Mt16/Mt32 entries in the status line and the revision history.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 09:06:58 +03:00
Valentin KleinandClaude Opus 5.5 706638b284 Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)
* Tests: bad-layer-id checks use an id that can't exist (#3343)

Layer ids come from one process-wide counter (shared with document and
smart-object ids, and bumped by ensure_ids_above on file loads). A full
`cargo test` run passes ids like 9999, so a layer a test just created can
get the "bad" id, the command succeeds and the assertion fails at random
(seen on CI in type_extra_cmds::tests::vertical_orientation_renders_columns_inside_the_canvas).

Use u64::MAX, which the counter never reaches, for every "no such layer"
sentinel in the engine and ui-egui tests. Test-only change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Tests: use u64::MAX for bad-layer-id sentinels added on main since (#3343)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 01:59:43 -04:00
Valentin KleinandClaude Opus 5.5 74812f4874 IO: abr fit and gradient eval check their own bounds (#5218)
fit() computed (y + 1) * h in u32, which passes u32::MAX for a plane
over 2^32 / max rows; the ABR and pattern parsers' edge caps keep real
inputs below that, but the guard lived in another crate. Spans are now
computed in u64. gradient_bake::eval indexed stops[0] and stops[i + 1]
relying on bake's two-stop check; it now handles an empty or lone stop
itself. Same results for every input that worked before.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 01:59:38 -04:00
Timothy DalyandClaude Opus 5.5 ff57499774 PSD: Mt16/Mt32 blocks mark the merged image's transparency (#5178)
The merged image carries its transparency in the first extra channel
when the layer count is stored negative, or when a "Saving Merged
Transparency" global block (Mtrn, Mt16, Mt32) is present. Photoshop
saves 32-bit documents the second way: a positive layer count, Mt32,
and a fourth channel named "Transparency" (psd-tools transparentbg).
merged_has_alpha only knew the first, so opening such a file added a
"Transparency" alpha channel to the document, and the oracle compared
it as if it were opaque white (83.7 % of pixels off; now 0.9 %, all on
the shape's edge).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 01:59:32 -04:00
7ad75b5db2 Layer masks: Reveal Selection drops the selection, as Photoshop does (#5251)
A mask made from the selection takes the selection with it in Photoshop: after
Layer > Layer Mask > Reveal Selection (the Layers panel's mask button with a
selection) the marching ants are gone. PhotoCraft kept the selection, so the
usual next step, Invert (Cmd/Ctrl+I) on the new mask, inverted only the part
inside the old selection and left the whole mask black, instead of flipping
the mask. Hide Selection (the Alt-click variant) already dropped it.

Reveal Selection now clears the selection in the same history step as the
mask: one undo brings the selection back and removes the mask.

Tests: adjust_cmds::tests::reveal_selection_drops_the_selection_so_invert_flips_the_whole_mask
(8/16/32-bit). Tests that deselected right after Reveal Selection no longer
need to (Deselect is disabled without a selection); layer_mask_depth and the
automation agent tasks now expect the selection to be gone.

Co-authored-by: abc2cb <271337822+abc2cb@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 01:59:27 -04:00
c7366b8938 Drop shadow: knocked out beneath the whole shape when the layer's mode blends with it (#5304)
Layer Knocks Out Drop Shadow only knocked the shadow out through see-through fill: at
100 % fill the layer was taken to cover it. That holds in Normal mode, but a layer in
Exclusion, Difference, Multiply, Screen and the rest blends with what's beneath it,
shadow and all: a white Exclusion bar with a drop shadow over black type came out as a
blank white bar instead of white type on black (Photoshop's merged image of the same
file shows the shadow kept out from under the bar), and a Multiply layer was darkened by
its own shadow. shadow_see_through() now knocks it out wholly in those modes, for the CPU
compositor and the GPU plan alike.

Co-authored-by: Daniel van Lith <deeev@Daniels-MacBook-Pro.local>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 01:59:23 -04:00
c0cb78090b panic_hunt: count panics that Session::execute contains (#4982) (#5219)
Session::execute catches a command's panic and returns an ordinary Err (the
last-resort guard in jobs.rs), so the unwind never reached panic_hunt's own
catch_unwind and a panicking command counted as a pass.

The harness now installs a panic hook that counts every panic in the process,
including on rayon workers, and a run fails if the count moved. Runs are
serialised so a panic is charged to the run that caused it. No production
code changes.

Test: contained_panics_count_and_graceful_errors_do_not. A contained panic
fails the run and a graceful Err passes; the first assertion fails without
the hook. The full --ignored fuzz stays green, so no command panics today.

Co-authored-by: prekabreki <prekabreki@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 01:59:18 -04:00
Nicolas FalesyandClaude Opus 5.5 7a0e60c104 test(engine): add Color Range fuzziness 0 exact-match test (TOOL-214-3) (#3581)
* test(engine): add Color Range fuzziness 0 exact-match test (#214)

Adds an explicit test for Sampled Colors at Fuzziness 0 (point sampling
and hex colors) asserting that exact matches are fully selected and
adjacent shades are rejected. Updates scorecard TOOL-214-3 to done.

* docs: regenerate scorecard (TOOL-214-3 done)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017WeVmjnnPPKdxVTpr2Vjtw

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 01:59:13 -04:00
Gert Pellin - GPE 7e28900df3 layer.setProps: refuse opacity and fill outside 0..1 (#5242) (#5291)
Opacity and Fill are fractions in layer.setProps but percentages in the
Layer Style commands, and a value above 1 was clamped silently: 55 gave
an opaque layer. Out-of-range or non-numeric values now fail with an
error that names the range, and the layer is left alone.
2026-10-14 01:59:09 -04:00
Gert Pellin - GPE 15f7618504 Object Selection: say so when the sampled layer is empty (#5246) (#5298)
select.object samples the active layer by default. On an empty layer
(scripts often add one above the photo) it found nothing and returned
without an error; the failure only surfaced at the next command that
needed a selection. It now fails with an error that names the cause and
the sampleAllLayers option, also when the layer's pixels lie outside the
rectangle or point.
2026-10-14 01:59:04 -04:00
Gert Pellin - GPE 4bbcede572 Fibers: fill an empty layer, as Photoshop does (#5241) (#5289)
Fibers renders from the foreground and background colours without
reading the layer, but its output area was the layer's content grown by
a zero halo: on an empty layer that is empty, so nothing was drawn (and
a following transform found nothing to transform). On a partly filled
layer only the content's bounding box was filled. It now writes the
reference bounds (the selection's, else the canvas) like the global
filters, without reading the whole layer as they do.
2026-10-14 01:59:00 -04:00
Gert Pellin - GPE 2da2889546 Background: an opacity, fill, blend mode or Select and Mask layer mask makes it Layer 0 (#4837)
The Background has none of them. layer.setProps applied them to it as it
was, and Select and Mask's Layer Mask output gave it a mask. Like
Photoshop (and like PhotoCraft already does for moving, transforming,
erasing, styles and Layer > Layer Mask), it now becomes a normal layer,
"Layer 0", first. Values that leave its look alone (opacity and fill
100 %, Normal) keep it the Background.

Fixes #4836
2026-10-14 01:58:55 -04:00
Vikram Bhaskaran 7c916d9ecd Validate selection modification limits before allocating the canvas mask. (#4591) 2026-10-14 01:58:51 -04:00
Vikram Bhaskaran 79e2107f71 Report channel copy allocation failures without losing the clipboard. (#4587) 2026-10-14 01:58:46 -04:00
33b360d5ee Reject clipboard origins that cannot form a new document (#4586)
* Reject clipboard origins that cannot be moved into a new document.

* Fill Clip.resolution in the unrepresentable-origin clipboard test.

main added resolution to Clip; the synthetic overflow fixture omitted it and failed engine lib tests.

* Format the clipboard origin test (cargo fmt)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Brandon Thomas <echelon@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 01:58:42 -04:00
Gert Pellin - GPE 077e513686 Color Range presets: weigh dark colours like Photoshop (#5243) (#5293)
Reds/Yellows/Greens/Cyans/Blues/Magentas selected hue closeness times
chroma. Measured against Photoshop 2025 on 126 colours per preset
(Reds, Yellows, Blues; hue +-40 degrees, saturation 5..100 %,
brightness 33..100 %), Photoshop also multiplies by (2 - max): bright
colours were already exact, darker ones came out up to 61 levels short.
With the factor every sample matches within one level. The muted navy
#3d3f54 from the issue now gets 35/255, as in Photoshop (it was 21):
Photoshop also leaves it below 50 %.
2026-10-14 01:58:36 -04:00
Ivan · VanTan e12b7f7352 fix(prefs): preserve selected themes during legacy migration (#5179) 2026-10-14 01:58:31 -04:00
Zer0C00L01andCursor Agent a954194277 PSD import: ResolutionInfo stays pixels per inch when the display unit is cm (#5280)
hRes and vRes are stored as pixels per inch. The unit that follows only
controls how that number is shown, so a 300 ppi file with unit cm opened
at 762 ppi. Export already writes the document ppi and does not divide
by 2.54.

Fixes #5201

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-10-14 01:58:27 -04:00
Michael HigginsandClaude Opus 5.5 2388d82165 Docs: oracle floor, open issues, workspace size and layer filters match main (#5376) (#5382)
- ROADMAP.md: the oracle floor is 145 of 258 (crates/io/tests/corpus.rs,
  gaps.md G1), not 133 of 256; 953 open issues, not 579.
- docs/architecture.md: ~539,000 lines in ~1,310 files and ~8,040
  #[test] functions, recounted 2026-10-13.
- README.md: "a layer kind filter" instead of "layer filters"; only the
  Kind filter exists.
- AGENTS.md: drop an empty bullet at the end of section 7.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 01:58:22 -04:00
LorenzoFasolino d11be6de78 docs: drop stale missing-tool rows, only Art History Brush is missing (#5063)
Task T-0002 del lab artcraft-lab.

File toccati:
   docs/brush-parity.md      | 5 +++--
   docs/gaps.md              | 6 +++---
   docs/target-app-parity.md | 5 +++--
   docs/ui-parity.md         | 7 ++++---
   4 files changed, 13 insertions(+), 10 deletions(-)

Evidenze: artifacts/T-0002/ (nel lab, non in questo repo).
2026-10-14 01:58:18 -04:00