Photoshop's Group Layers (Cmd/Ctrl+G) and Group from Layers create the new
group collapsed, so the Layers panel shows one row in place of the grouped
layers. layer.groupLayers and layer.new.groupFromLayers now do the same.
Layer::group still defaults to expanded, so New Group, PSD import and
artboards are unchanged.
Tests that walk group contents now open every group first with
layer.setExpanded {"all":true,"expanded":true}.
Closes#5571
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BNoCkwuu6CgnxJAii7QExa
Persist Character and Paragraph formatting as Type tool defaults and apply it through type.create. Preserve selected-text scope, foreground color, undo, reset, and nonblocking font loading.
Fixes#5556
Co-Authored-By: Codex <noreply@openai.com>
Since ed7df56a, list_recovery also lists a committed bundle whose sidecar
is not yet published (revision 0). The worker commits the manifest before
it writes the sidecar, so the retry test could catch the bundle between
the two and read revision 0 (seen on windows-latest; 215/300 local runs
on Linux under load). Wait until the entry carries the expected revision.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
selected_style reads the font engine through try_shared, which returns None while the system
font scan is still running. Under cargo test the test passed only because an earlier test in the
same process had already finished the scan; run on its own (nextest runs every test that way, and
`cargo test -- --exact` does too) it saw no engine and got "Regular" instead of "SemiBold". It now
waits for the scan with photocraft_text::shared(), as every_theme_shows_the_type_options does.
On main, alone, it failed before this and passes after, under both cargo test and nextest.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Photoshop's blend mode lists draw a line between their six groups
(Normal, Dissolve | darken | lighten | contrast | difference | colour).
The Layers panel's Blend Mode list and the options bar's Mode lists
(Brush/Pencil, Gradient) now do too. The lines are only drawn: options,
order, wheel, arrow keys, type-ahead and hover preview are unchanged.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A field that has been clicked into takes the wheel wherever the pointer
is: field_wheel::begin_frame takes plain and Shift wheel events out of
the frame's input before anything is laid out, so the canvas and panels
neither scroll nor pan. Alt and Ctrl/Cmd + wheel stay the view's.
Over a field that hasn't been clicked, the wheel steps it too (as in
Photopea, #4061), but only for a gesture that starts over the field. A
panel being scrolled keeps scrolling when a field passes under the
pointer.
One step a notch, as the Up/Down keys: 1, or 0.01 for small ranges,
x10 with Shift. A typed sum is worked out first. Hovering never takes
focus, and a non-finite step is dropped. The slider wheel and the
fields share widgets::count_notches.
Closes#5473
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Splitting the Windows tests renamed their check from `test (windows-latest)` to one per leg. No
status check is required on main today, but if one is added under the old name it would wait
forever. A small job under that name now fails unless the platform pick and the whole test matrix
passed (`needs` gives one result for all legs, so a failing Linux leg fails it too). It checks the
result instead of exiting 0 under `if: always()`, which would pass with every leg red. Suggested
by Zach in review.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test runs without a harness (AppKit needs the main thread), so nothing answered the `--list`
that cargo-nextest sends each test binary: on macOS the binary ran the whole test as its listing
and nextest failed on the output. It now lists itself in libtest's terse format, and nothing for
`--ignored`; a run passes `--exact <name>`, which falls through to the test as before. Found by
Zach running `cargo nextest run --workspace` on a Mac.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Recovery discovery can list a committed bundle before its sidecar is published. Wait for the expected revision rather than treating a fallback entry as write completion. Keep all failure, retry, revision and pixel assertions.
Co-authored-by: GPT-6 <noreply@openai.com>
Recovery discovery can list a committed bundle before its sidecar is published. Wait for the expected revision rather than treating a fallback entry as write completion. Keep all failure, retry, revision and pixel assertions.
Co-authored-by: GPT-6 <noreply@openai.com>
Recovery discovery can list a committed bundle before its sidecar is published. Wait for the expected revision rather than treating a fallback entry as write completion. Keep all failure, retry, revision and pixel assertions.
Co-authored-by: GPT-6 <noreply@openai.com>
Recovery discovery can list a committed bundle before its sidecar is published. Wait for the expected revision rather than treating a fallback entry as write completion. Keep all failure, retry, revision and pixel assertions.
Co-authored-by: GPT-6 <noreply@openai.com>
Recovery discovery can list a committed bundle before its sidecar is published. Wait for the expected revision rather than treating a fallback entry as write completion. Keep all failure, retry, revision and pixel assertions.
Co-authored-by: GPT-6 <noreply@openai.com>
Recovery discovery can list a committed bundle before its sidecar is published. Wait for the expected revision rather than treating a fallback entry as write completion. Keep all failure, retry, revision and pixel assertions.
Co-authored-by: GPT-6 <noreply@openai.com>
egui's ComboBox capped every list at the size its popup takes on the frame
it opens (default_area_size, 400 pt), so the Layers panel's 27 blend modes
scrolled even in tall windows. widgets::combo_list draws the button and its
list itself (keeping egui's ids): the list is as tall as its options up to
the visible window and scrolls only past that. It opens below the button at
its left edge, or moves up over it to fit, never beside it, so it stays put
while wheel steps change the value and the button's width (#1747). All five
former .height(420) dropdowns use it.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The Blur and Sharpen tools ran each dab's separable Gaussian
(local_blur) and the mix back onto the working copy on one thread. A
large brush is a lot of work per dab: a 2500 px dab is about 10^9
multiply-adds, so strokes on big images stalled the app for seconds.
Both passes of local_blur and the per-dab mix now run their rows in
parallel with rayon, as blur.rs already does. Every row does exactly
the same arithmetic in the same order, so the output is bit-identical:
the layer pixels after the strokes below hash the same as on main.
paint.blur, 200-point stroke on a 6000x4000 noise layer, release,
10-core M-series:
brush commit (main -> this) live stroke (main -> this)
300 px 323 ms -> 124 ms 497 ms -> 314 ms
1000 px 1.11 s -> 312 ms 1.70 s -> 996 ms
2500 px 2.77 s -> 843 ms 4.26 s -> 2.44 s
The live stroke keeps a larger serial share (region copies and
mix_back per push); that is left for a follow-up.
Refs #5426
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An error scope swallows the error DeviceHealth's uncaptured-error handler would have recorded, and scoped_work returns before submit_batch can poll the device: a watched compositor never learned of the failure and kept handing it work every frame. device_loss::destroyed_device_returns_an_error_not_a_panic caught this.
scoped_work now takes the health flag and hands a caught error to the new DeviceHealth::caught, which polls first so a lost device is recorded as a Fault::Lost rather than as an error. Only a watched caller records: the recovery tests render again after a transient validation error with no health flag set, and must keep doing so.
Also drops scoped_work's watched argument, which this change had left unused.
Preserve current upstream DDS, DPX, PCX, XPM and related export changes
while restoring JPEG XL format registration, dependencies, documentation,
Save As/Export As integration and independent lossless round-trip tests.
Retain the 16-bit alpha header correction.
Resolve the docs/brush-parity.md conflict by keeping both sides: the
upstream notes (Hue Jitter amount track, Color Replacement) and the
Brush Shift+right-click Mode picker note, in the header and the change table.