Commit Graph
11425 Commits
Author SHA1 Message Date
David Mann 0059bd597e Merge pull request #3498 from davidmann4/feat/auto-219-8-panel-command-check
xtask: check that every panel button routes through a command id (#3495)
2026-11-08 01:48:45 +01:00
David Mann 9849f778d8 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	docs/gaps.md
#	docs/scorecard.md
#	docs/ui-parity.md
2026-11-08 01:43:45 +01:00
Hector VillarrealandClaude Opus 5.5 5d601bbd98 Note Clear All tests: Enter is OK and Escape is Cancel (eliets2 review on crates/ui-egui/src/tools/note_clear_all_tests.rs, keyboard)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-07 18:42:50 -06:00
Hector VillarrealandClaude Opus 5.5 0ac80298ba Note Clear All tests: the alert drawn through dialogs.rs, its question and its OK / Cancel clicked (eliets2 review on crates/ui-egui/src/tools/note_clear_all_tests.rs, dialog rendering)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-07 18:42:43 -06:00
Hector VillarrealandClaude Opus 5.5 45bb76a7ab Note Clear All tests: the second Clear All is a real click (eliets2 review on crates/ui-egui/src/tools/note_clear_all_tests.rs, second-click test)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-07 18:42:36 -06:00
Hector VillarrealandClaude Opus 5.5 dd3588cd4e Note Clear All tests: OK after the document changed deletes nothing (eliets2 review on crates/ui-egui/src/tools/note_clear_all_tests.rs, confirm_clear_notes)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-07 18:42:30 -06:00
Hector Villarreal 599baaa26e Brush Preset picker: the tip's angle/roundness widget at its top left (#11821)
The picker shows the Brush Settings panel's angle/roundness widget left
of its Size and Hardness block, the same widget made reachable from the
picker. Its drags go through tools.setBrush as one journaled change
each, and Escape reverts an angle or roundness edit as it does a Size
or Hardness edit. A pointer position that isn't finite leaves the tip
as it was.
2026-11-07 18:42:11 -06:00
David Mann ce517049a7 Merge pull request #11221 from yoriswind/codex/transform-hit-zones-11097
Use whole-edge Free Transform handles and consistent rotate cursors
2026-11-08 01:41:27 +01:00
b42dcd5b1c Merge main into #8247 (resolve render.rs against faux-bold restructure)
Co-Authored-By: adi-1108 <adi-1108@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 01:41:13 +01:00
David MannandClaude Opus 5.5 6bd3773e07 Address CodeRabbit review: match the foreground at the document's precision, pin the protect-off row
The sampled colour is read from stored pixels, but the foreground was compared unrounded, so in
8- and 16-bit documents a foreground between two levels missed its own stored colour: Find Edges
erased it, and a foreground stored as the sample no longer protected anything. The foreground is
now rounded to the document's sample type first (32-bit float unchanged).

protect_off_is_unchanged now pins the whole alpha row, not only the first and last block.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 01:40:59 +01:00
David Mann 5c1b628973 Merge pull request #9970 from ljkx/feat/photo-filter-last-settings
Photo Filter opens at its last settings (#9879)
2026-11-08 01:40:42 +01:00
Hartmut Nörenberg c517e295b5 fix(ui): say why a Straighten Layer click was refused
`PhotocraftApp::run` puts what a command answered into the status line, but a refusal raised
before the command runs - the automation gate a control or MCP-driven click passes through -
returns from `run_command_at_depth` ahead of that report, and the button handler only reacted
to the hidden-layer alert. A denied synthetic click therefore did nothing at all, which reads
as a dead button rather than a refused one. It now reports any error it gets, the way
`eraser_ui` and the toolbar flyout do, and keeps opening the reference's alert for the hidden
layer alone.
2026-11-08 01:40:36 +01:00
Hartmut Nörenberg 1b0a3e1336 fix(engine): refuse Straighten Layer for a target that is gone
`Session::edit` keeps the selected layers valid after an edit but not the active id, so an
edit that drops the active layer leaves one behind that the document does not hold. The new
enabled check read that id and answered "live", and with an explicit `crop` the command then
rotated and cropped the whole canvas for a layer that is not there - the one outcome of this
state that changes pixels. Refusing it is what `select_layer` and `restore_layer_selection`
already do with a gone id, and it costs the resolve check the target lookup was doing anyway.
No command shipped today drops the active layer without re-targeting, so no real document
changes behaviour: this is the guard the review asked for, and the test reaches it through
`Session::edit` directly.
2026-11-08 01:40:36 +01:00
David Mann f076eb15fe Merge main into feat/hand-scroll-all-windows
# Conflicts:
#	crates/ui-egui/src/tools/tool_reset.rs
#	docs/ui-parity.md
2026-11-08 01:40:20 +01:00
David Mann 81971d3e6b Merge remote-tracking branch 'origin/main' into pr-9272 2026-11-08 01:38:34 +01:00
45edc58f89 PR #9991: give filmstrip raws their sidecar crop
The filmstrip that main added while #9991 was open holds raws opened together.
Only the shown raw read its sidecar crop, so a raw that was never shown, or was
shown and left, opened uncropped. The crop is now read when the raw is queued.

Co-Authored-By: ljkx <177671075+ljkx@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 01:36:38 +01:00
David Mann 100997baaa Merge origin/main into feat/raw-xmp-crop
# Conflicts:
#	crates/ui-egui/src/dialogs/camera_raw_ui/open.rs
#	crates/ui-egui/src/dialogs/camera_raw_ui/sidecar.rs
#	docs/file-format-parity.md
2026-11-08 01:36:16 +01:00
Hector VillarrealandClaude Opus 5.5 a4518da27a Perspective Crop: a corner drag rebuilds from the quad at the press, so releasing Alt puts the neighbours back (CodeRabbit review on crates/ui-egui/src/tools/perspective_crop_ui.rs:213)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-07 18:34:37 -06:00
David Mann a251816516 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/ui-egui/src/widgets/dropdown.rs
2026-11-08 01:30:33 +01:00
David Mann c9204e7c45 Merge remote-tracking branch 'origin/main' into pr-6083 2026-11-08 01:27:02 +01:00
50b877645f Merge origin/main into feat/cli-metadata-option (#9975)
Conflicts with main's --no-maximize-compatibility (#8064) in the CLI
export args, output mapping and dev-dependencies, and in the
file-format parity status line and revision history: both sides kept.

Co-Authored-By: ljkx <ljkx@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 01:26:47 +01:00
Hector VillarrealandClaude Opus 5.5 4a8e26a11a Notes: after a turn or flip the popup keeps today's origin, with its size kept (CodeRabbit review on crates/engine/src/canvas_geom.rs:252)
#11795 didn't measure where the popup sits after a rotation, so that case keeps today's placement
(the top-left of the mapped rectangle) and only the size rule applies. Image Size and Canvas Size
still keep the popup's offset from the icon.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-07 18:25:41 -06:00
Hector VillarrealandClaude Opus 5.5 b7e71b9ed5 Notes: an unset (all-zero) popup stays unset under Image Size, Canvas Size and turns (CodeRabbit review on crates/engine/src/canvas_geom.rs:252)
PSD export writes its default popup for an all-zero one; moving it with the icon turned it into
a 0 x 0 rectangle elsewhere, which export then wrote as is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-07 18:23:00 -06:00
e812bfcbae Merge origin/main into feat/smart-sharpen-canvas-preview (#9981)
Conflict only in the docs/ui-parity.md status line: kept both entries.

Co-Authored-By: ljkx <ljkx@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 01:22:40 +01:00
8f527110be #9396: the continue-path press no longer closes a short path, and hover stops cloning it
CodeRabbit on #9396: with both ends of a short open path in reach (as when
zoomed out), the canvas showed the continue-path pointer, but the press
resumed the path and then hit its first anchor, so the release closed it.
The press that resumes a path now never closes it, and the nearer end is
the one carried on. The path a Pen path carries on is now borrowed instead
of cloned, so the hover check no longer copies the whole path each frame.

Co-Authored-By: Leel Wasanatha <260480244+kavishkashehan726-sudo@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 01:20:55 +01:00
Triwarr 0525197133 Merge remote-tracking branch 'origin/main' into pdf
# Conflicts:
#	docs/scorecard.md
2026-11-08 01:09:29 +01:00
David MannandClaude Opus 5.5 4750447f23 Floor an imported brush's opacity at 1 % when it is selected
Importing an .abr with select picked its first brush without the 1 %
opacity floor, so a preset saved at 0 % showed 1 % but painted nothing
(#11812).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 01:03:17 +01:00
David MannandClaude Opus 5.5 6547fadccd Floor a restored brush's opacity at 1 %
A brush remembered at 0 % opacity (saved before the 1 % floor) read back
at 0: the options bar showed 1 % but strokes painted nothing. Restoring
now floors opacity at 1 %, like tools.setBrush (#11812).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 01:24:18 +00:00
David Mann 1d9c654b3a Merge remote-tracking branch 'origin/main' into fix/11812-brush-opacity-minimum 2026-11-08 00:57:07 +00:00
David Mann d463f92f0c Merge remote-tracking branch 'origin/main' into pr-9396 2026-11-08 00:59:40 +01:00
David Mann 3aa1d9f432 Merge pull request #12164 from ElNeMeR70/fix/patch-sample-all-layers-default-on-12125
Patch tool: start Content-Aware Sample All Layers on (#12125)
2026-11-08 00:41:59 +01:00
Hector VillarrealandClaude Opus 5.5 fe13a8acc3 Star Tool test: the star layer keeps the tool's fill and stroke (maintainer suggestion)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-07 17:41:12 -06:00
Hector Villarreal de9e11df9b Toolbar: Star Tool in the shape slot between Polygon and Line (#11377) 2026-11-07 17:32:45 -06:00
47e14b5da2 Photo Filter keeps only Preserve Luminosity from its last OK (#9970)
#9970 reopened Image > Adjustments > Photo Filter... at the filter, colour,
density and Preserve Luminosity of its last OK. Measured in the reference
application: after OK at 60, 70 and 74 %, with a preset or with Color and a
custom colour, it reopens every time at Warming Filter (85), the orange
swatch and 25 %; only Preserve Luminosity carries over (off after an OK with
it off, on after an OK with it on). Opening now starts from the neutral
settings and takes just that one value from the last OK; Alt still reopens
at all the last settings (#8900). Tests and the ui-parity row follow the
measured behaviour.

Co-Authored-By: ljkx <177671075+ljkx@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 00:30:59 +01:00
David Mann 153fcff8c3 Merge pull request #7121 from texjer/feat/camera-raw-sidecars
Camera Raw: Done saves the raws' settings to their sidecars without opening them
2026-11-08 00:30:42 +01:00
David Mann 36a754da5c Merge pull request #12173 from hectorviov/fix/sampler-drag-gestures
Color Sampler: a new point lands where the drag ends, markers follow the pointer, a click on a point moves it, Escape cancels (#11729)
2026-11-08 00:30:07 +01:00
David Mann 15be79be5e Merge pull request #9058 from Gotya-OFFCIAL/raw-hasselblad-3fr
raw: decode Hasselblad 3FR/FFF (X2D II 100C, uncompressed)
2026-11-08 00:29:05 +01:00
David Mann be26364ebc Merge pull request #12093 from yoriswind/codex/count-psd-resource-11759
Preserve Count groups in PSD resource 1080
2026-11-08 00:28:20 +01:00
David MannandClaude Opus 5.5 e6992a855d Background Eraser: a Tolerance set elsewhere wins over an interrupted edit (#11909)
The typed-text draft remembers the setting it was stored with and is only
used while that setting is unchanged, so a value set meanwhile (a tool
preset while the options bar was hidden) shows from the first frame.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 00:17:09 +01:00
David Mann 2da9714b74 Merge origin/main into feat/photo-filter-last-settings
# Conflicts:
#	crates/ui-egui/src/panels/smart_ui.rs
#	docs/ui-parity.md
2026-11-08 00:16:29 +01:00
Hector Villarreal 40c720f38e Perspective Crop: Shift and Alt constrain the new drag and corner drags (#11802)
pointer takes the held modifiers. A new drag with Shift draws a square
of the shorter drag side, with Alt a box centred on the press at twice
the drag, with both a centred square; the live box follows the
modifiers. Shift moves a dragged corner along the axis it mostly
follows; Alt keeps a rectangle one, the opposite corner fixed. Ctrl
and no modifier keep today's behaviour.
2026-11-07 17:16:24 -06:00
David Mann 49eabafbcb Merge pull request #11238 from NaufalDzz/layer-filter-find-layers
Select › Find Layers opens the Layers panel's Name filter (#10884)
2026-11-08 00:13:30 +01:00
David Mann 5525dc41ae Merge pull request #9306 from FartmanAndBurps/contrib/work-path-live-preview
Smooth live preview for Work Path dragging
2026-11-08 00:12:23 +01:00
David Mann d921488bc3 Merge pull request #11700 from TrevorBrown-dev/fix/magnetic-lasso-fastening-spacing-11687
Magnetic Lasso: fastening points are spaced as the reference measures (#11687)
2026-11-08 00:10:54 +01:00
Hector Villarreal fd0d543d0d Perspective Crop: the quad follows the pointer while corners are clicked (#11804)
After two clicks the preview is the two points with the pointer as the
third and fourth corner, after three the pointer is the fourth; it is
drawn with its grid in the finished quad's style, and the clicked
corners are square handles. The canvas sends button-up moves to the
tool while corners are pending, as it does for the Magnetic Lasso.
2026-11-07 17:10:17 -06:00
DuBearteandClaude Opus 5.5 508c5624d3 Stroke Emboss with its stroke wholly inside counts as an interior blend, as an Inner Bevel does
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-07 18:03:51 -05:00
David MannandClaude Opus 5.5 3ad1695d3e Background Eraser: keep the Tolerance text while it is typed (#11909)
While the field has the keyboard it gets back the value typed so far
instead of the clamped one, so a leading 0 on the way to 05 no longer
turns into 1 (and 15). The stored value is still clamped at once.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 00:01:49 +01:00
David Mann 6d5254d319 Merge pull request #12134 from hectorviov/fix/atn-droplet-print-gradient-tool
Actions: map Create Droplet and cover the Gradient tool's recorded steps (#10710)
2026-11-08 00:01:17 +01:00
DuBearte fb852a3029 Merge remote-tracking branch 'origin/main' into feat/8639-stroke-emboss 2026-11-07 17:59:32 -05:00
David Mann d438e97467 Merge pull request #10766 from yoriswind/codex/atn-menu-intent
Add five Classic Actions panel commands
2026-11-07 23:59:31 +01:00