Commit Graph
11425 Commits
Author SHA1 Message Date
Hector Villarreal 6b9628c92f Color Replacement: History names each edit "Color Replacement Tool" (#11933)
A Color Replacement click, stroke or Shift+click segment adds one History
state named "Color Replacement Tool", as in the reference application.
The command's label is the same name, so a recorded action's step reads
the same as the History state.
2026-11-07 20:47:03 -06:00
David Mann e04ecbdaa3 Merge pull request #10448 from qvest-ssels/feat/export-last-folder-10192
Export dialogs start in the last exported folder (#10192)
2026-11-08 03:45:55 +01:00
David Mann fda05f7b02 Regenerate docs/scorecard.md (merge queue)
On main + #10448, so main's gate stays green after the merge.
2026-11-08 03:45:37 +01:00
David Mann 62776f4b58 Merge branch 'main' into feat/export-last-folder-10192 (merge queue) 2026-11-08 03:45:33 +01:00
David Mann 420a9364e6 Merge pull request #10222 from aethelisdev/fix-wayland-drag-and-drop
ui-egui: support native file drag and drop on Wayland
2026-11-08 03:44:16 +01:00
Kaedo17 bfdf124639 test: stage the dismissal gate the way the gesture actually holds it
The re-merge to main (9ac3fa22b) broke this test's premise. Main gained
`canvas_tool_menu::magnetic_drawing` (#11689): a right-click over a Magnetic
Lasso border in progress opens no menu, on the canvas and through the control
channel alike. So a menu can no longer be open over a live border, and the
test's right-click setup asserted behaviour that is now deliberately gone.

The `menu_dismiss_press` check on the hover block is therefore a guard rather
than a sequence a pointer can reach. The test stages the dismissal state
directly instead, with the button held: the flag is scoped to a held button (a
frame with every button up clears it), so a pointer-up frame would clear it
before the gate reads it and prove nothing. Holding the button also showed the
guard does suppress the hover, which the pointer-up version silently did not.

Two failures found while rebasing, both fixed here:
- the obsolete right-click setup (this commit);
- the pointer-up staging, which passed the flag only after the clear.
2026-11-08 10:43:04 +08:00
ea37bf8bd9 #9077: drop the map_pixels wrapper the main merge left unused
Main's Equalize change (58d11d91ea) moved Equalize to map_pixels_in, and this PR
moves Average off map_pixels, so after merging main the wrapper had no caller and
clippy -D warnings failed on dead code. Fold its doc into map_pixels_in.

Co-Authored-By: ArjenS-LA <ArjenS-LA@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 03:30:26 +01:00
Hector Villarreal 7efd224081 Color Replacement: in Lab, Color keeps L and takes the foreground's a and b (#11922)
In a Lab document the Color mode no longer blends through RGB (which
changed the pixel's L): it keeps the stored L and moves a and b to the
foreground's, as in the reference application. Hue, Saturation and
Luminosity keep today's RGB blend.
2026-11-07 20:25:05 -06:00
517d0a9eea Merge origin/main into #9887 (Indexed Color Matte)
Keeps main's Fade preview path in filter_preview.rs and passes the PR's
tool colours to the non-Fade preview; catalogs keep both sides' rows.

Co-Authored-By: Firstbober <firstbober@tutanota.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 03:23:31 +01:00
Hector Villarreal 479ea9c96b Background Eraser: the compact brush popup from the picker and a right-click (#11910)
With the Background Eraser, the options-bar brush picker and a canvas
right-click open the reference application's compact popup instead of
the Brush Preset picker: Size, Hardness and Spacing with sliders, the
angle/roundness widget, Angle and Roundness, then the Size: and
Tolerance: pen dropdowns (Off, Pen Pressure, Stylus Wheel), the latter
with the tablet warning. No preset list or search field. Tolerance's
control is a tool option (Pen Pressure by default); Size's is the tool's
brush. Other tools keep the Brush Preset picker.
2026-11-07 20:22:51 -06:00
Hector Villarreal bb94bbef7b Color Replacement: Alt+click picks the foreground like the Eyedropper (#11914)
Holding Alt turns the Color Replacement tool into the Eyedropper, as in
the reference application: Alt+click and Alt+drag set the foreground
colour with the Eyedropper's settings, add no history state and change
no pixel, and the cursor shows the eyedropper. Ctrl+Alt keeps its
brush-resize meaning; a plain click still paints.
2026-11-07 20:11:29 -06:00
SBaksa 974c32ddc6 Patch: History names as the tool's (#12117)
select.lasso takes an optional historyName; the Patch tool sends "Patch Tool" so its
lasso is that step (the Lasso tool keeps "Lasso"). paint.patch records "Patch Selection"
in every mode; the content-aware job keeps its progress text.
Tests: patch_history_names_tests (engine) and patch_tool_history_names_tests (ui-egui).
2026-11-08 13:09:17 +11:00
David Mann d95faebaa3 Merge remote-tracking branch 'origin/main' into pr-9077
# Conflicts:
#	docs/gaps.md
#	docs/target-app-parity.md
2026-11-08 03:04:43 +01:00
David Mann 9da3cda6a7 Merge origin/main into feat/raw-xmp-crop
# Conflicts:
#	docs/file-format-parity.md
2026-11-08 02:56:35 +01:00
7a1cd03a58 Brush Settings: name the Spacing slider for accessibility (#5224)
The standalone Spacing track had no accessible name or slider role,
unlike the slider_row it replaced. It is now a slider named "Spacing"
with the current percentage, as CodeRabbit noted.

Co-Authored-By: augrclk <augrclk@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 02:56:31 +01:00
Hector Villarreal eb68c21f94 Brush: the reference's alert when it can't paint (#11898)
A Brush press on a hidden target layer, a layer with Lock All, or a
group's pixels opens the reference application's alert with OK instead
of a status-bar message, and paints nothing. The texts name the tool
from one place (brush_refusal::tool_name); tools whose wording wasn't
measured keep today's status bar. A group's targeted mask and Lock
transparent pixels still paint.
2026-11-07 19:56:20 -06:00
David Mann b30c5c8095 Merge pull request #12142 from hectorviov/fix/star-tool
Toolbar: Star Tool in the shape slot between Polygon and Line (#11377)
2026-11-08 02:56:14 +01:00
Kaedo17 7212bb87b5 Merge remote-tracking branch 'upstream/main' into HEAD 2026-11-08 09:54:50 +08:00
David Mann ed893ea812 Merge pull request #12188 from davidmann4/fix/11909-bg-eraser-tolerance-field
Background Eraser: Tolerance takes whole numbers 1-100 with an alert, bar tooltips (#11909)
2026-11-08 02:54:43 +01:00
David Mann f28cf95c88 Merge pull request #11921 from davidmann4/fix/11733-color-sampler-context-menu
Color Sampler: right-click menu on the canvas (#11733)
2026-11-08 02:51:57 +01:00
David MannandClaude Opus 5.5 6d3fe6f96f Background Eraser: partly erased pixels lose the sampled colour's tint (#11902)
A dab that erases a pixel only partly now also removes the sampled
colour's share from it: the kept colour becomes
(c - sampled x (1 - keep)) / keep per channel, clipped to the channel
range, so composited over the sampled colour it gives back the
original. Later dabs, in the same stroke and in later strokes, match
the pixel's current, decontaminated colour; sampling and the
Contiguous fill still read the pixels before the stroke. With the
graded alpha of #11901 this gives the reference application's drag
results.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 02:51:01 +01:00
Hector Villarreal fdbb79e46f Background Eraser: a 13 px hard tip at 25 % spacing after Reset Tool (#11911)
fresh_brush gives the Background Eraser the reference application's
reset tip, a 13 px hard round at 25 % spacing with Size control off, as
it gives the Brush its own (#11810). Reset Tool, Reset All Tools and the
tool's first use all start from it; other tools and strokes without a
brush keep their tips.
2026-11-07 19:50:53 -06:00
David Mann 02abef5983 Merge pull request #11920 from davidmann4/fix/11907-bg-eraser-digit-keys
Background Eraser: number keys set the Tolerance (#11907)
2026-11-08 02:50:02 +01:00
David Mann ce7706f041 Merge remote-tracking branch 'origin/main' into pr-5224
# Conflicts:
#	crates/ui-egui/src/panels/brush_panel/tests.rs
#	crates/ui-egui/src/panels/brush_sections/tests.rs
#	docs/brush-parity.md
#	docs/gaps.md
2026-11-08 02:49:33 +01:00
David Mann 4a7d746c0a Merge pull request #11823 from davidmann4/fix/11812-brush-opacity-minimum
Brush: opacity minimum 1 % and "00" sets 100 % (#11812)
2026-11-08 02:49:28 +01:00
Hector Villarreal 1f30e48673 Rasterize prompt: the smart object wording as in the reference (#11899)
The prompt for painting on a smart object reads "This smart object must
be rasterized before proceeding. Edit Contents will no longer be
available. Rasterize the smart object?", lower-case "smart object" as
measured. The 22 catalogs that translated the old text are re-keyed to
the new English text, so those languages keep a translation. The type,
shape and fill prompts are unchanged.
2026-11-07 19:45:31 -06:00
Triwarr 3ef91ec45a PDF: widen the dense-page cancellation margin
Raise the synthetic page to a million strokes so the 45 ms watcher
threshold keeps a wide margin on an optimised test build, and record why
the importer keeps one RenderCache per page.
2026-11-08 02:41:37 +01:00
David Mann 4da02a98a6 Merge pull request #9975 from ljkx/feat/cli-metadata-option
CLI: --metadata none|all leaves document XMP out of convert, run --out and batch exports (#9466)
2026-11-08 02:40:35 +01:00
Trevor Brown 01ef090890 Merge remote-tracking branch 'upstream/main' into feat/open-as-smart-object-11678 2026-11-07 20:38:23 -05:00
Trevor BrownandClaude Sonnet 5.5 2341642056 Open as Smart Object: import on a worker and complete through File > Open's colour policy and prompts (#11678)
The command is a job (inline under execute, a worker under start) that returns File > Open's result shape; the UI tracks it as an OpenTab so finish_open gives it the profile prompt (held, admitted with the smart object label) and after_open gives a raw the Camera Raw open dialog and the import warnings. Import options and the Color Settings policy match File > Open. The paths form is removed: the UI calls the command once per file.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Fable 5.1 briefed; Sonnet 5.5 wrote at medium
2026-11-07 20:38:18 -05:00
960bd438e3 Merge origin/main into PR #5250 (Both Axes on the Scatter header)
Co-Authored-By: augrclk <augrclk@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 02:37:20 +01:00
Triwarr 1df674997b PDF: cancel dense pages, complete page labels, isolate artboards
- render_page: forward Interrupt to craft-pdf through an owned flag and a
  scoped 5 ms watcher, so dense vector pages stop mid-render.
- Warn when craft-pdf reports a substituted font (the backend does not emit
  the flag yet).
- /PageLabels: emit an entry for every page, start at 0, and write no tree
  when every artboard name is empty.
- Export budget: charge retained page data plus the largest page's two f32
  buffers instead of the whole document canvas, saturating on overflow.
- Render each artboard from a document holding only its group, so
  overlapping boards no longer paint on each other's pages. One document
  shell is cloned and reused.
- Tests: dense-page cancellation, labels with an empty middle name and all
  empty, overlapping artboard pixels, sparse 9000x9000 canvas, seven US
  Letter pages.
2026-11-08 02:34:58 +01:00
David MannandClaude Opus 5.5 23f63c685e Background Eraser: Find Edges erases soft edges graded instead of cutting them hard (#11904)
Find Edges used to give every pixel within the Tolerance full weight,
so on a blurred edge it erased more than Contiguous. It now uses the
same graded weight (#11901), which keeps the transition as the
reference application does and still gives the Contiguous result on a
hard edge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 02:34:46 +01:00
David Mann 8c6f5d538e Merge origin/main into fix/gradient-stop-drag-off (#10823)
# Conflicts:
#	docs/ui-parity.md
2026-11-08 02:33:41 +01:00
Hector Villarreal 63ec0bef12 Blend mode keys leave Behind when they pick another mode (#11896)
Behind is one of the painting modes in the reference application: a
Shift+Alt letter or a Shift+minus/plus step that picks another mode (or
Clear) now also turns Behind off, in the same one tools.setBrush. With
Behind off the keys send what they did before.
2026-11-07 19:31:35 -06:00
David MannandClaude Opus 5.5 22882f690c Background Eraser: alpha falls off over the whole Tolerance (#11901)
One dab now erases a colour less the further it is from the sampled
colour, over the whole Tolerance, instead of fully up to the last
quarter of it. The weight is 1 - clamp((d - d0) / (T - d0), 0, 1) with
d0 = min(T / 20, 8 levels), measured with single clicks in the
reference application. The colour distance is the largest increase
plus the largest decrease over the channels, so opposite-sign changes
add up. Find Edges keeps its hard cut (#11904).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 02:24:08 +01:00
f826d0ac24 fix(text): #8247 colour glyph buffers follow main's fallible Coverage
Main made Coverage::new fallible (Coverage::try_new, finish -> Option, #4979);
the colour glyph Painter still called the old infallible API and its own
layer/clip buffers used vec! sized by the glyph window. Every buffer is now
reserved with try_reserve; a glyph that cannot be reserved makes the text
render nothing, as main does for its own passes, instead of aborting.

Co-Authored-By: adi-1108 <adi-1108@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 02:22:24 +01:00
yoriswind 20cd85365c Merge current main into toolbar W shortcut fix 2026-11-07 17:20:08 -08:00
David MannandClaude Opus 5.5 caae1c8a1f Address CodeRabbit review: close the sampler menu when its sampler changes
The Color Sampler menu kept only the sampler's index. If a control
command deleted an earlier sampler while the menu was open, the index
named another sampler and Delete removed that one. The menu now also
remembers the active document and the sampler's position; when either
no longer matches, Delete greys out and the menu closes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 02:19:35 +01:00
Trevor BrownandClaude Sonnet 5.5 b29fdc5a29 Open as Smart Object: the opening snapshot shows the placed smart object (#11678)
The smart object layer is built into the document before admission, so snapshot 0 holds it and the history is the single state "Open As Smart Object", as File > Open's is one state.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Fable 5.1 briefed; Sonnet 5.5 wrote at medium
2026-11-07 20:05:43 -05:00
Hartmut Nörenberg b170944c3e fix(engine): the Type tool converts only the text #12041 measured
Paragraph (box) text and vertical type are on the issue's *Not measured* list, whose rule is that
an unmeasured case keeps today's behaviour - and a coverage mask could not give back a box that
reflows or a column that stacks its lines, so their editable type layer stays. The commit converts
the measured case only: horizontal point text in an Indexed Color or a Bitmap document. The Type
Mask tools keep turning both into the selection, as they do today; there the user asked for one.

Also pin what happens when an edit that carries no coalesce key - the deliberately per-press
Alt+arrow kerning step - comes between the typing and the commit: the commit is a state of its own,
named for the type layer, exactly as the Type Mask commit and the plain layer's rename are in that
situation today. Nothing is mis-named; folding those states together would delete history the user
can undo today and belongs with #12039.

Tests: commits_as_selection across shape and orientation; the tool's commit of box and vertical text
in both modes; the split states and what each undo takes.
2026-11-08 02:03:17 +01:00
e522da0d76 PR #9144: other views move by the dragged view's document-pixel distance
Scroll All Windows and Shift+drag moved the other shown views to the same
relative location in their own documents. The reference application moves
every window by the same distance in image pixels (a view at 100 % moves
twice the screen distance of one at 50 %), so follow() now takes the
dragged view's step in document pixels, measured between its clamped
centers when Overscroll is off. The checkbox gets the reference tooltip,
and new tests check that 100%, Fit Screen and Fill Screen still change only
the active view with the option on.

Co-Authored-By: dotCooCoo <1206598+dotCooCoo@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 01:56:34 +01:00
8da11e891a PR #9991: Batch's quiet RAW opening applies the sidecar crop
Main added a non-interactive RAW opener for Batch while #9991 was open. It refused a
sidecar whose crop keys were unsupported. #9991 moves those keys from the ignored list into
LoadReport::crop, so after the merge Batch would drop the crop without saying so. It now
passes the crop into RawTuning, as the interactive open does.

Co-Authored-By: ljkx <177671075+ljkx@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 01:54:33 +01:00
David Mann f27b78a75c Merge pull request #12080 from davidmann4/fix/cmyk-ref-rounding-tie
CMYK: the test reference keeps the source ink over nothing (#12079)
2026-11-08 01:52:54 +01:00
David MannandClaude Opus 5.5 834f650f8e Address CodeRabbit review: recount the card parts before each checkbox
Two clicks on Brush Name and Brush Stroke in the same frame (assistive
technology or the control channel) both saw two parts on and turned
both off, leaving cards with no content. Count the parts on before each
checkbox so the last one stays on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 01:51:26 +01:00
Trevor Brown 585408de67 Merge remote-tracking branch 'upstream/main' into feat/open-as-smart-object-11678 2026-11-07 19:51:04 -05:00
David Mann 9ac3fa22b2 Merge pull request #9280 from davidmann4/fix/crop-invalid-rect
Crop: refuse an invalid explicit rectangle instead of cropping to the selection (#9279)
2026-11-08 01:50:23 +01:00
David Mann 940b352ca0 Merge pull request #9256 from davidmann4/fix/scale-effects-bevel-texture
Scale Effects and Image Size scale Bevel & Emboss Texture's scale (#9254)
2026-11-08 01:50:08 +01:00
David Mann 2e9a1d267e Merge pull request #9233 from davidmann4/fix/crop-shift-letter-keys
Crop: Shift+H, Shift+P and Shift+I switch tools again (#9232)
2026-11-08 01:49:51 +01:00
22ddcd3f7d New Guide Layout (#6083): tabbing past a field keeps the preset
Leaving a length field without typing rewrote its value on focus loss: an
empty automatic Width turned from null into "", which made a named preset
such as "8 Columns" switch to Custom. The field now writes back only when
normalising changes the text shown.

Co-Authored-By: safvanedge <safvanedge@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 01:49:24 +01:00