Commit Graph
2574 Commits
Author SHA1 Message Date
David MannandClaude Opus 5.5 d089908158 PSD: Offset and Custom smart filters open and save like Photoshop (#6304)
Offset (filter.other.offset) and Custom (filter.other.custom) applied as
smart filters were left out of PSD saves with a warning, and the same
filters in a Photoshop PSD opened only as verbatim, non-editable entries.
smart_map.rs now maps both ways in filterFX:

- Offset: filterID/class Ofst; Hrzn and Vrtc as long (signed), Fl  as the
  FlMd enum: Wrp  = wrap, Rpt  = repeat, Bckg = transparent ("Set to
  Transparent" on a layer). Unknown enum values, wrong types or missing
  keys keep the entry verbatim.
- Custom: filterID/class Cstm; Scl  and Ofst as long, Mtrx as 25 longs,
  row-major 5 x 5. Written as the engine renders it (no kernel = identity,
  missing cells 0, values clamped to -999..999, 1..9999, -9999..9999);
  fractional values have no PSD equivalent and are reported. On open,
  values outside Photoshop's ranges or a matrix that is not 25 longs keep
  the entry verbatim.

Measured in Photoshop: applied through Action Manager to a smart object,
saved, filterFX read back (Offset Wrap 0/0, Set to Background 12/-7,
Repeat 5/3; Custom default sharpen and a blur at Scale 2, Offset 10).
The measured files open as the editable filters and survive export and
re-import unchanged (checked locally, not committed).

Scorecard FILE-215-2 note and the file-format parity doc list the two
filters (still partial).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 22:45:46 +02:00
Davit Matchakhelidze 804fbedb88 Merge remote-tracking branch 'origin/main' into ka-language 2026-10-16 00:33:30 +04:00
vangel76andClaude Opus 5.5 14a2844fad Regenerate docs/scorecard.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-15 22:31:11 +02:00
vangel76andClaude Opus 5.5 18f9a64bc5 Merge upstream/main into fix/3290-filter-mask-paint
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-15 22:31:04 +02:00
David MannandClaude Opus 5.5 08515b40b1 Image Size: a Columns width unit from the Column Size preference (#6214)
Preferences > Units & Rulers > Column Size (width, gutter, in points) now
takes effect: Image Size and Canvas Size offer Columns on the Width unit
menu, where n columns are n x width + (n - 1) x gutter at the document's
resolution. Height has no Columns; picking another unit on Width leaves it.
The engine commands still take pixels, so recorded actions don't depend on
the preference. A zero, negative or non-finite Column Size falls back
(180 pt width, 0 or 12 pt gutter) instead of dividing by zero.

Both settings leave HIDDEN_UNTIL_IMPLEMENTED and show in Preferences with a
pt suffix; settings that do nothing 26 -> 24 of 166.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 22:25:13 +02:00
Marco Arnulfo 14b1783e93 Smart Filters: Delete/Backspace removes the selected filter, not its smart object (#4751) 2026-10-15 22:14:28 +02:00
David MannandClaude Opus 5.5 7f0e7cbee0 Zoom tool: holding the button zooms continuously with Animated Zoom on (#6210)
With Preferences > General > Animated Zoom on (the default), a Zoom tool
press held still past 0.3 s zooms continuously about the press point
(2 doublings a second, frame-rate independent, within the zoom_levels
range) until release; Alt zooms out. The release is then no click step.
A quick click still steps, Scrubby Zoom and the zoom rectangle are
unchanged, and with the preference off a hold is one click step.

The hold logic lives in the new zoom_hold.rs; canvas.rs only calls it.
general.animatedZoom leaves HIDDEN_UNTIL_IMPLEMENTED; prefs that do
nothing 25 of 166.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 22:11:45 +02:00
David MannandClaude Opus 5.5 e8f50f69c3 scorecard: TOOL-214-4 note and the pasteboard menu row catch up with main
Dragging layers onto another document's tab landed in #851 (#589), and the
pasteboard colour menu in #2633 (#2462); the TOOL-214-4 note and the
context-menu parity row still listed both as open.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 21:17:33 +02:00
David Mann 0aed96c7fd Merge remote-tracking branch 'origin/main' into docs/scorecard-stale-rows-2
# Conflicts:
#	docs/ui-parity.md
2026-10-15 21:17:33 +02:00
Khawar Zamman WaniandClaude Opus 5.5 1b666f4790 Pen: Auto Add/Delete on the path being drawn (#6140) (#6172)
While a path was being drawn, the Pen's Auto Add/Delete was off, so adding
a point meant finishing the path and switching to Add Anchor Point. Now a
click on a segment of the path in progress adds an anchor, a click on a
middle anchor deletes it, and drawing carries on from the last anchor. The
first anchor still closes the path and the last still breaks its handle.

The hover highlight draws over the path in progress, and the rubber band
hides where a click adds or deletes instead of placing an anchor.


Claude-Session: https://claude.ai/code/session_01JFTxZ57wCmWEDXxCn1Zuni

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-15 13:12:35 -06:00
Marco Arnulfo b11223b272 Codecs: save Cineon (.cin) film frames
Write Kodak Cineon 4.5: the 1024-byte generic header (V4.5, one or three
channels designated gray or R/G/B, 10 bits, code values 0-1023 over
densities 0-2.048) and a 1024-byte film header left undefined, then the
samples three to a big-endian 32-bit word, left justified (packing 5),
lines on a word boundary. Samples are written as round(v * 1023 / 65535),
so a frame opened from Cineon saves back with its code values; other
images take the encode plan (alpha dropped, CMYK and Lab to RGB) and are
quantized to 10 bits.

Cineon leaves ASYMMETRIC_EXCEPTIONS, Save As offers .cin, and the codecs
README, file-format parity and G10 are updated.
2026-10-15 20:41:58 +02:00
David MannandClaude Opus 5.5 a1837706ee Performance: a cancelled Gaussian Blur job stops within budget (#6205)
Cancelling a 24 MP Gaussian Blur r 50 job took up to ~400 ms (P25, budget
200 ms max). Stage timings showed two stretches without a cancel check:

- The transparency-lock pass (keep_alpha) that puts a Background layer's
  alpha back after the filter ran serially over every changed tile, about
  400-450 ms on 24 MP, with no cancel check. It now fixes the tiles in
  parallel, each in its own scratch surface, and checks for cancellation
  before each tile. Results are bit-identical to the serial pass (tested
  against it at 8, 16 and 32-bit).
- Box-blur column strips checked only before each strip; with ~31 strips
  per band and 32 threads one strip is tens of ms. line_passes now checks
  between passes.

P25 max: 337-399 ms -> 13-44 ms over five runs. The uncancelled job is
also faster: p50 about 690 -> 400 ms.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 19:17:07 +02:00
highperfocused 274d133353 Shift+Alt+right-click opens Photoshop's HUD Color Picker (#6098)
With a painting tool, Shift+Alt+right-press on the canvas opens a floating
hue strip and saturation/value square under the pointer. While the right
button stays down, moving over the HUD sets the foreground colour live
(coalesced tools.setColors, one history step); release keeps it, Escape
restores the starting colour. Alt+right-drag brush resize now requires
Shift not be held, so the two gestures stay distinct. Agents drive it with
ui.pointer button=right shift+alt (down opens, up closes).
2026-10-15 19:13:16 +02:00
PanPDXandClaude Opus 5.5 dc90b48026 docs: cite PR #6230 in the TYPE-218-1 note
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-15 10:00:38 -07:00
David MannandClaude Opus 5.5 a3cbc880e6 Preferences: Save in Background off saves in the foreground (#6207)
Preferences > File Handling > Save in Background was never read. Saves
already run as a background job; the setting now picks how the app
waits for it, as in Photoshop:

- On (default): you keep working while the file is written; progress
  shows in the document tab and the status bar. The modal progress
  dialog no longer appears for these saves.
- Off: the same job, worker and atomic write, but the modal progress
  dialog shows at once and no shortcut reaches the app until the file
  is complete; a close or quit asked for meanwhile waits for it.

The setting now shows in Edit > Preferences. Prefs audit: settings that
do nothing 26 -> 25 of 166.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 18:48:58 +02:00
IanHollow 3834845a60 Separate shortcut capture checks from native snapshot rendering
Keep capture and visible-label assertions GPU independent. Add opt-in checked snapshots at both scales under the existing GPU lock and Nextest group, with a fresh-output command that rejects empty test selections.

Assisted-by: OpenAI Codex (GPT-6)
Signed-off-by: IanHollow <72767437+IanHollow@users.noreply.github.com>
2026-10-15 09:45:41 -07:00
PanPDXandClaude Opus 5.5 3c0b472573 docs: match the Type features cell to its scorecard count
The cell's count was refreshed to 4/4/2 but its prose still called
manual kerning and type on a path missing; the scorecard has kerning
done and type on a path partial.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-15 09:25:38 -07:00
EuanTop d7828bda6f Add hex input to shape Fill and Stroke popovers 2026-10-16 00:01:16 +08:00
PanPDXandClaude Opus 5.5 6f74cace1a docs: refresh the Type scorecard count in gaps and target-app parity
Both quoted stale Type checklist counts (3/2/4 and 0/3/6); the
regenerated scorecard has 4 done, 4 partial, 2 missing with area type
(TYPE-218-10) as partial. The Type figure (40%) is an estimate this work
does not re-measure, so it and every percentage stay as they were; the
parity doc gets its status line and a revision-history row, per AGENTS.md
section 4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-15 09:00:04 -07:00
PanPDXandClaude Opus 5.5 cfe8f19202 docs: say what area type does with paths over 4096 anchors
The TYPE-218-10 note said type.fillPath still worked on paths beyond the
Type tool's click cap; it never did for curved paths, and it now refuses
them with "too many anchor points". The note says what a click and the
command each do, and docs/scorecard.md is regenerated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-15 08:52:38 -07:00
PanPDXandClaude Opus 5.5 9380a8ddb2 docs: record area type (TYPE-218-10) in the scorecard and gaps
Area type is partial: PSD saves it as paragraph text over the path's
bounds, and mixed type sizes in one area paragraph space at the largest
line. Also notes the 4096-anchor click limit and overflow of words wider
than every span. TYPE-218-1 now credits the Type tool click on an outline.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-15 08:06:22 -07:00
David MannandClaude Opus 5.5 442987528f Merge main into fix/4017-huge-new-document
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 16:52:49 +02:00
harrisonoconnorhover 61d9e8cc1a Merge current main and retain both Actions panel test additions 2026-10-15 10:43:26 -04:00
harrisonoconnorhover 2ecefa966a web: distinguish generated defaults from unsaved preset edits 2026-10-15 10:43:26 -04:00
David MannandClaude Opus 5.5 275576543f Merge main into feat/tool-213-7-live-retouch
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 16:38:01 +02:00
David MannandClaude Opus 5.5 674340230c Merge main into feat/file-216-2-large-fixtures
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 16:16:28 +02:00
Matthias Schlich b228c1c0c2 feat(psd): map Clouds, Difference Clouds, Fibers and Lens Flare smart filters
PSD smart filters Clds, DfrC, Fbrs and LnsF open as editable PhotoCraft filters instead of
kept-verbatim entries, and are written back like Photoshop: seeds, the item's foreground and
background colours, brightness, centre and lens (Zm/Nkn/Nkn1/PnVs = 50-300mm Zoom, 35mm,
105mm and Movie Prime), with Photoshop's descriptor names. Checked against items saved by
Photoshop 27.
2026-10-15 16:05:34 +02:00
David MannandClaude Opus 5.5 37a655a56c Merge main into feat/auto-219-8-panel-command-check
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 16:05:09 +02:00
David MannandClaude Opus 5.5 daaeeda7c7 Merge main into docs/scorecard-stale-rows-2
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 16:00:11 +02:00
Vikram Bhaskaran 529fb667f9 Merge remote-tracking branch 'origin/main' into feat/dicom-read
# Conflicts:
#	apps/photocraft-web/src/web.rs
#	apps/photocraft/src/services.rs
#	crates/codecs/README.md
#	crates/codecs/src/format.rs
#	crates/codecs/src/lib.rs
#	docs/file-format-parity.md
2026-10-16 00:22:26 +11:00
bazmarth 26ae488262 Merge remote-tracking branch 'origin/main' into feat/apply-color-to-selection
# Conflicts:
#	docs/ui-parity.md
2026-10-15 13:17:33 +00:00
bazmarth 7978cbc1ee Merge remote-tracking branch 'origin/main' into feat/polygon-corner-radius
# Conflicts:
#	docs/ui-parity.md
2026-10-15 13:17:31 +00:00
Vikram Bhaskaran 2af160d65f Merge remote-tracking branch 'origin/main' into feat/iff-read
# Conflicts:
#	apps/photocraft-web/src/web.rs
#	apps/photocraft/src/services.rs
#	crates/codecs/README.md
#	crates/codecs/src/format.rs
#	crates/codecs/src/lib.rs
#	crates/codecs/tests/detect_caps.rs
#	docs/gaps.md
2026-10-16 00:17:24 +11:00
Marco Arnulfo 4083eee2c5 Filter > Other > Frequency Separation (#1714)
A one-step setup of frequency separation for retouching: from the active pixel layer it builds a
"Frequency Separation" group right above it with a "Low Frequency" layer (Gaussian Blur at the
chosen radius, the same pixels Filter > Blur > Gaussian Blur makes) and a "High Frequency" layer,
High = (Source - Low) / 2 + 0.5 per colour channel on Linear Light, which composites back to the
source: within one level at 8 bits (as Photoshop's Apply Image recipe), exactly at 16 and 32 bits
for values in 0..1. One history step; the source layer is left as it was and High is targeted.

The command (layer.frequencySeparation, {"radius":0.1..1000=4}) gets the schema dialog for its
radius and sits in Filter > Other after Color to Alpha; it is no filter.* command because it adds
layers rather than filtering the target (no mask or channel routing, Fade or Last Filter). It is
refused on non-pixel and empty layers, a targeted channel or mask, and in CMYK and Lab, where
Linear Light does not rebuild the source.
2026-10-15 14:56:08 +02:00
David MannandClaude Opus 5.5 e22c4ec7ab CI: run the tests with cargo nextest (#6117)
cargo test runs the ~258 test binaries one at a time; nextest runs them in parallel. Its new `ci`
profile stops at the first failure (a red PR frees its runner early), fails a test that hangs for
10 minutes instead of letting it hold the runner, and repeats every failure at the end of the log;
the GPU test group still applies. Same --workspace --locked --features heif selection, so the build
is unchanged. Doctests stay on cargo test --doc.

postscript_only_style_shows_actual_subfamily relied on another test in the same process having
started the font scan; under nextest it runs alone, so it starts the scan itself (as #2933 does).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 14:40:15 +02:00
David MannandClaude Opus 5.5 2ab37e7e55 Scorecard: regenerate after merging main (TOOL-214-12 done, #5846)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 14:06:00 +02:00
David MannandClaude Opus 5.5 42e831fa30 History Options: no duplicate snapshot when saving an unchanged document (#2966)
Automatically Create New Snapshot When Saving adds no row when the document
is unchanged since the snapshot the previous save added (and that snapshot
is still there), so Ctrl+S on a clean document doesn't stack duplicates.
The new snapshot's tiles are trimmed against the history budget at once,
and its memory cost is documented: snapshots count against History & Cache
by dropping the oldest states, but are never dropped themselves.

Tests: the engine dedupe, and the desktop save path (a save adds one, Save a
Copy none, a background save finishing on another document snapshots the
document it saved). The purge test from main deletes the first snapshot so
it measures only the snapshot it takes.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 14:00:07 +02:00
Gustavo Ziger 0684657a92 Merge main into feat/zoom-animation-566 2026-10-15 08:35:41 -03:00
David MannandClaude Opus 5.5 cb8f2808d2 Merge origin/main into feat/history-snapshot-options
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 13:23:37 +02:00
itsF4LCON 862fa0c9a8 Merge remote-tracking branch 'upstream/main' into feat/2966-snapshot-dialog
# Conflicts:
#	crates/ui-egui/src/panels.rs
#	docs/control-protocol.md
#	docs/ui-parity.md
2026-10-15 13:08:02 +02:00
adrdsouza c71e3f94ad fix(psd): refine legacy point anchors after font resolution 2026-10-15 16:27:30 +05:30
David Mann 43d8572c9f Merge remote-tracking branch 'origin/main' into feat/tool-214-12-shape-feather
# Conflicts:
#	docs/scorecard.md
#	docs/ui-parity.md
2026-10-15 12:12:20 +02:00
Finn Newick a1d1e48548 Merge remote-tracking branch 'origin/main' into perf/doc-shared-blobs 2026-10-15 10:37:01 +01:00
jonathnwxh 906dc9ea94 Merge main preserving CSH import alongside image brushes and translations 2026-10-15 17:04:38 +08:00
Khawar Zamman WaniandClaude Opus 5.5 0d38aec094 Color panel: Photoshop's panel-menu modes, the same in every theme (#6000)
The theme no longer decides the Color panel's layout: Photoshop's themes used to
get the stretched spectrum field, the others a short field with HSB sliders.
The panel menu now picks it, as in Photoshop: Hue Cube (default), Brightness
Cube, Color Wheel, and Grayscale, RGB, HSB, CMYK, Lab and Web Color sliders over
a colour ramp, plus Copy Color as HTML / Hex Code, the ramp choices (RGB and
CMYK Spectrum, Grayscale Ramp, Current Colors) and Make Ramp Web Safe.

- Slider rows: label, gradient track with a triangle thumb, field and unit; the
  out-of-gamut and web-colour alerts sit under the chips. Web sliders snap to
  web steps and take hex. Typed HSB, CMYK and Lab values are kept while they
  still give the colour.
- Ramp: fills the group, white and black boxes at its end; Shift-click cycles
  the ramps, Alt-click picks the other colour, right-click opens its menu.
- Color Wheel: HSB sliders over a hue ring and a rotating saturation/brightness
  triangle, with an add-to-swatches button.
- The choice is saved in UI state; `ui.set colorPanel` merges and takes `mode`,
  `ramp` and `webSafeRamp`.
- Menu strings in all 20 complete catalogs; UI-217-17 done in the scorecard,
  ui-parity, gaps and control-protocol docs.

Closes #6000. Closes #2569.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HJVuULF2tg9pN2x4VJoED1
2026-10-15 14:04:39 +05:30
Davit Matchakhelidze 1407a8239e Merge upstream main into ka-language 2026-10-15 12:23:40 +04:00
abc2cb 7635c61f89 Merge remote-tracking branch 'upstream/main' into codex/github-smart-filters-usability-20261011
# Conflicts:
#	crates/ui-egui/src/i18n/hu.tsv
#	crates/ui-egui/src/i18n/sr.tsv
#	crates/ui-egui/src/i18n/tr.tsv
#	crates/ui-egui/src/i18n/vi.tsv
#	crates/ui-egui/src/smart_ui.rs
2026-10-15 11:20:35 +03:00
abc2cb 59763de9c6 Merge remote-tracking branch 'upstream/main' into feat/psd-distort-invert-smart-filters
# Conflicts:
#	docs/file-format-parity.md
2026-10-15 11:14:15 +03:00
df055f3dcb CI: fix the tests that keep main red, and ship the wasm as compressed parts (#5926, #5302) (#5941)
* Fix two ui-egui tests broken on main by concurrent landings

- profile_open_tests: #5614 renamed the built-in profile to "(PhotoCraft)" after #5208
  hard-coded "(Photocraft)" in the Use-embedded button label.
- smart_object_curves_preview_keeps_its_size_on_a_reduced_proxy (#5779): the reduced
  square is in the right place, but its corner pixels are 220/255 after the smart
  object's resampling; assert full coverage inside and over half at the corners.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Web: ship the wasm as compressed parts behind a boot module (#5302)

The release site held the app's wasm as one file, which sits at the 25 MiB
per-file cap of Cloudflare Pages, so the 24 MiB gate failed unrelated PRs.

packaging/web/package.sh now gzips the wasm and cuts it into parts of at
most 20 MiB under app/, and ships the page of a new crate,
apps/photocraft-web-boot. That module fetches the parts in order, has the
browser inflate them (DecompressionStream) and passes the stream to the
app's own wasm-bindgen loader, so the browser still compiles while it
downloads. A failed download is retried twice, then the page says so.

The check is now that no file in the site is over 24 MiB. trunk build in
apps/photocraft-web and the Docker image still give one .wasm.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Web boot: inflate the parts in the module where the browser can't (#5302)

* Tests: the adjustment-layer drag preview test follows #5778 (#5926)

#5778 caps a live adjustment-layer preview by the view's zoom, so at 100 %
the drag shows full resolution even with Low Resolution Previews on. The
test still expected the reduced copy there. It now checks that at 100 % every
column shows by default, and moves the low-res on/off comparison to 50 %,
where the reduced copy is still used: on, the drag shows only the (inverted)
black columns; off, it matches the committed view.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Brandon Thomas <echelon@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-15 09:21:30 +02:00
varanus-salvatorandClaude Opus 5.5 3227bf8366 Stroke: keep Overprint (overprint)
Photoshop stores Stroke › Overprint as `overprint` in the FrFX
descriptor. StrokeFx had no field for it, so an edited stroke was
written back without it and a stroke with Overprint on lost it.

Add `StrokeFx::overprint` (serde default, so older .pcraft files load),
read and write `overprint`, accept it in layer.layerStyle.stroke and show
the Overprint checkbox in the Layer Style dialog, as Photoshop does.
Rendering is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-15 12:55:18 +07:00